Skip to content

Secure, Fast, and Extensible Sandbox runtime for AI agents.

fix(sdk/ts): forbid cross-variant source and typeless auth fields at compile time

高然afb997475135
diff --git a/sdks/sandbox/javascript/src/models/sandboxes.ts b/sdks/sandbox/javascript/src/models/sandboxes.ts
index 64db38ac8..4054cb2d8 100644
--- a/sdks/sandbox/javascript/src/models/sandboxes.ts
+++ b/sdks/sandbox/javascript/src/models/sandboxes.ts
@@ -100,6 +100,7 @@ export interface InlineCredentialSource extends Record<string, unknown> {
* requests and is never present in Credential Vault state responses.
*/
value: string;
+ endpoint?: never;
}
export interface ExchangeCredentialSource extends Record<string, unknown> {
@@ -108,6 +109,7 @@ export interface ExchangeCredentialSource extends Record<string, unknown> {
* Header-resolver endpoint (`unix:///path` or `https://host[:port]`).
*/
endpoint: string;
+ value?: never;
}
export interface Credential extends Record<string, unknown> {
@@ -204,9 +206,14 @@ export type CredentialAuth =
} & CredentialAuthSubstitutions)
/**
* Typeless exchange form: only a credential reference (exchange-sourced).
- * `type?: never` keeps typo'd static kinds compile errors.
- */
- | ({ credential: string } & { type?: never });
+ * Static-only fields are `never` so they stay compile errors here.
+ */
+ | ({ credential: string } & {
+ type?: never;
+ name?: never;
+ headers?: never;
+ substitutions?: never;
+ });
export interface CredentialBinding extends Record<string, unknown> {
/**
diff --git a/sdks/sandbox/javascript/tests/credential-vault.test.mjs b/sdks/sandbox/javascript/tests/credential-vault.test.mjs
index e5e7ac837..f233b242f 100644
--- a/sdks/sandbox/javascript/tests/credential-vault.test.mjs
+++ b/sdks/sandbox/javascript/tests/credential-vault.test.mjs
@@ -243,11 +243,16 @@ test("Credential Vault state omits plaintext secret fields", async () => {
const dts = await readDistDeclarations();
const inlineCredentialSource = declarationBlock(dts, "InlineCredentialSource");
+ const exchangeCredentialSource = declarationBlock(dts, "ExchangeCredentialSource");
const credentialMetadata = declarationBlock(dts, "CredentialMetadata");
const authMetadata = declarationBlock(dts, "CredentialAuthMetadata");
const bindingMetadata = declarationBlock(dts, "CredentialBindingMetadata");
assert.match(inlineCredentialSource, /\btype\?: "inline"/);
+ // Cross-variant keys stay compile errors: each source variant forbids the
+ // other kind's field.
+ assert.match(inlineCredentialSource, /\bendpoint\?: never/);
+ assert.match(exchangeCredentialSource, /\bvalue\?: never/);
assert.doesNotMatch(credentialMetadata, /extends Record/);
assert.doesNotMatch(credentialMetadata, /\bsource\s*[?:]/);
assert.doesNotMatch(authMetadata, /extends Record/);
@@ -259,6 +264,8 @@ test("Credential Vault state omits plaintext secret fields", async () => {
assert.doesNotMatch(authMetadata, /\bheaders\s*[?:]/);
assert.doesNotMatch(bindingMetadata, /extends Record/);
assert.match(bindingMetadata, /\bauth\??: CredentialAuthMetadata/);
+ // Static-only auth fields stay compile errors on the typeless member.
+ assert.match(dts, /type\?: never;\s*\n\s*name\?: never;\s*\n\s*headers\?: never;\s*\n\s*substitutions\?: never/);
});
test("Egress declarations keep Credential Vault optional for custom adapters", async () => {