Skip to content

🔥 The free & Open Source DocuSign alternative

fix: create contact not working properly & update 400 error

prafull-opensignlabs5142a8c62dab
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js
index 3764bb74b..08a066e86 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/CreateDocumentWithTemplate.js
@@ -318,6 +318,6 @@ export default async function createDocumentWithTemplate(request, response) {
if (err.code === 101) {
return response.status(404).json({ error: 'Invalid template id!' });
}
- return response.status(400).json({ error: 'Something went wrong!' });
+ return response.status(400).json({ error: 'Something went wrong, please try again later!' });
}
}
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/createContact.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/createContact.js
index 29fc57bbd..879217e92 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/createContact.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/createContact.js
@@ -19,7 +19,7 @@ export default async function createContact(request, response) {
const contactbook = new Parse.Query('contracts_Contactbook');
contactbook.equalTo('Email', email);
contactbook.equalTo('CreatedBy', userPtr);
-
+ contactbook.notEqualTo('IsDeleted', true);
const userExists = await contactbook.first({ useMasterKey: true });
if (userExists) {
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/createDocument.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/createDocument.js
index 5e92267cf..1b88369a2 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/createDocument.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/createDocument.js
@@ -128,6 +128,6 @@ export default async function createDocument(request, response) {
}
} catch (err) {
console.log('err ', err);
- return response.status(400).json({ error: 'Something went wrong!' });
+ return response.status(400).json({ error: 'Something went wrong, please try again later!' });
}
}
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplatewithCoordinate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplatewithCoordinate.js
index 4624e2ba3..528827561 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplatewithCoordinate.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplatewithCoordinate.js
@@ -186,6 +186,6 @@ export default async function createTemplatewithCoordinate(request, response) {
}
} catch (err) {
console.log('err ', err);
- return response.status(400).json({ error: 'Something went wrong!' });
+ return response.status(400).json({ error: 'Something went wrong, please try again later!' });
}
}
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/getContactList.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/getContactList.js
index 68e0505d7..3ecfc7885 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/getContactList.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/getContactList.js
@@ -17,6 +17,7 @@ export default async function getContactList(request, response) {
Contactbook.notEqualTo('IsDeleted', true);
Contactbook.limit(limit);
Contactbook.skip(skip);
+ Contactbook.descending('createdAt');
const res = await Contactbook.find({ useMasterKey: true });
if (res && res.length > 0) {
const parseRes = JSON.parse(JSON.stringify(res));
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/saveWebhook.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/saveWebhook.js
index 675fe6e90..bbb2be945 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/saveWebhook.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/saveWebhook.js
@@ -18,14 +18,21 @@ export default async function saveWebhook(request, response) {
const isUrlExist = parseUser?.Webhook && parseUser?.Webhook === Url;
if (!isUrlExist) {
- const updateQuery = new Parse.Object('contracts_Users');
- updateQuery.id = user.id;
- updateQuery.set('Webhook', Url);
- const res = await updateQuery.save(null, { useMasterKey: true });
- if (res) {
- return response.json({
- result: 'Webhook updated successfully!',
- });
+ try {
+ const updateQuery = new Parse.Object('contracts_Users');
+ updateQuery.id = user.id;
+ updateQuery.set('Webhook', Url);
+ const res = await updateQuery.save(null, { useMasterKey: true });
+ if (res) {
+ return response.json({
+ result: 'Webhook updated successfully!',
+ });
+ }
+ } catch (err) {
+ console.log('Err ', err);
+ return response
+ .status(400)
+ .json({ error: 'Something went wrong, please try again later!' });
}
} else {
return response.status(401).json({ error: 'Webhook url already exists!' });
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js
index 30c9b9d41..51fda1139 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateDocument.js
@@ -33,7 +33,7 @@ export default async function updateDocument(request, response) {
updateQuery.set('Note', request?.body?.note);
}
if (request?.body?.description) {
- updateQuery.set('Name', request?.body?.description);
+ updateQuery.set('Description', request?.body?.description);
}
if (request?.body?.folderId) {
updateQuery.set('Folder', {
diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js
index 38dac8e6d..7bbe031b2 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/updateTemplate.js
@@ -33,7 +33,7 @@ export default async function updateTemplate(request, response) {
updateQuery.set('Note', request?.body?.note);
}
if (request?.body?.description) {
- updateQuery.set('Name', request?.body?.description);
+ updateQuery.set('Description', request?.body?.description);
}
if (request?.body?.folderId) {
updateQuery.set('Folder', {