Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

17.7 KB
Raw Blame
# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.
# SPDX-License-Identifier: AGPL-3.0

import json

import httpx
import pytest

from openviking_cli.client.http import AsyncHTTPClient
from openviking_cli.retrieve.types import ContextType
from openviking_cli.utils.config import OPENVIKING_CLI_CONFIG_ENV


class FakeSearchHTTP:
    def __init__(self):
        self.calls: list[tuple[str, dict[str, object]]] = []

    async def post(self, path: str, json: dict[str, object]):
        self.calls.append((path, json))
        return httpx.Response(
            200,
            json={
                "status": "success",
                "result": {
                    "memories": [],
                    "resources": [],
                    "skills": [],
                    "total": 0,
                },
            },
        )


def test_async_http_client_loads_missing_fields_from_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "gateway_token": "gateway-secret",
                "account": "config-account",
                "user": "config-user",
                "actor_peer_id": "config-actor",
                "timeout": 12.5,
                "profile": True,
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient(url="http://explicit-host:1933")

    assert client._url == "http://explicit-host:1933"
    assert client._api_key == "config-key"
    assert client._gateway_token == "gateway-secret"
    assert client._extra_headers["X-Gateway-Token"] == "gateway-secret"
    assert client._account == "config-account"
    assert client._user_id == "config-user"
    assert client._actor_peer_id == "config-actor"
    assert client._timeout == 12.5
    assert client._profile_enabled is True


def test_async_http_client_explicit_values_override_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "account": "config-account",
                "timeout": 12.5,
                "profile": True,
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="explicit-key",
        account="explicit-account",
        timeout=33.0,
        profile_enabled=False,
    )

    assert client._url == "http://explicit-host:1933"
    assert client._api_key == "explicit-key"
    assert client._account == "explicit-account"
    assert client._timeout == 33.0
    assert client._profile_enabled is False


def test_async_http_client_loads_agent_id_from_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "agent_id": "legacy-agent",
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient()

    assert client._actor_peer_id == "legacy-agent"


def test_async_http_client_rejects_mixed_config_agent_and_actor_peer(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "actor_peer_id": "actor-a",
                "agent_id": "legacy-agent",
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    with pytest.raises(ValueError, match="actor_peer_id cannot be used with agent_id"):
        AsyncHTTPClient()


@pytest.mark.asyncio
async def test_async_http_client_omits_identity_headers_when_unconfigured(tmp_path, monkeypatch):
    captured: dict[str, object] = {}
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    class FakeAsyncClient:
        def __init__(self, **kwargs):
            captured.update(kwargs)

    monkeypatch.setattr("openviking_sdk.client.httpx.AsyncClient", FakeAsyncClient)

    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="explicit-key",
        timeout=33.0,
        extra_headers={},
    )
    await client.initialize()

    assert client._user_id is None
    assert captured["headers"] == {
        "X-API-Key": "explicit-key",
    }


@pytest.mark.asyncio
async def test_async_http_client_sends_configured_identity_headers(tmp_path, monkeypatch):
    captured: dict[str, object] = {}
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    class FakeAsyncClient:
        def __init__(self, **kwargs):
            captured.update(kwargs)

    monkeypatch.setattr("openviking_sdk.client.httpx.AsyncClient", FakeAsyncClient)

    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="explicit-key",
        account="explicit-account",
        user_id="explicit-user",
        actor_peer_id="explicit-actor",
        timeout=33.0,
        extra_headers={},
    )
    await client.initialize()

    assert client._user_id == "explicit-user"
    assert captured["headers"] == {
        "X-API-Key": "explicit-key",
        "X-OpenViking-Account": "explicit-account",
        "X-OpenViking-User": "explicit-user",
        "X-OpenViking-Actor-Peer": "explicit-actor",
    }


@pytest.mark.asyncio
async def test_async_http_client_sends_agent_id_as_actor_peer_header(tmp_path, monkeypatch):
    captured: dict[str, object] = {}
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    class FakeAsyncClient:
        def __init__(self, **kwargs):
            captured.update(kwargs)

    monkeypatch.setattr("openviking_sdk.client.httpx.AsyncClient", FakeAsyncClient)

    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="explicit-key",
        agent_id="legacy-agent",
        timeout=33.0,
        extra_headers={},
    )
    await client.initialize()

    assert captured["headers"]["X-OpenViking-Actor-Peer"] == "legacy-agent"
    assert "X-OpenViking-Agent" not in captured["headers"]


@pytest.mark.asyncio
async def test_async_http_client_uses_sdk_initialize_with_compat_limits(tmp_path, monkeypatch):
    captured: dict[str, object] = {}
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    class FakeAsyncClient:
        def __init__(self, **kwargs):
            captured.update(kwargs)

    async def hook(response):
        return response

    monkeypatch.setattr("openviking_sdk.client.httpx.AsyncClient", FakeAsyncClient)

    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        auth_mode="oidc",
        oidc_token="header.payload.signature",
        event_hooks={"response": [hook]},
        timeout=33.0,
        extra_headers={},
    )
    await client.initialize()

    assert captured["headers"]["Authorization"] == "Bearer header.payload.signature"
    assert captured["event_hooks"] == {"response": [hook]}
    limits_repr = repr(captured["limits"])
    assert "max_connections=512" in limits_repr
    assert "max_keepalive_connections=128" in limits_repr


def test_async_http_client_rejects_unknown_ovcli_field(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(json.dumps({"ur": "http://localhost:1933"}))
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    with pytest.raises(ValueError, match=r"ovcli\.ur'.*ovcli\.url"):
        AsyncHTTPClient()


def test_async_http_client_reports_invalid_ovcli_value_path(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(json.dumps({"url": "http://localhost:1933", "timeout": "fast"}))
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    with pytest.raises(ValueError, match=r"Invalid value for 'ovcli\.timeout'"):
        AsyncHTTPClient()


def test_async_http_client_accepts_ovcli_upload_section(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "upload": {
                    "mode": "shared",
                    "ignore_dirs": "node_modules,.cache",
                    "include": "*.md,*.pdf",
                    "exclude": "*.tmp,*.log",
                },
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient()

    assert client._url == "http://config-host:1933"
    assert client._api_key == "config-key"
    assert client._upload_mode == "shared"


def test_async_http_client_rejects_unknown_ovcli_upload_field(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://localhost:1933",
                "upload": {
                    "unknown": "value",
                },
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    with pytest.raises(ValueError, match=r"ovcli\.upload\.unknown"):
        AsyncHTTPClient()


def test_async_http_client_loads_extra_headers_from_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "extra_headers": {
                    "X-Custom-Header": "custom-value",
                    "Authorization": "Bearer token",
                },
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient()

    assert client._url == "http://config-host:1933"
    assert client._extra_headers == {
        "X-Custom-Header": "custom-value",
        "Authorization": "Bearer token",
    }


def test_async_http_client_explicit_extra_headers_override_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://localhost:1933",
                "api_key": "config-key",
                "extra_headers": {"X-Custom-Header": "from-config"},
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient(
        extra_headers={"X-Custom-Header": "from-explicit", "Another-Header": "another-value"}
    )

    assert client._extra_headers == {
        "X-Custom-Header": "from-explicit",
        "Another-Header": "another-value",
    }


def test_async_http_client_loads_extra_header_alias_from_ovcli_config(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "extra_header": {
                    "X-Custom-Header": "custom-value",
                    "Authorization": "Bearer token",
                },
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient()

    assert client._url == "http://config-host:1933"
    assert client._extra_headers == {
        "X-Custom-Header": "custom-value",
        "Authorization": "Bearer token",
    }


def test_async_http_client_prefers_extra_headers_over_alias(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text(
        json.dumps(
            {
                "url": "http://config-host:1933",
                "api_key": "config-key",
                "extra_headers": {"X-Custom-Header": "from-plural"},
                "extra_header": {"X-Custom-Header": "from-singular"},
            }
        )
    )
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    client = AsyncHTTPClient()

    # extra_headers 优先
    assert client._extra_headers == {"X-Custom-Header": "from-plural"}


@pytest.mark.asyncio
async def test_async_http_client_find_does_not_send_peer_id(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(url="http://explicit-host:1933", api_key="key")
    client._http = http

    await client.find(
        "invoice",
        target_uri="viking://user/memories",
    )

    assert http.calls == [
        (
            "/api/v1/search/find",
            {
                "query": "invoice",
                "target_uri": "viking://user/memories",
                "limit": 10,
                "telemetry": False,
            },
        )
    ]


@pytest.mark.asyncio
async def test_async_http_client_agent_id_find_does_not_send_body_agent_id(
    tmp_path, monkeypatch
):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="key",
        agent_id="legacy-agent",
    )
    client._http = http

    await client.find("invoice")

    assert "agent_id" not in http.calls[0][1]
    assert "agent_uri" not in http.calls[0][1]
    assert "peer_id" not in http.calls[0][1]


@pytest.mark.asyncio
async def test_async_http_client_search_does_not_send_peer_id(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(url="http://explicit-host:1933", api_key="key")
    client._http = http

    await client.search(
        "invoice",
        target_uri="viking://user/memories",
        session_id="session-1",
    )

    assert http.calls == [
        (
            "/api/v1/search/search",
            {
                "query": "invoice",
                "target_uri": "viking://user/memories",
                "session_id": "session-1",
                "limit": 10,
                "telemetry": False,
            },
        )
    ]


@pytest.mark.asyncio
async def test_async_http_client_agent_id_add_message_does_not_send_body_agent_id(
    tmp_path,
    monkeypatch,
):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="key",
        agent_id="legacy-agent",
    )
    client._http = http

    await client.add_message("session-1", "assistant", content="hello")
    await client.add_message("session-1", "user", content="hi")

    assert http.calls[0] == (
        "/api/v1/sessions/session-1/messages",
        {"role": "assistant", "content": "hello"},
    )
    assert http.calls[1] == (
        "/api/v1/sessions/session-1/messages",
        {"role": "user", "content": "hi"},
    )


@pytest.mark.asyncio
async def test_async_http_client_agent_id_allows_explicit_message_peer_id(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(
        url="http://explicit-host:1933",
        api_key="key",
        agent_id="legacy-agent",
    )
    client._http = http

    await client.add_message(
        "session-1",
        "assistant",
        content="hello",
        peer_id="legacy-agent",
    )

    assert http.calls == [
        (
            "/api/v1/sessions/session-1/messages",
            {"role": "assistant", "content": "hello", "peer_id": "legacy-agent"},
        )
    ]


@pytest.mark.asyncio
async def test_async_http_client_find_sends_context_type(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(url="http://explicit-host:1933", api_key="key")
    client._http = http

    await client.find(
        "invoice",
        context_type=[ContextType.MEMORY, ContextType.RESOURCE],
    )

    assert http.calls == [
        (
            "/api/v1/search/find",
            {
                "query": "invoice",
                "target_uri": "",
                "limit": 10,
                "context_type": ["memory", "resource"],
                "telemetry": False,
            },
        )
    ]


@pytest.mark.asyncio
async def test_async_http_client_search_sends_context_type(tmp_path, monkeypatch):
    config_path = tmp_path / "ovcli.conf"
    config_path.write_text("{}")
    monkeypatch.setenv(OPENVIKING_CLI_CONFIG_ENV, str(config_path))

    http = FakeSearchHTTP()
    client = AsyncHTTPClient(url="http://explicit-host:1933", api_key="key")
    client._http = http

    await client.search(
        "invoice",
        context_type="skill",
    )

    assert http.calls == [
        (
            "/api/v1/search/search",
            {
                "query": "invoice",
                "target_uri": "",
                "limit": 10,
                "context_type": "skill",
                "telemetry": False,
            },
        )
    ]