Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
Fix/restore health identity (#2978)
xierfloat0279102b2171
diff --git a/openviking/server/routers/system.py b/openviking/server/routers/system.pyindex 7d9dde77b..f0b634ecc 100644--- a/openviking/server/routers/system.py+++ b/openviking/server/routers/system.py@@ -69,7 +69,7 @@ async def _embedding_probe(embedder) -> str:@router.get("/health", tags=["system"])async def health_check(request: Request):- """Health check endpoint (no authentication or identity resolution required)."""+ """Health check endpoint (no authentication required)."""from openviking import __version__result = {"status": "ok", "healthy": True, "version": __version__}@@ -80,6 +80,27 @@ async def health_check(request: Request):if config is not None and hasattr(config, "get_effective_auth_mode"):effective_auth_mode = config.get_effective_auth_mode()result["auth_mode"] = effective_auth_mode++ # Resolve identity when API key is provided+ x_api_key = request.headers.get("X-API-Key")+ authorization = request.headers.get("Authorization")++ if x_api_key or authorization:+ try:+ from openviking.server.auth import resolve_identity++ identity = await resolve_identity(+ request,+ x_api_key=x_api_key,+ authorization=authorization,+ x_openviking_account=request.headers.get("X-OpenViking-Account"),+ x_openviking_user=request.headers.get("X-OpenViking-User"),+ )+ result["account_id"] = str(identity.account_id)+ result["user_id"] = str(identity.user_id)+ result["role"] = str(identity.role)+ except Exception as e:+ logger.warning(f"Failed to resolve identity: {e}")except Exception as e:logger.error(f"Failed to get health check: {e}")diff --git a/tests/server/test_server_health.py b/tests/server/test_server_health.pyindex b8296ea5f..5c8aba094 100644--- a/tests/server/test_server_health.py+++ b/tests/server/test_server_health.py@@ -72,10 +72,11 @@ async def test_health_endpoint(client: httpx.AsyncClient):assert body["status"] == "ok"-async def test_health_endpoint_never_resolves_identity(caplog):+async def test_health_endpoint_resolves_identity_with_api_key(caplog):+ """When an API key is provided, /health should return identity information."""app = create_app(config=ServerConfig(- auth_mode="trusted",+ auth_mode="api_key",host="127.0.0.1",root_api_key="test-root-key",),@@ -90,11 +91,35 @@ async def test_health_endpoint_never_resolves_identity(caplog):assert resp.status_code == 200body = resp.json()assert body["status"] == "ok"- assert body["auth_mode"] == "trusted"+ assert body["auth_mode"] == "api_key"+ assert "account_id" in body+ assert "user_id" in body+ assert "role" in body+ assert body["role"] == "root"+ assert "Failed to resolve identity" not in caplog.text+++async def test_health_endpoint_without_api_key():+ """Without an API key, /health should not return identity information."""+ app = create_app(+ config=ServerConfig(+ auth_mode="api_key",+ host="127.0.0.1",+ root_api_key="test-root-key",+ ),+ service=SimpleNamespace(),+ )+ transport = httpx.ASGITransport(app=app)++ async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:+ resp = await client.get("/health")++ assert resp.status_code == 200+ body = resp.json()+ assert body["status"] == "ok"assert "account_id" not in bodyassert "user_id" not in bodyassert "role" not in body- assert "Failed to resolve identity" not in caplog.textasync def test_system_status(client: httpx.AsyncClient):