Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

Feat/memory overview (#1460)

chenjw0f058eaa2d63
diff --git a/openviking/prompts/templates/memory/entities.yaml b/openviking/prompts/templates/memory/entities.yaml
index cc5499f78..1e5b6725e 100644
--- a/openviking/prompts/templates/memory/entities.yaml
+++ b/openviking/prompts/templates/memory/entities.yaml
@@ -7,6 +7,13 @@ directory: "viking://user/{{ user_space }}/memories/entities"
filename_template: "{{ category }}/{{ name }}.md"
enabled: true
+overview_template: |-
+ # Entities Overview
+ {% if items %}**Category:** {{ items[0].file_content.category }}{% endif %}
+ {% for item in items %}
+ - [{{ item.file_content.name }}](./{{ item.file_name }})
+ {% endfor %}
+
fields:
- name: category
type: string
diff --git a/openviking/prompts/templates/memory/events.yaml b/openviking/prompts/templates/memory/events.yaml
index 57e9080f2..195cea458 100644
--- a/openviking/prompts/templates/memory/events.yaml
+++ b/openviking/prompts/templates/memory/events.yaml
@@ -19,6 +19,14 @@ content_template: |
time: {{extract_context.get_first_message_time_with_weekday_from_ranges(ranges|default(''))|default('N/A')}}
{{ extract_context.read_message_ranges(ranges|default('')).pretty_print() if ranges else '' }}
+
+overview_template: |-
+ # Events Overview
+ {% if items %}**Date:** {{ extract_context.get_year(items[0].file_content.ranges|default(''))|default('') }}/{{ extract_context.get_month(items[0].file_content.ranges|default(''))|default('') }}/{{ extract_context.get_day(items[0].file_content.ranges|default(''))|default('') }}{% endif %}
+ {% for item in items %}
+ - [{{ item.file_content.summary }}](./{{ item.file_name }})
+ {% endfor %}
+
fields:
- name: event_name
type: string
@@ -42,4 +50,5 @@ fields:
description: |
Conversation message index ranges to extract, format: "start-end,start-end,..."
Example: "0-3,40-45" means extract messages 0-3 and 40-45.
- merge_op: immutable
\ No newline at end of file
+ merge_op: immutable
+
diff --git a/openviking/prompts/templates/memory/preferences.yaml b/openviking/prompts/templates/memory/preferences.yaml
index c9d2049a8..d275b93d5 100644
--- a/openviking/prompts/templates/memory/preferences.yaml
+++ b/openviking/prompts/templates/memory/preferences.yaml
@@ -8,6 +8,15 @@ description: |
directory: "viking://user/{{ user_space }}/memories/preferences"
filename_template: "{{ user }}/{{ topic }}.md"
enabled: true
+
+overview_template: |-
+ # Preferences Overview
+ {% if items %}**User:** {{ items[0].file_content.user }}
+ **Topic:** {{ items[0].file_content.topic }}{% endif %}
+ {% for item in items %}
+ - [{{ item.file_content.topic }}](./{{ item.file_name }})
+ {% endfor %}
+
fields:
- name: user
type: string
diff --git a/openviking/session/compressor_v2.py b/openviking/session/compressor_v2.py
index cc81ec9ef..2d5ce523f 100644
--- a/openviking/session/compressor_v2.py
+++ b/openviking/session/compressor_v2.py
@@ -225,9 +225,7 @@ class SessionCompressorV2:
extract_context = ExtractContext(messages)
# Apply operations
- result = await updater.apply_operations(
- operations, ctx, registry=registry, extract_context=extract_context
- )
+ result = await updater.apply_operations(operations, ctx, extract_context=extract_context)
tracer.info(
f"Applied memory operations: written={len(result.written_uris)}, "
diff --git a/openviking/session/memory/dataclass.py b/openviking/session/memory/dataclass.py
index c2567e35a..dcf7873e0 100644
--- a/openviking/session/memory/dataclass.py
+++ b/openviking/session/memory/dataclass.py
@@ -59,6 +59,9 @@ class MemoryTypeSchema(BaseModel):
operation_mode: str = Field(
"upsert", description="Operation mode: 'upsert' (default), 'add_only', or 'update_only'"
)
+ overview_template: Optional[str] = Field(
+ None, description="Overview template for auto-generating .overview.md files"
+ )
class MemoryData(BaseModel):
@@ -205,7 +208,6 @@ class MemoryOperationsProtocol(Protocol):
reasoning: str
write_uris: List[Any]
edit_uris: List[Any]
- edit_overview_uris: List[Any]
delete_uris: List[str]
def is_empty(self) -> bool: ...
@@ -231,10 +233,6 @@ class StructuredMemoryOperations(FaultTolerantBaseModel):
default_factory=list,
description="Edit operations with flat data format",
)
- edit_overview_uris: List[Any] = Field(
- default_factory=list,
- description="Edit operations for .overview.md files using memory_type",
- )
delete_uris: List[str] = Field(
default_factory=list,
description="Delete operations as URI strings",
@@ -245,7 +243,6 @@ class StructuredMemoryOperations(FaultTolerantBaseModel):
return (
len(self.write_uris) == 0
and len(self.edit_uris) == 0
- and len(self.edit_overview_uris) == 0
and len(self.delete_uris) == 0
)
@@ -254,7 +251,6 @@ class StructuredMemoryOperations(FaultTolerantBaseModel):
return {
"write_uris": self.write_uris,
"edit_uris": self.edit_uris,
- "edit_overview_uris": self.edit_overview_uris,
"delete_uris": self.delete_uris,
}
diff --git a/openviking/session/memory/extract_loop.py b/openviking/session/memory/extract_loop.py
index e2dc33734..b764c7745 100644
--- a/openviking/session/memory/extract_loop.py
+++ b/openviking/session/memory/extract_loop.py
@@ -119,7 +119,6 @@ class ExtractLoop:
]
# 预计算 expected_fields
- # self._expected_fields = ["reasoning", "edit_overview_uris", "delete_uris"]
self._expected_fields = ["delete_uris"]
# 获取 ExtractContext(整个流程复用)
@@ -141,17 +140,12 @@ class ExtractLoop:
schema_str = json.dumps(self._json_schema, ensure_ascii=False)
messages = []
- # instruction() 返回字符串,需要包装成 message 格式
- messages.append(
- {
- "role": "system",
- "content": self.context_provider.instruction(),
- }
- )
messages.append(
{
"role": "system",
"content": f"""
+{self.context_provider.instruction()}
+
## Output Format
The final output of the model must strictly follow the JSON Schema format shown below:
```json
diff --git a/openviking/session/memory/memory_type_registry.py b/openviking/session/memory/memory_type_registry.py
index 504476f62..dca13ca68 100644
--- a/openviking/session/memory/memory_type_registry.py
+++ b/openviking/session/memory/memory_type_registry.py
@@ -186,6 +186,7 @@ class MemoryTypeRegistry:
directory=data.get("directory", ""),
enabled=data.get("enabled", data.get("enable", True)),
operation_mode=data.get("operation_mode", "upsert"),
+ overview_template=data.get("overview_template"),
)
async def initialize_memory_files(self, ctx: Any) -> None:
diff --git a/openviking/session/memory/memory_updater.py b/openviking/session/memory/memory_updater.py
index 15b1f4b2b..cad4869d9 100644
--- a/openviking/session/memory/memory_updater.py
+++ b/openviking/session/memory/memory_updater.py
@@ -9,6 +9,7 @@ to the storage system.
from typing import Any, Dict, List, Optional, Tuple
+import jinja2
from openviking.message import Message
from openviking.server.identity import RequestContext
from openviking.session.memory.dataclass import MemoryField
@@ -238,11 +239,11 @@ class MemoryUpdater:
self._viking_fs = get_viking_fs()
return self._viking_fs
+ @tracer()
async def apply_operations(
self,
operations: Any,
ctx: RequestContext,
- registry: Optional[MemoryTypeRegistry] = None,
extract_context: Any = None,
) -> MemoryUpdateResult:
"""
@@ -253,7 +254,7 @@ class MemoryUpdater:
Args:
operations: StructuredMemoryOperations from LLM with per-memory_type fields (e.g., soul, identity)
ctx: Request context
- registry: Optional MemoryTypeRegistry for URI resolution
+ extract_context: Optional context for template rendering
Returns:
MemoryUpdateResult with changes made
@@ -265,9 +266,7 @@ class MemoryUpdater:
logger.warning("VikingFS not available, skipping memory operations")
return result
- # Use provided registry or internal registry
- resolved_registry = registry or self._registry
- if not resolved_registry:
+ if not self._registry:
raise ValueError("MemoryTypeRegistry is required for URI resolution")
# Get actual user/agent space from ctx
@@ -277,7 +276,7 @@ class MemoryUpdater:
# Resolve all URIs first (pass extract_context for template rendering)
resolved_ops = resolve_all_operations(
operations,
- resolved_registry,
+ self._registry,
user_space=user_space,
agent_space=agent_space,
extract_context=extract_context,
@@ -311,15 +310,6 @@ class MemoryUpdater:
tracer.info(f"Op dump: {resolved_op.model.model_dump()}")
result.add_error(resolved_op.uri, e)
- # Apply edit_overview operations
- for op, uri in resolved_ops.edit_overview_operations:
- try:
- await self._apply_edit_overview(op, uri, ctx)
- result.add_edited(uri)
- except Exception as e:
- tracer.error(f"Failed to edit overview {uri}", e)
- result.add_error(uri, e)
-
# Apply delete operations
for _uri_str, uri in resolved_ops.delete_operations:
try:
@@ -333,6 +323,36 @@ class MemoryUpdater:
await self._vectorize_memories(result, ctx)
tracer.info(f"Memory operations applied: {result.summary()}")
+
+ # Generate overview files for directories that have modified files
+ # Include deleted_uris to handle cleanup when files are removed
+ all_modified_uris = result.written_uris + result.edited_uris + result.deleted_uris
+ if all_modified_uris:
+ # Collect unique directories with their memory types
+ dir_to_memory_type = {}
+ for uri in all_modified_uris:
+ # Extract directory path (remove the filename)
+ if "/" in uri:
+ dir_path = "/".join(uri.split("/")[:-1])
+ # Find which memory type this directory belongs to
+ for schema in self._registry.list_all():
+ if schema.overview_template and schema.directory:
+ env = jinja2.Environment(autoescape=False)
+ base_dir = env.from_string(schema.directory).render(
+ user_space=ctx.user.user_space_name(),
+ agent_space=ctx.user.agent_space_name(),
+ )
+ # Check if this uri belongs to this memory type's directory
+ if dir_path.startswith(base_dir.rstrip("/")):
+ # Use the directory containing the file directly
+ if dir_path not in dir_to_memory_type:
+ dir_to_memory_type[dir_path] = schema.memory_type
+
+ # Generate overview for each unique directory
+ for directory, memory_type in dir_to_memory_type.items():
+ logger.info(f"[apply_operations] Generating overview for {memory_type} at {directory}")
+ await self.generate_overview(memory_type, directory, ctx, extract_context)
+
return result
async def _apply_edit(
@@ -528,3 +548,114 @@ class MemoryUpdater:
except Exception as e:
logger.warning(f"Failed to vectorize memory {uri}: {e}")
+
+ async def generate_overview(
+ self,
+ memory_type: str,
+ directory: str,
+ ctx: RequestContext,
+ extract_context: Any = None,
+ ) -> None:
+ """
+ Generate .overview.md file for a directory based on overview_template.
+
+ Args:
+ memory_type: Memory type name (e.g., 'events')
+ directory: Directory path containing memory files
+ ctx: Request context
+ """
+ from openviking.session.memory.utils.messages import parse_memory_file_with_fields
+
+ tracer.info(f"[generate_overview] Called with memory_type={memory_type}, directory={directory}")
+
+ # Get the schema for this memory type
+ registry = self._registry
+ tracer.info(f"[generate_overview] registry={registry}")
+ schema = registry.get(memory_type)
+ tracer.info(f"[generate_overview] schema={schema}, overview_template={schema.overview_template if schema else None}")
+ if not schema or not schema.overview_template:
+ logger.debug(f"No overview_template for memory type: {memory_type}")
+ return
+
+ viking_fs = self._get_viking_fs()
+
+ # List direct .md files in the directory (excluding .overview.md and .abstract.md)
+ try:
+ # Use ls to list direct children
+ entries = await viking_fs.ls(directory, show_all_hidden=True, ctx=ctx)
+ tracer.info(f"[generate_overview] LS entries in {directory}: {entries}")
+
+ # Extract file paths from ls entries
+ md_files = []
+ base_uri = directory.rstrip("/")
+ for entry in entries:
+ name = entry.get("name", "")
+ if name.endswith(".md") and not name.endswith(".overview.md") and not name.endswith(".abstract.md"):
+ md_files.append(f"{base_uri}/{name}")
+
+ tracer.info(f"[generate_overview] Filtered md_files: {md_files}")
+ except Exception as e:
+ logger.warning(f"Failed to list files in {directory}: {e}")
+ return
+
+ # If no memory files, delete the .overview.md and the directory if empty
+ if not md_files:
+ overview_path = f"{directory.rstrip('/')}/.overview.md"
+ try:
+ await viking_fs.delete_file(overview_path, ctx=ctx)
+ tracer.info(f"[generate_overview] Removed orphaned overview: {overview_path}")
+ except Exception:
+ pass
+ # Try to delete empty directory
+ try:
+ await viking_fs.delete_file(directory, ctx=ctx)
+ tracer.info(f"[generate_overview] Removed empty directory: {directory}")
+ except Exception:
+ pass
+ return
+
+ # Parse each file and collect items
+ items = []
+ for file_path in md_files:
+ try:
+ content = await viking_fs.read_file(file_path, ctx=ctx)
+ parsed = parse_memory_file_with_fields(content)
+ tracer.info(f"[generate_overview] Parsed {file_path}: {parsed.keys() if parsed else None}")
+
+ # Extract filename from path
+ filename = file_path.split("/")[-1]
+
+ items.append({
+ "file_name": filename,
+ "file_content": parsed,
+ })
+ except Exception as e:
+ logger.warning(f"Failed to parse {file_path}: {e}")
+ continue
+
+ tracer.info(f"[generate_overview] Total items: {len(items)}")
+ if not items:
+ logger.debug(f"No valid memory files parsed in {directory}")
+ return
+
+ # Render the template
+ try:
+ env = jinja2.Environment(autoescape=False)
+ template = env.from_string(schema.overview_template)
+ rendered = template.render(
+ memory_type=memory_type,
+ items=items,
+ extract_context=extract_context,
+ )
+ tracer.info(f"[generate_overview] Rendered overview length: {len(rendered)}")
+ except Exception as e:
+ logger.error(f"Failed to render overview template for {memory_type}: {e}")
+ return
+
+ # Write .overview.md to the directory
+ overview_path = f"{directory.rstrip('/')}/.overview.md"
+ try:
+ await viking_fs.write_file(overview_path, rendered, ctx=ctx)
+ tracer.info(f"[generate_overview] Generated overview: {overview_path}")
+ except Exception as e:
+ logger.error(f"Failed to write overview {overview_path}: {e}")
diff --git a/openviking/session/memory/schema_model_generator.py b/openviking/session/memory/schema_model_generator.py
index 33a655244..ef123e348 100644
--- a/openviking/session/memory/schema_model_generator.py
+++ b/openviking/session/memory/schema_model_generator.py
@@ -15,7 +15,7 @@ from pydantic.config import ConfigDict
from openviking.session.memory.dataclass import FaultTolerantBaseModel, MemoryTypeSchema
from openviking.session.memory.merge_op import MergeOp, MergeOpFactory
-from openviking.session.memory.merge_op.base import FieldType, StrPatch, get_python_type_for_field
+from openviking.session.memory.merge_op.base import FieldType, get_python_type_for_field
from openviking_cli.utils import get_logger
logger = get_logger(__name__)
@@ -38,14 +38,10 @@ class SchemaModelGenerator:
for polymorphic memory data.
"""
- # Generic overview edit model shared by all memory types
- _generic_overview_edit_model: Optional[Type[BaseModel]] = None
-
def __init__(self, schemas: List[MemoryTypeSchema]):
self.schemas = schemas
self._model_cache: Dict[str, Type[BaseModel]] = {}
self._flat_data_models: Dict[str, Type[BaseModel]] = {}
- self._overview_edit_models: Dict[str, Type[BaseModel]] = {}
self._union_model: Optional[Type[BaseModel]] = None
self._operations_model: Optional[Type[BaseModel]] = None
@@ -121,44 +117,6 @@ class SchemaModelGenerator:
models[memory_type.memory_type] = self.create_flat_data_model(memory_type)
return models
- def create_overview_edit_model(self, memory_type: MemoryTypeSchema) -> Type[BaseModel]:
- """
- Create a simplified model for editing .overview.md files.
-
- The model includes:
- - memory_type (literal discriminator)
- - overview (Union[str, StrPatch])
-
- Args:
- memory_type: The memory type schema
-
- Returns:
- Dynamically created overview edit model class
- """
- # Use cached generic model
- if SchemaModelGenerator._generic_overview_edit_model is not None:
- return SchemaModelGenerator._generic_overview_edit_model
-
- # Create generic model with string memory_type (not Literal)
- model = create_model(
- "GenericOverviewEdit",
- __config__=ConfigDict(extra="forbid"),
- memory_type=(
- str,
- Field(..., description="Memory type to edit (e.g., 'profile', 'skills')"),
- ),
- overview=(
- Optional[Union[str, StrPatch]],
- Field(
- None,
- description="Overview content (L1). Use Markdown with internal links: [filename](filename.md), e.g., [python](python.md), [go](go.md). Supports direct string or patch format.",
- ),
- ),
- )
-
- SchemaModelGenerator._generic_overview_edit_model = model
- return model
-
def create_discriminated_union_model(self) -> Type[BaseModel]:
"""
Create a unified MemoryData model with discriminator support.
@@ -271,14 +229,6 @@ class SchemaModelGenerator:
# enabled_memory_types[0] if enabled_memory_types else None
# )
- # field_definitions["edit_overview_uris"] = (
- # List[generic_overview_edit], # type: ignore
- # Field(
- # default_factory=list,
- # description="Edit operations for .overview.md files using memory_type",
- # ),
- # )
-
field_definitions["delete_uris"] = (
List[str],
Field(default_factory=list, description="Delete operations as URI strings"),
@@ -304,7 +254,7 @@ class SchemaModelGenerator:
else:
# Single value (not None)
return False
- return len(self.edit_overview_uris) == 0 and len(self.delete_uris) == 0
+ return len(self.delete_uris) == 0
def to_legacy_operations(self) -> Dict[str, Any]:
"""Convert new per-type structure to legacy write_uris/edit_uris format."""
@@ -330,7 +280,6 @@ class SchemaModelGenerator:
return {
"write_uris": write_uris,
"edit_uris": edit_uris,
- #"edit_overview_uris": self.edit_overview_uris,
"delete_uris": self.delete_uris,
}
diff --git a/openviking/session/memory/session_extract_context_provider.py b/openviking/session/memory/session_extract_context_provider.py
index 90be44c83..f5a97c6c7 100644
--- a/openviking/session/memory/session_extract_context_provider.py
+++ b/openviking/session/memory/session_extract_context_provider.py
@@ -36,6 +36,10 @@ class SessionExtractContextProvider(ExtractContextProvider):
self._schema_directories = None
self._extract_context = None # 缓存 ExtractContext 实例
+ # 读取 eager_prefetch 配置
+ config = get_openviking_config()
+ self._eager_prefetch = config.memory.eager_prefetch if config.memory else False
+
def get_extract_context(self) -> "ExtractContext":
"""获取或创建 ExtractContext 实例(缓存)"""
from openviking.session.memory.memory_updater import ExtractContext
@@ -286,6 +290,7 @@ After exploring, analyze the conversation and output ALL memory write/edit/delet
# logger.warning(f"Failed to read .overview.md: {e}")
# 在每个之前 ls 的目录内执行 search(替换原来的 ls 操作)
+ files_to_read_from_search = [] # 收集需要读取的文件(eager_prefetch 模式)
if search_tool and viking_fs and ls_dirs:
for dir_uri in ls_dirs:
# 创建只在该目录搜索的 tool_ctx
@@ -303,13 +308,16 @@ After exploring, analyze the conversation and output ALL memory write/edit/delet
# 处理搜索结果
if isinstance(search_result, list):
result_value = [m.get("uri", "") for m in search_result]
+ if self._eager_prefetch:
+ files_to_read_from_search.extend(result_value)
elif isinstance(search_result, dict):
if "error" in search_result:
result_value = f"Error: {search_result.get('error')}"
else:
- result_value = [
- m.get("uri", "") for m in search_result.get("memories", [])
- ]
+ uris = [m.get("uri", "") for m in search_result.get("memories", [])]
+ result_value = uris
+ if self._eager_prefetch:
+ files_to_read_from_search.extend(uris)
else:
result_value = []
@@ -339,10 +347,31 @@ After exploring, analyze the conversation and output ALL memory write/edit/delet
except Exception as e:
logger.warning(f"Failed to read {file_uri}: {e}")
+ # eager_prefetch 模式:读取所有搜索到的文件内容
+ if self._eager_prefetch and read_tool and viking_fs:
+ for file_uri in files_to_read_from_search:
+ if not file_uri:
+ continue
+ try:
+ result_str = await read_tool.execute(viking_fs, tool_ctx, uri=file_uri)
+ add_tool_call_pair_to_messages(
+ messages=pre_fetch_messages,
+ call_id=call_id_seq,
+ tool_name="read",
+ params={"uri": file_uri},
+ result=result_str,
+ )
+ call_id_seq += 1
+ except Exception as e:
+ logger.warning(f"Failed to read {file_uri}: {e}")
+
return pre_fetch_messages
def get_tools(self) -> List[str]:
- """获取可用的工具列表 - 会话场景只使用 read"""
+ """获取可用的工具列表"""
+ if self._eager_prefetch:
+ # eager_prefetch 模式下不提供工具,所有内容已在 prefetch 中加载
+ return []
return ["read"]
def get_memory_schemas(self, ctx: RequestContext) -> List[Any]:
diff --git a/openviking/session/memory/utils/uri.py b/openviking/session/memory/utils/uri.py
index dcc2a0613..85c5628f0 100644
--- a/openviking/session/memory/utils/uri.py
+++ b/openviking/session/memory/utils/uri.py
@@ -379,60 +379,12 @@ def resolve_flat_model_uri(
return generate_uri(schema, uri_fields, user_space, agent_space, extract_context)
-def resolve_overview_edit_uri(
- overview_model: Any,
- registry: MemoryTypeRegistry,
- user_space: str = "default",
- agent_space: str = "default",
-) -> str:
- """
- Resolve URI for an overview edit operation.
-
- Args:
- overview_model: Overview edit model with memory_type and overview fields
- registry: MemoryTypeRegistry to get schema
- user_space: User space for substitution
- agent_space: Agent space for substitution
-
- Returns:
- Resolved URI for .overview.md file (e.g., viking://user/default/memories/.overview.md)
-
- Raises:
- ValueError: If memory_type not found or directory not found
- """
- # Get memory_type from model
- if hasattr(overview_model, "memory_type"):
- memory_type_str = overview_model.memory_type
- elif isinstance(overview_model, dict):
- memory_type_str = overview_model.get("memory_type")
- else:
- raise ValueError("overview_model must have memory_type field")
-
- # Get schema from registry
- schema = registry.get(memory_type_str)
- if not schema:
- raise ValueError(f"Unknown memory type: {memory_type_str}")
-
- if not schema.directory:
- raise ValueError(f"Memory type {memory_type_str} has no directory configured")
-
- # Render directory using Jinja2
- context = {"user_space": user_space, "agent_space": agent_space}
- directory = _render_jinja_template(schema.directory, context)
-
- # Return the .overview.md URI
- return f"{directory}/.overview.md"
-
-
class ResolvedOperations:
"""Operations with resolved URIs."""
def __init__(self):
# Unified operations list - all are edit (will read existing file first)
self.operations: List[ResolvedOperation] = []
- self.edit_overview_operations: List[
- Tuple[Any, str]
- ] = [] # (overview_edit_model, overview_uri)
self.delete_operations: List[Tuple[str, str]] = [] # (uri_str, uri_str) - just the uri
self.errors: List[str] = []
@@ -494,15 +446,6 @@ def resolve_all_operations(
except Exception as e:
resolved.errors.append(f"Failed to resolve {field_name} operation: {e}")
- # Resolve edit_overview operations (overview edit models)
- # if hasattr(operations, "edit_overview_uris"):
- # for op in operations.edit_overview_uris:
- # try:
- # uri = resolve_overview_edit_uri(op, registry, user_space, agent_space)
- # resolved.edit_overview_operations.append((op, uri))
- # except Exception as e:
- # resolved.errors.append(f"Failed to resolve edit_overview operation: {e}")
-
# Resolve delete operations (already URI strings)
if hasattr(operations, "delete_uris"):
for uri in operations.delete_uris:
@@ -557,10 +500,6 @@ def validate_operations_uris(
if not is_uri_allowed(resolved_op.uri, allowed_dirs, allowed_patterns):
errors.append(f"Operation URI not allowed: {resolved_op.uri}")
- for _op, uri in resolved.edit_overview_operations:
- if not is_uri_allowed(uri, allowed_dirs, allowed_patterns):
- errors.append(f"Edit overview operation URI not allowed: {uri}")
-
for _uri_str, uri in resolved.delete_operations:
if not is_uri_allowed(uri, allowed_dirs, allowed_patterns):
errors.append(f"Delete operation URI not allowed: {uri}")
diff --git a/openviking_cli/utils/config/memory_config.py b/openviking_cli/utils/config/memory_config.py
index ec4e4d7dc..075376906 100644
--- a/openviking_cli/utils/config/memory_config.py
+++ b/openviking_cli/utils/config/memory_config.py
@@ -40,6 +40,14 @@ class MemoryConfig(BaseModel):
"0 means unlimited retries."
),
)
+ eager_prefetch: bool = Field(
+ default=False,
+ description=(
+ "When enabled, prefetch will execute search + read to preload all memory file contents "
+ "into the context, and no read/search tools will be provided to the LLM. "
+ "When disabled (default), LLM has read tool and reads files on-demand."
+ ),
+ )
model_config = {"extra": "forbid"}
diff --git a/tests/session/memory/test_compressor_v2.py b/tests/session/memory/test_compressor_v2.py
index a783bed57..d7facd72b 100644
--- a/tests/session/memory/test_compressor_v2.py
+++ b/tests/session/memory/test_compressor_v2.py
@@ -302,7 +302,6 @@ class TestCompressorV2:
SimpleNamespace(
write_uris=[],
edit_uris=[],
- edit_overview_uris=[],
delete_uris=[],
),
[],
@@ -447,7 +446,6 @@ class TestCompressorV2:
SimpleNamespace(
write_uris=[],
edit_uris=[],
- edit_overview_uris=[],
delete_uris=[],
),
[],
diff --git a/tests/session/memory/test_memory_extractor_flow.py b/tests/session/memory/test_memory_extractor_flow.py
index af6bde56b..a50ffa800 100644
--- a/tests/session/memory/test_memory_extractor_flow.py
+++ b/tests/session/memory/test_memory_extractor_flow.py
@@ -540,9 +540,8 @@ class TestMemoryExtractorFlow:
with patch(
"openviking.session.memory.memory_updater.get_viking_fs", return_value=viking_fs
):
- updater = MemoryUpdater()
- # Pass the registry from orchestrator
- result = await updater.apply_operations(operations, ctx, registry=orchestrator.registry)
+ updater = MemoryUpdater(registry=orchestrator.registry)
+ result = await updater.apply_operations(operations, ctx)
assert isinstance(result, MemoryUpdateResult)
@@ -658,9 +657,8 @@ class TestMemoryExtractorFlow:
with patch(
"openviking.session.memory.memory_updater.get_viking_fs", return_value=viking_fs
):
- updater = MemoryUpdater()
- # Pass the registry from orchestrator
- result = await updater.apply_operations(operations, ctx, registry=orchestrator.registry)
+ updater = MemoryUpdater(registry=orchestrator.registry)
+ result = await updater.apply_operations(operations, ctx)
assert isinstance(result, MemoryUpdateResult)