Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(memory): skip empty messages in event chat logs (#5139)
agent179348922491
diff --git a/openviking/session/memory/memory_updater.py b/openviking/session/memory/memory_updater.pyindex 1910129c0..066209ad3 100644--- a/openviking/session/memory/memory_updater.py+++ b/openviking/session/memory/memory_updater.py@@ -622,7 +622,9 @@ class MessageRange:if not current_messages:returncontent = self._format_merged_content(current_messages)- formatted.append(f"**{self._speaker_for(current_messages[0])}**: {content}")+ # Tool-only messages have no chat text, but must keep their range indices.+ if content.strip():+ formatted.append(f"**{self._speaker_for(current_messages[0])}**: {content}")current_messages = []for msg in msg_group:diff --git a/tests/session/memory/test_memory_updater.py b/tests/session/memory/test_memory_updater.pyindex 77f997a09..0d6b49f33 100644--- a/tests/session/memory/test_memory_updater.py+++ b/tests/session/memory/test_memory_updater.py@@ -4,12 +4,13 @@Tests for MemoryUpdater."""+from copy import deepcopyfrom unittest.mock import AsyncMock, MagicMock, patchimport pytestfrom openviking.message import Message-from openviking.message.part import TextPart+from openviking.message.part import TextPart, ToolPartfrom openviking.prompts.manager import PromptManagerfrom openviking.server.identity import RequestContext, Rolefrom openviking.session.memory.dataclass import (@@ -160,6 +161,94 @@ class TestMemoryUpdater:assert "Gina can expand her clothing store now." in content+ @pytest.mark.parametrize("peer_id", [None, "project-peer"])+ def test_extract_context_event_content_skips_tool_only_messages(self, peer_id):+ messages = [+ Message(+ id="0",+ role="assistant",+ peer_id=peer_id,+ parts=[TextPart(text="Started writing. "), TextPart(text="Keep spacing.")],+ ),+ Message(+ id="1",+ role="assistant",+ peer_id=peer_id,+ parts=[ToolPart(tool_name="write", tool_status="running")],+ ),+ Message(+ id="2",+ role="user",+ peer_id=peer_id,+ parts=[ToolPart(tool_name="write", tool_status="completed", tool_output="OK")],+ ),+ Message(+ id="3",+ role="assistant",+ peer_id=peer_id,+ parts=[TextPart(text="Finished writing."), ToolPart(tool_name="write")],+ ),+ ]+ original = deepcopy(messages)+ context = ExtractContext(messages)+ speaker = peer_id or "assistant"+ expected = (+ f"**{speaker}**: Started writing. Keep spacing.\n**{speaker}**: Finished writing."+ )++ assert context.get_event_content("0-3", "Summary", 0) == expected+ assert context.get_event_content("0,3", "Summary", 0) == expected.replace("\n", "\n...\n")+ assert context.read_message_ranges("1-2").elements == [messages[1:3]]+ assert messages == original++ registry = MemoryTypeRegistry(load_schemas=False)+ registry.load_from_yaml(+ str(PromptManager._get_bundled_templates_dir() / "memory" / "events.yaml")+ )+ rendered = MemoryFileUtils.write(+ MemoryFile(extra_fields={"summary": "Summary", "ranges": "0-3"}),+ content_template=registry.get("events").content_template,+ extract_context=context,+ )+ assert expected in rendered+ assert not any(line.strip() == f"**{speaker}**:" for line in rendered.splitlines())++ @pytest.mark.parametrize("peer_id", [None, "project-peer"])+ @pytest.mark.parametrize(+ "parts",+ [+ pytest.param([], id="no-parts"),+ pytest.param([TextPart(text="")], id="empty-text"),+ pytest.param([TextPart(text=" \t\n")], id="whitespace-text"),+ pytest.param([ToolPart(tool_name="read", tool_status="running")], id="tool-call"),+ pytest.param(+ [ToolPart(tool_name="read", tool_status="completed", tool_output="OK")],+ id="tool-result",+ ),+ ],+ )+ def test_extract_context_event_content_skips_empty_bodies(self, peer_id, parts):+ context = ExtractContext([Message(id="0", role="user", peer_id=peer_id, parts=parts)])++ assert context.read_message_ranges("0").pretty_print() == ""+ assert context.get_event_content("0", "", 0) == ""+ assert context.get_event_content("0", "Summary", 0) == "Summary"++ @pytest.mark.parametrize("peer_id", [None, "project-peer"])+ def test_extract_context_event_content_preserves_chunks_around_tool_messages(self, peer_id):+ text = "A long source message with several sentences. " * 12+ messages = [+ Message(id="0", role="assistant", peer_id=peer_id, parts=[TextPart(text=text)]),+ Message(id="1", role="assistant", peer_id=peer_id, parts=[ToolPart(tool_name="read")]),+ Message(id="2", role="user", peer_id=peer_id, parts=[TextPart(text="Confirmed.")]),+ ]+ context = ExtractContext(messages)++ assert len(context.messages) > len(messages)+ assert context.get_event_content(f"0-{len(context.messages) - 1}", "", 0) == (+ f"**{peer_id or 'assistant'}**: {text}\n**{peer_id or 'user'}**: Confirmed."+ )+def test_create(self):"""Test creating a MemoryUpdater."""updater = MemoryUpdater()