Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(session): drop user registry check for message role_id (#1601)

Qin Haojie1b5728a906f4
diff --git a/openviking/server/routers/sessions.py b/openviking/server/routers/sessions.py
index 6ea6b2d29..20bba03ec 100644
--- a/openviking/server/routers/sessions.py
+++ b/openviking/server/routers/sessions.py
@@ -133,14 +133,6 @@ def _resolve_message_role_id(
if not _ROLE_ID_PATTERN.match(role_id):
raise InvalidArgumentError("role_id must be alpha-numeric string.")
- if request.role == "user":
- api_key_manager = getattr(http_request.app.state, "api_key_manager", None)
- has_user = getattr(api_key_manager, "has_user", None)
- if callable(has_user) and not has_user(ctx.account_id, role_id):
- raise InvalidArgumentError(
- f"role_id '{role_id}' is not a registered user in account '{ctx.account_id}'."
- )
-
return role_id
diff --git a/tests/server/test_api_sessions.py b/tests/server/test_api_sessions.py
index 05a8d9380..949f1c347 100644
--- a/tests/server/test_api_sessions.py
+++ b/tests/server/test_api_sessions.py
@@ -345,7 +345,7 @@ async def test_add_message_user_request_autofills_role_id(service, monkeypatch):
assert session.messages[-1].role_id == "assistant-user"
-async def test_add_message_rejects_unregistered_user_role_id(service, monkeypatch):
+async def test_add_message_admin_request_allows_unregistered_user_role_id(service, monkeypatch):
manager = APIKeyManager(root_key=TEST_ROOT_KEY, viking_fs=service.viking_fs)
await manager.load()
account_id = "acct_session_invalid"
@@ -356,15 +356,19 @@ async def test_add_message_rejects_unregistered_user_role_id(service, monkeypatc
role=Role.ADMIN,
)
- with pytest.raises(InvalidArgumentError, match="not a registered user"):
- await _call_add_message_route(
- service,
- monkeypatch,
- ctx=ctx,
- payload=_message_request("user", content="hello invalid", role_id="ghost"),
- api_key_manager=manager,
- session_id="invalid-user-role-id",
- )
+ response = await _call_add_message_route(
+ service,
+ monkeypatch,
+ ctx=ctx,
+ payload=_message_request("user", content="hello invalid", role_id="ghost"),
+ api_key_manager=manager,
+ session_id="invalid-user-role-id",
+ )
+
+ assert response.result["message_count"] == 1
+ session = await service.sessions.get("invalid-user-role-id", ctx, auto_create=False)
+ await session.load()
+ assert session.messages[-1].role_id == "ghost"
async def test_add_multiple_messages(client: httpx.AsyncClient):