Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(acl): resolve ACLs from records hidden by the caller's scroll filter (#5983)

t0saki2290984168c1
diff --git a/openviking/storage/acl.py b/openviking/storage/acl.py
index 129608b79..43ab1c3f2 100644
--- a/openviking/storage/acl.py
+++ b/openviking/storage/acl.py
@@ -2,7 +2,7 @@
from __future__ import annotations
-from dataclasses import dataclass
+from dataclasses import dataclass, replace
from enum import Enum
from typing import TYPE_CHECKING, Any, Iterable, Literal, Mapping, Protocol, Sequence
@@ -361,7 +361,8 @@ class AclManager:
limit=500,
cursor=cursor,
output_fields=output_fields,
- ctx=ctx,
+ # ACL resolution must see records the caller's own grants hide.
+ ctx=replace(ctx, bypass_acl=True),
)
records.extend(page)
if cursor is None:
diff --git a/tests/storage/test_viking_vector_scope_filter.py b/tests/storage/test_viking_vector_scope_filter.py
index 5394165b0..d227869ad 100644
--- a/tests/storage/test_viking_vector_scope_filter.py
+++ b/tests/storage/test_viking_vector_scope_filter.py
@@ -9,7 +9,7 @@ from unittest.mock import AsyncMock
import pytest
from openviking.server.identity import RequestContext, Role
-from openviking.storage.acl import AclManager
+from openviking.storage.acl import AclAction, AclManager, acl_allows
from openviking.storage.collection_schemas import CollectionSchemas
from openviking.storage.expr import And, Eq, In, Or, PathScope, RawDSL
from openviking.storage.viking_vector_index_backend import (
@@ -155,6 +155,54 @@ async def test_scroll_and_count_hide_cross_user_records(vector_backend_factory,
await backend.close()
[email protected](("reader_grants", "allowed"), [([], False), (["1:user:reader"], True)])
+async def test_acl_resolution_sees_restricted_records_hidden_from_caller(
+ vector_backend_factory, tmp_path, reader_grants, allowed
+):
+ reader = RequestContext(user=UserIdentifier("acct", "reader"), role=Role.USER)
+ backend = vector_backend_factory(
+ config=VectorDBBackendConfig(
+ backend="local",
+ name="context",
+ dimension=4,
+ path=str(tmp_path / "acl_vectors"),
+ )
+ )
+ try:
+ assert await backend.create_collection(
+ "context", CollectionSchemas.context_collection("context", 4)
+ )
+ backend.acl_manager = AclManager(backend, _AclConfigReader(True))
+ await backend._upsert_many_raw(
+ [
+ {
+ "id": record_id,
+ "uri": uri,
+ "account_id": "acct",
+ "context_type": "resource",
+ "level": 2,
+ "updated_at": "2026-01-01T00:00:00Z",
+ "vector": [1.0, 0.0, 0.0, 0.0],
+ "acl_mode": mode,
+ "acl_direct_grants": direct,
+ "acl_inherited_grants": inherited,
+ }
+ for record_id, uri, mode, direct, inherited in (
+ ("dir", "viking://resources/private", "restricted", reader_grants, []),
+ ("file", "viking://resources/private/rules.md", "inherit", [], reader_grants),
+ )
+ ],
+ ctx=RequestContext(user=UserIdentifier("acct", "admin"), role=Role.ADMIN),
+ )
+
+ acl = await backend.acl_manager.resolve("viking://resources/private/rules.md", reader)
+
+ assert acl_allows(acl, reader, AclAction.READ) is allowed
+ finally:
+ await backend.close()
+
+
def test_descendant_target_elides_only_visible_root_path_filter():
ctx = _ctx()
target = "viking://resources/wiki/physics"