Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(embedder): scope Gemini async clients to each request (#5428)

Asurada27fc25171866
diff --git a/openviking/models/embedder/gemini_embedders.py b/openviking/models/embedder/gemini_embedders.py
index f962792fa..3ab1cd937 100644
--- a/openviking/models/embedder/gemini_embedders.py
+++ b/openviking/models/embedder/gemini_embedders.py
@@ -136,20 +136,17 @@ class GeminiDenseEmbedder(DenseEmbedderBase):
)
if dimension is not None and not (1 <= dimension <= 3072):
raise ValueError(f"dimension must be between 1 and 3072, got {dimension}")
+ self._client_kwargs: Dict[str, Any] = {"api_key": api_key}
if _HTTP_RETRY_AVAILABLE:
- self.client = genai.Client(
- api_key=api_key,
- http_options=HttpOptions(
- retry_options=HttpRetryOptions(
- attempts=max(self.max_retries + 1, 1),
- initial_delay=0.5,
- max_delay=8.0,
- exp_base=2.0,
- )
- ),
+ self._client_kwargs["http_options"] = HttpOptions(
+ retry_options=HttpRetryOptions(
+ attempts=max(self.max_retries + 1, 1),
+ initial_delay=0.5,
+ max_delay=8.0,
+ exp_base=2.0,
+ )
)
- else:
- self.client = genai.Client(api_key=api_key)
+ self.client = genai.Client(**self._client_kwargs)
self.task_type = task_type
self.query_param = query_param
self.document_param = document_param
@@ -252,11 +249,15 @@ class GeminiDenseEmbedder(DenseEmbedderBase):
task_type = self._resolve_task_type(is_query=is_query, task_type=task_type)
async def _call() -> EmbedResult:
- result = await self.client.aio.models.embed_content(
- model=self.model_name,
- contents=text,
- config=self._build_config(task_type=task_type, title=title),
- )
+ # Keep creation, use and cleanup on the calling event loop.
+ # Account embedders are shared by HTTP and background worker loops.
+ with genai.Client(**self._client_kwargs) as client:
+ async with client.aio as async_client:
+ result = await async_client.models.embed_content(
+ model=self.model_name,
+ contents=text,
+ config=self._build_config(task_type=task_type, title=title),
+ )
vector = truncate_and_normalize(list(result.embeddings[0].values), self._dimension)
return EmbedResult(dense_vector=vector)
@@ -281,8 +282,4 @@ class GeminiDenseEmbedder(DenseEmbedderBase):
return self._dimension
def close(self):
- if hasattr(self.client, "_http_client"):
- try:
- self.client._http_client.close()
- except Exception:
- pass
+ self.client.close()