Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(reindex): repair maintenance route and keep content compatibility (#1583)
Brian Le28d54f3aa3cd
diff --git a/openviking/server/routers/content.py b/openviking/server/routers/content.pyindex 73a9de442..09ba9046c 100644--- a/openviking/server/routers/content.py+++ b/openviking/server/routers/content.py@@ -2,6 +2,7 @@# SPDX-License-Identifier: AGPL-3.0"""Content endpoints for OpenViking HTTP Server."""+import asynciofrom urllib.parse import quotefrom fastapi import APIRouter, Body, Depends, Query@@ -9,10 +10,16 @@ from fastapi.responses import Response as FastAPIResponsefrom pydantic import BaseModel, ConfigDictfrom openviking.pyagfs.exceptions import AGFSClientError, AGFSNotFoundError-from openviking.server.auth import get_request_context+from openviking.server.auth import get_request_context, require_rolefrom openviking.server.dependencies import get_service-from openviking.server.identity import RequestContext-from openviking.server.models import Response+from openviking.server.identity import RequestContext, Role+from openviking.server.models import ErrorInfo, Response+from openviking.server.routers.maintenance import (+ REINDEX_TASK_TYPE,+ ReindexRequest,+ _background_reindex_tracked,+ _do_reindex,+)from openviking.server.telemetry import run_operationfrom openviking.telemetry import TelemetryRequestfrom openviking_cli.exceptions import NotFoundError@@ -171,3 +178,69 @@ async def write(result=execution.result,telemetry=execution.telemetry,).model_dump(exclude_none=True)++[email protected]("/reindex", deprecated=True)+async def reindex(+ body: ReindexRequest = Body(...),+ ctx: RequestContext = require_role(Role.ROOT, Role.ADMIN),+):+ """Compatibility alias for older clients that still call /api/v1/content/reindex."""+ from openviking.service.task_tracker import get_task_tracker+ from openviking.storage.viking_fs import get_viking_fs++ uri = body.uri+ viking_fs = get_viking_fs()++ if not await viking_fs.exists(uri, ctx=ctx):+ return Response(+ status="error",+ error=ErrorInfo(code="NOT_FOUND", message=f"URI not found: {uri}"),+ )++ service = get_service()+ tracker = get_task_tracker()++ if body.wait:+ if tracker.has_running(+ REINDEX_TASK_TYPE,+ uri,+ owner_account_id=ctx.account_id,+ owner_user_id=ctx.user.user_id,+ ):+ return Response(+ status="error",+ error=ErrorInfo(+ code="CONFLICT",+ message=f"URI {uri} already has a reindex in progress",+ ),+ )+ result = await _do_reindex(service, uri, body.regenerate, ctx)+ return Response(status="ok", result=result)++ task = tracker.create_if_no_running(+ REINDEX_TASK_TYPE,+ uri,+ owner_account_id=ctx.account_id,+ owner_user_id=ctx.user.user_id,+ )+ if task is None:+ return Response(+ status="error",+ error=ErrorInfo(+ code="CONFLICT",+ message=f"URI {uri} already has a reindex in progress",+ ),+ )+ asyncio.create_task(+ _background_reindex_tracked(service, uri, body.regenerate, ctx, task.task_id)+ )+ return Response(+ status="ok",+ result={+ "uri": uri,+ "status": "accepted",+ "task_id": task.task_id,+ "message": "Reindex is processing in the background",+ },+ )diff --git a/openviking/server/routers/maintenance.py b/openviking/server/routers/maintenance.pyindex d2fb37780..a258bc598 100644--- a/openviking/server/routers/maintenance.py+++ b/openviking/server/routers/maintenance.py@@ -4,12 +4,12 @@import asyncio-from fastapi import APIRouter, Body, Depends+from fastapi import APIRouter, Bodyfrom pydantic import BaseModel-from openviking.server.auth import get_request_context, require_auth_root_or_admin+from openviking.server.auth import require_rolefrom openviking.server.dependencies import get_service-from openviking.server.identity import RequestContext+from openviking.server.identity import RequestContext, Rolefrom openviking.server.models import ErrorInfo, Responsefrom openviking_cli.utils import get_logger@@ -30,10 +30,9 @@ router = APIRouter(prefix="/api/v1/maintenance", tags=["maintenance"])@router.post("/reindex")-@require_auth_root_or_adminasync def reindex(- request: ReindexRequest = Body(...),- _ctx: RequestContext = Depends(get_request_context),+ body: ReindexRequest = Body(...),+ ctx: RequestContext = require_role(Role.ROOT, Role.ADMIN),):"""Reindex content at a URI.@@ -47,11 +46,11 @@ async def reindex(from openviking.service.task_tracker import get_task_trackerfrom openviking.storage.viking_fs import get_viking_fs- uri = request.uri+ uri = body.uriviking_fs = get_viking_fs()# Validate URI exists- if not await viking_fs.exists(uri, ctx=_ctx):+ if not await viking_fs.exists(uri, ctx=ctx):return Response(status="error",error=ErrorInfo(code="NOT_FOUND", message=f"URI not found: {uri}"),@@ -60,13 +59,13 @@ async def reindex(service = get_service()tracker = get_task_tracker()- if request.wait:+ if body.wait:# Synchronous path: block until reindex completesif tracker.has_running(REINDEX_TASK_TYPE,uri,- owner_account_id=_ctx.account_id,- owner_user_id=_ctx.user.user_id,+ owner_account_id=ctx.account_id,+ owner_user_id=ctx.user.user_id,):return Response(status="error",@@ -75,15 +74,15 @@ async def reindex(message=f"URI {uri} already has a reindex in progress",),)- result = await _do_reindex(service, uri, request.regenerate, _ctx)+ result = await _do_reindex(service, uri, body.regenerate, ctx)return Response(status="ok", result=result)else:# Async path: run in background, return task_id for pollingtask = tracker.create_if_no_running(REINDEX_TASK_TYPE,uri,- owner_account_id=_ctx.account_id,- owner_user_id=_ctx.user.user_id,+ owner_account_id=ctx.account_id,+ owner_user_id=ctx.user.user_id,)if task is None:return Response(@@ -94,7 +93,7 @@ async def reindex(),)asyncio.create_task(- _background_reindex_tracked(service, uri, request.regenerate, _ctx, task.task_id)+ _background_reindex_tracked(service, uri, body.regenerate, ctx, task.task_id))return Response(status="ok",diff --git a/tests/server/test_api_content.py b/tests/server/test_api_content.pyindex e1edc4184..2228e17c9 100644--- a/tests/server/test_api_content.py+++ b/tests/server/test_api_content.py@@ -149,8 +149,45 @@ async def test_reindex_uses_request_tenant_for_exists(monkeypatch):)monkeypatch.setattr("openviking.server.routers.content._do_reindex", fake_do_reindex)- response = await reindex(request=request, _ctx=ctx)+ response = await reindex(body=request, ctx=ctx)assert response.status == "ok"assert seen["uri"] == "viking://resources/demo/demo-note.md"assert seen["ctx"] == ctx+++async def test_maintenance_reindex_sync_success_returns_ok_payload(client, monkeypatch):+ async def fake_do_reindex(service, uri, regenerate, ctx):+ return {"status": "success", "message": "Indexed 1 resources"}++ class FakeVikingFS:+ async def exists(self, uri, ctx=None):+ return True++ class FakeTracker:+ def has_running(self, task_type, uri, owner_account_id=None, owner_user_id=None):+ return False++ monkeypatch.setattr(+ "openviking.storage.viking_fs.get_viking_fs",+ lambda: FakeVikingFS(),+ )+ monkeypatch.setattr(+ "openviking.service.task_tracker.get_task_tracker",+ lambda: FakeTracker(),+ )+ monkeypatch.setattr(+ "openviking.server.routers.maintenance.get_service",+ lambda: SimpleNamespace(),+ )+ monkeypatch.setattr("openviking.server.routers.maintenance._do_reindex", fake_do_reindex)++ response = await client.post(+ "/api/v1/maintenance/reindex",+ json={"uri": "viking://resources/demo", "wait": True},+ )++ assert response.status_code == 200+ body = response.json()+ assert body["status"] == "ok"+ assert body["result"]["status"] == "success"