Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(memory): isolate unresolved URI operations (#3299)

Yu Zhang295ce577b17d
diff --git a/openviking/session/memory/memory_updater.py b/openviking/session/memory/memory_updater.py
index 4d1ee96e5..0b32bf397 100644
--- a/openviking/session/memory/memory_updater.py
+++ b/openviking/session/memory/memory_updater.py
@@ -808,23 +808,25 @@ class MemoryUpdater:
result.add_error("unknown", ValueError(error))
return result
- unresolved_ops = [
- resolved_op for resolved_op in operations.upsert_operations if not resolved_op.uris
- ]
- if unresolved_ops:
- missing = [
- f"{resolved_op.memory_type}(page_id={resolved_op.page_id})"
- for resolved_op in unresolved_ops
- ]
- raise ValueError(
- f"Cannot apply operations: missing resolved URIs for {', '.join(missing)}"
+ applicable_upserts: List[ResolvedOperation] = []
+ has_unresolved_upserts = False
+ for resolved_op in operations.upsert_operations:
+ if resolved_op.uris:
+ applicable_upserts.append(resolved_op)
+ continue
+ has_unresolved_upserts = True
+ error_target = f"{resolved_op.memory_type}(page_id={resolved_op.page_id})"
+ resolution_error = ValueError("Missing resolved URI")
+ result.add_error(error_target, resolution_error)
+ tracer.error(
+ f"Skipping unresolved memory operation: {error_target}: {resolution_error}"
)
# Distribute resolved_links to corresponding upsert operations
self._distribute_links_to_operations(operations)
# Apply unified operations - _apply_edit returns True if edited, False if written
- for resolved_op in operations.upsert_operations:
+ for resolved_op in applicable_upserts:
try:
await self._apply_upsert(
resolved_op,
@@ -860,6 +862,13 @@ class MemoryUpdater:
upserted_uri_keys = {_same_batch_delete_conflict_key(uri) for uri in upserted_uris}
for file_content in operations.delete_file_contents:
delete_uri = file_content.uri
+ if has_unresolved_upserts:
+ delete_error = ValueError(
+ "Skipped delete because batch contains unresolved upsert URIs"
+ )
+ result.add_error(delete_uri, delete_error)
+ tracer.error(f"Skipping delete for {delete_uri}: {delete_error}")
+ continue
if delete_uri in upserted_uris:
tracer.info(
f"[apply_operations] skipping delete for {delete_uri}: "
diff --git a/tests/session/memory/test_memory_updater.py b/tests/session/memory/test_memory_updater.py
index 3b6b0cbcc..403e95143 100644
--- a/tests/session/memory/test_memory_updater.py
+++ b/tests/session/memory/test_memory_updater.py
@@ -4,7 +4,7 @@
Tests for MemoryUpdater.
"""
-from unittest.mock import AsyncMock, MagicMock
+from unittest.mock import AsyncMock, MagicMock, patch
import pytest
@@ -415,35 +415,112 @@ class TestMemoryUpdater:
isolation_handler.calculate_memory_uris.assert_not_called()
@pytest.mark.asyncio
- async def test_apply_operations_requires_pre_resolved_uris(self):
+ async def test_apply_operations_isolates_unresolved_uris(self):
registry = MagicMock()
registry.get.return_value = MemoryTypeSchema(
- memory_type="entities",
- description="entity memory",
- directory="viking://user/{{ user_space }}/memories/entities",
- filename_template="{{ name }}.md",
+ memory_type="events",
+ description="event memory",
+ directory="viking://user/{{ user_space }}/memories/events",
+ filename_template="{{ event_name }}.md",
fields=[],
)
updater = MemoryUpdater(registry=registry)
updater._get_viking_fs = MagicMock(return_value=MagicMock())
+ updater._apply_upsert = AsyncMock(return_value=None)
+ updater._sync_resource_refs_for_result = AsyncMock()
+ updater._vectorize_memories = AsyncMock()
+ updater.generate_overview = AsyncMock()
+ resolved_uri = "viking://user/alice/memories/events/resolved.md"
operations = ResolvedOperations(
upsert_operations=[
ResolvedOperation(
- memory_fields={"name": "SharedFact", "content": "shared content"},
- memory_type="entities",
+ memory_fields={"event_name": "resolved", "summary": "resolved event"},
+ memory_type="events",
+ uris=[resolved_uri],
+ page_id=101,
+ ),
+ ResolvedOperation(
+ memory_fields={"event_name": "unresolved", "summary": "unresolved event"},
+ memory_type="events",
uris=[],
- page_id=100,
- )
+ page_id=102,
+ ),
],
delete_file_contents=[],
errors=[],
)
ctx = RequestContext(user=UserIdentifier("acme", "alice"), role=Role.USER)
- with pytest.raises(ValueError, match="missing resolved URIs"):
- await updater.apply_operations(operations=operations, ctx=ctx)
+ with patch("openviking.session.memory.memory_updater.tracer.error") as tracer_error:
+ result = await updater.apply_operations(operations=operations, ctx=ctx)
+
+ assert result.written_uris == [resolved_uri]
+ assert len(result.errors) == 1
+ error_target, error = result.errors[0]
+ assert error_target == "events(page_id=102)"
+ assert str(error) == "Missing resolved URI"
+ tracer_error.assert_called_once_with(
+ "Skipping unresolved memory operation: "
+ "events(page_id=102): Missing resolved URI"
+ )
+
+ @pytest.mark.asyncio
+ async def test_apply_operations_skips_deletes_when_replacement_uri_is_unresolved(self):
+ registry = MagicMock()
+ registry.get.return_value = MemoryTypeSchema(
+ memory_type="events",
+ description="event memory",
+ directory="viking://user/{{ user_space }}/memories/events",
+ filename_template="{{ event_name }}.md",
+ fields=[],
+ )
+
+ updater = MemoryUpdater(registry=registry)
+ updater._get_viking_fs = MagicMock(return_value=MagicMock())
+ updater._apply_upsert = AsyncMock(return_value=None)
+ updater._apply_delete = AsyncMock()
+ updater._sync_resource_refs_for_result = AsyncMock()
+ updater._vectorize_memories = AsyncMock()
+ updater.generate_overview = AsyncMock()
+
+ resolved_uri = "viking://user/alice/memories/events/resolved.md"
+ old_uri = "viking://user/alice/memories/events/old.md"
+ operations = ResolvedOperations(
+ upsert_operations=[
+ ResolvedOperation(
+ memory_fields={"event_name": "resolved", "summary": "resolved event"},
+ memory_type="events",
+ uris=[resolved_uri],
+ page_id=101,
+ ),
+ ResolvedOperation(
+ memory_fields={
+ "event_name": "replacement",
+ "summary": "replacement event",
+ },
+ memory_type="events",
+ uris=[],
+ page_id=102,
+ ),
+ ],
+ delete_file_contents=[
+ MemoryFile(uri=old_uri, extra_fields={"memory_type": "events"})
+ ],
+ errors=[],
+ )
+ ctx = RequestContext(user=UserIdentifier("acme", "alice"), role=Role.USER)
+
+ result = await updater.apply_operations(operations=operations, ctx=ctx)
+
+ assert result.written_uris == [resolved_uri]
+ assert result.deleted_uris == []
+ assert [(target, str(error)) for target, error in result.errors] == [
+ ("events(page_id=102)", "Missing resolved URI"),
+ (old_uri, "Skipped delete because batch contains unresolved upsert URIs"),
+ ]
+ updater._apply_delete.assert_not_awaited()
@pytest.mark.asyncio
async def test_apply_operations_matches_overview_directory_from_resolved_user_uri(self):