Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(rerank): accept sparse indexed results (#3121)

huangruiteng2f5b2e27e101
diff --git a/openviking/models/rerank/openai_rerank.py b/openviking/models/rerank/openai_rerank.py
index bd0665760..2dcb9e222 100644
--- a/openviking/models/rerank/openai_rerank.py
+++ b/openviking/models/rerank/openai_rerank.py
@@ -101,13 +101,13 @@ class OpenAIRerankClient(RerankBase):
if len(results) != len(documents):
logger.warning(
- "[OpenAIRerankClient] Unexpected rerank result length: expected=%s actual=%s",
+ "[OpenAIRerankClient] Sparse rerank results: expected=%s actual=%s",
len(documents),
len(results),
)
- return None
- # Results may not be in original order — sort by index
+ # Results may be sparse or out of order. Missing documents keep a
+ # zero score while returned scores map back to their input indexes.
scores = [0.0] * len(documents)
for item in results:
idx = item.get("index")
diff --git a/tests/misc/test_rerank_openai.py b/tests/misc/test_rerank_openai.py
index b835950ef..311f8838b 100644
--- a/tests/misc/test_rerank_openai.py
+++ b/tests/misc/test_rerank_openai.py
@@ -76,11 +76,12 @@ class TestOpenAIRerankClient:
assert result is None
- def test_rerank_batch_length_mismatch_returns_none(self):
+ def test_rerank_batch_sparse_results_fill_missing_scores_with_zero(self):
client = self._make_client()
mock_response = MagicMock()
mock_response.json.return_value = {
"results": [
+ {"index": 2, "relevance_score": 0.7},
{"index": 0, "relevance_score": 0.9},
]
}
@@ -88,10 +89,13 @@ class TestOpenAIRerankClient:
with patch(
"openviking.models.rerank.openai_rerank.requests.post", return_value=mock_response
- ):
- result = client.rerank_batch("query", ["doc1", "doc2"])
+ ), patch("openviking.models.rerank.openai_rerank.logger.warning") as warning:
+ result = client.rerank_batch("query", ["doc1", "doc2", "doc3"])
- assert result is None
+ assert result == [0.9, 0.0, 0.7]
+ warning.assert_called_once_with(
+ "[OpenAIRerankClient] Sparse rerank results: expected=%s actual=%s", 3, 2
+ )
def test_rerank_batch_out_of_bounds_index_returns_none(self):
"""An index that is >= len(documents) should return None."""