Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(embedding): derive Jina default dimension from the model (#5426)
Mohammad Hijjawi3123344fe8ca
diff --git a/openviking/models/embedder/jina_embedders.py b/openviking/models/embedder/jina_embedders.pyindex 2d2897ab6..91bbf6911 100644--- a/openviking/models/embedder/jina_embedders.py+++ b/openviking/models/embedder/jina_embedders.py@@ -30,6 +30,11 @@ DEFAULT_JINA_CODE_DOCUMENT_TASK = "nl2code.passage"_UNSET = object()+def get_jina_model_default_dimension(model_name: Optional[str]) -> int:+ """Get the default (maximum) output dimension for a Jina embedding model."""+ return JINA_MODEL_DIMENSIONS.get(model_name or "", 1024)++def _get_default_task_params(model_name: str) -> tuple[str, str]:"""Return the default Jina task names for the selected model."""if model_name.startswith("jina-code-embeddings-"):@@ -125,7 +130,7 @@ class JinaDenseEmbedder(DenseEmbedderBase):self._async_client_cache = LoopScopedAsyncClientCache()# Determine dimension- max_dim = JINA_MODEL_DIMENSIONS.get(model_name, 1024)+ max_dim = get_jina_model_default_dimension(model_name)if dimension is not None and dimension > max_dim:raise ValueError(f"Requested dimension {dimension} exceeds maximum {max_dim} for model '{model_name}'. "diff --git a/openviking_cli/utils/config/embedding_config.py b/openviking_cli/utils/config/embedding_config.pyindex f4f278c82..723d30639 100644--- a/openviking_cli/utils/config/embedding_config.py+++ b/openviking_cli/utils/config/embedding_config.py@@ -454,6 +454,13 @@ class EmbeddingModelConfig(BaseModel):return get_cohere_model_default_dimension(model)+ if provider == "jina":+ from openviking.models.embedder.jina_embedders import (+ get_jina_model_default_dimension,+ )++ return get_jina_model_default_dimension(model)+if provider == "gemini":from openviking.models.embedder.gemini_embedders import GeminiDenseEmbedder@@ -476,7 +483,7 @@ class EmbeddingModelConfig(BaseModel):except ImportError:return 1024- # Providers without a known dimension lookup (volcengine, jina,+ # Providers without a known dimension lookup (volcengine,# vikingdb, ollama for unlisted models, etc.) cannot be cross-checked# here without an explicit dimension. Return None so validation skips# them; same-provider credentials are typically dimension-compatible@@ -540,6 +547,13 @@ class EmbeddingModelConfig(BaseModel):return get_cohere_model_default_dimension(effective_model)+ if provider == "jina":+ from openviking.models.embedder.jina_embedders import (+ get_jina_model_default_dimension,+ )++ return get_jina_model_default_dimension(effective_model)+if provider == "gemini":from openviking.models.embedder.gemini_embedders import GeminiDenseEmbedderdiff --git a/tests/unit/test_jina_embedder.py b/tests/unit/test_jina_embedder.pyindex 9ce0ba41c..0f2266482 100644--- a/tests/unit/test_jina_embedder.py+++ b/tests/unit/test_jina_embedder.py@@ -10,6 +10,7 @@ from openviking.models.embedder import JinaDenseEmbedderfrom openviking.models.embedder.jina_embedders import (JINA_MODEL_DIMENSIONS,)+from openviking_cli.utils.config.embedding_config import EmbeddingModelConfigclass TestJinaDenseEmbedder:@@ -346,3 +347,10 @@ class TestJinaDenseEmbedder:api_key="test-key",)assert embedder_0_5b.get_dimension() == 768++ @pytest.mark.parametrize("model", sorted(JINA_MODEL_DIMENSIONS))+ def test_config_default_dimension_matches_embedder(self, model):+ """Without an explicit dimension, the schema must match the vectors Jina returns."""+ config = EmbeddingModelConfig(provider="jina", api_key="test-key", model=model)+ embedder = JinaDenseEmbedder(model_name=model, api_key="test-key")+ assert config.get_effective_dimension() == embedder.get_dimension()