Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(embedding): disable OpenAI SDK retries (#5166)
zhanggaoyuan341ce7a7b8ff
diff --git a/openviking/models/embedder/openai_embedders.py b/openviking/models/embedder/openai_embedders.pyindex 648240026..c4c122d20 100644--- a/openviking/models/embedder/openai_embedders.py+++ b/openviking/models/embedder/openai_embedders.py@@ -144,7 +144,10 @@ class OpenAIDenseEmbedder(DenseEmbedderBase):self.extra_body = extra_bodyself._provider = provider.lower()self.provider = (configured_provider or provider).lower()- self._client_kwargs: Dict[str, Any] = {"api_key": self.api_key or "no-key"}+ self._client_kwargs: Dict[str, Any] = {+ "api_key": self.api_key or "no-key",+ "max_retries": 0,+ }# Allow missing api_key when api_base is set (e.g. local OpenAI-compatible servers)if not self.api_key and not self.api_base:diff --git a/tests/unit/test_extra_headers_embedding.py b/tests/unit/test_extra_headers_embedding.pyindex f16a81189..5075a0298 100644--- a/tests/unit/test_extra_headers_embedding.py+++ b/tests/unit/test_extra_headers_embedding.py@@ -60,6 +60,20 @@ class TestExtraHeadersDirectConstruction:call_kwargs = mock_openai_class.call_args[1]assert "default_headers" not in call_kwargs+ @patch("openviking.models.embedder.openai_embedders.openai.OpenAI")+ def test_sdk_retries_disabled(self, mock_openai_class):+ """OpenAI SDK retries should be disabled in favor of OpenViking retries."""+ mock_openai_class.return_value = _make_mock_client()++ OpenAIDenseEmbedder(+ model_name="text-embedding-3-small",+ api_key="sk-test",+ )++ mock_openai_class.assert_called_once()+ call_kwargs = mock_openai_class.call_args[1]+ assert call_kwargs["max_retries"] == 0+class TestExtraHeadersViaFactory:"""Test extra_headers forwarding through EmbeddingConfig._create_embedder."""