Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(memory): skills template None value causes empty content (#1952)

chenjw3928a619508c
diff --git a/openviking/prompts/templates/memory/skills.yaml b/openviking/prompts/templates/memory/skills.yaml
index 4cceed43d..b2a1670ae 100644
--- a/openviking/prompts/templates/memory/skills.yaml
+++ b/openviking/prompts/templates/memory/skills.yaml
@@ -7,7 +7,7 @@ enabled: true
content_template: |
Skill: {{ skill_name }}
- - Success rate: {{ ((success_count|default(0) / (total_executions|default(1) if total_executions|default(0) > 0 else 1)) * 100)|round|int }}% ({{ success_count|default(0) }}/{{ total_executions|default(0) }})
+ - Success rate: {{ ((success_count|default(0, true) / (total_executions|default(1, true) if total_executions|default(0, true) > 0 else 1)) * 100)|round|int }}% ({{ success_count|default(0, true) }}/{{ total_executions|default(0, true) }})
- Best for: {{ best_for|default('N/A') }}
- Recommended flow: {{ recommended_flow|default('N/A') }}
- Key dependencies: {{ key_dependencies|default('N/A') }}
diff --git a/openviking/session/memory/utils/content.py b/openviking/session/memory/utils/content.py
index be9152672..664312dbb 100644
--- a/openviking/session/memory/utils/content.py
+++ b/openviking/session/memory/utils/content.py
@@ -76,9 +76,11 @@ def serialize_with_metadata(
jinja_template = env.from_string(content_template)
content = jinja_template.render(**template_vars).strip()
- except Exception:
- # If template rendering fails, use content as-is
- pass
+ except Exception as e:
+ from openviking.telemetry import tracer
+
+ tracer.error(f"Template rendering failed, skipping write: {e}")
+ raise
# Clean metadata - remove None values and memory_type
clean_metadata = {k: v for k, v in metadata.items() if v is not None and k != "memory_type"}