Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(memory): reject non-schema extraction results (#5731)

Lusen Dong3b64adf01c44
diff --git a/openviking/session/memory/utils/json_parser.py b/openviking/session/memory/utils/json_parser.py
index 380a4f093..4eb209d45 100644
--- a/openviking/session/memory/utils/json_parser.py
+++ b/openviking/session/memory/utils/json_parser.py
@@ -379,7 +379,8 @@ def parse_json_with_stability(
Args:
content: Raw LLM response string
model_class: Optional Pydantic model class to validate against
- expected_fields: Optional list of field names to keep (filter out extra fields)
+ expected_fields: Optional field names to keep. Non-empty objects containing
+ none of these fields are rejected instead of becoming an empty result.
Returns:
Tuple of (parsed_data, error_message). error_message is None on success.
@@ -430,10 +431,10 @@ def parse_json_with_stability(
# Filter to only expected fields if provided
if expected_fields:
- filtered_data = {}
- for k, v in parsed_data.items():
- if k in expected_fields:
- filtered_data[k] = v
+ filtered_data = {k: v for k, v in parsed_data.items() if k in expected_fields}
+ if parsed_data and not filtered_data:
+ fields = ", ".join(sorted(parsed_data))
+ return None, f"No expected fields found; got fields: {fields}"
parsed_data = filtered_data
# If no model class, return the raw dict
diff --git a/tests/session/memory/test_extraction_output_protocol.py b/tests/session/memory/test_extraction_output_protocol.py
index 878da01da..b3745f68d 100644
--- a/tests/session/memory/test_extraction_output_protocol.py
+++ b/tests/session/memory/test_extraction_output_protocol.py
@@ -182,6 +182,11 @@ def test_json_protocol_preserves_stable_parser_and_empty_contract():
assert '"preferences": []' in protocol.render_final_instruction(context)
assert '"delete_ids": []' in protocol.render_final_instruction(context)
+ assert protocol.parse('{"memory_operations": [{"type": "edit"}]}', context) == (
+ None,
+ "No expected fields found; got fields: memory_operations",
+ )
+
def test_python_contract_and_bindings_expose_only_selected_schema_fields():
uri = "viking://user/alice/memories/preferences/editor.md"