Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix: unify runtime loggers with openviking logger (#1981)

Jiahui Zhou3bcefb298da6
diff --git a/openviking/metrics/exporters/otel.py b/openviking/metrics/exporters/otel.py
index a00596bf8..d48793a74 100644
--- a/openviking/metrics/exporters/otel.py
+++ b/openviking/metrics/exporters/otel.py
@@ -17,15 +17,15 @@ Key design goals:
from __future__ import annotations
import asyncio
-import logging
import time
from typing import Any, Iterable, Optional, Tuple
import requests
from openviking.metrics.core.base import MetricExporter
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
try:
import grpc
diff --git a/openviking/metrics/global_api.py b/openviking/metrics/global_api.py
index 931132702..96af2a193 100644
--- a/openviking/metrics/global_api.py
+++ b/openviking/metrics/global_api.py
@@ -19,11 +19,11 @@ from __future__ import annotations
import asyncio
import inspect
-import logging
import threading
from typing import Optional
from openviking.server.config import ServerConfig
+from openviking_cli.utils import get_logger
from .account_dimension import (
configure_metric_account_dimension as _configure_metric_account_dimension_runtime,
@@ -47,7 +47,7 @@ from .core.runtime import EventCollectorRouter
from .exporters.otel import OTelMetricExporter
from .exporters.prometheus import PrometheusExporter
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
_lock = threading.Lock()
_registry: Optional[MetricRegistry] = None
diff --git a/openviking/models/embedder/base.py b/openviking/models/embedder/base.py
index 51e5ead60..618ae3ece 100644
--- a/openviking/models/embedder/base.py
+++ b/openviking/models/embedder/base.py
@@ -12,9 +12,10 @@ from typing import Any, Awaitable, Callable, Dict, List, Optional, TypeVar
from openviking.telemetry import get_current_telemetry
from openviking.utils.model_retry import retry_async, retry_sync
+from openviking_cli.utils import get_logger
T = TypeVar("T")
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
_token_tracker_instance = None
diff --git a/openviking/models/embedder/cohere_embedders.py b/openviking/models/embedder/cohere_embedders.py
index 714bdbee1..96e15e787 100644
--- a/openviking/models/embedder/cohere_embedders.py
+++ b/openviking/models/embedder/cohere_embedders.py
@@ -8,14 +8,14 @@ for asymmetric retrieval.
"""
import asyncio
-import logging
from typing import Any, Dict, List, Optional
import httpx
from openviking.models.embedder.base import DenseEmbedderBase, EmbedResult, truncate_and_normalize
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
COHERE_MODEL_DIMENSIONS = {
"embed-v4.0": 1536,
diff --git a/openviking/models/embedder/gemini_embedders.py b/openviking/models/embedder/gemini_embedders.py
index da05f305a..c6ac23d7d 100644
--- a/openviking/models/embedder/gemini_embedders.py
+++ b/openviking/models/embedder/gemini_embedders.py
@@ -16,15 +16,14 @@ try:
except ImportError:
_HTTP_RETRY_AVAILABLE = False
-import logging
-
from openviking.models.embedder.base import (
DenseEmbedderBase,
EmbedResult,
truncate_and_normalize,
)
+from openviking_cli.utils import get_logger
-logger = logging.getLogger("gemini_embedders")
+logger = get_logger(__name__)
_TEXT_BATCH_SIZE = 100
diff --git a/openviking/models/embedder/jina_embedders.py b/openviking/models/embedder/jina_embedders.py
index 5a447eb62..8dd5024cc 100644
--- a/openviking/models/embedder/jina_embedders.py
+++ b/openviking/models/embedder/jina_embedders.py
@@ -2,7 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0
"""Jina AI Embedder Implementation"""
-import logging
from typing import Any, Dict, List, Optional
import openai
@@ -11,8 +10,9 @@ from openviking.models.embedder.base import (
DenseEmbedderBase,
EmbedResult,
)
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
# Default dimensions for Jina embedding models
JINA_MODEL_DIMENSIONS = {
diff --git a/openviking/models/embedder/litellm_embedders.py b/openviking/models/embedder/litellm_embedders.py
index 8d1b650c0..7e63919f3 100644
--- a/openviking/models/embedder/litellm_embedders.py
+++ b/openviking/models/embedder/litellm_embedders.py
@@ -6,7 +6,6 @@ Uses litellm to provide a unified embedding interface across many providers
(OpenRouter, Ollama, vLLM, and any OpenAI-compatible endpoint).
"""
-import logging
import os
from typing import Any, Dict, List, Optional
@@ -14,8 +13,9 @@ import litellm
from openviking.models.embedder.base import DenseEmbedderBase, EmbedResult
from openviking.telemetry import get_current_telemetry
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class LiteLLMDenseEmbedder(DenseEmbedderBase):
diff --git a/openviking/models/embedder/local_embedders.py b/openviking/models/embedder/local_embedders.py
index 0ad37be66..395fde5eb 100644
--- a/openviking/models/embedder/local_embedders.py
+++ b/openviking/models/embedder/local_embedders.py
@@ -5,7 +5,6 @@
from __future__ import annotations
import importlib
-import logging
import os
from dataclasses import dataclass
from pathlib import Path
@@ -15,8 +14,9 @@ import requests
from openviking.models.embedder.base import DenseEmbedderBase, EmbedResult
from openviking.storage.errors import EmbeddingConfigurationError
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
DEFAULT_LOCAL_MODEL_CACHE_DIR = "~/.cache/openviking/models"
DEFAULT_LOCAL_DENSE_MODEL = "bge-small-zh-v1.5-f16"
diff --git a/openviking/models/embedder/openai_embedders.py b/openviking/models/embedder/openai_embedders.py
index 937f2f04f..554a159af 100644
--- a/openviking/models/embedder/openai_embedders.py
+++ b/openviking/models/embedder/openai_embedders.py
@@ -2,7 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0
"""OpenAI Embedder Implementation"""
-import logging
from typing import Any, Dict, List, Optional
import openai
@@ -15,8 +14,9 @@ from openviking.models.embedder.base import (
)
from openviking.models.vlm.registry import DEFAULT_AZURE_API_VERSION
from openviking.telemetry import get_current_telemetry
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class OpenAIDenseEmbedder(DenseEmbedderBase):
diff --git a/openviking/models/embedder/voyage_embedders.py b/openviking/models/embedder/voyage_embedders.py
index 5edc652ea..dcc92682c 100644
--- a/openviking/models/embedder/voyage_embedders.py
+++ b/openviking/models/embedder/voyage_embedders.py
@@ -2,14 +2,14 @@
# SPDX-License-Identifier: AGPL-3.0
"""Voyage AI dense embedder implementation."""
-import logging
from typing import Any, Dict, List, Optional
import openai
from openviking.models.embedder.base import DenseEmbedderBase, EmbedResult
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
VOYAGE_MODEL_DIMENSIONS = {
"voyage-3": 1024,
diff --git a/openviking/models/rerank/base.py b/openviking/models/rerank/base.py
index dcc25acdb..89b4e7b60 100644
--- a/openviking/models/rerank/base.py
+++ b/openviking/models/rerank/base.py
@@ -9,8 +9,10 @@ Provides common token usage tracking functionality.
import logging
from typing import Any, Dict
+from openviking_cli.utils import get_logger
+
_token_tracker_instance = None
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
def _get_token_tracker():
diff --git a/openviking/models/rerank/cohere_rerank.py b/openviking/models/rerank/cohere_rerank.py
index 79a3e22a8..c38620811 100644
--- a/openviking/models/rerank/cohere_rerank.py
+++ b/openviking/models/rerank/cohere_rerank.py
@@ -8,15 +8,15 @@ Same interface: rerank_batch(query, documents) -> List[float]
"""
# For logging, use Python's built-in logging
-import logging
import time
from typing import List, Optional
import httpx
from openviking.models.rerank.base import RerankBase
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class CohereRerankClient(RerankBase):
diff --git a/openviking/models/rerank/litellm_rerank.py b/openviking/models/rerank/litellm_rerank.py
index 8bc2e9159..c41e722c2 100644
--- a/openviking/models/rerank/litellm_rerank.py
+++ b/openviking/models/rerank/litellm_rerank.py
@@ -5,13 +5,13 @@ LiteLLM Rerank API Client.
"""
# For logging, use Python's built-in logging
-import logging
import time
from typing import List, Optional
from openviking.models.rerank.base import RerankBase
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class LiteLLMRerankClient(RerankBase):
diff --git a/openviking/models/rerank/openai_rerank.py b/openviking/models/rerank/openai_rerank.py
index 490743f38..50ff96843 100644
--- a/openviking/models/rerank/openai_rerank.py
+++ b/openviking/models/rerank/openai_rerank.py
@@ -8,14 +8,14 @@ via api_key + api_base configuration.
"""
# For logging, use Python's built-in logging
-import logging
from typing import Dict, List, Optional
import requests
from openviking.models.rerank.base import RerankBase
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class OpenAIRerankClient(RerankBase):
diff --git a/openviking/models/rerank/volcengine_rerank.py b/openviking/models/rerank/volcengine_rerank.py
index f9e103e61..92a5a55ab 100644
--- a/openviking/models/rerank/volcengine_rerank.py
+++ b/openviking/models/rerank/volcengine_rerank.py
@@ -9,7 +9,6 @@ Provides rerank functionality for hierarchical retrieval.
import json
# For logging, use Python's built-in logging
-import logging
import time
from typing import List, Optional
@@ -19,8 +18,9 @@ from volcengine.base.Request import Request
from volcengine.Credentials import Credentials
from openviking.models.rerank.base import RerankBase
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class RerankClient(RerankBase):
diff --git a/openviking/models/vlm/backends/litellm_vlm.py b/openviking/models/vlm/backends/litellm_vlm.py
index 3f52b4334..04d019558 100644
--- a/openviking/models/vlm/backends/litellm_vlm.py
+++ b/openviking/models/vlm/backends/litellm_vlm.py
@@ -4,7 +4,6 @@
import base64
import json
-import logging
import os
import time
from pathlib import Path
@@ -18,10 +17,11 @@ from litellm import acompletion, completion
from openviking.telemetry import tracer
from openviking.utils.model_retry import retry_async, retry_sync
+from openviking_cli.utils import get_logger
from ..base import ToolCall, VLMBase, VLMResponse
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
def _is_google_generate_language_endpoint(api_base: str) -> bool:
diff --git a/openviking/models/vlm/backends/openai_vlm.py b/openviking/models/vlm/backends/openai_vlm.py
index 8f3a9458a..25547d6a7 100644
--- a/openviking/models/vlm/backends/openai_vlm.py
+++ b/openviking/models/vlm/backends/openai_vlm.py
@@ -4,13 +4,13 @@
import base64
import json
-import logging
import time
from pathlib import Path
from typing import Any, Dict, List, Optional, Union
from urllib.parse import urlparse
from openviking.telemetry import tracer
+from openviking_cli.utils import get_logger
try:
import openai
@@ -22,7 +22,7 @@ from openviking.utils.model_retry import retry_async, retry_sync
from ..base import ToolCall, VLMBase, VLMResponse
from ..registry import DEFAULT_AZURE_API_VERSION
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
_DASHSCOPE_HOSTS = {
diff --git a/openviking/models/vlm/backends/volcengine_vlm.py b/openviking/models/vlm/backends/volcengine_vlm.py
index 8ffb11af1..8f385abb4 100644
--- a/openviking/models/vlm/backends/volcengine_vlm.py
+++ b/openviking/models/vlm/backends/volcengine_vlm.py
@@ -5,16 +5,17 @@
import asyncio
import base64
import json
-import logging
import time
from pathlib import Path
from typing import Any, Dict, List, Optional, Union
from openviking.telemetry import tracer
+from openviking_cli.utils import get_logger
+
from ..base import ToolCall, VLMResponse
from .openai_vlm import OpenAIVLM
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class VolcEngineVLM(OpenAIVLM):
@@ -157,7 +158,9 @@ class VolcEngineVLM(OpenAIVLM):
# 用 tracer.info 打印请求
tracer.info(f"request: {json.dumps(kwargs_messages, ensure_ascii=False, indent=2)}")
if tools:
- tracer.info(f"tools: {json.dumps([t['function']['name'] for t in tools], ensure_ascii=False)}")
+ tracer.info(
+ f"tools: {json.dumps([t['function']['name'] for t in tools], ensure_ascii=False)}"
+ )
client = self.get_async_client()
diff --git a/openviking/models/vlm/base.py b/openviking/models/vlm/base.py
index 3cfbee579..0ac0b1b30 100644
--- a/openviking/models/vlm/base.py
+++ b/openviking/models/vlm/base.py
@@ -10,11 +10,12 @@ from pathlib import Path
from typing import Any, Dict, List, Optional, Union
from openviking.utils.time_utils import format_iso8601
+from openviking_cli.utils import get_logger
from .token_usage import TokenUsageTracker
_THINK_TAG_RE = re.compile(r"<think>[\s\S]*?</think>")
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
@dataclass
diff --git a/openviking/observability/context.py b/openviking/observability/context.py
index d1cb3d541..553fa4027 100644
--- a/openviking/observability/context.py
+++ b/openviking/observability/context.py
@@ -20,7 +20,6 @@ Key features:
from __future__ import annotations
import contextvars
-import logging
import uuid
from contextlib import contextmanager
from dataclasses import dataclass, field
@@ -37,8 +36,6 @@ except ImportError:
format_span_id = None
format_trace_id = None
-logger = logging.getLogger(__name__)
-
@dataclass
class ObservabilityContext:
diff --git a/openviking/observability/http_observability_middleware.py b/openviking/observability/http_observability_middleware.py
index 77c353428..ce30a1085 100644
--- a/openviking/observability/http_observability_middleware.py
+++ b/openviking/observability/http_observability_middleware.py
@@ -28,6 +28,7 @@ from openviking.observability.context import (
reset_root_observability_context,
)
from openviking.telemetry.span_models import RootSpanAttributes, create_root_span_attributes
+from openviking_cli.utils import get_logger
# Try to import opentelemetry - will be None if not installed
try:
@@ -40,7 +41,7 @@ except ImportError:
Status = None
StatusCode = None
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
_HTTP_IGNORE_ROUTES = frozenset(
{
diff --git a/openviking/parse/accessors/registry.py b/openviking/parse/accessors/registry.py
index 985cb2bf1..d4aed7526 100644
--- a/openviking/parse/accessors/registry.py
+++ b/openviking/parse/accessors/registry.py
@@ -6,13 +6,14 @@ Registry for Data Accessors.
Manages DataAccessor registration and provides automatic source routing.
"""
-import logging
from pathlib import Path
from typing import List, Optional, Union
+from openviking_cli.utils import get_logger
+
from .base import DataAccessor, LocalResource
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class AccessorRegistry:
diff --git a/openviking/parse/parsers/code/ast/extractor.py b/openviking/parse/parsers/code/ast/extractor.py
index af2753962..e737cf02c 100644
--- a/openviking/parse/parsers/code/ast/extractor.py
+++ b/openviking/parse/parsers/code/ast/extractor.py
@@ -3,14 +3,14 @@
"""ASTExtractor: language detection + dispatch to per-language extractors."""
import importlib
-import logging
from pathlib import Path
from typing import Dict, Optional
from openviking.parse.parsers.code.ast.languages.base import LanguageExtractor
from openviking.parse.parsers.code.ast.skeleton import CodeSkeleton
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
# File extension → internal language key
_EXT_MAP: Dict[str, str] = {
diff --git a/openviking/parse/parsers/pdf.py b/openviking/parse/parsers/pdf.py
index 123332c0f..9f7c24ee7 100644
--- a/openviking/parse/parsers/pdf.py
+++ b/openviking/parse/parsers/pdf.py
@@ -12,7 +12,6 @@ This design simplifies PDF handling by delegating structure analysis
to the MarkdownParser after conversion.
"""
-import logging
import re
import time
from collections import Counter, defaultdict
@@ -27,9 +26,10 @@ from openviking.parse.base import (
lazy_import,
)
from openviking.parse.parsers.base_parser import BaseParser
+from openviking_cli.utils import get_logger
from openviking_cli.utils.config.parser_config import PDFConfig
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class PDFParser(BaseParser):
diff --git a/openviking/parse/registry.py b/openviking/parse/registry.py
index cd8318a1f..3dc1b9298 100644
--- a/openviking/parse/registry.py
+++ b/openviking/parse/registry.py
@@ -6,7 +6,6 @@ Parser registry for OpenViking.
Provides automatic parser selection based on file type.
"""
-import logging
from pathlib import Path
from typing import TYPE_CHECKING, Callable, Dict, List, Optional, Union
@@ -28,12 +27,13 @@ from openviking.parse.parsers.powerpoint import PowerPointParser
from openviking.parse.parsers.text import TextParser
from openviking.parse.parsers.word import WordParser
from openviking.parse.parsers.zip_parser import ZipParser
+from openviking_cli.utils import get_logger
from openviking_cli.utils.config.parser_config import ParserConfig
if TYPE_CHECKING:
from openviking.parse.custom import CustomParserProtocol
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class ParserRegistry:
diff --git a/openviking/parse/tree_builder.py b/openviking/parse/tree_builder.py
index 15a992be2..444ae1f03 100644
--- a/openviking/parse/tree_builder.py
+++ b/openviking/parse/tree_builder.py
@@ -20,7 +20,6 @@ IMPORTANT (v5.0 Architecture):
- Content splitting is handled by Parser, not TreeBuilder
"""
-import logging
from typing import Optional
from openviking.core.building_tree import BuildingTree
@@ -29,9 +28,10 @@ from openviking.parse.parsers.media.utils import get_media_base_uri, get_media_t
from openviking.server.identity import RequestContext
from openviking.storage.viking_fs import get_viking_fs
from openviking.utils import parse_code_hosting_url
+from openviking_cli.utils import get_logger
from openviking_cli.utils.uri import VikingURI
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class TreeBuilder:
diff --git a/openviking/server/oauth/provider.py b/openviking/server/oauth/provider.py
index f0045b306..00eeea9e5 100644
--- a/openviking/server/oauth/provider.py
+++ b/openviking/server/oauth/provider.py
@@ -12,7 +12,6 @@ strings keyed by their SHA-256 hash, so this module contains no cryptography.
from __future__ import annotations
-import logging
import secrets
from typing import Callable, Optional
from urllib.parse import urlencode
@@ -32,12 +31,13 @@ from pydantic import AnyUrl
from openviking.server.identity import Role
from openviking.server.oauth.otp import generate_otp
from openviking.server.oauth.storage import OAuthStore
+from openviking_cli.utils import get_logger
# Mirrors auth.py:_ROLE_RANK; duplicated here to avoid the import cycle
# (auth.py already depends on this module via the Provider Protocol).
_ROLE_RANK = {Role.USER: 0, Role.ADMIN: 1, Role.ROOT: 2}
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
# Access tokens carry this prefix so the auth.py bearer router can cheaply
# discriminate them from API keys without an extra DB lookup. The prefix is
diff --git a/openviking/server/oauth/router.py b/openviking/server/oauth/router.py
index f7ea777a2..8a5943f9c 100644
--- a/openviking/server/oauth/router.py
+++ b/openviking/server/oauth/router.py
@@ -18,7 +18,6 @@ metadata) is delegated to the official ``mcp.server.auth`` SDK (mounted from
from __future__ import annotations
import html
-import logging
import os
from typing import Optional
from urllib.parse import urlencode
@@ -38,8 +37,9 @@ from openviking_cli.exceptions import (
PermissionDeniedError,
UnavailableError,
)
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
router = APIRouter(tags=["oauth"])
diff --git a/openviking/server/oauth/storage.py b/openviking/server/oauth/storage.py
index 30e09f715..d9606bd3b 100644
--- a/openviking/server/oauth/storage.py
+++ b/openviking/server/oauth/storage.py
@@ -22,7 +22,6 @@ from __future__ import annotations
import asyncio
import json
-import logging
import secrets
import sqlite3
import time
@@ -30,8 +29,9 @@ from pathlib import Path
from typing import Any, Iterable, Optional
from openviking.server.oauth.otp import hash_secret
+from openviking_cli.utils import get_logger
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
_SCHEMA = """
diff --git a/openviking/server/routers/sessions.py b/openviking/server/routers/sessions.py
index 4c32a8e5c..4f2628427 100644
--- a/openviking/server/routers/sessions.py
+++ b/openviking/server/routers/sessions.py
@@ -2,7 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0
"""Sessions endpoints for OpenViking HTTP Server."""
-import logging
from typing import Any, Dict, List, Literal, Optional
from fastapi import APIRouter, Body, Depends, Path, Query, Request
@@ -17,9 +16,10 @@ from openviking.server.models import ErrorInfo, Response
from openviking.server.responses import error_response
from openviking.server.telemetry import run_operation
from openviking.telemetry import TelemetryRequest
+from openviking_cli.utils import get_logger
router = APIRouter(prefix="/api/v1/sessions", tags=["sessions"])
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
class TextPartRequest(BaseModel):
diff --git a/openviking/server/routers/stats.py b/openviking/server/routers/stats.py
index f636d07a9..e76d50e44 100644
--- a/openviking/server/routers/stats.py
+++ b/openviking/server/routers/stats.py
@@ -2,7 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0
"""Memory health statistics endpoints for OpenViking HTTP Server."""
-import logging
from typing import Optional
from fastapi import APIRouter, Depends, Path, Query
@@ -12,9 +11,10 @@ from openviking.server.dependencies import get_service
from openviking.server.identity import RequestContext
from openviking.server.models import ErrorInfo, Response
from openviking.storage.stats_aggregator import MEMORY_CATEGORIES, StatsAggregator
+from openviking_cli.utils import get_logger
router = APIRouter(prefix="/api/v1/stats", tags=["stats"])
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
def _get_aggregator() -> StatsAggregator:
diff --git a/openviking_cli/session/user_id.py b/openviking_cli/session/user_id.py
index ca377c630..a0a12e555 100644
--- a/openviking_cli/session/user_id.py
+++ b/openviking_cli/session/user_id.py
@@ -1,9 +1,10 @@
import hashlib
-import logging
import re
from typing import Optional
-logger = logging.getLogger(__name__)
+from openviking_cli.utils import get_logger
+
+logger = get_logger(__name__)
# Validation pattern reused across different modules
# Note: hyphen (-) must be at the end or escaped to avoid being interpreted as a range
diff --git a/openviking_cli/utils/config/open_viking_config.py b/openviking_cli/utils/config/open_viking_config.py
index 25076e77b..067137f9f 100644
--- a/openviking_cli/utils/config/open_viking_config.py
+++ b/openviking_cli/utils/config/open_viking_config.py
@@ -45,6 +45,11 @@ from .telemetry_config import TelemetryConfig
from .vlm_config import VLMConfig
+def _get_config_warning_logger():
+ """Use stdlib logging during config bootstrap to avoid early logger side effects."""
+ return logging.getLogger(__name__)
+
+
class OpenVikingConfig(BaseModel):
"""Main configuration for OpenViking."""
@@ -151,7 +156,7 @@ class OpenVikingConfig(BaseModel):
@model_validator(mode="after")
def _warn_on_deprecated_language_fallback(self) -> "OpenVikingConfig":
if self.language_fallback and self.language_fallback != "en":
- logging.getLogger(__name__).warning(
+ _get_config_warning_logger().warning(
"Config field 'language_fallback=%s' is deprecated and has no effect; "
"remove it, or set 'output_language_override' to pin an explicit language.",
self.language_fallback,
@@ -253,7 +258,7 @@ class OpenVikingConfig(BaseModel):
isinstance(memory_config_data, dict)
and "agent_scope_mode" in memory_config_data
):
- logging.getLogger(__name__).warning(
+ _get_config_warning_logger().warning(
"memory.agent_scope_mode is deprecated and ignored. "
"User/agent namespace behavior is now controlled by per-account "
"namespace policy."
@@ -344,6 +349,9 @@ class OpenVikingConfigSingleton:
)
finally:
cls._initializing = False
+ from openviking_cli.utils.logger import reconfigure_logging
+
+ reconfigure_logging()
return cls._instance
@classmethod
@@ -378,6 +386,9 @@ class OpenVikingConfigSingleton:
)
finally:
cls._initializing = False
+ from openviking_cli.utils.logger import reconfigure_logging
+
+ reconfigure_logging()
return cls._instance
@classmethod
diff --git a/openviking_cli/utils/logger.py b/openviking_cli/utils/logger.py
index 76b8ca3c4..1a6fb0589 100644
--- a/openviking_cli/utils/logger.py
+++ b/openviking_cli/utils/logger.py
@@ -664,6 +664,35 @@ def _create_log_handler(log_output: str, config: Optional[Any]) -> logging.Handl
return logging.FileHandler(log_output, encoding="utf-8")
+def _configure_logger_instance(
+ logger: logging.Logger,
+ *,
+ level: int,
+ formatter: logging.Formatter,
+ handler: logging.Handler,
+) -> None:
+ """Apply a fully configured handler to a logger."""
+ logger.handlers.clear()
+ logger.addHandler(handler)
+ logger.propagate = False
+ logger.setLevel(level)
+
+
+def _build_standard_handler(
+ log_output: str,
+ config: Optional[Any],
+ format_string: str,
+) -> logging.Handler:
+ handler = _create_log_handler(log_output, config)
+ handler.setFormatter(logging.Formatter(format_string))
+
+ # Add trace id filter
+ from openviking.telemetry.tracer import TraceIdLoggingFilter
+
+ handler.addFilter(TraceIdLoggingFilter())
+ return handler
+
+
def get_logger(
name: str = "openviking",
format_string: Optional[str] = None,
@@ -684,20 +713,12 @@ def get_logger(
if not logger.handlers:
log_level_str, log_format, log_output, config = _load_log_config()
level = getattr(logging, log_level_str, logging.INFO)
- handler = _create_log_handler(log_output, config)
-
if format_string is None:
format_string = log_format
- formatter = logging.Formatter(format_string)
- handler.setFormatter(formatter)
-
- # Add trace id filter
- from openviking.telemetry.tracer import TraceIdLoggingFilter
- handler.addFilter(TraceIdLoggingFilter())
-
- logger.addHandler(handler)
- logger.propagate = False
- logger.setLevel(level)
+ handler = _build_standard_handler(log_output, config, format_string)
+ _configure_logger_instance(
+ logger, level=level, formatter=logging.Formatter(format_string), handler=handler
+ )
# If OTel log export is globally initialized, attach the handler automatically.
if add_otel_handler or _otel_log_handler_initialized:
@@ -706,8 +727,49 @@ def get_logger(
return logger
-# Default logger instance
-default_logger = get_logger()
+class _LazyDefaultLogger:
+ """Compatibility proxy that defers logger creation until first use."""
+
+ def _logger(self) -> logging.Logger:
+ return get_logger()
+
+ def __getattr__(self, name: str) -> Any:
+ return getattr(self._logger(), name)
+
+
+default_logger = _LazyDefaultLogger()
+
+
+def reconfigure_logging() -> None:
+ """Re-apply logging configuration to already-created OpenViking loggers."""
+ log_level_str, log_format, log_output, config = _load_log_config()
+ level = getattr(logging, log_level_str, logging.INFO)
+
+ logger_dict = logging.Logger.manager.loggerDict
+ target_names = [
+ name
+ for name, candidate in logger_dict.items()
+ if isinstance(candidate, logging.Logger)
+ and (name == "openviking" or name.startswith("openviking.") or name.startswith("uvicorn"))
+ ]
+ if "openviking" not in target_names:
+ target_names.append("openviking")
+
+ for logger_name in sorted(set(target_names)):
+ logger = logging.getLogger(logger_name)
+ format_string = log_format
+ if logger_name.startswith("uvicorn"):
+ handler = _create_log_handler(log_output, config)
+ handler.setFormatter(logging.Formatter(log_format))
+ handler.addFilter(TraceContextFilter())
+ else:
+ handler = _build_standard_handler(log_output, config, format_string)
+ _configure_logger_instance(
+ logger,
+ level=level,
+ formatter=logging.Formatter(format_string),
+ handler=handler,
+ )
def configure_uvicorn_logging() -> None:
@@ -718,18 +780,17 @@ def configure_uvicorn_logging() -> None:
"""
log_level_str, log_format, log_output, config = _load_log_config()
level = getattr(logging, log_level_str, logging.INFO)
- handler = _create_log_handler(log_output, config)
- formatter = logging.Formatter(log_format)
- handler.setFormatter(formatter)
-
- # Add unified trace context filter
- handler.addFilter(TraceContextFilter())
# Configure all Uvicorn loggers
uvicorn_logger_names = ["uvicorn", "uvicorn.error", "uvicorn.access"]
for logger_name in uvicorn_logger_names:
logger = logging.getLogger(logger_name)
- logger.handlers.clear()
- logger.addHandler(handler)
- logger.setLevel(level)
- logger.propagate = False
+ handler = _create_log_handler(log_output, config)
+ handler.setFormatter(logging.Formatter(log_format))
+ handler.addFilter(TraceContextFilter())
+ _configure_logger_instance(
+ logger,
+ level=level,
+ formatter=logging.Formatter(log_format),
+ handler=handler,
+ )
diff --git a/tests/api_test/tools/tests/test_logger_usage_regression.py b/tests/api_test/tools/tests/test_logger_usage_regression.py
new file mode 100644
index 000000000..332f5493c
--- /dev/null
+++ b/tests/api_test/tools/tests/test_logger_usage_regression.py
@@ -0,0 +1,49 @@
+import pathlib
+
+_ROOT = pathlib.Path(__file__).resolve().parents[4]
+
+
+def _read(relative_path: str) -> str:
+ return (_ROOT / relative_path).read_text(encoding="utf-8")
+
+
+def test_runtime_modules_use_unified_get_logger():
+ target_files = [
+ "openviking/server/oauth/router.py",
+ "openviking/server/oauth/storage.py",
+ "openviking/server/oauth/provider.py",
+ "openviking/server/routers/sessions.py",
+ "openviking/server/routers/stats.py",
+ "openviking/observability/http_observability_middleware.py",
+ "openviking/observability/context.py",
+ "openviking/metrics/global_api.py",
+ "openviking/metrics/exporters/otel.py",
+ "openviking/parse/registry.py",
+ "openviking/parse/tree_builder.py",
+ "openviking/parse/accessors/registry.py",
+ "openviking/parse/parsers/pdf.py",
+ "openviking/parse/parsers/code/ast/extractor.py",
+ "openviking/models/rerank/base.py",
+ "openviking/models/rerank/volcengine_rerank.py",
+ "openviking/models/rerank/openai_rerank.py",
+ "openviking/models/rerank/litellm_rerank.py",
+ "openviking/models/rerank/cohere_rerank.py",
+ "openviking/models/embedder/base.py",
+ "openviking/models/embedder/jina_embedders.py",
+ "openviking/models/embedder/cohere_embedders.py",
+ "openviking/models/embedder/openai_embedders.py",
+ "openviking/models/embedder/voyage_embedders.py",
+ "openviking/models/embedder/litellm_embedders.py",
+ "openviking/models/embedder/local_embedders.py",
+ "openviking/models/embedder/gemini_embedders.py",
+ "openviking/models/vlm/base.py",
+ "openviking/models/vlm/backends/litellm_vlm.py",
+ "openviking/models/vlm/backends/volcengine_vlm.py",
+ "openviking/models/vlm/backends/openai_vlm.py",
+ "openviking_cli/session/user_id.py",
+ ]
+
+ for relative_path in target_files:
+ content = _read(relative_path)
+ assert "get_logger(__name__)" in content, relative_path
+ assert "logging.getLogger(__name__)" not in content, relative_path
diff --git a/tests/telemetry/test_observability_context.py b/tests/telemetry/test_observability_context.py
index a60ea57c4..0eac617a9 100644
--- a/tests/telemetry/test_observability_context.py
+++ b/tests/telemetry/test_observability_context.py
@@ -19,6 +19,8 @@ Key features tested:
from __future__ import annotations
import asyncio
+import subprocess
+import sys
from typing import Optional
import pytest
@@ -130,6 +132,26 @@ class TestObservabilityContextBasics:
assert fields["custom_field"] == "custom_value"
+ def test_import_from_fresh_interpreter_does_not_trigger_circular_import(self) -> None:
+ """
+ Test that observability context can be imported in a fresh interpreter.
+
+ This guards against package-level import cycles between
+ ``openviking.observability.context`` and ``openviking_cli.utils``.
+ """
+ result = subprocess.run(
+ [
+ sys.executable,
+ "-c",
+ "import importlib; importlib.import_module('openviking.observability.context')",
+ ],
+ capture_output=True,
+ text=True,
+ check=False,
+ )
+
+ assert result.returncode == 0, result.stderr
+
class TestRootContextBinding:
"""
diff --git a/tests/test_config_loader.py b/tests/test_config_loader.py
index bf148c340..e1db79a12 100644
--- a/tests/test_config_loader.py
+++ b/tests/test_config_loader.py
@@ -2,6 +2,8 @@
# SPDX-License-Identifier: AGPL-3.0
"""Tests for config_loader utilities."""
+import logging
+
import pytest
from openviking_cli.utils.config import (
@@ -333,3 +335,41 @@ def test_openviking_config_singleton_initialize_missing_message_uses_openviking_
OpenVikingConfigSingleton.initialize()
finally:
OpenVikingConfigSingleton.reset_instance()
+
+
+def test_early_logger_initialization_is_reconfigured_to_file_output(tmp_path, monkeypatch):
+ from openviking_cli.utils.config.open_viking_config import OpenVikingConfigSingleton
+ from openviking_cli.utils.logger import get_logger
+
+ logger_name = "openviking.test.early_init"
+ logger = logging.getLogger(logger_name)
+ logger.handlers.clear()
+
+ OpenVikingConfigSingleton.reset_instance()
+ monkeypatch.setenv("OPENVIKING_CONFIG_FILE", "/tmp/codex-no-config.json")
+
+ early_logger = get_logger(logger_name)
+ assert any(isinstance(h, logging.StreamHandler) for h in early_logger.handlers)
+
+ config_path = tmp_path / "ov.conf"
+ config_path.write_text(
+ (
+ "{"
+ '"storage": {"workspace": "%s"}, '
+ '"log": {"output": "file", "level": "INFO", '
+ '"format": "%%(message)s", "rotation": false, "rotation_days": 7, '
+ '"rotation_interval": "midnight"}'
+ "}"
+ )
+ % str(tmp_path).replace("\\", "\\\\"),
+ encoding="utf-8",
+ )
+
+ try:
+ OpenVikingConfigSingleton.initialize(config_path=str(config_path))
+ refreshed_logger = get_logger(logger_name)
+ assert any(isinstance(h, logging.FileHandler) for h in refreshed_logger.handlers)
+ assert not any(type(h) is logging.StreamHandler for h in refreshed_logger.handlers)
+ finally:
+ refreshed_logger.handlers.clear()
+ OpenVikingConfigSingleton.reset_instance()