Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix: skill search ranking - use overview for embedding and fix visited set filtering (#228)

Zayn Jarvis3f65a326ebe3
diff --git a/openviking/retrieve/hierarchical_retriever.py b/openviking/retrieve/hierarchical_retriever.py
index 5aea089d7..d99a9a8dd 100644
--- a/openviking/retrieve/hierarchical_retriever.py
+++ b/openviking/retrieve/hierarchical_retriever.py
@@ -334,20 +334,27 @@ class HierarchicalRetriever:
alpha * score + (1 - alpha) * current_score if current_score else score
)
- if passes_threshold(final_score) and uri not in visited:
+ if not passes_threshold(final_score):
+ logger.debug(
+ f"[RecursiveSearch] URI {uri} score {final_score} did not pass threshold {effective_threshold}"
+ )
+ continue
+
+ # Always collect results that pass threshold, even if already
+ # visited as a directory starting point. The visited set only
+ # prevents re-entering directories for child search.
+ if not any(c.get("uri") == uri for c in collected):
r["_final_score"] = final_score
collected.append(r)
logger.debug(
f"[RecursiveSearch] Added URI: {uri} to candidates with score: {final_score}"
)
+
+ if uri not in visited:
if r.get("is_leaf"):
visited.add(uri)
- continue
- heapq.heappush(dir_queue, (-final_score, uri))
- else:
- logger.debug(
- f"[RecursiveSearch] URI {uri} score {final_score} did not pass threshold {effective_threshold}"
- )
+ else:
+ heapq.heappush(dir_queue, (-final_score, uri))
# Convergence check
current_topk = sorted(collected, key=lambda x: x.get("_final_score", 0), reverse=True)[
diff --git a/openviking/utils/skill_processor.py b/openviking/utils/skill_processor.py
index 5017fe1bb..5942ed71d 100644
--- a/openviking/utils/skill_processor.py
+++ b/openviking/utils/skill_processor.py
@@ -74,10 +74,12 @@ class SkillProcessor:
"source_path": skill_dict.get("source_path", ""),
},
)
- context.set_vectorize(Vectorize(text=context.abstract))
-
overview = await self._generate_overview(skill_dict, config)
+ # Use overview for vectorization (richer semantic content than abstract alone)
+ vectorize_text = overview if overview else context.abstract
+ context.set_vectorize(Vectorize(text=vectorize_text))
+
skill_dir_uri = f"viking://agent/skills/{context.meta['name']}"
await self._write_skill_content(