Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
feat(vlm): expose timeout as a config field and thread it through (#1580)
Brian Le416d99f5ab1b
diff --git a/openviking/models/vlm/backends/litellm_vlm.py b/openviking/models/vlm/backends/litellm_vlm.pyindex e6cca8dc9..913acd484 100644--- a/openviking/models/vlm/backends/litellm_vlm.py+++ b/openviking/models/vlm/backends/litellm_vlm.py@@ -15,12 +15,9 @@ os.environ["LITELLM_LOCAL_MODEL_COST_MAP"] = "True"import litellmfrom litellm import acompletion, completion-from openviking.telemetry import tracer-from openviking.utils.model_retry import retry_async, retry_sync-from ..base import ToolCall, VLMBase, VLMResponselogger = logging.getLogger(__name__)@@ -209,6 +206,7 @@ class LiteLLMVLMProvider(VLMBase):"model": model,"messages": messages,"temperature": self.temperature,+ "timeout": self.timeout,}if self.max_tokens is not None:kwargs["max_tokens"] = self.max_tokens@@ -322,7 +320,7 @@ class LiteLLMVLMProvider(VLMBase):response = completion(**kwargs)elapsed = time.perf_counter() - t0self._update_token_usage_from_response(response, duration_seconds=elapsed)- tracer.info(f'response={response}')+ tracer.info(f"response={response}")if tools:return self._build_vlm_response(response, has_tools=True)return self._clean_response(self._extract_content_from_response(response))@@ -353,7 +351,7 @@ class LiteLLMVLMProvider(VLMBase):response = await acompletion(**kwargs)elapsed = time.perf_counter() - t0self._update_token_usage_from_response(response, duration_seconds=elapsed)- tracer.info(f'response={response}')+ tracer.info(f"response={response}")if tools:return self._build_vlm_response(response, has_tools=True)return self._clean_response(self._extract_content_from_response(response))diff --git a/openviking/models/vlm/backends/openai_vlm.py b/openviking/models/vlm/backends/openai_vlm.pyindex 8668ecd23..2db58ed29 100644--- a/openviking/models/vlm/backends/openai_vlm.py+++ b/openviking/models/vlm/backends/openai_vlm.py@@ -10,7 +10,6 @@ from pathlib import Pathfrom typing import Any, Dict, List, Optional, Unionfrom urllib.parse import urlparse-from openviking.telemetry import tracertry:@@ -78,6 +77,7 @@ class OpenAIVLM(VLMBase):self.api_base,self.api_version,self.extra_headers,+ self.timeout,)if self.provider == "azure":self._sync_client = openai.AzureOpenAI(**kwargs)@@ -96,6 +96,7 @@ class OpenAIVLM(VLMBase):self.api_base,self.api_version,self.extra_headers,+ self.timeout,)if self.provider == "azure":self._async_client = openai.AsyncAzureOpenAI(**kwargs)diff --git a/openviking/models/vlm/base.py b/openviking/models/vlm/base.pyindex 5845f8656..bf210e60b 100644--- a/openviking/models/vlm/base.py+++ b/openviking/models/vlm/base.py@@ -61,6 +61,7 @@ class VLMBase(ABC):self.api_base = config.get("api_base")self.temperature = config.get("temperature", 0.0)self.max_retries = config.get("max_retries", 3)+ self.timeout = config.get("timeout", 60.0)self.max_tokens = config.get("max_tokens")self.extra_headers = config.get("extra_headers")self.stream = config.get("stream", False)diff --git a/openviking_cli/utils/config/vlm_config.py b/openviking_cli/utils/config/vlm_config.pyindex 5bff0a8e4..5b1791e3e 100644--- a/openviking_cli/utils/config/vlm_config.py+++ b/openviking_cli/utils/config/vlm_config.py@@ -13,6 +13,15 @@ class VLMConfig(BaseModel):api_base: Optional[str] = Field(default=None, description="API base URL")temperature: float = Field(default=0.0, description="Generation temperature")max_retries: int = Field(default=3, description="Maximum retry attempts")+ timeout: float = Field(+ default=60.0,+ gt=0.0,+ description=(+ "Per-request HTTP timeout in seconds for VLM API calls. Applied to "+ "the underlying OpenAI/Azure/LiteLLM clients. Increase for slow or "+ "high-latency endpoints (e.g., DashScope, local inference servers)."+ ),+ )provider: Optional[str] = Field(default=None, description="Provider type")backend: Optional[str] = Field(diff --git a/tests/models/vlm/test_timeout_config.py b/tests/models/vlm/test_timeout_config.pynew file mode 100644index 000000000..1f09a2551--- /dev/null+++ b/tests/models/vlm/test_timeout_config.py@@ -0,0 +1,102 @@+# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.+# SPDX-License-Identifier: AGPL-3.0+"""Tests for ``vlm.timeout`` configuration propagation.++Before this was wired through, ``_build_openai_client_kwargs`` exposed a+``timeout`` parameter (#1208) but callers never passed it, so the default+60.0s was always used and end users could not override it via ``ov.conf``.+These tests lock in that the config value flows through to the underlying+OpenAI and LiteLLM clients.+"""++from unittest import mock++import pytest+from pydantic import ValidationError++from openviking.models.vlm.backends.openai_vlm import (+ OpenAIVLM,+ _build_openai_client_kwargs,+)+from openviking_cli.utils.config.vlm_config import VLMConfig+++def test_vlm_config_accepts_timeout():+ cfg = VLMConfig(model="gpt-4o-mini", api_key="sk-x", timeout=120.0)+ assert cfg.timeout == 120.0+++def test_vlm_config_timeout_defaults_to_60():+ cfg = VLMConfig(model="gpt-4o-mini", api_key="sk-x")+ assert cfg.timeout == 60.0+++def test_vlm_config_rejects_non_positive_timeout():+ with pytest.raises(ValidationError):+ VLMConfig(model="gpt-4o-mini", api_key="sk-x", timeout=0)+++def test_build_openai_client_kwargs_default_timeout():+ kwargs = _build_openai_client_kwargs("openai", "sk-x", "https://example.invalid", None, None)+ assert kwargs["timeout"] == 60.0+++def test_build_openai_client_kwargs_custom_timeout():+ kwargs = _build_openai_client_kwargs(+ "openai",+ "sk-x",+ "https://example.invalid",+ None,+ None,+ timeout=120.0,+ )+ assert kwargs["timeout"] == 120.0+++def test_openai_vlm_propagates_config_timeout():+ vlm = OpenAIVLM(+ {+ "provider": "openai",+ "model": "gpt-4o-mini",+ "api_key": "sk-x",+ "api_base": "https://example.invalid",+ "timeout": 120.0,+ }+ )+ assert vlm.timeout == 120.0++ with mock.patch("openviking.models.vlm.backends.openai_vlm.openai.OpenAI") as fake:+ vlm.get_client()+ assert fake.call_args.kwargs.get("timeout") == 120.0+++def test_openai_vlm_defaults_to_60_timeout_when_config_omits_it():+ vlm = OpenAIVLM(+ {+ "provider": "openai",+ "model": "gpt-4o-mini",+ "api_key": "sk-x",+ "api_base": "https://example.invalid",+ }+ )+ assert vlm.timeout == 60.0++ with mock.patch("openviking.models.vlm.backends.openai_vlm.openai.OpenAI") as fake:+ vlm.get_client()+ assert fake.call_args.kwargs.get("timeout") == 60.0+++def test_litellm_build_kwargs_includes_timeout():+ from openviking.models.vlm.backends.litellm_vlm import LiteLLMVLMProvider++ vlm = LiteLLMVLMProvider(+ {+ "provider": "openai",+ "model": "gpt-4o-mini",+ "api_key": "sk-x",+ "api_base": "https://example.invalid",+ "timeout": 90.0,+ }+ )+ kwargs = vlm._build_text_kwargs(prompt="hi")+ assert kwargs["timeout"] == 90.0