Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
Restrict auto recall to transformContext assemble (#2532)
Mingjian Que5854dbfdc236
diff --git a/examples/openclaw-plugin/context-engine.ts b/examples/openclaw-plugin/context-engine.tsindex 1c772c299..352b916ba 100644--- a/examples/openclaw-plugin/context-engine.ts+++ b/examples/openclaw-plugin/context-engine.ts@@ -364,26 +364,6 @@ function prependRecallToLatestUserMessage(messages: AgentMessage[], recallBlock:return prependRecallAtIndex(messages, messages.length - 1, recallBlock);}-function injectRecallIntoContext(messages: AgentMessage[], recallBlock: string): AgentMessage[] {- const latest = messages.at(-1);- if (latest?.role === "user" && !hasAutoRecallBlock(latest)) {- return prependRecallToLatestUserMessage(messages, recallBlock);- }-- const firstUserIndex = messages.findIndex((msg) => msg.role === "user" && !hasAutoRecallBlock(msg));- if (firstUserIndex >= 0) {- return prependRecallAtIndex(messages, firstUserIndex, recallBlock);- }-- return [- {- role: "user",- content: recallBlock,- },- ...messages,- ];-}-function emitDiag(log: Logger, stage: string, sessionId: string, data: Record<string, unknown>, enabled = true): void {if (!enabled) return;log.info(`openviking: diag ${JSON.stringify({ ts: Date.now(), stage, sessionId, data })}`);@@ -1296,43 +1276,6 @@ export function createMemoryOpenVikingContextEngine(params: {return { sanitized, archive, session, budgets, instruction };}- async function buildRecallForAssemble(params: {- ovSessionId: string;- agentId: string;- peerId?: string;- queryInput: RecallQueryInput;- client?: OpenVikingClient;- }): Promise<AssembleRecall> {- const query = prepareRecallQuery(params.queryInput.text);- if (!query.query || query.query.length < 5) {- diag("assemble_recall_skip", params.ovSessionId, {- reason: "empty_or_short_query",- querySource: params.queryInput.source,- queryChars: query.finalChars,- peerId: params.peerId ?? null,- });- return { memoryCount: 0, estimatedTokens: 0, queryChars: query.finalChars };- }-- if (query.truncated) {- logger.info(- `openviking: recall query truncated (` +- `chars=${query.originalChars}->${query.finalChars})`,- );- }-- const recall = await buildLongTermMemoryRecallContext({- cfg,- client: params.client ?? await getClient(),- agentId: params.agentId,- peerId: params.peerId,- queryText: query.query,- logger,- verbose: (message) => logger.info(message),- });- return { ...recall, queryChars: query.finalChars };- }-function recallDiagFields(params: {recall: AssembleRecall;queryInput: RecallQueryInput;@@ -1363,42 +1306,6 @@ export function createMemoryOpenVikingContextEngine(params: {});}- function emptyAssembleRecall(): AssembleRecall {- return { memoryCount: 0, estimatedTokens: 0, queryChars: 0 };- }-- function assembleRecallOnlyResult(params: {- ovSessionId: string;- reason: string;- baseMessages: AgentMessage[];- originalTokens: number;- recall: AssembleRecall;- recallBlock: string;- queryInput: RecallQueryInput;- peerId?: string;- sender: ResolvedSender;- extra?: Record<string, unknown>;- }): AssembleResult {- const withRecall = injectRecallIntoContext(params.baseMessages, params.recallBlock);- const estimatedTokens = roughEstimate(withRecall);- diag("assemble_result", params.ovSessionId, {- passthrough: false,- reason: params.reason,- ...(params.extra ?? {}),- outputMessagesCount: withRecall.length,- inputTokenEstimate: params.originalTokens,- estimatedTokens,- ...recallDiagFields({- recall: params.recall,- queryInput: params.queryInput,- peerId: params.peerId,- sender: params.sender,- }),- messages: messageDigest(withRecall),- });- return { messages: withRecall, estimatedTokens };- }-return {info: {id,@@ -1563,77 +1470,13 @@ export function createMemoryOpenVikingContextEngine(params: {const client = await getClient();const routingRef = assembleParams.sessionId ?? sessionKey ?? OVSessionId;const agentId = resolveAgentId(routingRef, sessionKey, OVSessionId);- const peerId = resolveAssembleRecallPeerId(agentId, sender);- const recallQueryInput = resolveRecallQueryInput({- latestMessage,- prompt: assembleParams.prompt,- senderName: sender.senderName,- preferPrompt: true,- });- const hasInjectedRecall = messages.some((message) => hasAutoRecallBlock(message));- let recall = emptyAssembleRecall();- if (cfg.autoRecall && !hasInjectedRecall) {- try {- recall = await buildRecallForAssemble({- ovSessionId: OVSessionId,- agentId,- peerId,- queryInput: recallQueryInput,- client,- });- } catch (recallErr) {- logger.warn?.(`openviking: auto-recall failed: ${String(recallErr)}`);- diag("assemble_recall_failed", OVSessionId, {- error: String(recallErr),- querySource: recallQueryInput.source,- peerId: peerId ?? null,- senderSource: sender.source,- });- }- }- const recallContextBlock = recall.section- ? buildOpenVikingContextBlock({ sections: [recall.section] })- : "";- let ctx;- try {- ctx = await client.getSessionContext(OVSessionId, tokenBudget, agentId);- } catch (ctxErr) {- if (recallContextBlock) {- return assembleRecallOnlyResult({- ovSessionId: OVSessionId,- reason: "recall_only_context_unavailable",- baseMessages: messages,- originalTokens,- recall,- recallBlock: recallContextBlock,- queryInput: recallQueryInput,- peerId,- sender,- extra: { contextError: String(ctxErr) },- });- }- throw ctxErr;- }+ const ctx = await client.getSessionContext(OVSessionId, tokenBudget, agentId);const preAbstracts = ctx?.pre_archive_abstracts ?? [];const hasArchives = !!ctx?.latest_archive_overview || preAbstracts.length > 0;const activeCount = ctx?.messages?.length ?? 0;if (!ctx || (!hasArchives && activeCount === 0)) {- if (recallContextBlock) {- return assembleRecallOnlyResult({- ovSessionId: OVSessionId,- reason: "recall_only_no_ov_data",- baseMessages: messages,- originalTokens,- recall,- recallBlock: recallContextBlock,- queryInput: recallQueryInput,- peerId,- sender,- extra: { archiveCount: 0, activeCount: 0 },- });- }return assemblePassthrough(OVSessionId, "no_ov_data", messages, originalTokens, {archiveCount: 0, activeCount: 0,});@@ -1658,9 +1501,7 @@ export function createMemoryOpenVikingContextEngine(params: {});}- const outputMessages = recallContextBlock- ? injectRecallIntoContext(sanitized, recallContextBlock)- : sanitized;+ const outputMessages = sanitized;const assembledTokens = roughEstimate(outputMessages) + instruction.tokens;const tokensSaved = originalTokens - assembledTokens;const savingPct = originalTokens > 0 ? Math.round((tokensSaved / originalTokens) * 100) : 0;@@ -1679,7 +1520,9 @@ export function createMemoryOpenVikingContextEngine(params: {sessionTokens: session.tokens,sessionBudget: budgets.sessionContext,reservedBudget: budgets.reserved,- ...recallDiagFields({ recall, queryInput: recallQueryInput, peerId, sender }),+ senderIdFound: sender.found,+ senderId: sender.senderId ?? null,+ senderSource: sender.source,messages: messageDigest(outputMessages),});diff --git a/examples/openclaw-plugin/tests/ut/context-engine-assemble.test.ts b/examples/openclaw-plugin/tests/ut/context-engine-assemble.test.tsindex fd2a2e197..eb67d77f9 100644--- a/examples/openclaw-plugin/tests/ut/context-engine-assemble.test.ts+++ b/examples/openclaw-plugin/tests/ut/context-engine-assemble.test.ts@@ -173,6 +173,7 @@ describe("context-engine assemble()", () => {cfgOverrides: {autoRecall: true,peer_role: "person",+ recallResources: true,},},);@@ -188,7 +189,7 @@ describe("context-engine assemble()", () => {messages: sourceMessages,});- expect(client.find).toHaveBeenCalledTimes(1);+ expect(client.find).toHaveBeenCalledTimes(2);for (const call of client.find.mock.calls) {expect(call[1]).toMatchObject({ peerId: "wx_user-01_abc" });}@@ -197,7 +198,7 @@ describe("context-engine assemble()", () => {}});- it("uses prompt metadata sender_id for main assemble peer auto-recall when runtimeContext is missing", async () => {+ it("does not auto-recall during main assemble from prompt metadata", async () => {vi.stubGlobal("fetch",vi.fn().mockResolvedValue({@@ -219,20 +220,6 @@ describe("context-engine assemble()", () => {client.getSessionContext.mockRejectedValueOnce(new Error("OpenViking request failed [NOT_FOUND]: Session not found"),);- client.find- .mockResolvedValueOnce({- memories: [- {- uri: "viking://user/acme/peers/ou_bcc/memories/profile.md",- level: 2,- category: "profile",- abstract: "# 秦浩杰\n- 正在维护的项目:openviking",- score: 0.92,- },- ],- total: 1,- })- .mockResolvedValueOnce({ memories: [], total: 0 });const prompt = ["Conversation info (untrusted metadata):",@@ -258,30 +245,27 @@ describe("context-engine assemble()", () => {"","[System: mention metadata]",].join("\n");+ const liveMessages = [{ role: "user", content: "live main assemble prompt" }];const result = await engine.assemble({sessionId: "session-main-prompt-peer",sessionKey: "agent:main:feishu:group:oc_123",- messages: [],+ messages: liveMessages,prompt,});- expect(client.find).toHaveBeenCalledTimes(1);- for (const call of client.find.mock.calls) {- expect(call[1]).toMatchObject({ peerId: "ou_bcc" });- }- expect(result.messages[0]?.role).toBe("user");- expect(result.messages[0]?.content).toContain("Source: openviking-auto-recall");- expect(result.messages[0]?.content).toContain("<openviking-context>");- expect(result.messages[0]?.content).toContain("## Long-term Memories");- expect(result.messages[0]?.content).not.toContain("<relevant-memories>");- expect(result.messages[0]?.content).toContain("正在维护的项目:openviking");+ expect(client.getSessionContext).toHaveBeenCalled();+ expect(client.find).not.toHaveBeenCalled();+ expect(result.messages).toEqual(liveMessages);+ expect(result.messages[0]?.content).not.toContain("Source: openviking-auto-recall");+ expect(result.messages[0]?.content).not.toContain("<openviking-context>");+ expect(result.messages[0]?.content).not.toContain("## Long-term Memories");} finally {vi.unstubAllGlobals();}});- it("prefers runtimeContext senderId over prompt metadata for main assemble recall", async () => {+ it("does not inject auto-recall into main assemble OV context", async () => {vi.stubGlobal("fetch",vi.fn().mockResolvedValue({@@ -294,9 +278,19 @@ describe("context-engine assemble()", () => {{latest_archive_overview: "",pre_archive_abstracts: [],- messages: [],- estimatedTokens: 0,- stats: makeStats(),+ messages: [+ {+ id: "stored-main-user",+ role: "user",+ created_at: "2026-04-30T00:00:00Z",+ parts: [{ type: "text", text: "Stored OpenViking prompt." }],+ },+ ],+ estimatedTokens: 12,+ stats: {+ ...makeStats(),+ activeTokens: 12,+ },},{cfgOverrides: {@@ -306,10 +300,11 @@ describe("context-engine assemble()", () => {},);- await engine.assemble({+ const liveMessages = [{ role: "user", content: "live prompt" }];+ const result = await engine.assemble({sessionId: "session-main-runtime-peer",runtimeContext: { senderId: "trusted/runtime-user" },- messages: [],+ messages: liveMessages,prompt: ["Conversation info (untrusted metadata):","```json",@@ -321,10 +316,15 @@ describe("context-engine assemble()", () => {].join("\n"),});- expect(client.find).toHaveBeenCalledTimes(1);- for (const call of client.find.mock.calls) {- expect(call[1]).toMatchObject({ peerId: "trusted_runtime-user" });- }+ expect(client.getSessionContext).toHaveBeenCalled();+ expect(client.find).not.toHaveBeenCalled();+ expect(result.messages[0]).toEqual({+ role: "user",+ content: "Stored OpenViking prompt.",+ });+ expect(result.messages[0]?.content).not.toContain("Source: openviking-auto-recall");+ expect(result.messages[0]?.content).not.toContain("<openviking-context>");+ expect(result.messages[0]?.content).not.toContain("## Long-term Memories");} finally {vi.unstubAllGlobals();}@@ -351,6 +351,7 @@ describe("context-engine assemble()", () => {cfgOverrides: {autoRecall: true,peer_role: "assistant",+ recallResources: true,},},);@@ -365,7 +366,7 @@ describe("context-engine assemble()", () => {messages: sourceMessages,});- expect(client.find).toHaveBeenCalledTimes(1);+ expect(client.find).toHaveBeenCalledTimes(2);for (const call of client.find.mock.calls) {expect(call[1]).toMatchObject({ peerId: "agent:session-assistant-peer" });}diff --git a/examples/openclaw-plugin/tests/ut/plugin-normal-flow-real-server.test.ts b/examples/openclaw-plugin/tests/ut/plugin-normal-flow-real-server.test.tsindex 49ae3f43f..716aedb08 100644--- a/examples/openclaw-plugin/tests/ut/plugin-normal-flow-real-server.test.ts+++ b/examples/openclaw-plugin/tests/ut/plugin-normal-flow-real-server.test.ts@@ -234,8 +234,8 @@ describe("plugin normal flow with healthy backend", () => {expect(assembled.messages[0]?.role).toBe("user");const firstAssembledMessage = String(assembled.messages[0]?.content);- expect(firstAssembledMessage).toContain("Source: openviking-auto-recall");- expect(firstAssembledMessage).toContain("User prefers Rust for backend tasks.");+ expect(firstAssembledMessage).not.toContain("Source: openviking-auto-recall");+ expect(firstAssembledMessage).not.toContain("User prefers Rust for backend tasks.");expect(firstAssembledMessage).toContain("[Session History Summary]\nEarlier work focused on backend stack choices.",);@@ -243,6 +243,9 @@ describe("plugin normal flow with healthy backend", () => {role: "assistant",content: [{ type: "text", text: "Stored answer from OpenViking." }],});+ expect(+ requests.some((entry) => entry.method === "POST" && entry.path === "/api/v1/search/find"),+ ).toBe(false);const transformed = await contextEngine.assemble({sessionId: "session-normal",