Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(memory): escape "-->" in MEMORY_FIELDS values (#4992)

alanhuangyoo5ace39d3ecee
diff --git a/openviking/session/memory/utils/memory_file_utils.py b/openviking/session/memory/utils/memory_file_utils.py
index 2cf3566d7..2953a6985 100644
--- a/openviking/session/memory/utils/memory_file_utils.py
+++ b/openviking/session/memory/utils/memory_file_utils.py
@@ -108,6 +108,9 @@ def _serialize_with_metadata(
metadata_json = json.dumps(
clean_metadata, indent=2, default=_serialize_datetime, ensure_ascii=False
)
+ # A "-->" inside a value would close the comment early. "\u003e" is the same
+ # character to any JSON parser, so the fields still read back unchanged.
+ metadata_json = metadata_json.replace("-->", "--\\u003e")
comment = f"\n\n<!-- MEMORY_FIELDS\n{metadata_json}\n-->"
diff --git a/tests/session/memory/test_memory_utils.py b/tests/session/memory/test_memory_utils.py
index 693691afe..cbe0b3ec6 100644
--- a/tests/session/memory/test_memory_utils.py
+++ b/tests/session/memory/test_memory_utils.py
@@ -17,6 +17,7 @@ from openviking.session.memory.utils import (
parse_memory_file_with_fields,
validate_uri_template,
)
+from openviking.session.memory.utils.content_visibility import visible_content
from openviking.session.memory.utils.memory_file_utils import MemoryFileUtils
@@ -380,6 +381,23 @@ Content"""
assert parsed["version"] == 1
assert parsed["content"] == "Prefers concise responses."
+ def test_field_value_containing_comment_terminator_round_trips(self):
+ memory_file = MemoryFile(
+ uri="viking://user/default/memories/events/2026/09/14/pipeline_switch.md",
+ memory_type="events",
+ content="Moved the ETL pipeline.",
+ extra_fields={"summary": "switched kafka --> flink", "ranges": "0-1"},
+ )
+
+ written = MemoryFileUtils.write(memory_file)
+ read_back = MemoryFileUtils.read(written, uri=memory_file.uri)
+
+ assert read_back.extra_fields["summary"] == "switched kafka --> flink"
+ assert read_back.extra_fields["ranges"] == "0-1"
+ assert read_back.memory_type == "events"
+ assert read_back.content == "Moved the ETL pipeline."
+ assert visible_content(written, uri=memory_file.uri) == "Moved the ETL pipeline."
+
def test_write_strips_user_identity_fields_from_memory_fields_comment(self):
memory_file = MemoryFile(
uri="viking://user/alice/memories/preferences/code_style.md",