Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

add_message改为写入TextPart列表,避免session消息解析异常; extract_session增加json转换方法 (#131)

Mingjian Que5e49ffd36e52
diff --git a/openviking/server/routers/sessions.py b/openviking/server/routers/sessions.py
index e8ae3c2db..0fa173823 100644
--- a/openviking/server/routers/sessions.py
+++ b/openviking/server/routers/sessions.py
@@ -2,11 +2,12 @@
# SPDX-License-Identifier: Apache-2.0
"""Sessions endpoints for OpenViking HTTP Server."""
-from typing import Optional
+from typing import Any, Optional
from fastapi import APIRouter, Depends, Path
from pydantic import BaseModel
+from openviking.message.part import TextPart
from openviking.server.auth import verify_api_key
from openviking.server.dependencies import get_service
from openviking.server.models import Response
@@ -27,6 +28,18 @@ class AddMessageRequest(BaseModel):
content: str
+def _to_jsonable(value: Any) -> Any:
+ """Convert internal objects (e.g. Context) into JSON-serializable values."""
+ to_dict = getattr(value, "to_dict", None)
+ if callable(to_dict):
+ return to_dict()
+ if isinstance(value, list):
+ return [_to_jsonable(item) for item in value]
+ if isinstance(value, dict):
+ return {k: _to_jsonable(v) for k, v in value.items()}
+ return value
+
+
@router.post("")
async def create_session(
request: CreateSessionRequest,
@@ -103,7 +116,7 @@ async def extract_session(
"""Extract memories from a session."""
service = get_service()
result = await service.sessions.extract(session_id)
- return Response(status="ok", result=result)
+ return Response(status="ok", result=_to_jsonable(result))
@router.post("/{session_id}/messages")
@@ -116,7 +129,7 @@ async def add_message(
service = get_service()
session = service.sessions.session(session_id)
session.load()
- session.add_message(request.role, request.content)
+ session.add_message(request.role, [TextPart(text=request.content)])
return Response(
status="ok",
result={
diff --git a/tests/server/test_api_sessions.py b/tests/server/test_api_sessions.py
index dea40617d..78ec82517 100644
--- a/tests/server/test_api_sessions.py
+++ b/tests/server/test_api_sessions.py
@@ -85,6 +85,42 @@ async def test_add_multiple_messages(client: httpx.AsyncClient):
assert count3 >= count2
+async def test_add_message_persistence_regression(
+ client: httpx.AsyncClient, service
+):
+ """Regression: message payload must persist as valid parts across loads."""
+ create_resp = await client.post(
+ "/api/v1/sessions", json={"user": "test"}
+ )
+ session_id = create_resp.json()["result"]["session_id"]
+
+ resp1 = await client.post(
+ f"/api/v1/sessions/{session_id}/messages",
+ json={"role": "user", "content": "Message A"},
+ )
+ assert resp1.status_code == 200
+ assert resp1.json()["result"]["message_count"] == 1
+
+ resp2 = await client.post(
+ f"/api/v1/sessions/{session_id}/messages",
+ json={"role": "user", "content": "Message B"},
+ )
+ assert resp2.status_code == 200
+ assert resp2.json()["result"]["message_count"] == 2
+
+ # Re-load through API path to ensure session file can be parsed back.
+ get_resp = await client.get(f"/api/v1/sessions/{session_id}")
+ assert get_resp.status_code == 200
+ assert get_resp.json()["result"]["message_count"] == 2
+
+ # Verify stored message content survives load/decode.
+ session = service.sessions.session(session_id)
+ session.load()
+ assert len(session.messages) == 2
+ assert session.messages[0].content == "Message A"
+ assert session.messages[1].content == "Message B"
+
+
async def test_delete_session(client: httpx.AsyncClient):
create_resp = await client.post(
"/api/v1/sessions", json={"user": "test"}
@@ -139,3 +175,34 @@ async def test_extract_session(client: httpx.AsyncClient):
)
assert resp.status_code == 200
assert resp.json()["status"] == "ok"
+
+
+async def test_extract_session_jsonable_regression(
+ client: httpx.AsyncClient, service, monkeypatch
+):
+ """Regression: extract endpoint should serialize internal objects."""
+
+ class FakeMemory:
+ __slots__ = ("uri",)
+
+ def __init__(self, uri: str):
+ self.uri = uri
+
+ def to_dict(self):
+ return {"uri": self.uri}
+
+ async def fake_extract(_session_id: str):
+ return [FakeMemory("viking://user/memories/mock.md")]
+
+ monkeypatch.setattr(service.sessions, "extract", fake_extract)
+
+ create_resp = await client.post(
+ "/api/v1/sessions", json={"user": "test"}
+ )
+ session_id = create_resp.json()["result"]["session_id"]
+
+ resp = await client.post(f"/api/v1/sessions/{session_id}/extract")
+ assert resp.status_code == 200
+ body = resp.json()
+ assert body["status"] == "ok"
+ assert body["result"] == [{"uri": "viking://user/memories/mock.md"}]