Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(path_lock): (#3353)
Kchen5f945fa8e606
diff --git a/openviking/storage/transaction/path_lock.py b/openviking/storage/transaction/path_lock.pyindex 3a7fc212a..693c51935 100644--- a/openviking/storage/transaction/path_lock.py+++ b/openviking/storage/transaction/path_lock.py@@ -168,6 +168,9 @@ class PathLockEngine:await self._async_agfs.mkdir(path)logger.debug(f"Directory created: {path}")except Exception as e:+ if await self._is_existing_directory_async(path):+ logger.debug(f"Directory created concurrently: {path}")+ return Truelogger.warning(f"Failed to create directory {path}: {e}")return Falsereturn Truediff --git a/tests/transaction/test_exact_path_lock.py b/tests/transaction/test_exact_path_lock.pyindex 7cf8f6f6a..e5f1b63f3 100644--- a/tests/transaction/test_exact_path_lock.py+++ b/tests/transaction/test_exact_path_lock.py@@ -2,6 +2,9 @@# SPDX-License-Identifier: AGPL-3.0"""Tests for ExactPathLock semantics."""+import asyncio+import threading+import pytestfrom openviking.storage.transaction.lock_handle import LockHandle@@ -85,6 +88,43 @@ class _MemoryAgfs:return [{"name": name, "isDir": is_dir} for name, is_dir in names.items()]+class _ConcurrentParentCreationAgfs(_MemoryAgfs):+ def __init__(self, shared_parent: str):+ super().__init__()+ self.shared_parent = shared_parent+ self._initial_stat_barrier = threading.Barrier(2)+ self._state_lock = threading.Lock()+ self._missing_stat_count = 0+ self.mkdir_attempts = 0++ def stat(self, path: str):+ path = path.rstrip("/") or "/"+ should_report_missing = False+ if path == self.shared_parent:+ with self._state_lock:+ if self._missing_stat_count < 2:+ self._missing_stat_count += 1+ should_report_missing = True+ if should_report_missing:+ self._initial_stat_barrier.wait(timeout=5)+ raise FileNotFoundError(path)+ return super().stat(path)++ def mkdir(self, path: str):+ path = path.rstrip("/") or "/"+ if path != self.shared_parent:+ return super().mkdir(path)+ with self._state_lock:+ self.mkdir_attempts += 1+ if path in self.dirs:+ raise FileExistsError(path)+ parent = self._parent(path)+ if parent not in self.dirs:+ raise FileNotFoundError(parent)+ self.dirs.add(path)+ return {"message": "created"}++def _agfs_with_docs_dir() -> _MemoryAgfs:agfs = _MemoryAgfs()agfs.mkdir("/local")@@ -108,6 +148,36 @@ async def test_exact_path_lock_allows_sibling_paths():await lock.release(second)+async def test_exact_path_locks_tolerate_concurrent_parent_creation():+ shared_parent = "/local/default/resources/shared"+ agfs = _ConcurrentParentCreationAgfs(shared_parent)+ agfs.mkdir("/local")+ agfs.mkdir("/local/default")+ agfs.mkdir("/local/default/resources")+ lock = PathLockEngine(agfs)+ first = LockHandle(id="exact-a")+ second = LockHandle(id="exact-b")++ acquired = await asyncio.gather(+ lock.acquire_exact_path(f"{shared_parent}/a.md", first),+ lock.acquire_exact_path(f"{shared_parent}/b.md", second),+ )++ assert acquired == [True, True]+ assert agfs.mkdir_attempts == 2+ exact_lock_paths = [+ path+ for path in agfs.files+ if path.startswith(f"{shared_parent}/")+ and path.rsplit("/", 1)[-1].startswith(EXACT_LOCK_FILE_PREFIX)+ ]+ assert len(exact_lock_paths) == 2++ await lock.release(first)+ await lock.release(second)++@pytest.mark.asyncioasync def test_exact_path_lock_blocks_same_path_without_creating_target():agfs = _agfs_with_docs_dir()