Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

Discard invalid write-time search tags (#4000)

Jiahui Zhou62fbf68e8462
diff --git a/openviking/service/session_service.py b/openviking/service/session_service.py
index cd31d01ce..0273a1ba8 100644
--- a/openviking/service/session_service.py
+++ b/openviking/service/session_service.py
@@ -252,7 +252,10 @@ class SessionService:
else:
session.meta.auto_commit_policy = None
if event_tags is not None:
- session.meta.event_search_tags = normalize_search_tags(event_tags)
+ session.meta.event_search_tags = normalize_search_tags(
+ event_tags,
+ discard_invalid=True,
+ )
await session.ensure_exists()
self._record_lifecycle_metric("create", "ok")
return session
@@ -507,7 +510,9 @@ class SessionService:
self._ensure_initialized()
session = await self.get(session_id, ctx)
normalized_event_tags = (
- normalize_search_tags(event_tags) if event_tags is not None else None
+ normalize_search_tags(event_tags, discard_invalid=True)
+ if event_tags is not None
+ else None
)
if normalized_event_tags is not None or update_auto_commit_policy:
await session.update_config(
diff --git a/openviking/storage/content_write.py b/openviking/storage/content_write.py
index fe129a327..64d188daa 100644
--- a/openviking/storage/content_write.py
+++ b/openviking/storage/content_write.py
@@ -594,7 +594,7 @@ class ContentWriteCoordinator:
raise InvalidArgumentError(str(exc)) from exc
self._validate_tag_mode(mode)
- normalized_tags = normalize_search_tags(tags)
+ normalized_tags = normalize_search_tags(tags, discard_invalid=True)
stat = await self._safe_stat(normalized_uri, ctx=ctx)
if stat.get("isDir"):
return await self._set_directory_tags(
diff --git a/openviking/utils/ingest_options.py b/openviking/utils/ingest_options.py
index fa1e1defe..cd7dc0e64 100644
--- a/openviking/utils/ingest_options.py
+++ b/openviking/utils/ingest_options.py
@@ -32,7 +32,10 @@ class IngestOptions:
) -> "IngestOptions":
if tags is None:
return cls()
- return cls(search_tags=normalize_search_tags(tags), search_tag_mode=mode)
+ return cls(
+ search_tags=normalize_search_tags(tags, discard_invalid=True),
+ search_tag_mode=mode,
+ )
@classmethod
def from_value(cls, value: "IngestOptions | Mapping[str, Any] | None") -> "IngestOptions":
diff --git a/openviking/utils/tags.py b/openviking/utils/tags.py
index d30eac14b..918b1d663 100644
--- a/openviking/utils/tags.py
+++ b/openviking/utils/tags.py
@@ -4,11 +4,14 @@
from __future__ import annotations
+import logging
from collections import OrderedDict
from typing import Any, Iterable
from openviking_cli.exceptions import InvalidArgumentError
+logger = logging.getLogger(__name__)
+
def normalize_search_tag(tag: str) -> str:
"""Validate and normalize a single k=v search tag."""
@@ -26,18 +29,38 @@ def normalize_search_tag(tag: str) -> str:
return f"{key}={raw_value}"
-def normalize_search_tags(tags: Iterable[str] | None) -> list[str]:
+def normalize_search_tags(
+ tags: Iterable[str] | None,
+ *,
+ discard_invalid: bool = False,
+) -> list[str]:
"""Normalize explicit search tags while preserving stable order."""
if not tags:
return []
values_by_key: OrderedDict[str, str] = OrderedDict()
+ invalid_tags: list[str] = []
for item in tags:
if item is None:
continue
- value = normalize_search_tag(item)
+ try:
+ value = normalize_search_tag(item)
+ except InvalidArgumentError:
+ if discard_invalid:
+ invalid_tags.append(str(item))
+ continue
+ raise
key, raw_value = value.split("=", 1)
values_by_key[key] = raw_value
+ if invalid_tags:
+ logger.warning(
+ "Discarded invalid search tags: %s",
+ invalid_tags,
+ extra={
+ "invalid_tags": invalid_tags,
+ "invalid_tag_count": len(invalid_tags),
+ },
+ )
return [f"{key}={value}" for key, value in values_by_key.items()]
diff --git a/tests/server/test_admin_rebuild_api.py b/tests/server/test_admin_rebuild_api.py
index 5e1c4a1f0..97381e3c8 100644
--- a/tests/server/test_admin_rebuild_api.py
+++ b/tests/server/test_admin_rebuild_api.py
@@ -346,31 +346,17 @@ async def test_reindex_executor_rejects_dry_run_for_non_prune_mode_direct():
@pytest.mark.asyncio
-async def test_reindex_executor_validates_tags_before_creating_background_task(monkeypatch):
+async def test_reindex_executor_discards_invalid_tags_before_creating_background_task():
from openviking.service.reindex_executor import ReindexExecutor
- class FakeTracker:
- async def create_if_no_running(self, *args, **kwargs):
- raise AssertionError("task must not be created for invalid tags")
-
- monkeypatch.setattr(
- "openviking.service.reindex_executor.get_task_tracker",
- lambda: FakeTracker(),
- )
- ctx = RequestContext(
- user=UserIdentifier(account_id="test", user_id="alice"),
- role=Role.ROOT,
+ ingest_options = ReindexExecutor._resolve_ingest_options(
+ mode="vectors_only",
+ tags=["invalid", "team=search"],
+ tag_mode="replace",
)
- with pytest.raises(OpenVikingError, match="expected strict k=v"):
- await ReindexExecutor().execute(
- uri="viking://resources/demo",
- mode="vectors_only",
- wait=False,
- tags=["invalid"],
- tag_mode="replace",
- ctx=ctx,
- )
+ assert ingest_options is not None
+ assert ingest_options.search_tags == ["team=search"]
@pytest.mark.asyncio
diff --git a/tests/server/test_api_content_write.py b/tests/server/test_api_content_write.py
index 29bda4063..363b426ea 100644
--- a/tests/server/test_api_content_write.py
+++ b/tests/server/test_api_content_write.py
@@ -323,14 +323,14 @@ async def test_set_tags_rejects_wait_and_timeout_fields(client_with_resource):
assert body["status"] == "error"
-async def test_set_tags_rejects_invalid_kv_tag(client_with_resource):
+async def test_set_tags_discards_invalid_kv_tag(client_with_resource):
client, uri = client_with_resource
file_uri = await _first_file_uri(client, uri)
resp = await client.post(
"/api/v1/fs/attrs/set_tags",
- json={"uri": file_uri, "tags": ["project-a"]},
+ json={"uri": file_uri, "tags": ["project-a", "team=search"]},
)
- assert resp.status_code == 400
+ assert resp.status_code == 200
body = resp.json()
- assert body["status"] == "error"
- assert body["error"]["code"] == "INVALID_ARGUMENT"
+ assert body["status"] == "ok"
+ assert body["result"]["tags"] == ["team=search"]
diff --git a/tests/server/test_api_sessions_event_tags.py b/tests/server/test_api_sessions_event_tags.py
index 9736ca011..02b5a1074 100644
--- a/tests/server/test_api_sessions_event_tags.py
+++ b/tests/server/test_api_sessions_event_tags.py
@@ -59,14 +59,18 @@ async def test_session_config_updates_event_tags_and_auto_commit_policy(
assert disabled.json()["result"]["auto_commit_policy"] is None
-async def test_session_event_tags_reject_invalid_values(client: httpx.AsyncClient):
+async def test_session_event_tags_discard_invalid_values(client: httpx.AsyncClient):
response = await client.post(
"/api/v1/sessions",
- json={"memory_extraction_config": {"events": {"tags": ["missing-equals"]}}},
+ json={
+ "memory_extraction_config": {
+ "events": {"tags": ["missing-equals", "channel=web"]}
+ }
+ },
)
- assert response.status_code == 400
- assert response.json()["error"]["code"] == "INVALID_ARGUMENT"
+ assert response.status_code == 200
+ assert _event_tags(response) == ["channel=web"]
async def test_create_session_duplicate_event_tag_keys_keep_last_value(
diff --git a/tests/server/test_content_write_service.py b/tests/server/test_content_write_service.py
index 424ddfa2d..dfdad1d0a 100644
--- a/tests/server/test_content_write_service.py
+++ b/tests/server/test_content_write_service.py
@@ -1313,7 +1313,7 @@ async def test_set_tags_append_merges_existing_tags(monkeypatch):
@pytest.mark.asyncio
-async def test_set_tags_rejects_non_kv_tags(monkeypatch):
+async def test_set_tags_discards_non_kv_tags(monkeypatch):
file_uri = "viking://resources/demo/doc.md"
root_uri = "viking://resources/demo"
ctx = RequestContext(user=UserIdentifier.the_default_user(), role=Role.USER)
@@ -1321,12 +1321,24 @@ async def test_set_tags_rejects_non_kv_tags(monkeypatch):
coordinator = ContentWriteCoordinator(viking_fs=fake_vfs)
class _FakeVectorStore:
+ def __init__(self):
+ self.update_calls = []
+
async def update_search_tags(self, uri: str, tags, *, mode: str, levels=None, ctx=None):
- raise AssertionError("invalid tags must fail before store update")
+ del levels, ctx
+ self.update_calls.append((uri, list(tags), mode))
+ return [{"uri": uri}]
- fake_vfs.vector_store = _FakeVectorStore()
- with pytest.raises(InvalidArgumentError, match="k=v"):
- await coordinator.set_tags(uri=file_uri, tags=["project-a"], ctx=ctx)
+ fake_store = _FakeVectorStore()
+ fake_vfs.vector_store = fake_store
+ result = await coordinator.set_tags(
+ uri=file_uri,
+ tags=["project-a", "team=search"],
+ ctx=ctx,
+ )
+
+ assert result["tags"] == ["team=search"]
+ assert fake_store.update_calls == [(file_uri, ["team=search"], "replace")]
@pytest.mark.asyncio
diff --git a/tests/unit/test_search_tags_filter.py b/tests/unit/test_search_tags_filter.py
index b8aea5032..cd780d249 100644
--- a/tests/unit/test_search_tags_filter.py
+++ b/tests/unit/test_search_tags_filter.py
@@ -1,7 +1,10 @@
# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.
# SPDX-License-Identifier: AGPL-3.0
+import logging
+
from openviking.server.routers.search import _resolve_search_filter
+from openviking.utils import tags as tags_module
from openviking.utils.tags import build_search_tags_filter, normalize_search_tags
@@ -27,6 +30,26 @@ def test_search_tags_duplicate_keys_keep_last_value():
assert normalize_search_tags(["channel=web", "channel=app"]) == ["channel=app"]
+def test_discard_invalid_search_tags_logs_one_warning_for_batch(caplog):
+ tags_module.logger.addHandler(caplog.handler)
+ try:
+ with caplog.at_level(logging.WARNING, logger="openviking.utils.tags"):
+ result = normalize_search_tags(
+ ["bad-one", "also-bad", "team=search"],
+ discard_invalid=True,
+ )
+ finally:
+ tags_module.logger.removeHandler(caplog.handler)
+
+ assert result == ["team=search"]
+ warnings = [record for record in caplog.records if record.levelno == logging.WARNING]
+ assert len(warnings) == 1
+ assert warnings[0].invalid_tags == ["bad-one", "also-bad"]
+ assert "Discarded invalid search tags" in warnings[0].message
+ assert "bad-one" in warnings[0].message
+ assert "also-bad" in warnings[0].message
+
+
def test_find_tags_filter_requires_all_tags():
result = _resolve_search_filter(
request_filter=None,