Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(session): tolerate placeholder memory telemetry URIs (#4598)
zgy63ba98cadb1d
diff --git a/openviking/session/compressor_v3.py b/openviking/session/compressor_v3.pyindex 4ef8df2ae..7da07f951 100644--- a/openviking/session/compressor_v3.py+++ b/openviking/session/compressor_v3.py@@ -165,21 +165,29 @@ def _report_extraction_telemetry(result: Any, operations: ResolvedOperations) ->types_by_uri = _memory_type_by_uri(operations)actions_by_type: dict[str, dict[str, int]] = {}+ def memory_type_for_telemetry(uri: Any) -> str:+ if memory_type := types_by_uri.get(str(uri)):+ return str(memory_type)+ try:+ return str(MemoryUpdater.memory_type_from_uri(str(uri)) or "unknown")+ except ValueError:+ return "unknown"+def add(memory_type: Any, action: str) -> None:normalized_type = str(memory_type or "unknown")type_actions = actions_by_type.setdefault(normalized_type, {})type_actions[action] = type_actions.get(action, 0) + 1for uri in result.written_uris:- add(types_by_uri.get(str(uri), MemoryUpdater.memory_type_from_uri(uri)), "created")+ add(memory_type_for_telemetry(uri), "created")for uri in result.edited_uris:- add(types_by_uri.get(str(uri), MemoryUpdater.memory_type_from_uri(uri)), "merged")+ add(memory_type_for_telemetry(uri), "merged")for uri in result.deleted_uris:- add(types_by_uri.get(str(uri), MemoryUpdater.memory_type_from_uri(uri)), "deleted")+ add(memory_type_for_telemetry(uri), "deleted")for operation in result.skipped_operations:add(getattr(operation, "memory_type", None), "skipped")for uri, _error in result.errors:- add(types_by_uri.get(str(uri), MemoryUpdater.memory_type_from_uri(uri)), "failed")+ add(memory_type_for_telemetry(uri), "failed")for memory_type, actions in actions_by_type.items():for action, value in actions.items():diff --git a/tests/session/test_compressor_v3.py b/tests/session/test_compressor_v3.pyindex 0ef2080c8..8fae732a6 100644--- a/tests/session/test_compressor_v3.py+++ b/tests/session/test_compressor_v3.py@@ -18,6 +18,7 @@ from openviking.session.compressor_v3 import (_experience_root_uri,_experience_snapshot_provenance,_experience_trajectory_map,+ _report_extraction_telemetry,_visible_experience_snapshot_uris,)from openviking.session.memory.dataclass import (@@ -46,6 +47,7 @@ from openviking.session.train import (Trajectory,)from openviking.session.train.components.session_commit import _case_spec_message_to_request+from openviking.telemetry import OperationTelemetry, bind_telemetryfrom openviking_cli.session.user_id import UserIdentifier@@ -111,6 +113,44 @@ def test_extract_long_term_memories_preserves_legacy_positional_parameter_order(]+def test_report_extraction_telemetry_handles_placeholder_error_targets():+ operations = ResolvedOperations(+ upsert_operations=[+ ResolvedOperation(+ old_memory_file_content=None,+ memory_fields={},+ memory_type="events",+ uris=["unknown"],+ )+ ],+ delete_file_contents=[],+ errors=[],+ )+ result = MemoryUpdateResult()+ result.add_written("unknown")+ result.add_edited("viking://user/u/memories/preferences/pref.md")+ result.add_deleted("viking://user/u/memories/events/old.md")+ result.add_error("events(page_id=xyz)", ValueError("Missing resolved URI"))++ telemetry = OperationTelemetry(operation="session.commit", enabled=True)+ with bind_telemetry(telemetry):+ _report_extraction_telemetry(result, operations)++ summary = telemetry.finish().summary+ extract = summary["memory"]["extract"]+ assert extract["actions"] == {+ "created": 1,+ "merged": 1,+ "deleted": 1,+ "failed": 1,+ }+ assert extract["actions_by_type"] == {+ "events": {"created": 1, "deleted": 1},+ "preferences": {"merged": 1},+ "unknown": {"failed": 1},+ }++@pytest.mark.asyncioasync def test_memory_diff_includes_intentionally_skipped_operations(monkeypatch):monkeypatch.setattr(