Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(web-studio): render raw HTML in Markdown preview with sanitization (#4046)
Zonas Zhou65ca4386943b
diff --git a/web-studio/package-lock.json b/web-studio/package-lock.jsonindex 75a302a12..eac84dceb 100644--- a/web-studio/package-lock.json+++ b/web-studio/package-lock.json@@ -57,6 +57,8 @@"react-i18next": "^17.0.2","react-markdown": "^10.1.0","recharts": "^3.8.1",+ "rehype-raw": "^7.0.0",+ "rehype-sanitize": "^6.0.0","remark-gfm": "^4.0.1","shadcn": "^4.1.2","sonner": "^2.0.7",diff --git a/web-studio/package.json b/web-studio/package.jsonindex a258d9e55..e2908daea 100644--- a/web-studio/package.json+++ b/web-studio/package.json@@ -67,6 +67,8 @@"react-i18next": "^17.0.2","react-markdown": "^10.1.0","recharts": "^3.8.1",+ "rehype-raw": "^7.0.0",+ "rehype-sanitize": "^6.0.0","remark-gfm": "^4.0.1","shadcn": "^4.1.2","sonner": "^2.0.7",diff --git a/web-studio/src/routes/resources/-components/file-preview-html.test.tsx b/web-studio/src/routes/resources/-components/file-preview-html.test.tsxnew file mode 100644index 000000000..23f60afdf--- /dev/null+++ b/web-studio/src/routes/resources/-components/file-preview-html.test.tsx@@ -0,0 +1,118 @@+// @vitest-environment jsdom++import { QueryClient, QueryClientProvider } from '@tanstack/react-query'+import { render } from '@testing-library/react'+import type { PropsWithChildren } from 'react'+import { describe, expect, it, vi } from 'vitest'++import type { VikingFsEntry } from '../-types/viking-fm'+import { FilePreview } from './file-preview'++vi.mock('react-i18next', () => ({+ useTranslation: () => ({ t: (key: string) => key }),+}))++vi.mock('#/gen/ov-client/client.gen', () => ({+ client: {+ buildUrl: ({ query }: { query: { uri: string } }) =>+ `/api/v1/content/download?uri=${encodeURIComponent(query.uri)}`,+ },+}))++vi.mock('#/lib/ov-client', () => ({+ getContentDownload: vi.fn(),+ ovClient: { getOptions: () => ({ baseUrl: '' }) },+}))++const markdown = [+ '# Heading',+ '',+ '<div>rendered</div>',+ '',+ '<table><tbody><tr><th colspan="2">head</th></tr><tr><td rowspan="2">cell</td><td>a</td></tr><tr><td>b</td></tr></tbody></table>',+ '',+ '<script>window.__pwned = true</script>',+].join('\n')++vi.mock('../-hooks/viking-fm', () => ({+ useInvalidateVikingFs: () => ({+ invalidateList: vi.fn(),+ invalidatePreview: vi.fn(),+ invalidateTree: vi.fn(),+ }),+ useVikingFilePreview: () => ({+ canLoadContent: false,+ isContentLoaded: true,+ isFetching: false,+ isLoading: false,+ preview: {+ content: markdown,+ fileType: 'markdown',+ shouldAutoRead: true,+ },+ refetch: vi.fn(),+ }),+ useVikingFsStat: () => ({+ data: undefined,+ isLoading: false,+ }),+}))++const file: VikingFsEntry = {+ abstract: '',+ isDir: false,+ modTime: '2026-08-04 12:00',+ modTimestamp: null,+ name: 'index.md',+ overview: '',+ size: '24 B',+ sizeBytes: 24,+ uri: 'viking://resources/wiki/index.md',+}++function renderPreview() {+ const queryClient = new QueryClient({+ defaultOptions: { queries: { retry: false } },+ })+ const wrapper = ({ children }: PropsWithChildren) => (+ <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>+ )+ return render(+ <FilePreview+ file={file}+ onClose={vi.fn()}+ onNavigate={vi.fn()}+ showCloseButton={false}+ />,+ { wrapper },+ )+}++describe('FilePreview Markdown raw HTML', () => {+ it('renders raw HTML elements instead of escaping them', () => {+ const { container } = renderPreview()++ const rendered = Array.from(container.querySelectorAll('div')).find(+ (el) => el.textContent === 'rendered',+ )+ expect(rendered).toBeTruthy()+ expect(container.textContent).not.toContain('<div>')+ })++ it('renders raw HTML tables through the shared table components', () => {+ const { container } = renderPreview()++ const head = container.querySelector('table th')+ const spanned = container.querySelector('table td')+ expect(head?.textContent).toBe('head')+ expect(head?.getAttribute('colspan')).toBe('2')+ expect(spanned?.textContent).toBe('cell')+ expect(spanned?.getAttribute('rowspan')).toBe('2')+ })++ it('strips script tags', () => {+ const { container } = renderPreview()++ expect(container.querySelector('script')).toBeNull()+ })+})diff --git a/web-studio/src/routes/resources/-components/file-preview.tsx b/web-studio/src/routes/resources/-components/file-preview.tsxindex bebd3ac94..686b05526 100644--- a/web-studio/src/routes/resources/-components/file-preview.tsx+++ b/web-studio/src/routes/resources/-components/file-preview.tsx@@ -3,6 +3,8 @@ import type { ComponentProps, ReactNode } from 'react'import { useQuery } from '@tanstack/react-query'import hljs from 'highlight.js/lib/core'import ReactMarkdown from 'react-markdown'+import rehypeRaw from 'rehype-raw'+import rehypeSanitize from 'rehype-sanitize'import remarkGfm from 'remark-gfm'import { X, Pencil, Save, XCircle, Loader2 } from 'lucide-react'import { useTranslation } from 'react-i18next'@@ -629,15 +631,27 @@ const markdownComponents = {code: MarkdownCode,pre: MarkdownPre,table: ({ children }: ComponentProps<'table'>) => (- <div className="my-4 overflow-x-auto rounded-md border">+ <div className="overflow-x-auto"><table className="w-full border-collapse text-sm">{children}</table></div>),- td: ({ children }: ComponentProps<'td'>) => (- <td className="border-t px-3 py-2 align-top">{children}</td>+ td: ({ children, colSpan, rowSpan }: ComponentProps<'td'>) => (+ <td+ className="border px-3 py-2 text-center align-middle"+ colSpan={colSpan}+ rowSpan={rowSpan}+ >+ {children}+ </td>),- th: ({ children }: ComponentProps<'th'>) => (- <th className="bg-muted/50 px-3 py-2 text-left font-medium">{children}</th>+ th: ({ children, colSpan, rowSpan }: ComponentProps<'th'>) => (+ <th+ className="border bg-muted/50 px-3 py-2 text-center align-middle font-medium"+ colSpan={colSpan}+ rowSpan={rowSpan}+ >+ {children}+ </th>),}@@ -1589,6 +1603,7 @@ export function FilePreview({<article className="prose prose-sm max-w-none break-words dark:prose-invert dark:prose-pre:bg-muted-foreground/20"><ReactMarkdownremarkPlugins={[remarkGfm]}+ rehypePlugins={[rehypeRaw, rehypeSanitize]}urlTransform={(url) => url}components={{...markdownComponents,