Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

feat(skill): support zip upload for add_skill API (#312)

SeanZ6d0b2142fe9a
diff --git a/crates/ov_cli/src/client.rs b/crates/ov_cli/src/client.rs
index b4687a950..808d6c6fb 100644
--- a/crates/ov_cli/src/client.rs
+++ b/crates/ov_cli/src/client.rs
@@ -100,9 +100,14 @@ impl HttpClient {
let form = reqwest::multipart::Form::new().part("file", part);
+ let mut headers = self.build_headers();
+ // Remove Content-Type: application/json, let reqwest set multipart/form-data automatically
+ headers.remove(reqwest::header::CONTENT_TYPE);
+
let response = self
.http
.post(&url)
+ .headers(headers)
.multipart(form)
.send()
.await
@@ -460,12 +465,26 @@ impl HttpClient {
wait: bool,
timeout: Option<f64>,
) -> Result<serde_json::Value> {
- let body = serde_json::json!({
- "data": data,
- "wait": wait,
- "timeout": timeout,
- });
- self.post("/api/v1/skills", &body).await
+ let path_obj = Path::new(data);
+
+ if path_obj.exists() && path_obj.is_dir() && !self.is_local_server() {
+ let zip_file = self.zip_directory(path_obj)?;
+ let temp_path = self.upload_temp_file(zip_file.path()).await?;
+
+ let body = serde_json::json!({
+ "temp_path": temp_path,
+ "wait": wait,
+ "timeout": timeout,
+ });
+ self.post("/api/v1/skills", &body).await
+ } else {
+ let body = serde_json::json!({
+ "data": data,
+ "wait": wait,
+ "timeout": timeout,
+ });
+ self.post("/api/v1/skills", &body).await
+ }
}
// ============ Relation Methods ============
diff --git a/openviking/server/routers/resources.py b/openviking/server/routers/resources.py
index dbfa0ae14..5e850c66a 100644
--- a/openviking/server/routers/resources.py
+++ b/openviking/server/routers/resources.py
@@ -34,7 +34,8 @@ class AddResourceRequest(BaseModel):
class AddSkillRequest(BaseModel):
"""Request model for add_skill."""
- data: Any
+ data: Any = None
+ temp_path: Optional[str] = None
wait: bool = False
timeout: Optional[float] = None
@@ -108,8 +109,13 @@ async def add_skill(
):
"""Add skill to OpenViking."""
service = get_service()
+
+ data = request.data
+ if request.temp_path:
+ data = request.temp_path
+
result = await service.resources.add_skill(
- data=request.data,
+ data=data,
ctx=_ctx,
wait=request.wait,
timeout=request.timeout,
diff --git a/openviking/utils/skill_processor.py b/openviking/utils/skill_processor.py
index 9b337567c..2b9310d75 100644
--- a/openviking/utils/skill_processor.py
+++ b/openviking/utils/skill_processor.py
@@ -6,6 +6,8 @@ Skill Processor for OpenViking.
Handles skill parsing, LLM generation, and storage operations.
"""
+import tempfile
+import zipfile
from pathlib import Path
from typing import Any, Dict, List, Optional
@@ -116,11 +118,16 @@ class SkillProcessor:
auxiliary_files = []
base_path = None
- # Convert string paths to Path objects
if isinstance(data, str):
path_obj = Path(data)
if path_obj.exists():
- data = path_obj
+ if zipfile.is_zipfile(path_obj):
+ temp_dir = Path(tempfile.mkdtemp())
+ with zipfile.ZipFile(path_obj, "r") as zipf:
+ zipf.extractall(temp_dir)
+ data = temp_dir
+ else:
+ data = path_obj
if isinstance(data, Path):
if data.is_dir():
diff --git a/openviking_cli/client/http.py b/openviking_cli/client/http.py
index 5be344024..3975c28ed 100644
--- a/openviking_cli/client/http.py
+++ b/openviking_cli/client/http.py
@@ -314,13 +314,28 @@ class AsyncHTTPClient(BaseClient):
timeout: Optional[float] = None,
) -> Dict[str, Any]:
"""Add skill to OpenViking."""
+ request_data = {
+ "wait": wait,
+ "timeout": timeout,
+ }
+
+ if isinstance(data, str):
+ path_obj = Path(data)
+ if path_obj.exists() and path_obj.is_dir() and not self._is_local_server():
+ zip_path = self._zip_directory(data)
+ try:
+ temp_path = await self._upload_temp_file(zip_path)
+ request_data["temp_path"] = temp_path
+ finally:
+ Path(zip_path).unlink(missing_ok=True)
+ else:
+ request_data["data"] = data
+ else:
+ request_data["data"] = data
+
response = await self._http.post(
"/api/v1/skills",
- json={
- "data": data,
- "wait": wait,
- "timeout": timeout,
- },
+ json=request_data,
)
return self._handle_response(response)