Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(fs): include uri in stat responses (#4448)

Zayn Jarvis74ad6a1ee813
diff --git a/openviking/server/routers/filesystem.py b/openviking/server/routers/filesystem.py
index dd90683fb..c768caa25 100644
--- a/openviking/server/routers/filesystem.py
+++ b/openviking/server/routers/filesystem.py
@@ -158,7 +158,7 @@ async def stat(
uri = validate_request_viking_uri(resolve_path_variables(uri), _ctx)
try:
result = await service.fs.stat(uri, ctx=_ctx)
- return Response(status="ok", result=result)
+ return Response(status="ok", result={**result, "uri": uri})
except AGFSNotFoundError:
raise NotFoundError(uri, "file")
except AGFSClientError as e:
diff --git a/tests/api_test/filesystem/slow/test_fs_field_consistency.py b/tests/api_test/filesystem/slow/test_fs_field_consistency.py
index 1201c0b68..0a4af1a12 100644
--- a/tests/api_test/filesystem/slow/test_fs_field_consistency.py
+++ b/tests/api_test/filesystem/slow/test_fs_field_consistency.py
@@ -124,15 +124,9 @@ class TestFsFieldConsistency:
stat_resp = api_client.fs_stat(file_uri)
assert stat_resp.status_code == 200
result = stat_resp.json().get("result", {})
- if "uri" in result:
- assert result["uri"] == file_uri, (
- f"stat uri should match request, got {result['uri']} != {file_uri}"
- )
- elif "name" in result:
- expected_name = file_uri.rstrip("/").split("/")[-1]
- assert result["name"] == expected_name, (
- f"stat name should match file name, got {result['name']} != {expected_name}"
- )
+ assert result.get("uri") == file_uri, (
+ f"stat uri should match request, got {result.get('uri')} != {file_uri}"
+ )
def test_ls_simple_mode(self, api_client):
with tempfile.TemporaryDirectory() as temp_dir:
diff --git a/tests/server/test_filesystem_router.py b/tests/server/test_filesystem_router.py
index e7c8aaa5a..128efc233 100644
--- a/tests/server/test_filesystem_router.py
+++ b/tests/server/test_filesystem_router.py
@@ -4,8 +4,11 @@
from types import SimpleNamespace
+import httpx
import pytest
+from fastapi import FastAPI
+from openviking.server.auth import get_request_context
from openviking.server.identity import RequestContext, Role
from openviking.server.routers import filesystem
from openviking_cli.session.user_id import UserIdentifier
@@ -141,6 +144,48 @@ async def test_dev_root_http_mkdir_expands_home_alias_from_request_identity(
assert seen["ctx"].user.user_id == "alice"
+async def test_http_stat_returns_canonical_request_uri(monkeypatch):
+ seen = {}
+ request_context = RequestContext(
+ user=UserIdentifier("acct", "alice"), role=Role.USER
+ )
+
+ async def fake_stat(uri, ctx=None):
+ seen.update(uri=uri, ctx=ctx)
+ return {
+ "name": "notes.md",
+ "size": 12,
+ "mode": 0o644,
+ "modTime": "2026-08-28T00:00:00Z",
+ "isDir": False,
+ "isLocked": False,
+ }
+
+ monkeypatch.setattr(
+ filesystem,
+ "get_service",
+ lambda: SimpleNamespace(fs=SimpleNamespace(stat=fake_stat)),
+ )
+
+ app = FastAPI()
+ app.include_router(filesystem.router)
+ app.dependency_overrides[get_request_context] = lambda: request_context
+ transport = httpx.ASGITransport(app=app)
+ async with httpx.AsyncClient(
+ transport=transport, base_url="http://testserver"
+ ) as client:
+ response = await client.get(
+ "/api/v1/fs/stat",
+ params={"uri": "viking://~/resources/notes.md"},
+ )
+
+ assert response.status_code == 200, response.text
+ assert response.json()["result"]["uri"] == "viking://user/alice/resources/notes.md"
+ assert seen["uri"] == "viking://user/alice/resources/notes.md"
+ assert seen["ctx"].user.user_id == "alice"
+
+
@pytest.mark.asyncio
async def test_ls_user_container_lists_only_caller_space(app, client, service):
"""`viking://user` is the container of user spaces, not a current-user shorthand."""