Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(pi-plugin): preserve camelCase tool result messages (#4940)

NanHan Qing7c88d5c5ad6a
diff --git a/examples/pi-coding-agent-extension/lib/capture-adapter.mjs b/examples/pi-coding-agent-extension/lib/capture-adapter.mjs
index f8da674b6..de2dc522a 100644
--- a/examples/pi-coding-agent-extension/lib/capture-adapter.mjs
+++ b/examples/pi-coding-agent-extension/lib/capture-adapter.mjs
@@ -10,7 +10,7 @@ function normalizeRole(role) {
const value = String(role || "").toLowerCase();
if (value === "user") return "user";
if (value === "assistant") return "assistant";
- if (value === "tool" || value === "tool_result") return "user";
+ if (value === "tool" || value === "tool_result" || value === "toolresult") return "user";
if (value === "tool_call" || value === "toolcall") return "assistant";
return "";
}
diff --git a/examples/pi-coding-agent-extension/tests/capture-adapter.test.mjs b/examples/pi-coding-agent-extension/tests/capture-adapter.test.mjs
index de6b45584..5e41a8da9 100644
--- a/examples/pi-coding-agent-extension/tests/capture-adapter.test.mjs
+++ b/examples/pi-coding-agent-extension/tests/capture-adapter.test.mjs
@@ -16,29 +16,54 @@ test("extractBranchCapturePayloads converts user text to message payload", () =>
assert.equal(result.payloads[0].peer_id, "peer-a");
});
-test("extractBranchCapturePayloads emits structured tool parts", () => {
- const branch = [
- {
- type: "message",
- message: {
- role: "assistant",
- content: [
- { type: "text", text: "I will inspect it." },
- { type: "tool_call", id: "call-1", name: "read", input: { path: "a.txt" } },
- ],
- },
- },
- ];
+for (const role of ["toolResult", "tool_result", "tool"]) {
+ for (const isError of [false, true]) {
+ test(`extractBranchCapturePayloads preserves ${role} ${isError ? "error" : "completed"} results`, () => {
+ const output = [{ type: "text", text: "OVTOOLMARKER98765\n" }];
+ const branch = [
+ { type: "message", message: { role: "user", content: "Run the command and report its output." } },
+ {
+ type: "message",
+ message: {
+ role: "assistant",
+ content: [{
+ type: "toolCall",
+ id: "call-1",
+ name: "bash",
+ arguments: { command: "echo OVTOOLMARKER98765" },
+ }],
+ },
+ },
+ {
+ type: "message",
+ message: { role, toolCallId: "call-1", toolName: "bash", content: output, isError },
+ },
+ ];
+ const cfg = { captureAssistantTurns: true, captureToolMaxChars: 2000 };
+ const result = extractBranchCapturePayloads(branch, 0, cfg);
+ assert.deepEqual(result.payloads.map((payload) => payload.role), ["user", "assistant", "user"]);
+ assert.deepEqual(result.payloads[1].parts, [{
+ type: "tool",
+ tool_id: "call-1",
+ tool_name: "bash",
+ tool_status: "running",
+ tool_input: { command: "echo OVTOOLMARKER98765" },
+ }]);
+ assert.deepEqual(result.payloads[2].parts, [{
+ type: "tool",
+ tool_id: "call-1",
+ tool_name: "bash",
+ tool_status: isError ? "error" : "completed",
+ tool_output: JSON.stringify(output),
+ }]);
- const result = extractBranchCapturePayloads(branch, 0, {
- captureAssistantTurns: true,
- captureToolMaxChars: 2000,
- });
- assert.equal(result.payloads.length, 1);
- assert.equal(result.payloads[0].role, "assistant");
- assert.ok(Array.isArray(result.payloads[0].parts));
- assert.equal(result.payloads[0].parts.some((part) => part.type === "tool" && part.tool_name === "read"), true);
-});
+ const incremental = extractBranchCapturePayloads(branch, 2, cfg);
+ assert.deepEqual(incremental.payloads, [result.payloads[2]]);
+ assert.equal(incremental.nextEntryCount, 3);
+ assert.deepEqual(extractBranchCapturePayloads(branch, incremental.nextEntryCount, cfg).payloads, []);
+ });
+ }
+}
test("extractBranchCapturePayloads resets watermark when branch shrinks", () => {
const result = extractBranchCapturePayloads([