Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(core): make Working Memory generation opt-in (#5696)

weihan7d77e3d68fea
diff --git a/docs/en/api/05-sessions.md b/docs/en/api/05-sessions.md
index ea3c9f752..c779abd2e 100644
--- a/docs/en/api/05-sessions.md
+++ b/docs/en/api/05-sessions.md
@@ -43,7 +43,7 @@ Create a new session. Sessions are containers for conversations, storing message
| Parameter | Type | Required | Default | Description |
|-----------|------|----------|---------|-------------|
| session_id | str | No | None | Session ID. Creates new session with auto-generated ID if None |
-| memory_policy | object | No | None | Default memory extraction policy for the session. Optional `self` and `peer` switches control write targets, optional `working_memory.enabled=false` skips archive summaries, and optional top-level `memory_types` limits extraction to specific enabled memory schemas. Including `experiences` automatically activates `cases` and `trajectories`; without `experiences`, explicitly supplied `cases` and `trajectories` are ignored. Use JSON booleans for every `enabled` value. Legacy boolean-like values remain accepted temporarily (including string `"false"`, which is parsed as false) but emit a deprecation warning. When `memory_types` is omitted or `null`, all enabled memory schemas are allowed. Invalid shapes or unknown memory types are rejected with `InvalidArgumentError`. |
+| memory_policy | object | No | None | Default memory extraction policy for the session. Optional `self` and `peer` switches control write targets, `working_memory.enabled` defaults to `false` (no archive/checkpoint summaries); explicitly set it to `true` to generate summaries, and optional top-level `memory_types` limits extraction to specific enabled memory schemas. Including `experiences` automatically activates `cases` and `trajectories`; without `experiences`, explicitly supplied `cases` and `trajectories` are ignored. Use JSON booleans for every `enabled` value. Legacy boolean-like values remain accepted temporarily (including string `"false"`, which is parsed as false) but emit a deprecation warning. When `memory_types` is omitted or `null`, all enabled memory schemas are allowed. Invalid shapes or unknown memory types are rejected with `InvalidArgumentError`. |
| auto_commit_policy | object | No | None | Optional auto-commit policy (see table below). Any provided fields are validated, clamped to their bounds, and merged over the defaults; the effective policy is returned in the response `result.auto_commit_policy` and persisted into session metadata. If omitted, the new Session inherits `server.user_config_defaults.auto_commit_policy`, then the existing `memory.session_auto_commit.enabled` behavior. The policy can later be partially updated or disabled through `update_session_config()`. |
`auto_commit_policy` fields (all optional; omitted fields fall back to the defaults when a policy is present):
@@ -807,7 +807,7 @@ ov session get-session-context a1b2c3d4 --token-budget 128000
#### 1. API Implementation Introduction
-Get the full contents of one completed archive for a session. This endpoint is typically used with `get_session_context()` when you need to view older archive details.
+Get the full contents of one completed archive for a session. A normal WM-disabled archive returns its raw `messages` with empty `abstract` and `overview`; no summary is generated on read. Pending, failed, missing, or corrupt archives retain their existing error behavior. This explicit history read is independent of the bounded `get_session_context()` prompt view.
**Code Entries:**
- `openviking/session/session.py:Session.get_session_archive()` - Core implementation
@@ -1335,7 +1335,7 @@ Commit a session. Message archiving (Phase 1) completes before the response retu
**Two-Phase Commit Flow:**
- **Phase 1 (Synchronous)**: Split messages according to the retention policy, persist the archive and recovery records, enqueue Phase 2, and write retained messages back to the live session
-- **Phase 2 (Asynchronous)**: Generate summaries (L0/L1) and extract long-term memories
+- **Phase 2 (Asynchronous)**: Extract long-term memories; generate WM/checkpoint summaries only when the effective WM policy is enabled (default: disabled)
**Notes:**
- Consecutive commits are accepted; only requests that produce an archive return a separate `task_id`. No-op commits do not create tasks.
@@ -1358,6 +1358,7 @@ Commit a session. Message archiving (Phase 1) completes before the response retu
|-----------|------|----------|---------|-------------|
| session_id | str | Yes | - | Session ID to commit |
| keep_recent_count | int | No | 0 | Number of recent live messages to retain (kept live, not archived) after commit. `0` (default) archives all messages. |
+| enable_working_memory | bool or null | No | null | Override only WM generation for this commit. Omitted/null inherits the resolved policy; true/false leaves self/peer/memory_types and saved policies unchanged. Strings/numbers are rejected. The response includes `effective_enable_working_memory`. |
| reset_context | bool | No | false | HTTP API: archive all live messages, then append a boundary archive containing only a `.done` marker with `context_reset`. Keeps the session ID and raw history, clears injected context and stops future summaries from inheriting pre-reset overviews. Requires `keep_recent_count=0` and no `retention_mode`. |
`reset_context` is used by the OpenClaw plugin reset hook and `Session.commit_async()`. It also creates a boundary when there are no live messages, unless the newest archive is already a reset boundary. Memory extraction for older archives can finish independently; long-term memories are preserved. The SDK and CLI do not expose a dedicated `reset_context` option; use the HTTP API when needed.
diff --git a/docs/zh/api/05-sessions.md b/docs/zh/api/05-sessions.md
index 4242cc28a..2607865a5 100644
--- a/docs/zh/api/05-sessions.md
+++ b/docs/zh/api/05-sessions.md
@@ -43,7 +43,7 @@ Session API 按认证用户作用域访问会话,并返回 canonical user sess
| 参数 | 类型 | 必填 | 默认值 | 说明 |
|------|------|------|--------|------|
| session_id | str | 否 | None | 会话 ID。如果为 None,则创建一个自动生成 ID 的新会话 |
-| memory_policy | object | 否 | None | 会话默认的记忆抽取策略。可选的 `self` 和 `peer` 开关控制写入目标;可选的 `working_memory.enabled=false` 跳过 archive summary;可选的顶层 `memory_types` 将抽取限制为指定的 enabled memory schema。包含 `experiences` 时会自动激活 `cases` 和 `trajectories`;不包含 `experiences` 时,显式传入的 `cases` 和 `trajectories` 会被忽略。所有 `enabled` 值都应使用 JSON 布尔值。旧版 boolean-like 值暂时仍兼容(字符串 `"false"` 会正确解析为 false),但会产生弃用警告。`memory_types` 未传或为 `null` 时允许所有 enabled memory schema。非法结构或未知 memory type 会以 `InvalidArgumentError` 拒绝。 |
+| memory_policy | object | 否 | None | 会话默认的记忆抽取策略。可选的 `self` 和 `peer` 开关控制写入目标;`working_memory.enabled` 默认 `false`,不生成归档摘要和 checkpoint 摘要,显式设为 `true` 才会生成;可选的顶层 `memory_types` 将抽取限制为指定的 enabled memory schema。包含 `experiences` 时会自动激活 `cases` 和 `trajectories`;不包含 `experiences` 时,显式传入的 `cases` 和 `trajectories` 会被忽略。所有 `enabled` 值都应使用 JSON 布尔值。旧版 boolean-like 值暂时仍兼容(字符串 `"false"` 会正确解析为 false),但会产生弃用警告。`memory_types` 未传或为 `null` 时允许所有 enabled memory schema。非法结构或未知 memory type 会以 `InvalidArgumentError` 拒绝。 |
| auto_commit_policy | object | 否 | None | 可选的自动 commit 策略(见下表)。传入的字段会被校验并 clamp 到取值范围,然后合并到默认值之上;最终生效的策略会在响应的 `result.auto_commit_policy` 中返回,并持久化到 session meta。省略时,新 Session 先继承 `server.user_config_defaults.auto_commit_policy`,再沿用现有 `memory.session_auto_commit.enabled` 行为。之后可通过 `update_session_config()` 部分更新或禁用该策略。 |
`auto_commit_policy` 字段(均为可选;存在 policy 时,未传字段回退到默认值):
@@ -803,6 +803,8 @@ ov session get-session-context a1b2c3d4 --token-budget 128000
### get_session_archive()
+正常完成的无 WM 归档仍返回 `messages` 原文,`abstract` 和 `overview` 为空字符串,读取时不会补生成摘要。pending、failed、不存在或损坏归档仍遵循原有错误契约。此接口主动展开单个归档,不改变 `/context` 的历史边界。
+
#### 1. API 实现介绍
获取某次已完成归档的完整内容。该接口通常配合 `get_session_context()` 使用,当需要查看更早的归档详情时调用。
@@ -1355,6 +1357,7 @@ ov add-memory '[{"role":"user","content":"Hello"},{"role":"assistant","content":
|------|------|------|--------|------|
| session_id | str | 是 | - | 要提交的会话 ID |
| keep_recent_count | int | 否 | 0 | 提交后保留为 live 状态的最近消息数 (保持 live, 不归档)。`0` (默认) 归档全部消息。 |
+| enable_working_memory | bool 或 null | 否 | null | 仅覆盖本次 commit 的 WM 生成开关;省略/null 沿用有效策略,true/false 不改变 self、peer、memory_types 或已保存策略。拒绝字符串和数字;响应的 `effective_enable_working_memory` 返回实际生效值。 |
| reset_context | bool | 否 | false | HTTP API:归档全部 live messages 后追加只含 `.done`(带 `context_reset`)的边界 archive,目录内没有消息文件。保留 session ID 和原始历史,清空注入上下文,并阻止后续摘要继承 reset 前的 overview。要求 `keep_recent_count=0`,且不设置 `retention_mode`。 |
`reset_context` 供 OpenClaw 插件 reset hook 和 `Session.commit_async()` 使用;没有 live messages 时也会创建边界;若最新 archive 已是 reset 边界则不重复创建。旧 archive 的记忆提取可以继续完成,长期记忆保留。SDK 和 CLI 没有专用的 `reset_context` 参数,需要时使用 HTTP API。
diff --git a/openviking/server/routers/sessions.py b/openviking/server/routers/sessions.py
index 57cc5608d..3423bdfc7 100644
--- a/openviking/server/routers/sessions.py
+++ b/openviking/server/routers/sessions.py
@@ -5,7 +5,7 @@
from typing import Any, Dict, List, Literal, Optional
from fastapi import APIRouter, Body, Depends, HTTPException, Path, Query
-from pydantic import BaseModel, Field, field_validator, model_validator
+from pydantic import BaseModel, Field, StrictBool, field_validator, model_validator
from openviking.core.path_variables import resolve_path_variables
from openviking.core.peer_id import normalize_peer_id
@@ -366,8 +366,8 @@ async def get_session(
result["pending_tokens"] = int(session.meta.pending_tokens or 0)
result["auto_commit_policy"] = service.sessions.effective_auto_commit_policy(session)
result.pop("event_search_tags", None)
- result["memory_extraction_config"] = (
- service.sessions.effective_memory_extraction_config(session)
+ result["memory_extraction_config"] = service.sessions.effective_memory_extraction_config(
+ session
)
return Response(status="ok", result=result)
@@ -400,9 +400,7 @@ async def update_session_config(
from openviking_cli.exceptions import NotFoundError
service = get_service()
- event_tags = _event_tags_from_extraction_config(
- request.memory_extraction_config
- )
+ event_tags = _event_tags_from_extraction_config(request.memory_extraction_config)
update_auto_commit_policy = "auto_commit_policy" in request.model_fields_set
auto_commit_policy = (
request.auto_commit_policy.model_dump(exclude_none=True)
@@ -434,9 +432,9 @@ async def update_session_config(
)
except NotFoundError:
return error_response("NOT_FOUND", f"Session {session_id} not found")
- return Response(
- status="ok", result=execution.result, telemetry=execution.telemetry
- ).model_dump(exclude_none=True)
+ return Response(status="ok", result=execution.result, telemetry=execution.telemetry).model_dump(
+ exclude_none=True
+ )
@router.get("/{session_id}/tool-results")
@@ -535,9 +533,7 @@ async def get_session_archive(
try:
result = await session.get_session_archive(archive_id)
except NotFoundError:
- return error_response(
- code="NOT_FOUND", message=f"Archive {archive_id} not found"
- )
+ return error_response(code="NOT_FOUND", message=f"Archive {archive_id} not found")
return Response(status="ok", result=_to_jsonable(result))
@@ -591,6 +587,10 @@ class CommitRequest(BaseModel):
behavior.
"""
+ enable_working_memory: Optional[StrictBool] = Field(
+ default=None,
+ description="Override only Working Memory generation for this commit; null inherits policy.",
+ )
reset_context: bool = Field(
default=False,
strict=True,
@@ -672,6 +672,7 @@ async def commit_session(
service = get_service()
commit_kwargs: Dict[str, Any] = {"keep_recent_count": body.keep_recent_count}
optional_retention = {
+ "enable_working_memory": body.enable_working_memory,
"retention_mode": body.retention_mode,
"keep_recent_turn_count": body.keep_recent_turn_count,
"retained_message_token_budget": body.retained_message_token_budget,
diff --git a/openviking/service/session_service.py b/openviking/service/session_service.py
index 3e160d5b1..c33f07129 100644
--- a/openviking/service/session_service.py
+++ b/openviking/service/session_service.py
@@ -372,6 +372,7 @@ class SessionService:
ctx: RequestContext,
keep_recent_count: int = 0,
*,
+ enable_working_memory: Optional[bool] = None,
retention_mode: Optional[str] = None,
keep_recent_turn_count: Optional[int] = None,
retained_message_token_budget: Optional[int] = None,
@@ -394,6 +395,7 @@ class SessionService:
session_id,
ctx,
keep_recent_count=keep_recent_count,
+ enable_working_memory=enable_working_memory,
retention_mode=retention_mode,
keep_recent_turn_count=keep_recent_turn_count,
retained_message_token_budget=retained_message_token_budget,
@@ -408,6 +410,7 @@ class SessionService:
ctx: RequestContext,
keep_recent_count: int = 0,
*,
+ enable_working_memory: Optional[bool] = None,
retention_mode: Optional[str] = None,
keep_recent_turn_count: Optional[int] = None,
retained_message_token_budget: Optional[int] = None,
@@ -433,6 +436,7 @@ class SessionService:
session = await self.get(session_id, ctx)
commit_kwargs: Dict[str, Any] = {"keep_recent_count": keep_recent_count}
optional_retention = {
+ "enable_working_memory": enable_working_memory,
"retention_mode": retention_mode,
"keep_recent_turn_count": keep_recent_turn_count,
"retained_message_token_budget": retained_message_token_budget,
@@ -566,9 +570,7 @@ class SessionService:
return False
self._auto_commit_inflight.add(claim)
except Exception:
- logger.debug(
- "Skipped auto-commit scheduling for %s", session_id, exc_info=True
- )
+ logger.debug("Skipped auto-commit scheduling for %s", session_id, exc_info=True)
return False
task = asyncio.create_task(self.run_auto_commit(session_id, ctx, reason=reason_hint))
diff --git a/openviking/session/archive_store.py b/openviking/session/archive_store.py
index d5eb97e65..6a17e703a 100644
--- a/openviking/session/archive_store.py
+++ b/openviking/session/archive_store.py
@@ -104,6 +104,15 @@ class ArchiveStore:
# Pure helpers (no I/O)
# ------------------------------------------------------------------
+ @staticmethod
+ def normalize_done(done: Dict[str, Any]) -> Dict[str, Any]:
+ """Read markers written before the WM switch was renamed."""
+ normalized = dict(done)
+ if "enable_working_memory" not in normalized and "working_memory_enabled" in normalized:
+ normalized["enable_working_memory"] = normalized["working_memory_enabled"]
+ normalized.pop("working_memory_enabled", None)
+ return normalized
+
@staticmethod
def archive_index_from_uri(archive_uri: str) -> int:
"""Parse archive_NNN suffix into an integer index."""
@@ -252,7 +261,7 @@ class ArchiveStore:
raw_done = await self._viking_fs.read_file(done_uri, ctx=self._ctx)
parsed_done = json.loads(raw_done or "{}")
if isinstance(parsed_done, dict):
- done = parsed_done
+ done = self.normalize_done(parsed_done)
except Exception as exc:
# Marker existence still means completion, but unreadable
# contents cannot extend coverage to earlier archives.
@@ -265,7 +274,7 @@ class ArchiveStore:
# Otherwise leave overview empty here and let context assembly
# lazy-load the newest terminal completed archive's overview.
overview = ""
- if done.get("working_memory_enabled") is True:
+ if done.get("enable_working_memory") is True:
overview = await self.read_overview(archive["archive_uri"])
if not overview.strip():
# New markers distinguish an intentionally overview-less
@@ -354,18 +363,25 @@ class ArchiveStore:
"archive_uri": state.archive_uri,
"index": state.index,
"context_reset": state.done.get("context_reset") is True,
+ "enable_working_memory": state.done.get("enable_working_memory"),
}
)
return completed
- async def is_context_reset_archive(self, archive_uri: str) -> bool:
- """Return True when the archive's ``.done`` marks a context reset boundary."""
+ async def read_done(self, archive_uri: str) -> Dict[str, Any]:
+ """Read completion metadata without changing the terminal boundary."""
try:
- done = json.loads(await self._viking_fs.read_file(f"{archive_uri}/.done", ctx=self._ctx))
+ done = json.loads(
+ await self._viking_fs.read_file(f"{archive_uri}/.done", ctx=self._ctx)
+ )
except Exception:
- return False
- return isinstance(done, dict) and done.get("context_reset") is True
+ return {}
+ return self.normalize_done(done) if isinstance(done, dict) else {}
+
+ async def is_context_reset_archive(self, archive_uri: str) -> bool:
+ """Return True when the archive's ``.done`` marks a context reset boundary."""
+ return (await self.read_done(archive_uri)).get("context_reset") is True
# ------------------------------------------------------------------
# Sidecar readers
@@ -374,9 +390,7 @@ class ArchiveStore:
async def read_overview(self, archive_uri: str) -> str:
"""Read archive overview text."""
try:
- overview = await self._viking_fs.read_file(
- f"{archive_uri}/.overview.md", ctx=self._ctx
- )
+ overview = await self._viking_fs.read_file(f"{archive_uri}/.overview.md", ctx=self._ctx)
except Exception:
return ""
return body_for_preview(overview or "")
@@ -384,9 +398,7 @@ class ArchiveStore:
async def read_abstract(self, archive_uri: str, overview: str = "") -> str:
"""Read archive abstract text, falling back to summary extraction."""
try:
- abstract = await self._viking_fs.read_file(
- f"{archive_uri}/.abstract.md", ctx=self._ctx
- )
+ abstract = await self._viking_fs.read_file(f"{archive_uri}/.abstract.md", ctx=self._ctx)
except Exception:
abstract = ""
diff --git a/openviking/session/memory_policy.py b/openviking/session/memory_policy.py
index a56ffec76..2312f3081 100644
--- a/openviking/session/memory_policy.py
+++ b/openviking/session/memory_policy.py
@@ -91,7 +91,7 @@ class MemoryPolicy:
self_enabled: bool = True
peer_enabled: bool = True
memory_types: Optional[set[str]] = None
- working_memory_enabled: bool = True
+ enable_working_memory: bool = False
@classmethod
def default(cls) -> "MemoryPolicy":
@@ -114,8 +114,8 @@ class MemoryPolicy:
self_enabled=_target_enabled(data.get("self"), default_enabled=True, key="self"),
peer_enabled=_target_enabled(data.get("peer"), default_enabled=True, key="peer"),
memory_types=_parse_memory_types(data.get("memory_types")),
- working_memory_enabled=_target_enabled(
- data.get("working_memory"), default_enabled=True, key="working_memory"
+ enable_working_memory=_target_enabled(
+ data.get("working_memory"), default_enabled=False, key="working_memory"
),
)
@@ -133,8 +133,9 @@ class MemoryPolicy:
"self": {"enabled": self.self_enabled},
"peer": {"enabled": self.peer_enabled},
}
- if not self.working_memory_enabled:
- data["working_memory"] = {"enabled": False}
+ # Queue and recovery snapshots must preserve explicit opt-in across
+ # default changes, as must persisted user and session policies.
+ data["working_memory"] = {"enabled": self.enable_working_memory}
if self.memory_types is not None:
data["memory_types"] = sorted(self.memory_types)
return data
diff --git a/openviking/session/session.py b/openviking/session/session.py
index 309e8aee3..2ab01e8f3 100644
--- a/openviking/session/session.py
+++ b/openviking/session/session.py
@@ -9,7 +9,7 @@ import asyncio
import inspect
import json
import re
-from dataclasses import dataclass, field
+from dataclasses import dataclass, field, replace
from datetime import datetime, timezone
from typing import TYPE_CHECKING, Any, Awaitable, Callable, Dict, List, Optional
from uuid import uuid4
@@ -143,7 +143,7 @@ def _apply_agent_evolution_setting(
self_enabled=policy.self_enabled,
peer_enabled=policy.peer_enabled,
memory_types=effective_types,
- working_memory_enabled=policy.working_memory_enabled,
+ enable_working_memory=policy.enable_working_memory,
)
@@ -1215,6 +1215,7 @@ class Session:
keep_recent_count: int = 0,
*,
memory_policy: Optional[Dict[str, Any]] = None,
+ enable_working_memory: Optional[bool] = None,
retention_mode: Optional[str] = None,
keep_recent_turn_count: Optional[int] = None,
retained_message_token_budget: Optional[int] = None,
@@ -1225,6 +1226,7 @@ class Session:
self.commit_async(
keep_recent_count=keep_recent_count,
memory_policy=memory_policy,
+ enable_working_memory=enable_working_memory,
retention_mode=retention_mode,
keep_recent_turn_count=keep_recent_turn_count,
retained_message_token_budget=retained_message_token_budget,
@@ -1238,6 +1240,7 @@ class Session:
keep_recent_count: int = 0,
*,
memory_policy: Optional[Dict[str, Any]] = None,
+ enable_working_memory: Optional[bool] = None,
retention_mode: Optional[str] = None,
keep_recent_turn_count: Optional[int] = None,
retained_message_token_budget: Optional[int] = None,
@@ -1311,6 +1314,8 @@ class Session:
effective_min_tail = max(0, int(1 if min_raw_tail_steps is None else min_raw_tail_steps))
if turn_mode and effective_token_budget <= 0:
raise ValueError("retained_message_token_budget must be greater than 0")
+ if enable_working_memory is not None and not isinstance(enable_working_memory, bool):
+ raise ValueError("enable_working_memory must be a boolean or null")
in_memory_default_memory_policy = self._meta.memory_policy
agent_evolution_enabled = self._agent_evolution_enabled
if self._agent_evolution_enabled_provider is not None:
@@ -1327,6 +1332,10 @@ class Session:
effective_policy,
agent_evolution_enabled=agent_evolution_enabled,
)
+ if enable_working_memory is not None:
+ effective_policy = replace(
+ effective_policy, enable_working_memory=enable_working_memory
+ )
effective_memory_policy = effective_policy.to_dict()
effective_memory_types = sorted(_effective_memory_types(effective_policy))
agent_memory_skip_reason = _agent_memory_skip_reason(
@@ -1395,6 +1404,10 @@ class Session:
effective_policy,
agent_evolution_enabled=agent_evolution_enabled,
)
+ if enable_working_memory is not None:
+ effective_policy = replace(
+ effective_policy, enable_working_memory=enable_working_memory
+ )
effective_memory_policy = effective_policy.to_dict()
effective_memory_types = sorted(_effective_memory_types(effective_policy))
agent_memory_skip_reason = _agent_memory_skip_reason(
@@ -1434,6 +1447,7 @@ class Session:
"task_id": None,
"archive_uri": None,
"archived": False,
+ "effective_enable_working_memory": effective_policy.enable_working_memory,
"reason": "no_messages",
"trace_id": trace_id,
**({"reset_context": True} if reset_context else {}),
@@ -1487,6 +1501,7 @@ class Session:
"task_id": None,
"archive_uri": None,
"archived": False,
+ "effective_enable_working_memory": effective_policy.enable_working_memory,
"reason": "all_within_keep_window",
"trace_id": trace_id,
"estimated_active_tokens": (
@@ -1633,6 +1648,7 @@ class Session:
"task_id": task_id,
"archive_uri": archive_uri,
"archived": True,
+ "effective_enable_working_memory": effective_policy.enable_working_memory,
"trace_id": trace_id,
**({"reset_context": True} if reset_context else {}),
"estimated_active_tokens": (
@@ -1649,7 +1665,10 @@ class Session:
"""
# ponytail: reuse archive ordering; no second session identity or context store.
newest = f"{self._session_uri}/history/archive_{self._compression.compression_index:03d}"
- if self._compression.compression_index > 0 and await self._archives.is_context_reset_archive(newest):
+ if (
+ self._compression.compression_index > 0
+ and await self._archives.is_context_reset_archive(newest)
+ ):
return # Context is already empty; no second boundary needed.
self._compression.compression_index += 1
archive_uri = (
@@ -1658,7 +1677,7 @@ class Session:
try:
await self._viking_fs.write_file(
f"{archive_uri}/.done",
- json.dumps({"context_reset": True, "working_memory_enabled": False}),
+ json.dumps({"context_reset": True, "enable_working_memory": False}),
ctx=self.ctx,
)
except Exception as exc:
@@ -1982,14 +2001,20 @@ class Session:
ov_config = get_openviking_config()
effective_policy = MemoryPolicy.from_dict(memory_policy)
extraction_batch_limits = resolve_extraction_batch_limits(auto_commit_policy)
- working_memory_enabled = effective_policy.working_memory_enabled
+ enable_working_memory = effective_policy.enable_working_memory
+ logger.info(
+ "Session commit task=%s archive=%s enable_working_memory=%s",
+ task_id,
+ archive_uri,
+ enable_working_memory,
+ )
checkpoint_requests = (
await self._checkpoints.collect_requests_for_phase2(
archive_uri,
covered_failed_archives,
messages,
)
- if working_memory_enabled
+ if enable_working_memory
else []
)
latest_archive_overview = (
@@ -1997,7 +2022,7 @@ class Session:
exclude_archive_uri=archive_uri,
before_archive_index=archive_index,
)
- if working_memory_enabled
+ if enable_working_memory
else ""
)
extraction_messages = await self._tool_outputs.hydrate_for_extraction(messages)
@@ -2010,7 +2035,7 @@ class Session:
)
async def _run_archive_summary() -> None:
- if not working_memory_enabled:
+ if not enable_working_memory:
logger.info(
"Working Memory summary skipped "
"(memory_policy.working_memory.enabled=false)"
@@ -2127,7 +2152,9 @@ class Session:
archive_uri,
{
"completed_memory_steps": (
- self._archives.serialize_completed_memory_steps(completed_memory_steps)
+ self._archives.serialize_completed_memory_steps(
+ completed_memory_steps
+ )
)
},
)
@@ -2163,7 +2190,7 @@ class Session:
and (long_term_memory_types is None or bool(long_term_memory_types))
and bool(long_term_messages)
)
- if working_memory_enabled or (self._session_compressor and long_term_has_work):
+ if enable_working_memory or (self._session_compressor and long_term_has_work):
logger.info(
"Starting post-commit extraction from %s archived messages",
len(messages),
@@ -2171,7 +2198,7 @@ class Session:
extraction_tasks: List[Any] = []
extraction_labels: List[str] = []
- if working_memory_enabled:
+ if enable_working_memory:
extraction_tasks.append(_run_archive_summary())
extraction_labels.append("archive_summary")
@@ -2347,7 +2374,7 @@ class Session:
archive_uri,
first_message_id,
last_message_id,
- working_memory_enabled=working_memory_enabled,
+ enable_working_memory=enable_working_memory,
coverage_start_archive=coverage_start_archive,
coverage_end_archive=coverage_end_archive,
covered_failed_archives=covered_failed_archives,
@@ -2433,7 +2460,7 @@ class Session:
first_message_id: str,
last_message_id: str,
*,
- working_memory_enabled: Optional[bool] = None,
+ enable_working_memory: Optional[bool] = None,
coverage_start_archive: Optional[str] = None,
coverage_end_archive: Optional[str] = None,
covered_failed_archives: Optional[List[str]] = None,
@@ -2447,7 +2474,7 @@ class Session:
{
"starting_message_id": first_message_id,
"ending_message_id": last_message_id,
- "working_memory_enabled": working_memory_enabled,
+ "enable_working_memory": enable_working_memory,
"coverage_start_archive": coverage_start_archive or archive_id,
"coverage_end_archive": coverage_end_archive or archive_id,
"covered_failed_archives": list(covered_failed_archives or []),
@@ -2582,10 +2609,14 @@ class Session:
continue
overview = await self._archives.read_overview(archive["archive_uri"])
- if not overview:
+ if not overview and archive.get("enable_working_memory") is not False:
break
- abstract = await self._archives.read_abstract(archive["archive_uri"], overview)
+ abstract = (
+ await self._archives.read_abstract(archive["archive_uri"], overview)
+ if overview
+ else ""
+ )
return {
"archive_id": archive_id,
"abstract": abstract,
@@ -2649,7 +2680,9 @@ class Session:
}
elif await self._archives.is_context_reset_archive(terminal["archive_uri"]):
terminal = None
- else:
+ elif (await self._archives.read_done(terminal["archive_uri"])).get(
+ "enable_working_memory"
+ ) is not False:
# A required overview that is missing or unreadable still keeps
# the archive terminal here; the warning is emitted by the full
# scan used for Phase 2 bookkeeping.
@@ -2674,7 +2707,9 @@ class Session:
archive["archive_uri"],
)
- merged_messages = self._archives.stable_deduplicate_messages(archive_messages + list(self._messages))
+ merged_messages = self._archives.stable_deduplicate_messages(
+ archive_messages + list(self._messages)
+ )
merged_messages = await self._checkpoints.insert_terminal_checkpoints(
merged_messages,
terminal if terminal_state == "completed" else None,
diff --git a/openviking/storage/queuefs/session_commit_msg.py b/openviking/storage/queuefs/session_commit_msg.py
index 0cdd6283c..d66dce1a6 100644
--- a/openviking/storage/queuefs/session_commit_msg.py
+++ b/openviking/storage/queuefs/session_commit_msg.py
@@ -21,6 +21,9 @@ class SessionCommitMsg:
# commit. Already normalized by the producer; empty means "no tags".
event_search_tags: List[str] = field(default_factory=list)
auto_commit_policy: Dict[str, Any] = field(default_factory=dict)
+ # Version 1 snapshots explicitly encode WM. Version 0 (before default-off)
+ # omitted true; only queued work, never saved user intent, inherits that value.
+ memory_policy_version: int = 1
def to_dict(self) -> Dict[str, Any]:
return asdict(self)
@@ -31,4 +34,9 @@ class SessionCommitMsg:
if not isinstance(payload, dict):
raise ValueError("session commit queue payload must be an object")
known_fields = {item.name for item in fields(cls)}
- return cls(**{key: value for key, value in payload.items() if key in known_fields})
+ data = {key: value for key, value in payload.items() if key in known_fields}
+ if payload.get("memory_policy_version", 0) == 0:
+ policy = dict(data.get("memory_policy") or {})
+ policy.setdefault("working_memory", {"enabled": True})
+ data["memory_policy"] = policy
+ return cls(**data)
diff --git a/openviking_cli/client/_http_compat.py b/openviking_cli/client/_http_compat.py
index 2ef6165e6..003fc9ad5 100644
--- a/openviking_cli/client/_http_compat.py
+++ b/openviking_cli/client/_http_compat.py
@@ -173,6 +173,7 @@ class AsyncHTTPClient(import_openviking_sdk().AsyncHTTPClient):
telemetry: Any = False,
*,
keep_recent_count: int = 0,
+ enable_working_memory: bool | None = None,
retention_mode: str | None = None,
keep_recent_turn_count: int | None = None,
retained_message_token_budget: int | None = None,
@@ -185,6 +186,7 @@ class AsyncHTTPClient(import_openviking_sdk().AsyncHTTPClient):
"telemetry": telemetry,
}
optional = {
+ "enable_working_memory": enable_working_memory,
"retention_mode": retention_mode,
"keep_recent_turn_count": keep_recent_turn_count,
"retained_message_token_budget": retained_message_token_budget,
@@ -229,6 +231,7 @@ class SyncHTTPClient(import_openviking_sdk().SyncHTTPClient):
telemetry: Any = False,
*,
keep_recent_count: int = 0,
+ enable_working_memory: bool | None = None,
retention_mode: str | None = None,
keep_recent_turn_count: int | None = None,
retained_message_token_budget: int | None = None,
@@ -240,6 +243,7 @@ class SyncHTTPClient(import_openviking_sdk().SyncHTTPClient):
session_id,
telemetry=telemetry,
keep_recent_count=keep_recent_count,
+ enable_working_memory=enable_working_memory,
retention_mode=retention_mode,
keep_recent_turn_count=keep_recent_turn_count,
retained_message_token_budget=retained_message_token_budget,
diff --git a/sdk/python/openviking_sdk/options.py b/sdk/python/openviking_sdk/options.py
index e09cfc966..f8b55c02b 100644
--- a/sdk/python/openviking_sdk/options.py
+++ b/sdk/python/openviking_sdk/options.py
@@ -172,6 +172,7 @@ class BatchAddMessagesOptions(_ExtraOptions, total=False):
class CommitSessionOptions(_ExtraOptions, total=False):
+ enable_working_memory: Optional[bool]
retention_mode: Literal["turn_budget"]
keep_recent_turn_count: int
retained_message_token_budget: int
diff --git a/sdk/python/tests/test_async_client_behaviors.py b/sdk/python/tests/test_async_client_behaviors.py
index b012cb569..d98e307d0 100644
--- a/sdk/python/tests/test_async_client_behaviors.py
+++ b/sdk/python/tests/test_async_client_behaviors.py
@@ -118,6 +118,7 @@ async def test_async_http_client_sends_message_semantics_and_turn_retention():
"demo-session",
options={
"retention_mode": "turn_budget",
+ "enable_working_memory": True,
"keep_recent_turn_count": 3,
"retained_message_token_budget": 12_000,
"min_raw_tail_steps": 1,
@@ -133,6 +134,7 @@ async def test_async_http_client_sends_message_semantics_and_turn_retention():
}
assert fake_http.post.await_args_list[1].kwargs["json"] == {
"keep_recent_count": 0,
+ "enable_working_memory": True,
"retention_mode": "turn_budget",
"keep_recent_turn_count": 3,
"retained_message_token_budget": 12_000,
diff --git a/sdk/typescript/src/client.ts b/sdk/typescript/src/client.ts
index a7d7c11e0..f0f511912 100644
--- a/sdk/typescript/src/client.ts
+++ b/sdk/typescript/src/client.ts
@@ -931,6 +931,7 @@ export class OpenVikingClient {
options = optionsOrKeepRecentCount;
}
const body = compact({
+ enable_working_memory: options.enableWorkingMemory,
keep_recent_count: options.keepRecentCount,
retention_mode: options.retentionMode,
keep_recent_turn_count: options.keepRecentTurnCount,
diff --git a/sdk/typescript/src/types.ts b/sdk/typescript/src/types.ts
index aaa332ad3..d22620ed4 100644
--- a/sdk/typescript/src/types.ts
+++ b/sdk/typescript/src/types.ts
@@ -304,6 +304,8 @@ export interface BatchAddMessagesOptions {
}
/** Session commit and turn-retention options. */
export interface CommitSessionOptions {
+ /** Override only Working Memory for this commit; null inherits the session policy. */
+ enableWorkingMemory?: boolean | null;
keepRecentCount?: number;
retentionMode?: "turn_budget";
keepRecentTurnCount?: number;
diff --git a/sdk/typescript/tests/client.test.ts b/sdk/typescript/tests/client.test.ts
index f224b40a8..b49d4d2d9 100644
--- a/sdk/typescript/tests/client.test.ts
+++ b/sdk/typescript/tests/client.test.ts
@@ -149,6 +149,7 @@ describe("OpenVikingClient", () => {
sourceMessageIds: ["user-1"],
});
await client.commitSession("session-1", {
+ enableWorkingMemory: true,
retentionMode: "turn_budget",
keepRecentTurnCount: 3,
retainedMessageTokenBudget: 12_000,
@@ -163,6 +164,7 @@ describe("OpenVikingClient", () => {
source_message_ids: ["user-1"],
});
expect(JSON.parse(String(fetcher.mock.calls[1]![1]?.body))).toEqual({
+ enable_working_memory: true,
retention_mode: "turn_budget",
keep_recent_turn_count: 3,
retained_message_token_budget: 12_000,
diff --git a/tests/conftest.py b/tests/conftest.py
index aca5eacc4..813998d7c 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -4,7 +4,6 @@
"""Global test fixtures"""
import asyncio
-import shutil
from pathlib import Path
from typing import AsyncGenerator, Generator
@@ -83,7 +82,6 @@ _patch_agfs_grep_if_missing()
# Test data root directory
PROJECT_ROOT = Path(__file__).parent.parent
-TEST_TMP_DIR = PROJECT_ROOT / "test_data" / "tmp"
@pytest.fixture(scope="session")
@@ -95,11 +93,9 @@ def event_loop():
@pytest.fixture(scope="function")
-def temp_dir() -> Generator[Path, None, None]:
- """Create temp directory, auto-cleanup before and after test"""
- shutil.rmtree(TEST_TMP_DIR, ignore_errors=True)
- TEST_TMP_DIR.mkdir(parents=True, exist_ok=True)
- yield TEST_TMP_DIR
+def temp_dir(tmp_path: Path) -> Generator[Path, None, None]:
+ """Keep concurrent test runs from deleting each other's vector stores."""
+ yield tmp_path
@pytest.fixture(scope="function")
@@ -195,3 +191,9 @@ def request_context() -> RequestContext:
user=UserIdentifier.the_default_user(),
role=Role.USER,
)
+
+
+def working_memory_policy():
+ """Explicit opt-in for tests exercising WM/checkpoint generation."""
+ return {"working_memory": {"enabled": True}}
diff --git a/tests/server/test_api_sessions.py b/tests/server/test_api_sessions.py
index 910b43bcb..9226df929 100644
--- a/tests/server/test_api_sessions.py
+++ b/tests/server/test_api_sessions.py
@@ -471,7 +471,6 @@ async def test_get_session_context_includes_incomplete_archive_messages(
assert resp.status_code == 200
body = resp.json()
assert [m["parts"][0]["text"] for m in body["result"]["messages"]] == [
- "Archived seed",
"Pending user message",
"Pending assistant response",
"Current live message",
@@ -1343,9 +1342,11 @@ async def test_get_session_context_endpoint_returns_trimmed_latest_archive_and_m
)
[email protected]("wm_enabled", [False, True])
async def test_get_session_archive_endpoint_returns_archive_details(
client: httpx.AsyncClient,
service,
+ wm_enabled,
):
# See test_get_session_context_*: stub memory extraction (not covered by the
# server fake VLM) so the archive completes; this test checks the archive
@@ -1367,7 +1368,10 @@ async def test_get_session_archive_endpoint_returns_archive_details(
f"/api/v1/sessions/{session_id}/messages",
json=_message_request("assistant", content="archived answer"),
)
- commit_resp = await client.post(f"/api/v1/sessions/{session_id}/commit")
+ commit_resp = await client.post(
+ f"/api/v1/sessions/{session_id}/commit", json={"enable_working_memory": wm_enabled}
+ )
+ assert commit_resp.json()["result"]["effective_enable_working_memory"] is wm_enabled
task_id = commit_resp.json()["result"]["task_id"]
await _wait_for_task(client, task_id)
@@ -1376,8 +1380,8 @@ async def test_get_session_archive_endpoint_returns_archive_details(
body = resp.json()
assert body["status"] == "ok"
assert body["result"]["archive_id"] == "archive_001"
- assert body["result"]["overview"]
- assert body["result"]["abstract"]
+ assert bool(body["result"]["overview"]) is wm_enabled
+ assert bool(body["result"]["abstract"]) is wm_enabled
assert [m["parts"][0]["text"] for m in body["result"]["messages"]] == [
"archived question",
"archived answer",
@@ -1444,7 +1448,9 @@ async def test_commit_failed_when_summary_fails_does_not_block_next_commit(
"""If the core Working Memory summary fails, the archive is .failed.json (no
.done) and the task fails — but a failed archive must not block later commits.
"""
- create_resp = await client.post("/api/v1/sessions", json={})
+ create_resp = await client.post(
+ "/api/v1/sessions", json={"memory_policy": {"working_memory": {"enabled": True}}}
+ )
session_id = create_resp.json()["result"]["session_id"]
async def failing_summary(*args, **kwargs):
@@ -1481,3 +1487,11 @@ async def test_commit_failed_when_summary_fails_does_not_block_next_commit(
body = resp.json()
assert body["status"] == "ok"
assert body["result"]["archived"] is True
+
+
[email protected]("invalid", ["false", "true", 0, 1, {}, []])
+def test_commit_working_memory_override_requires_boolean(invalid):
+ from pydantic import ValidationError
+
+ with pytest.raises(ValidationError):
+ sessions_router.CommitRequest.model_validate({"enable_working_memory": invalid})
diff --git a/tests/session/conftest.py b/tests/session/conftest.py
index 79ea9b271..7e8eef5c7 100644
--- a/tests/session/conftest.py
+++ b/tests/session/conftest.py
@@ -74,6 +74,7 @@ async def client(
if commit_tasks:
await asyncio.gather(*commit_tasks, return_exceptions=True)
+
@pytest_asyncio.fixture(scope="function")
async def session(
client,
@@ -130,3 +131,16 @@ async def session_with_tool_call(
msg = session.add_message("assistant", [TextPart("Executing tool..."), tool_part])
yield session, msg.id, tool_id
+
+
+@pytest_asyncio.fixture
+async def wm_session_with_messages(client, service, request_context, working_memory_policy):
+ session = await service.sessions.create(request_context, memory_policy=working_memory_policy)
+ for role, text in [
+ ("user", "Hello, this is a test message."),
+ ("assistant", "Hello! How can I help you today?"),
+ ("user", "I need help with testing."),
+ ("assistant", "I can help you with testing."),
+ ]:
+ await session.add_message_async(role, [TextPart(text)])
+ yield session
diff --git a/tests/session/test_session_commit.py b/tests/session/test_session_commit.py
index 698d86ab7..4f5c1454d 100644
--- a/tests/session/test_session_commit.py
+++ b/tests/session/test_session_commit.py
@@ -38,14 +38,14 @@ class TestCommit:
"""Test commit"""
async def test_commit_preserves_unicode_separators_and_accepts_later_messages(
- self, session_with_messages: Session
+ self, wm_session_with_messages: Session
):
"""Unicode separators inside a message must not split its JSONL record."""
unicode_text = "before\u2028middle\u2029after\u0085tail"
- session_with_messages.add_message("assistant", [TextPart(unicode_text)])
- session_with_messages.add_message("user", [TextPart("continue")])
+ wm_session_with_messages.add_message("assistant", [TextPart(unicode_text)])
+ wm_session_with_messages.add_message("user", [TextPart("continue")])
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
assert isinstance(result, dict)
assert result.get("status") == "accepted"
@@ -53,9 +53,9 @@ class TestCommit:
assert result.get("task_id") is not None
assert "memory_diff_uri" not in result
assert "memories_extracted" not in result
- archive_content = await session_with_messages._viking_fs.read_file(
+ archive_content = await wm_session_with_messages._viking_fs.read_file(
f"{result['archive_uri']}/messages.jsonl",
- ctx=session_with_messages.ctx,
+ ctx=wm_session_with_messages.ctx,
)
archived_messages = [
json.loads(line) for line in archive_content.split("\n") if line.strip()
@@ -69,29 +69,29 @@ class TestCommit:
async def test_commit_extracts_memories(
self,
- session_with_messages: Session,
+ wm_session_with_messages: Session,
service: OpenVikingService,
):
"""Test commit kicks off background memory extraction"""
async def extract_long_term_memories(**kwargs):
archive_uri = kwargs["archive_uri"]
- await session_with_messages._viking_fs.write_file(
+ await wm_session_with_messages._viking_fs.write_file(
uri=f"{archive_uri}/memory_diff.json",
content=json.dumps({"archive_uri": archive_uri}),
- ctx=session_with_messages.ctx,
+ ctx=wm_session_with_messages.ctx,
)
return []
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
side_effect=extract_long_term_memories
)
- if hasattr(session_with_messages._session_compressor, "extract_execution_memories"):
- session_with_messages._session_compressor.extract_execution_memories = AsyncMock(
+ if hasattr(wm_session_with_messages._session_compressor, "extract_execution_memories"):
+ wm_session_with_messages._session_compressor.extract_execution_memories = AsyncMock(
return_value={"contexts": [], "session_skills": []}
)
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_id = result["task_id"]
# Wait for background memory extraction to complete
@@ -102,9 +102,9 @@ class TestCommit:
== f"{task_result['result']['archive_uri']}/memory_diff.json"
)
memory_diff = json.loads(
- await session_with_messages._viking_fs.read_file(
+ await wm_session_with_messages._viking_fs.read_file(
task_result["result"]["memory_diff_uri"],
- ctx=session_with_messages.ctx,
+ ctx=wm_session_with_messages.ctx,
)
)
assert memory_diff["archive_uri"] == task_result["result"]["archive_uri"]
@@ -112,15 +112,15 @@ class TestCommit:
memory_counts = task_result["result"]["memories_extracted"]
assert isinstance(memory_counts, dict)
- # Wait for semantic/embedding queues
- await service.resources.wait_processed(timeout=60.0)
+ # The extraction stub emits no semantic or embedding work. Its task
+ # completion above is the relevant processing boundary for this test.
async def test_phase2_splits_with_the_committed_auto_commit_policy(
self,
- session_with_messages: Session,
+ wm_session_with_messages: Session,
monkeypatch,
):
- await session_with_messages.update_config(
+ await wm_session_with_messages.update_config(
auto_commit_policy={
"pending_token_threshold": 0,
"message_count_threshold": 1,
@@ -140,27 +140,32 @@ class TestCommit:
return f"{latest_archive_overview}\n{messages[0].id}"
monkeypatch.setattr(Session, "_generate_archive_summary_async", generate_summary)
+ monkeypatch.setattr(
+ Session,
+ "_get_vlm_config",
+ AsyncMock(return_value=SimpleNamespace(is_available=lambda: True)),
+ )
extract_long_term = AsyncMock(return_value=[])
- session_with_messages._session_compressor.extract_long_term_memories = extract_long_term
+ wm_session_with_messages._session_compressor.extract_long_term_memories = extract_long_term
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
+ phase1 = await wm_session_with_messages._read_phase1_meta(result["archive_uri"])
+ assert phase1["queue_message"]["auto_commit_policy"]["message_count_threshold"] == 1
assert len(working_memory_batches) == 4
assert all(len(batch) == 1 for batch in working_memory_batches)
assert extract_long_term.await_count == 4
assert all(len(call.kwargs["messages"]) == 1 for call in extract_long_term.await_args_list)
- phase1 = await session_with_messages._read_phase1_meta(result["archive_uri"])
- assert phase1["queue_message"]["auto_commit_policy"]["message_count_threshold"] == 1
async def test_commit_task_reports_intentionally_skipped_memory_operations(
self,
- session_with_messages: Session,
+ wm_session_with_messages: Session,
):
async def extract_long_term_memories(**kwargs):
archive_uri = kwargs["archive_uri"]
- await session_with_messages._viking_fs.write_file(
+ await wm_session_with_messages._viking_fs.write_file(
uri=f"{archive_uri}/memory_diff.json",
content=json.dumps(
{
@@ -182,15 +187,15 @@ class TestCommit:
],
}
),
- ctx=session_with_messages.ctx,
+ ctx=wm_session_with_messages.ctx,
)
return []
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
side_effect=extract_long_term_memories
)
- commit_result = await session_with_messages.commit_async()
+ commit_result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(commit_result["task_id"])
assert commit_result["status"] == "accepted"
@@ -209,7 +214,7 @@ class TestCommit:
async def test_recovered_commit_task_reads_existing_skipped_memory_operations(
self,
- session_with_messages: Session,
+ wm_session_with_messages: Session,
monkeypatch,
):
original_prepare = Session._prepare_phase2_archive_messages
@@ -262,9 +267,9 @@ class TestCommit:
"_prepare_phase2_archive_messages",
prepare_with_completed_long_term,
)
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock()
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock()
- commit_result = await session_with_messages.commit_async()
+ commit_result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(commit_result["task_id"])
assert task_result["status"] == "completed"
@@ -279,20 +284,20 @@ class TestCommit:
}
],
}
- session_with_messages._session_compressor.extract_long_term_memories.assert_not_awaited()
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_not_awaited()
async def test_commit_default_disables_agent_memory_but_keeps_archive(
- self, session_with_messages: Session
+ self, wm_session_with_messages: Session
):
async def account_setting_provider() -> bool:
return False
- session_with_messages._agent_evolution_enabled_provider = account_setting_provider
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._agent_evolution_enabled_provider = account_setting_provider
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value=[]
)
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert result["archived"] is True
@@ -303,7 +308,7 @@ class TestCommit:
assert "experiences" not in task_result["result"]["effective_memory_types"]
assert task_result["result"]["agent_memory_skip_reason"] == ("agent_evolution_disabled")
call_kwargs = (
- session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
+ wm_session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
)
assert call_kwargs["agent_evolution_enabled"] is False
assert "cases" not in call_kwargs["allowed_memory_types"]
@@ -311,14 +316,14 @@ class TestCommit:
assert "experiences" not in call_kwargs["allowed_memory_types"]
async def test_commit_uses_account_setting_and_enables_agent_memory(
- self, session_with_messages: Session
+ self, wm_session_with_messages: Session
):
- session_with_messages._agent_evolution_enabled_provider = lambda: True
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._agent_evolution_enabled_provider = lambda: True
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value=[]
)
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
@@ -327,7 +332,7 @@ class TestCommit:
assert "trajectories" in task_result["result"]["effective_memory_types"]
assert "experiences" in task_result["result"]["effective_memory_types"]
call_kwargs = (
- session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
+ wm_session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
)
assert call_kwargs["agent_evolution_enabled"] is True
assert call_kwargs["allowed_memory_types"] is None
@@ -358,9 +363,9 @@ class TestCommit:
memory_policy_provider.assert_awaited_once_with()
async def test_disabled_agent_evolution_keeps_working_memory(
- self, session_with_messages: Session, monkeypatch
+ self, wm_session_with_messages: Session, monkeypatch
):
- session_with_messages._agent_evolution_enabled_provider = lambda: False
+ wm_session_with_messages._agent_evolution_enabled_provider = lambda: False
summary_called = False
async def fake_summary(_session, messages, latest_archive_overview=""):
@@ -370,11 +375,11 @@ class TestCommit:
return "# Working Memory\n\nAgent memory production is disabled."
monkeypatch.setattr(Session, "_generate_archive_summary_async", fake_summary)
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value=[]
)
- result = await session_with_messages.commit_async(
+ result = await wm_session_with_messages.commit_async(
memory_policy={
"memory_types": ["cases", "trajectories", "experiences"],
"working_memory": {"enabled": True},
@@ -385,11 +390,11 @@ class TestCommit:
assert task_result["status"] == "completed"
assert summary_called is True
archive_uri = task_result["result"]["archive_uri"]
- assert await _marker_exists(session_with_messages, archive_uri, ".overview.md")
- session_with_messages._session_compressor.extract_long_term_memories.assert_not_awaited()
+ assert await _marker_exists(wm_session_with_messages, archive_uri, ".overview.md")
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_not_awaited()
async def test_commit_reports_session_skills_separately(
- self, session_with_messages: Session, monkeypatch
+ self, wm_session_with_messages: Session, monkeypatch
):
config = MagicMock()
config.memory.extraction_enabled = True
@@ -397,15 +402,15 @@ class TestCommit:
config.vlm = SimpleNamespace(is_available=lambda: False)
monkeypatch.setattr("openviking.session.session.get_openviking_config", lambda: config)
- session_with_messages._agent_evolution_enabled_provider = lambda: True
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._agent_evolution_enabled_provider = lambda: True
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value={
"contexts": [],
"session_skills": [{"uri": "viking://user/test/skills/code-review"}],
}
)
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
@@ -415,58 +420,58 @@ class TestCommit:
"viking://user/test/skills/code-review"
]
assert "memory_diff_uri" not in task_result["result"]
- session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
call_kwargs = (
- session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
+ wm_session_with_messages._session_compressor.extract_long_term_memories.call_args.kwargs
)
assert call_kwargs["allowed_memory_types"] is None
async def test_commit_skips_session_skills_without_execution_memory_type(
- self, session_with_messages: Session, monkeypatch
+ self, wm_session_with_messages: Session, monkeypatch
):
config = MagicMock()
config.memory.extraction_enabled = True
config.memory.session_skill_extraction_enabled = True
monkeypatch.setattr("openviking.session.session.get_openviking_config", lambda: config)
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value=[]
)
- session_with_messages._meta.memory_policy = {"memory_types": ["profile"]}
+ wm_session_with_messages._meta.memory_policy = {"memory_types": ["profile"]}
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
assert task_result["result"]["memories_extracted"] == {}
assert task_result["result"]["session_skills_extracted"] == 0
assert "memory_diff_uri" not in task_result["result"]
- session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
async def test_commit_skips_session_skill_extraction_when_disabled(
- self, session_with_messages: Session, monkeypatch
+ self, wm_session_with_messages: Session, monkeypatch
):
config = MagicMock()
config.memory.extraction_enabled = True
config.memory.session_skill_extraction_enabled = False
monkeypatch.setattr("openviking.session.session.get_openviking_config", lambda: config)
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
return_value=[]
)
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
assert task_result["result"]["session_skills_extracted"] == 0
assert task_result["result"]["session_skill_uris"] == []
assert "memory_diff_uri" not in task_result["result"]
- session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
async def test_commit_can_skip_working_memory_summary(
- self, session_with_messages: Session, monkeypatch
+ self, wm_session_with_messages: Session, monkeypatch
):
config = MagicMock()
config.memory.extraction_enabled = True
@@ -486,12 +491,12 @@ class TestCommit:
assert kwargs.get("latest_archive_overview", "") == ""
return []
- session_with_messages._generate_archive_summary_async = fake_summary
- session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
+ wm_session_with_messages._generate_archive_summary_async = fake_summary
+ wm_session_with_messages._session_compressor.extract_long_term_memories = AsyncMock(
side_effect=fake_extract
)
- result = await session_with_messages.commit_async(
+ result = await wm_session_with_messages.commit_async(
memory_policy={"working_memory": {"enabled": False}}
)
task_result = await _wait_for_task(result["task_id"])
@@ -499,12 +504,12 @@ class TestCommit:
assert task_result["status"] == "completed"
assert summary_called is False
archive_uri = task_result["result"]["archive_uri"]
- assert not await _marker_exists(session_with_messages, archive_uri, ".overview.md")
- assert not await _marker_exists(session_with_messages, archive_uri, ".abstract.md")
- context = await session_with_messages.get_session_context()
+ assert not await _marker_exists(wm_session_with_messages, archive_uri, ".overview.md")
+ assert not await _marker_exists(wm_session_with_messages, archive_uri, ".abstract.md")
+ context = await wm_session_with_messages.get_session_context()
assert context["latest_archive_overview"] == ""
assert context["messages"] == []
- session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
+ wm_session_with_messages._session_compressor.extract_long_term_memories.assert_awaited_once()
async def test_commit_routes_peer_memory_with_single_full_context_pass(
self,
@@ -586,16 +591,16 @@ class TestCommit:
},
]
- async def test_commit_archives_messages(self, session_with_messages: Session):
+ async def test_commit_archives_messages(self, wm_session_with_messages: Session):
"""Test commit archives messages"""
- initial_message_count = len(session_with_messages.messages)
+ initial_message_count = len(wm_session_with_messages.messages)
assert initial_message_count > 0
- result = await session_with_messages.commit_async()
+ result = await wm_session_with_messages.commit_async()
assert result.get("archived") is True
# Current message list should be cleared after commit
- assert len(session_with_messages.messages) == 0
+ assert len(wm_session_with_messages.messages) == 0
async def test_commit_empty_session(self, session: Session):
"""Test committing empty session"""
@@ -642,6 +647,7 @@ class TestCommit:
session = client(session_id="commit_keep_recent_count_test")
await session.ensure_exists()
+ session._meta.memory_policy = {"working_memory": {"enabled": True}}
session._session_compressor.extract_long_term_memories = AsyncMock(return_value=[])
session.add_message("user", [TextPart("Round 1 user")])
@@ -649,7 +655,7 @@ class TestCommit:
session.add_message("user", [TextPart("Round 2 user")])
session.add_message("assistant", [TextPart("Round 2 assistant")])
- result = await session.commit_async(keep_recent_count=2)
+ result = await session.commit_async(keep_recent_count=2, enable_working_memory=True)
task_result = await _wait_for_task(result["task_id"])
assert task_result["status"] == "completed"
@@ -684,18 +690,16 @@ class TestCommit:
session._meta.memory_policy = {
"peer": {"enabled": False},
"memory_types": ["profile"],
+ "working_memory": {"enabled": True},
}
session._session_compressor.extract_long_term_memories = AsyncMock(return_value=[])
session.add_message("user", [TextPart("First round message")])
session.add_message("assistant", [TextPart("First round response")])
- result1 = await session.commit_async()
+ result1 = await session.commit_async(enable_working_memory=True)
await _wait_for_task(result1["task_id"])
- previous_overview = await session._viking_fs.read_file(
- f"{result1['archive_uri']}/.overview.md",
- ctx=session.ctx,
- )
+ previous_overview = await session._archives.read_overview(result1["archive_uri"])
seen: dict[str, str] = {}
session_type = type(session)
@@ -718,7 +722,7 @@ class TestCommit:
session.add_message("user", [TextPart("Second round message")])
session.add_message("assistant", [TextPart("Second round response")])
- result2 = await session.commit_async()
+ result2 = await session.commit_async(enable_working_memory=True)
task_result = await _wait_for_task(result2["task_id"])
assert task_result["status"] == "completed"
diff --git a/tests/session/test_session_context.py b/tests/session/test_session_context.py
index 626d4e04c..866c57bc7 100644
--- a/tests/session/test_session_context.py
+++ b/tests/session/test_session_context.py
@@ -38,7 +38,9 @@ async def client(
service: OpenVikingService,
request_context: RequestContext,
monkeypatch,
+ working_memory_policy,
):
+ service.sessions.set_default_user_memory_policy(working_memory_policy)
_install_fake_vlm(monkeypatch)
monkeypatch.setattr(get_openviking_config().memory, "extraction_enabled", False)
client = partial(service.sessions.session, request_context)
diff --git a/tests/session/test_session_retention_integration.py b/tests/session/test_session_retention_integration.py
index 98e06c139..cf8c0703c 100644
--- a/tests/session/test_session_retention_integration.py
+++ b/tests/session/test_session_retention_integration.py
@@ -4,6 +4,7 @@
import asyncio
import json
from types import SimpleNamespace
+from unittest.mock import AsyncMock
from uuid import uuid4
import pytest
@@ -162,7 +163,7 @@ async def test_done_with_missing_required_overview_reports_failed_without_raw(
done={
"starting_message_id": "u1",
"ending_message_id": "u1",
- "working_memory_enabled": True,
+ "enable_working_memory": True,
},
)
@@ -727,6 +728,7 @@ async def test_wm_creation_returns_two_products_in_one_model_call(
)
vlm = FakeVLM()
+ session._vlm_resolver = SimpleNamespace(get_vlm=AsyncMock(return_value=vlm))
monkeypatch.setattr(
"openviking.session.session.get_openviking_config",
lambda: SimpleNamespace(vlm=vlm),
@@ -764,11 +766,12 @@ async def test_wm_creation_passes_configured_output_language_to_prompt(client, m
def is_available() -> bool:
return True
- async def get_completion_async(self, **kwargs):
- prompts.append(kwargs)
+ async def get_completion_async(self, prompt, **kwargs):
+ prompts.append({"prompt": prompt, **kwargs})
return "# Working Memory"
vlm = FakeVLM()
+ session._vlm_resolver = SimpleNamespace(get_vlm=AsyncMock(return_value=vlm))
monkeypatch.setattr(
"openviking.session.session.get_openviking_config",
lambda: SimpleNamespace(vlm=vlm, output_language_override="zh-CN"),
@@ -792,11 +795,12 @@ async def test_wm_creation_detects_language_from_multiline_user_message(client,
def is_available() -> bool:
return True
- async def get_completion_async(self, **kwargs):
- prompts.append(kwargs)
+ async def get_completion_async(self, prompt, **kwargs):
+ prompts.append({"prompt": prompt, **kwargs})
return "# Working Memory"
vlm = FakeVLM()
+ session._vlm_resolver = SimpleNamespace(get_vlm=AsyncMock(return_value=vlm))
monkeypatch.setattr(
"openviking.session.session.get_openviking_config",
lambda: SimpleNamespace(vlm=vlm),
@@ -807,9 +811,7 @@ async def test_wm_creation_detects_language_from_multiline_user_message(client,
_text_message(
"multiline-user",
"user",
- "Task details:\n"
- "当前生产环境已经完成部署。\n"
- "请用中文总结当前状态和后续风险。",
+ "Task details:\n当前生产环境已经完成部署。\n请用中文总结当前状态和后续风险。",
)
]
)
@@ -861,6 +863,7 @@ async def test_wm_update_returns_two_products_in_one_model_call(
)
vlm = FakeVLM()
+ session._vlm_resolver = SimpleNamespace(get_vlm=AsyncMock(return_value=vlm))
monkeypatch.setattr(
"openviking.session.session.get_openviking_config",
lambda: SimpleNamespace(vlm=vlm),
diff --git a/tests/session/test_working_memory_default_off.py b/tests/session/test_working_memory_default_off.py
new file mode 100644
index 000000000..6fa633aad
--- /dev/null
+++ b/tests/session/test_working_memory_default_off.py
@@ -0,0 +1,106 @@
+# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.
+# SPDX-License-Identifier: AGPL-3.0
+
+"""WM is optional; durable archives and long-term extraction are not."""
+
+import json
+from unittest.mock import AsyncMock
+
+import pytest
+
+from openviking.message import TextPart
+from openviking.session import Session
+from openviking.session.checkpoints import CheckpointPlanner
+from tests.session.test_session_commit import _wait_for_task
+
+
[email protected]("keep_count", [0, 2])
+async def test_default_commit_keeps_raw_archive_and_ltm_without_summary(
+ session_with_messages, keep_count, monkeypatch
+):
+ session = session_with_messages
+ summary = AsyncMock(side_effect=AssertionError("WM must not run by default"))
+ checkpoint = AsyncMock(side_effect=AssertionError("checkpoint must not run by default"))
+ extract = AsyncMock(return_value=[])
+ monkeypatch.setattr(Session, "_generate_archive_summary_async", summary)
+ monkeypatch.setattr(CheckpointPlanner, "collect_requests_for_phase2", checkpoint)
+ monkeypatch.setattr(session._session_compressor, "extract_long_term_memories", extract)
+ original = list(session.messages)
+ result = await session.commit_async(keep_recent_count=keep_count)
+ assert result["effective_enable_working_memory"] is False
+ task = await _wait_for_task(result["task_id"])
+ assert task["status"] == "completed"
+ summary.assert_not_awaited()
+ checkpoint.assert_not_awaited()
+ extract.assert_awaited_once()
+ assert extract.call_args.kwargs["latest_archive_overview"] == ""
+ done = await session._archives.read_done(result["archive_uri"])
+ assert done["enable_working_memory"] is False
+ archive_id = result["archive_uri"].rsplit("/", 1)[-1]
+ archive = await session.get_session_archive(archive_id)
+ assert archive["overview"] == archive["abstract"] == ""
+ assert [message["id"] for message in archive["messages"]] == [
+ message.id for message in original[: len(original) - keep_count]
+ ]
+ context = await session.get_session_context()
+ assert context["latest_archive_overview"] == ""
+ assert context["stats"]["failedArchives"] == 0
+ assert len(context["messages"]) == keep_count
+
+
[email protected]("override", [True, False, None])
+async def test_commit_wm_override_only_changes_queued_wm_field(session, monkeypatch, override):
+ policy = {
+ "self": {"enabled": False},
+ "peer": {"enabled": True},
+ "memory_types": ["profile"],
+ "working_memory": {"enabled": False},
+ }
+ session._meta.memory_policy = policy
+ await session._save_meta()
+ session.add_message("user", [TextPart("remember this preference")])
+ queued = []
+
+ async def enqueue(_name, data):
+ queued.append(data)
+ return data["task_id"]
+
+ from openviking.storage.queuefs import get_queue_manager
+
+ monkeypatch.setattr(get_queue_manager(), "enqueue", enqueue)
+ result = await session.commit_async(enable_working_memory=override)
+ expected = {**policy, "working_memory": {"enabled": override is True}}
+ assert queued[0]["memory_policy"] == expected
+ assert result["effective_enable_working_memory"] is (override is True)
+ assert session._meta.memory_policy == policy
+ phase1 = await session._read_phase1_meta(result["archive_uri"])
+ assert phase1["queue_message"]["memory_policy"] == expected
+
+
[email protected]("wm_key", ["enable_working_memory", "working_memory_enabled"])
+async def test_latest_done_without_wm_does_not_resurrect_older_summary(session, wm_key):
+ for index, enabled in [(1, True), (2, False)]:
+ uri = f"{session.uri}/history/archive_{index:03d}"
+ await session._viking_fs.write_file(f"{uri}/messages.jsonl", "", ctx=session.ctx)
+ await session._viking_fs.write_file(
+ f"{uri}/.done", json.dumps({wm_key: enabled}), ctx=session.ctx
+ )
+ if enabled:
+ await session._viking_fs.write_file(f"{uri}/.overview.md", "Old WM", ctx=session.ctx)
+ session.add_message("user", [TextPart("current input")])
+ context = await session.get_session_context()
+ assert context["latest_archive_overview"] == ""
+ assert context["stats"]["failedArchives"] == 0
+ assert [message["parts"][0]["text"] for message in context["messages"]] == ["current input"]
+ archive = await session.get_session_archive("archive_002")
+ assert archive["overview"] == archive["abstract"] == ""
+ assert archive["messages"] == []
+ assert (await session._archives.scan_states())[-1].state == "completed"
+
+
[email protected]("wm_key", ["enable_working_memory", "working_memory_enabled"])
+async def test_missing_required_summary_is_failed_for_both_marker_names(session, wm_key):
+ uri = f"{session.uri}/history/archive_001"
+ await session._viking_fs.write_file(f"{uri}/.done", json.dumps({wm_key: True}), ctx=session.ctx)
+ assert (await session._archives.scan_states())[0].state == "failed"
+ assert (await session.get_session_context())["stats"]["failedArchives"] == 1
diff --git a/tests/unit/session/test_agent_evolution_policy.py b/tests/unit/session/test_agent_evolution_policy.py
index 8a9a2ba9b..78c9c3bb3 100644
--- a/tests/unit/session/test_agent_evolution_policy.py
+++ b/tests/unit/session/test_agent_evolution_policy.py
@@ -1,13 +1,21 @@
# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.
# SPDX-License-Identifier: AGPL-3.0
+import pytest
+
from openviking.session import session as session_module
from openviking.session.memory_policy import MemoryPolicy
-def test_global_enabled_agent_evolution_preserves_session_memory_types():
[email protected]("enable_working_memory", [None, False, True])
+def test_global_enabled_agent_evolution_preserves_session_memory_types(enable_working_memory):
policy = MemoryPolicy.from_dict(
- {"memory_types": ["profile", "events", "cases", "trajectories", "experiences"]}
+ {
+ "memory_types": ["profile", "events", "cases", "trajectories", "experiences"],
+ "working_memory": (
+ {"enabled": enable_working_memory} if enable_working_memory is not None else None
+ ),
+ }
)
effective = session_module._apply_agent_evolution_setting(
@@ -24,7 +32,7 @@ def test_global_enabled_agent_evolution_preserves_session_memory_types():
}
assert effective.self_enabled is True
assert effective.peer_enabled is True
- assert effective.working_memory_enabled is True
+ assert effective.enable_working_memory is (enable_working_memory is True)
def test_disabled_agent_evolution_cannot_be_bypassed_by_session_policy():
diff --git a/tests/unit/session/test_memory_policy.py b/tests/unit/session/test_memory_policy.py
index f2aaaabe9..6a18b7222 100644
--- a/tests/unit/session/test_memory_policy.py
+++ b/tests/unit/session/test_memory_policy.py
@@ -20,7 +20,7 @@ def test_memory_policy_defaults_to_self_and_peer():
assert policy.self_enabled is True
assert policy.peer_enabled is True
assert policy.memory_types is None
- assert policy.working_memory_enabled is True
+ assert policy.enable_working_memory is False
def test_memory_policy_can_disable_peer_memory():
@@ -46,6 +46,7 @@ def test_memory_policy_uses_top_level_memory_types():
"self": {"enabled": False},
"peer": {"enabled": True},
"memory_types": ["events", "profile"],
+ "working_memory": {"enabled": False},
}
@@ -54,7 +55,7 @@ def test_memory_policy_can_disable_working_memory():
assert policy.self_enabled is True
assert policy.peer_enabled is True
- assert policy.working_memory_enabled is False
+ assert policy.enable_working_memory is False
assert policy.to_dict() == {
"self": {"enabled": True},
"peer": {"enabled": True},
@@ -204,5 +205,26 @@ async def test_initialize_memory_files_renders_fields_without_init_value_as_empt
assert "{{ also_no_init }}" not in content
assert "filled" in content
# Fields without init_value render as empty, not as the literal placeholder.
- assert "- **NoInit:** \n" in content
- assert "- **AlsoNoInit:** \n" in content
+ lines = [line.rstrip() for line in content.splitlines()]
+ assert "- **NoInit:**" in lines
+ assert "- **AlsoNoInit:**" in lines
+
+
[email protected]("value", [None, {}, {"peer": {"enabled": True}}, {"working_memory": {}}])
+def test_missing_working_memory_is_disabled(value):
+ assert MemoryPolicy.from_dict(value).enable_working_memory is False
+
+
[email protected]("enabled", [True, False])
+def test_working_memory_round_trips_in_task_and_user_snapshots(enabled):
+ policy = MemoryPolicy.from_dict(
+ {
+ "self": {"enabled": False},
+ "peer": {"enabled": True},
+ "memory_types": ["profile"],
+ "working_memory": {"enabled": enabled},
+ }
+ )
+ snapshot = json.loads(json.dumps(policy.to_dict()))
+ assert snapshot["working_memory"]["enabled"] is enabled
+ assert MemoryPolicy.from_dict(snapshot) == policy
diff --git a/tests/unit/session/test_session_commit_resume.py b/tests/unit/session/test_session_commit_resume.py
index dbf2b5439..90adac7c7 100644
--- a/tests/unit/session/test_session_commit_resume.py
+++ b/tests/unit/session/test_session_commit_resume.py
@@ -12,10 +12,43 @@ import pytest
from openviking.message import Message, TextPart, ToolPart
from openviking.service.task_tracker import TaskStatus, TaskTracker, set_task_tracker
+from openviking.session.memory_policy import MemoryPolicy
from openviking.session.session import Session
from openviking.storage.queuefs.session_commit_msg import SessionCommitMsg
[email protected]("enabled", [False, True])
+def test_new_queue_snapshot_preserves_wm_across_worker_reload(enabled):
+ message = SessionCommitMsg(
+ task_id="t",
+ session_id="s",
+ session_uri="viking://user/default/sessions/s",
+ archive_uri="viking://user/default/sessions/s/history/archive_001",
+ user={},
+ memory_policy=MemoryPolicy(enable_working_memory=enabled).to_dict(),
+ )
+ restored = SessionCommitMsg.from_dict(message.to_dict())
+ assert MemoryPolicy.from_dict(restored.memory_policy).enable_working_memory is enabled
+
+
+def test_legacy_queued_work_keeps_old_default_without_migrating_user_policy():
+ policy = {"self": {"enabled": False}, "memory_types": ["profile"]}
+ message = SessionCommitMsg.from_dict(
+ {
+ "task_id": "t",
+ "session_id": "s",
+ "session_uri": "viking://user/default/sessions/s",
+ "archive_uri": "viking://user/default/sessions/s/history/archive_001",
+ "user": {},
+ "memory_policy": policy,
+ }
+ )
+ assert MemoryPolicy.from_dict(message.memory_policy).enable_working_memory is True
+ assert MemoryPolicy.from_dict(policy).enable_working_memory is False
+ assert message.memory_policy["self"] == policy["self"]
+ assert message.memory_policy["memory_types"] == policy["memory_types"]
+
+
class _TaskStore:
def __init__(self):
self.tasks = {}
@@ -135,7 +168,9 @@ def test_phase2_auto_commit_policy_parameters_are_appended():
signature = inspect.signature(Session._run_memory_extraction)
assert list(signature.parameters)[-1] == "auto_commit_policy"
- assert fields(SessionCommitMsg)[-1].name == "auto_commit_policy"
+ # New snapshot metadata is appended after the existing positional fields.
+ assert fields(SessionCommitMsg)[-2].name == "auto_commit_policy"
+ assert fields(SessionCommitMsg)[-1].name == "memory_policy_version"
@pytest.mark.asyncio
diff --git a/tests/utils/mock_agfs.py b/tests/utils/mock_agfs.py
index ee061d89d..c259a4c61 100644
--- a/tests/utils/mock_agfs.py
+++ b/tests/utils/mock_agfs.py
@@ -4,6 +4,8 @@ import uuid
from pathlib import Path
from unittest.mock import MagicMock
+from openviking.pyagfs import AGFSNotFoundError
+
class MockLocalAGFS:
"""
@@ -126,7 +128,7 @@ class MockLocalAGFS:
def read_file(self, path, ctx=None, **kwargs):
p = self._resolve(path)
if not p.exists():
- raise FileNotFoundError(path)
+ raise AGFSNotFoundError(path)
return p.read_bytes()
def read(self, path, ctx=None, **kwargs):
@@ -158,7 +160,7 @@ class MockLocalAGFS:
def stat(self, path, ctx=None):
p = self._resolve(path)
if not p.exists():
- raise FileNotFoundError(path)
+ raise AGFSNotFoundError(path)
s = p.stat()
return {
"size": s.st_size,
diff --git a/web-studio/src/gen/ov-client/types.gen.ts b/web-studio/src/gen/ov-client/types.gen.ts
index 22f271ba0..919e12798 100644
--- a/web-studio/src/gen/ov-client/types.gen.ts
+++ b/web-studio/src/gen/ov-client/types.gen.ts
@@ -263,6 +263,10 @@ export type BodyTempUploadApiV1ResourcesTempUploadPost = {
* behavior.
*/
export type CommitRequest = {
+ /**
+ * Override only Working Memory generation for this commit; null inherits policy.
+ */
+ enable_working_memory?: boolean | null;
/**
* Keep Recent Count
*
diff --git a/web-studio/src/lib/user-memory-policy.test.ts b/web-studio/src/lib/user-memory-policy.test.ts
new file mode 100644
index 000000000..aab735a61
--- /dev/null
+++ b/web-studio/src/lib/user-memory-policy.test.ts
@@ -0,0 +1,25 @@
+import { describe, expect, it } from 'vitest'
+
+import {
+ buildMemoryPolicy,
+ identifyMemoryPreset,
+ memoryPresets,
+} from './user-memory-policy'
+
+describe('working memory opt-in', () => {
+ it.each(memoryPresets)(
+ '%s defaults off and survives preset identification',
+ (preset) => {
+ const policy = buildMemoryPolicy(preset)
+ expect(policy.working_memory?.enabled).toBe(false)
+ expect(identifyMemoryPreset(policy)).toBe(preset)
+ expect(
+ identifyMemoryPreset({ ...policy, working_memory: { enabled: true } }),
+ ).toBe('custom')
+ },
+ )
+
+ it('treats a legacy missing WM field as disabled', () => {
+ expect(identifyMemoryPreset({})).toBe('general')
+ })
+})
diff --git a/web-studio/src/lib/user-memory-policy.ts b/web-studio/src/lib/user-memory-policy.ts
index f7dd68e0c..0bf458790 100644
--- a/web-studio/src/lib/user-memory-policy.ts
+++ b/web-studio/src/lib/user-memory-policy.ts
@@ -19,7 +19,7 @@ export function buildMemoryPolicy(preset: MemoryPreset): UserMemoryPolicy {
return {
self: { enabled: true },
peer: { enabled: preset === 'general' },
- working_memory: { enabled: true },
+ working_memory: { enabled: false },
...(preset === 'general'
? {}
: {
@@ -41,7 +41,8 @@ export function identifyMemoryPreset(
return (
policy.self?.enabled !== false &&
(policy.peer?.enabled !== false) === expected.peer?.enabled &&
- policy.working_memory?.enabled !== false &&
+ (policy.working_memory?.enabled ?? false) ===
+ expected.working_memory?.enabled &&
(types
? types.length === expectedTypes.length &&
expectedTypes.every((type) => types.includes(type))
diff --git a/web-studio/src/routes/users/-components/custom-memory-policy.tsx b/web-studio/src/routes/users/-components/custom-memory-policy.tsx
index 85576ad48..195a859ea 100644
--- a/web-studio/src/routes/users/-components/custom-memory-policy.tsx
+++ b/web-studio/src/routes/users/-components/custom-memory-policy.tsx
@@ -68,7 +68,7 @@ export function CustomMemoryPolicy({
<input
className="mt-1"
type="checkbox"
- checked={draft[key]?.enabled !== false}
+ checked={draft[key]?.enabled ?? key !== 'working_memory'}
onChange={(event) =>
setDraft({
...draft,