Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix (#2696)

Qin Haojie88e5db2b39b2
diff --git a/openviking/service/task_tracker.py b/openviking/service/task_tracker.py
index 6f5b8bb26..cc3c53f48 100644
--- a/openviking/service/task_tracker.py
+++ b/openviking/service/task_tracker.py
@@ -74,13 +74,20 @@ _init_lock = threading.Lock()
def get_task_tracker() -> "TaskTracker":
- """Get or create the global persistent TaskTracker singleton."""
- global _instance
- if _instance is None:
- with _init_lock:
- if _instance is None:
- _instance = _build_default_task_tracker()
- return _instance
+ """Get the global TaskTracker singleton installed by service storage initialization."""
+ with _init_lock:
+ if _instance is None:
+ logger.error(
+ "TaskTracker accessed before service storage initialization; refusing to create "
+ "a separate AGFS client. Ensure OpenVikingService installs the shared tracker "
+ "with set_task_tracker() before task APIs are used.",
+ stack_info=True,
+ )
+ raise RuntimeError(
+ "TaskTracker not initialized. OpenVikingService must install the shared "
+ "tracker with set_task_tracker() during storage initialization."
+ )
+ return _instance
def set_task_tracker(tracker: "TaskTracker") -> None:
@@ -519,14 +526,3 @@ class TaskTracker:
for t in tasks:
grouped[t.task_type][t.status.value] += 1
return {k: dict(v) for k, v in grouped.items()}
-
-
-def _build_default_task_tracker() -> TaskTracker:
- """Build the default persistent tracker from the active storage config."""
- from openviking.utils.agfs_utils import build_runtime_ragfs_binding_config, create_agfs_client
- from openviking_cli.utils.config import get_openviking_config
-
- config = get_openviking_config()
- binding_config, _ = build_runtime_ragfs_binding_config(config)
- agfs = create_agfs_client(binding_config)
- return config.storage.build_task_tracker(agfs)
diff --git a/tests/session/conftest.py b/tests/session/conftest.py
index 85cd77e43..30dc37b58 100644
--- a/tests/session/conftest.py
+++ b/tests/session/conftest.py
@@ -17,7 +17,6 @@ from openviking.session import Session
@pytest_asyncio.fixture(autouse=True)
async def _drain_background_tasks(client: AsyncOpenViking):
"""Wait for background commit tasks to finish before client teardown."""
- reset_task_tracker()
yield
# Drain asyncio.create_task() background tasks BEFORE client.close()
tracker = get_task_tracker()
diff --git a/tests/test_task_tracker.py b/tests/test_task_tracker.py
index 328411997..340a7eb63 100644
--- a/tests/test_task_tracker.py
+++ b/tests/test_task_tracker.py
@@ -15,15 +15,12 @@ from openviking.service.task_store import PersistentTaskStore
from openviking.service.task_tracker import (
TaskStatus,
TaskTracker,
- _build_default_task_tracker,
_sanitize_error,
get_task_tracker,
reset_task_tracker,
set_task_tracker,
)
-from openviking.utils.agfs_utils import RagfsBindingConfig
from openviking_cli.session.user_id import UserIdentifier
-from openviking_cli.utils.config import AGFSConfig
pytestmark = pytest.mark.asyncio
@@ -430,60 +427,11 @@ async def test_singleton_reset():
assert t1 is not t2
-async def test_build_default_task_tracker_uses_runtime_encryption_binding(monkeypatch):
- captured = {}
- fake_agfs = object()
-
- class _FakeStorage:
- def __init__(self):
- self.agfs = AGFSConfig(backend="memory")
-
- def build_task_tracker(self, agfs):
- captured["build_arg"] = agfs
- return "fake-tracker"
-
- class _FakeConfig:
- def __init__(self):
- self.storage = _FakeStorage()
-
- def to_dict(self):
- return {"encryption": {"enabled": True, "provider": "local"}}
-
- class _FakeProvider:
- async def get_root_key(self):
- return b"t" * 32
-
- class _FakeEncryptor:
- provider_type = 9
-
- def __init__(self):
- self.provider = _FakeProvider()
-
- async def _bootstrap(config):
- assert config["encryption"]["enabled"] is True
- return _FakeEncryptor()
-
- def _fake_create_agfs_client(config):
- captured["binding_config"] = config
- return fake_agfs
-
- monkeypatch.setattr("openviking.crypto.config.bootstrap_encryption", _bootstrap)
- monkeypatch.setattr("openviking.utils.agfs_utils.create_agfs_client", _fake_create_agfs_client)
- monkeypatch.setattr(
- "openviking_cli.utils.config.get_openviking_config",
- lambda: _FakeConfig(),
- )
-
- tracker = _build_default_task_tracker()
-
- assert tracker == "fake-tracker"
- assert captured["build_arg"] is fake_agfs
- assert isinstance(captured["binding_config"], RagfsBindingConfig)
- assert isinstance(captured["binding_config"].agfs, AGFSConfig)
- assert captured["binding_config"].to_binding_dict()["encryption"] == {
- "root_key": b"t" * 32,
- "provider_type": 9,
- }
+async def test_get_task_tracker_requires_service_initialization(caplog):
+ caplog.set_level("ERROR")
+ with pytest.raises(RuntimeError, match="TaskTracker not initialized"):
+ get_task_tracker()
+ assert "refusing to create a separate AGFS client" in caplog.text
async def test_persistent_store_cross_tracker_visibility():