Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(rerank): align VikingDB scores by document ID (#5833)

agent8d52018cfb44
diff --git a/openviking/models/rerank/volcengine_rerank.py b/openviking/models/rerank/volcengine_rerank.py
index 5fec1679d..c373a88eb 100644
--- a/openviking/models/rerank/volcengine_rerank.py
+++ b/openviking/models/rerank/volcengine_rerank.py
@@ -7,6 +7,7 @@ Provides rerank functionality for hierarchical retrieval.
"""
import json
+import math
# For logging, use Python's built-in logging
import time
@@ -170,8 +171,10 @@ class RerankClient(RerankBase):
duration_seconds=time.monotonic() - started,
)
- # Each document is a separate group, data array returns scores for each group sequentially
+ # The response is ranked by relevance; ids refer to input document groups.
data = result_payload["data"]
+ if not isinstance(data, list):
+ raise ValueError("Rerank data must be a list")
if len(data) != len(documents):
logger.warning(
"[RerankClient] Unexpected rerank result length: expected=%s actual=%s",
@@ -179,7 +182,23 @@ class RerankClient(RerankBase):
len(data),
)
return None
- scores = [item.get("score", 0.0) for item in data]
+ scores = [0.0] * len(documents)
+ seen = set()
+ for item in data:
+ if not isinstance(item, dict):
+ raise ValueError("Invalid rerank result item")
+ index = item.get("id")
+ if isinstance(index, str) and index.isdecimal():
+ index = int(index)
+ if type(index) is not int or not 0 <= index < len(documents):
+ raise ValueError("Invalid rerank document id")
+ if index in seen:
+ raise ValueError("Duplicate rerank document id")
+ score = float(item["score"])
+ if not math.isfinite(score):
+ raise ValueError("Non-finite rerank score")
+ seen.add(index)
+ scores[index] = score
logger.debug(f"[RerankClient] Reranked {len(documents)} documents")
return scores
diff --git a/tests/unit/models/rerank/test_vikingdb_rerank_alignment.py b/tests/unit/models/rerank/test_vikingdb_rerank_alignment.py
new file mode 100644
index 000000000..230b5b27b
--- /dev/null
+++ b/tests/unit/models/rerank/test_vikingdb_rerank_alignment.py
@@ -0,0 +1,84 @@
+# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.
+# SPDX-License-Identifier: AGPL-3.0
+"""VikingDB scores must remain attached to their input documents."""
+
+from unittest.mock import Mock, patch
+
+import pytest
+
+from openviking.models.rerank.volcengine_rerank import RerankClient
+
+
+def client():
+ return RerankClient(ak="test-ak", sk="test-sk")
+
+
+def rerank(client, data, documents=None):
+ response = Mock(status_code=200)
+ response.json.return_value = {"result": {"data": data}}
+ with patch(
+ "openviking.models.rerank.volcengine_rerank.requests.request", return_value=response
+ ):
+ return client.rerank_batch("query", documents or ["doc A", "doc B", "doc C"])
+
+
[email protected]("order", [(0, 1, 2), (1, 0, 2), (2, 1, 0)])
+def test_response_order_does_not_change_document_scores(client, order):
+ expected = [0.2, 0.9, 0.6]
+ data = [{"id": index, "score": expected[index]} for index in order]
+ assert rerank(client, data) == expected
+
+
+def test_numeric_string_ids_preserve_document_scores(client):
+ assert rerank(
+ client, [{"id": "2", "score": 0.6}, {"id": "0", "score": 0.2}, {"id": "1", "score": 0.9}]
+ ) == [0.2, 0.9, 0.6]
+
+
[email protected]("bad_id", [None, -1, 3, 0.5, True, "not-an-id"])
+def test_invalid_document_id_fails_batch(client, bad_id):
+ assert (
+ rerank(
+ client, [{"id": bad_id, "score": 0.2}, {"id": 1, "score": 0.9}, {"id": 2, "score": 0.6}]
+ )
+ is None
+ )
+
+
+def test_missing_document_id_fails_batch(client):
+ assert (
+ rerank(client, [{"score": 0.2}, {"id": 1, "score": 0.9}, {"id": 2, "score": 0.6}]) is None
+ )
+
+
+def test_duplicate_id_cannot_hide_a_missing_document(client):
+ assert (
+ rerank(client, [{"id": 0, "score": 0.2}, {"id": 0, "score": 0.9}, {"id": 2, "score": 0.6}])
+ is None
+ )
+
+
+def test_incomplete_response_fails_batch(client):
+ assert rerank(client, [{"id": 0, "score": 0.2}, {"id": 2, "score": 0.6}]) is None
+
+
[email protected]("score", [float("nan"), float("inf"), -float("inf"), None])
+def test_invalid_score_fails_batch(client, score):
+ assert (
+ rerank(
+ client, [{"id": 0, "score": score}, {"id": 1, "score": 0.9}, {"id": 2, "score": 0.6}]
+ )
+ is None
+ )
+
+
[email protected]("data", [None, {}, ["bad-item", {}, {}]])
+def test_malformed_results_fail_batch(client, data):
+ assert rerank(client, data) is None
+
+
+def test_empty_input_does_not_call_provider(client):
+ with patch("openviking.models.rerank.volcengine_rerank.requests.request") as request:
+ assert client.rerank_batch("query", []) == []
+ request.assert_not_called()