Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(plugins): treat camelCase isError as an error tool result (#4724)
Nick James98f24e1690b8
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.ymlindex 3462f58c6..c060246c1 100644--- a/.github/workflows/pr.yml+++ b/.github/workflows/pr.yml@@ -82,6 +82,7 @@ jobs:examples/memory-plugin-shared/workspace-registry.test.mjs \examples/memory-plugin-shared/plugin-known-keys.test.mjs \examples/memory-plugin-shared/uri-guard.test.mjs \+ examples/memory-plugin-shared/capture-utils.test.mjs \examples/dsh-memory-plugin/*.test.mjs \examples/opencode-plugin/tests/*.test.mjs \examples/opencode-plugin/servers/mcp-proxy.test.mjs \diff --git a/examples/claude-code-memory-plugin/scripts/shared/capture-utils.mjs b/examples/claude-code-memory-plugin/scripts/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/claude-code-memory-plugin/scripts/shared/capture-utils.mjs+++ b/examples/claude-code-memory-plugin/scripts/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/codex-memory-plugin/scripts/shared/capture-utils.mjs b/examples/codex-memory-plugin/scripts/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/codex-memory-plugin/scripts/shared/capture-utils.mjs+++ b/examples/codex-memory-plugin/scripts/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/dsh-memory-plugin/capture.test.mjs b/examples/dsh-memory-plugin/capture.test.mjsindex 44d43579e..7a72c76e8 100644--- a/examples/dsh-memory-plugin/capture.test.mjs+++ b/examples/dsh-memory-plugin/capture.test.mjs@@ -79,6 +79,34 @@ test("preserves DSH tool call identity in captured tool results", () => {assert.equal(names.size, 0);});+test("marks DSH tool-result errors with the error status", () => {+ const names = new Map();+ captureEvent({+ type: "tool/call",+ data: { callId: "call-err", name: "bash", arguments: "{\"command\":\"df\"}" },+ }, CONFIG, names);++ const captured = captureEvent({+ type: "tool/result",+ data: {+ message: {+ role: "user",+ content: [{+ type: "tool-result",+ toolCallId: "call-err",+ content: [{ type: "text", text: "bash: df: command not found" }],+ isError: true,+ }],+ source: { kind: "tool", callId: "call-err" },+ },+ },+ }, CONFIG, names);++ assert.equal(captured.role, "user");+ assert.equal(captured.parts[0].type, "tool");+ assert.equal(captured.parts[0].tool_status, "error");+});+test("does not retain tool call names when tool-result capture is disabled", () => {const names = new Map();const config = { ...CONFIG, captureToolResults: false };diff --git a/examples/dsh-memory-plugin/shared/capture-utils.mjs b/examples/dsh-memory-plugin/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/dsh-memory-plugin/shared/capture-utils.mjs+++ b/examples/dsh-memory-plugin/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/memory-plugin-shared/capture-utils.test.mjs b/examples/memory-plugin-shared/capture-utils.test.mjsnew file mode 100644index 000000000..3086abc63--- /dev/null+++ b/examples/memory-plugin-shared/capture-utils.test.mjs@@ -0,0 +1,59 @@+import test from "node:test"+import assert from "node:assert/strict"+import { extractPartsFromPayload } from "./lib/capture-utils.mjs"++function toolPart(parts) {+ return parts.find((part) => part?.type === "tool")+}++test("toolStatus marks a camelCase isError result as error", () => {+ const parts = extractPartsFromPayload({+ role: "user",+ content: [{+ type: "tool-result",+ toolCallId: "call-1",+ content: [{ type: "text", text: "bash: df: command not found" }],+ isError: true,+ }],+ }, { toolNameById: { "call-1": "bash" } })+ assert.equal(toolPart(parts).tool_status, "error")+})++test("toolStatus keeps snake_case is_error support", () => {+ const parts = extractPartsFromPayload({+ role: "user",+ content: [{+ type: "tool_result",+ tool_use_id: "call-2",+ is_error: true,+ output: "connection refused",+ }],+ }, { toolNameById: { "call-2": "mysqladmin" } })+ assert.equal(toolPart(parts).tool_status, "error")+})++test("toolStatus recognizes a camelCase isError nested under state", () => {+ const parts = extractPartsFromPayload({+ role: "user",+ content: [{+ type: "tool-result",+ toolCallId: "call-2b",+ state: { isError: true },+ output: "connection refused",+ }],+ }, { toolNameById: { "call-2b": "mysqladmin" } })+ assert.equal(toolPart(parts).tool_status, "error")+})++test("toolStatus stays completed for a successful camelCase result", () => {+ const parts = extractPartsFromPayload({+ role: "user",+ content: [{+ type: "tool-result",+ toolCallId: "call-3",+ content: [{ type: "text", text: "ok" }],+ isError: false,+ }],+ }, { toolNameById: { "call-3": "bash" } })+ assert.equal(toolPart(parts).tool_status, "completed")+})diff --git a/examples/memory-plugin-shared/lib/capture-utils.mjs b/examples/memory-plugin-shared/lib/capture-utils.mjsindex 796e19d56..75e76bbad 100644--- a/examples/memory-plugin-shared/lib/capture-utils.mjs+++ b/examples/memory-plugin-shared/lib/capture-utils.mjs@@ -151,7 +151,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/opencode-plugin/lib/shared/capture-utils.mjs b/examples/opencode-plugin/lib/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/opencode-plugin/lib/shared/capture-utils.mjs+++ b/examples/opencode-plugin/lib/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/pi-coding-agent-extension/shared/capture-utils.mjs b/examples/pi-coding-agent-extension/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/pi-coding-agent-extension/shared/capture-utils.mjs+++ b/examples/pi-coding-agent-extension/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}diff --git a/examples/zcode-memory-plugin/scripts/shared/capture-utils.mjs b/examples/zcode-memory-plugin/scripts/shared/capture-utils.mjsindex 3e078db47..38e0baecc 100644--- a/examples/zcode-memory-plugin/scripts/shared/capture-utils.mjs+++ b/examples/zcode-memory-plugin/scripts/shared/capture-utils.mjs@@ -152,7 +152,7 @@ function toolId(block) {function toolStatus(block, kind) {if (kind === "call") return "running";- if (block?.is_error || block?.error || block?.state?.error) return "error";+ if (block?.is_error || block?.isError || block?.state?.isError || block?.error || block?.state?.error) return "error";const status = oneLine(block?.status || block?.state?.status || "");return status || "completed";}