Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(sdk): expose tree level limit (#4110)

Zhenghan Song9a5b47a2ce21
diff --git a/sdk/go/client_test.go b/sdk/go/client_test.go
index 9ba69c8ce..ff981c192 100644
--- a/sdk/go/client_test.go
+++ b/sdk/go/client_test.go
@@ -177,30 +177,43 @@ func TestFindOmitsSearchFiltersWhenUnset(t *testing.T) {
}
}
-func TestListSendsOrderingOptions(t *testing.T) {
+func TestListAndTreeSendQueryOptions(t *testing.T) {
+ wantTreeLimits := []string{"0", "3"}
client, closeServer := testClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
- if r.URL.Path != "/api/v1/fs/ls" {
- t.Fatalf("path = %s", r.URL.Path)
- }
- if got := r.URL.Query().Get("node_limit"); got != "200" {
- t.Fatalf("node_limit = %q", got)
- }
- if got := r.URL.Query().Get("sort_by"); got != "mtime" {
- t.Fatalf("sort_by = %q", got)
- }
- if got := r.URL.Query().Get("sort_order"); got != "desc" {
- t.Fatalf("sort_order = %q", got)
+ switch r.URL.Path {
+ case "/api/v1/fs/ls":
+ if got := r.URL.Query().Get("node_limit"); got != "200" {
+ t.Fatalf("node_limit = %q", got)
+ }
+ if got := r.URL.Query().Get("sort_by"); got != "mtime" {
+ t.Fatalf("sort_by = %q", got)
+ }
+ if got := r.URL.Query().Get("sort_order"); got != "desc" {
+ t.Fatalf("sort_order = %q", got)
+ }
+ case "/api/v1/fs/tree":
+ if got := r.URL.Query().Get("level_limit"); got != wantTreeLimits[0] {
+ t.Fatalf("level_limit = %q, want %q", got, wantTreeLimits[0])
+ }
+ wantTreeLimits = wantTreeLimits[1:]
+ default:
+ t.Fatalf("unexpected request %s %s", r.Method, r.URL.Path)
}
writeOK(t, w, []any{})
}))
defer closeServer()
- _, err := client.List(context.Background(), "viking://session", &ListOptions{
+ if _, err := client.List(context.Background(), "viking://session", &ListOptions{
NodeLimit: 200,
SortBy: "mtime",
SortOrder: "desc",
- })
- if err != nil {
+ }); err != nil {
+ t.Fatal(err)
+ }
+ if _, err := client.Tree(context.Background(), "viking://resources/docs", &TreeOptions{LevelLimit: Int(0)}); err != nil {
+ t.Fatal(err)
+ }
+ if _, err := client.Tree(context.Background(), "viking://resources/docs", nil); err != nil {
t.Fatal(err)
}
}
diff --git a/sdk/go/filesystem.go b/sdk/go/filesystem.go
index bbc546d13..d9db25fc2 100644
--- a/sdk/go/filesystem.go
+++ b/sdk/go/filesystem.go
@@ -59,12 +59,17 @@ func (c *Client) Tree(ctx context.Context, uri string, opts *TreeOptions) ([]map
if nodeLimit == 0 {
nodeLimit = 1000
}
+ levelLimit := 3
+ if opts.LevelLimit != nil {
+ levelLimit = *opts.LevelLimit
+ }
query := url.Values{}
query.Set("uri", NormalizeURI(uri))
query.Set("output", output)
queryInt(query, "abs_limit", absLimit)
queryBool(query, "show_all_hidden", opts.ShowAllHidden)
queryInt(query, "node_limit", nodeLimit)
+ queryInt(query, "level_limit", levelLimit)
var result []map[string]any
err := c.doJSON(ctx, http.MethodGet, "/api/v1/fs/tree", query, nil, &result)
return result, err
diff --git a/sdk/go/types.go b/sdk/go/types.go
index bb88e1108..f7581c846 100644
--- a/sdk/go/types.go
+++ b/sdk/go/types.go
@@ -160,6 +160,7 @@ type TreeOptions struct {
AbsLimit int
ShowAllHidden bool
NodeLimit int
+ LevelLimit *int
}
// RemoveOptions controls Remove.
diff --git a/sdk/python/openviking_sdk/client.py b/sdk/python/openviking_sdk/client.py
index 5efc30c29..f045bd68e 100644
--- a/sdk/python/openviking_sdk/client.py
+++ b/sdk/python/openviking_sdk/client.py
@@ -1063,6 +1063,7 @@ class AsyncHTTPClient:
abs_limit: int = 128,
show_all_hidden: bool = False,
node_limit: int = 1000,
+ level_limit: int = 3,
) -> List[Dict[str, Any]]:
response = await self._request(
"GET",
@@ -1073,6 +1074,7 @@ class AsyncHTTPClient:
"abs_limit": abs_limit,
"show_all_hidden": show_all_hidden,
"node_limit": node_limit,
+ "level_limit": level_limit,
},
)
return self._handle_response(response)
@@ -2198,6 +2200,7 @@ class SyncHTTPClient:
abs_limit: int = 128,
show_all_hidden: bool = False,
node_limit: int = 1000,
+ level_limit: int = 3,
) -> List[Dict[str, Any]]:
return run_async(
self._async_client.tree(
@@ -2206,6 +2209,7 @@ class SyncHTTPClient:
abs_limit=abs_limit,
show_all_hidden=show_all_hidden,
node_limit=node_limit,
+ level_limit=level_limit,
)
)
diff --git a/sdk/python/tests/test_async_client_behaviors.py b/sdk/python/tests/test_async_client_behaviors.py
index 7cc4cd609..bd34b1553 100644
--- a/sdk/python/tests/test_async_client_behaviors.py
+++ b/sdk/python/tests/test_async_client_behaviors.py
@@ -923,7 +923,7 @@ async def test_glob_normalizes_scope_uri():
@pytest.mark.asyncio
-async def test_ls_passes_full_query_params():
+async def test_ls_and_tree_pass_query_params():
client = AsyncHTTPClient(url="http://localhost:1933")
fake_http = SimpleNamespace(get=AsyncMock(return_value=object()))
client._http = fake_http
@@ -940,10 +940,14 @@ async def test_ls_passes_full_query_params():
sort_by="mtime",
sort_order="desc",
)
-
- fake_http.get.assert_awaited_once_with(
- "/api/v1/fs/ls",
- params={
+ await client.tree("viking://resources/", level_limit=2)
+ await client.tree("viking://resources/", level_limit=0)
+ await client.tree("viking://resources/")
+
+ ls_call = fake_http.get.await_args_list[0]
+ assert ls_call.args == ("/api/v1/fs/ls",)
+ assert ls_call.kwargs == {
+ "params": {
"uri": "viking://resources/",
"simple": True,
"recursive": True,
@@ -954,7 +958,11 @@ async def test_ls_passes_full_query_params():
"sort_by": "mtime",
"sort_order": "desc",
},
- )
+ }
+ assert [
+ tree_call.kwargs["params"]["level_limit"]
+ for tree_call in fake_http.get.await_args_list[1:]
+ ] == [2, 0, 3]
@pytest.mark.asyncio
diff --git a/sdk/typescript/src/client.ts b/sdk/typescript/src/client.ts
index 0a6c481f4..35e48c5c3 100644
--- a/sdk/typescript/src/client.ts
+++ b/sdk/typescript/src/client.ts
@@ -441,6 +441,7 @@ export class OpenVikingClient {
abs_limit: options.absLimit ?? 128,
show_all_hidden: options.showAllHidden ?? false,
node_limit: options.nodeLimit ?? 1000,
+ level_limit: options.levelLimit ?? 3,
},
});
}
diff --git a/sdk/typescript/src/types.ts b/sdk/typescript/src/types.ts
index 3d01d7414..fcd70cc3f 100644
--- a/sdk/typescript/src/types.ts
+++ b/sdk/typescript/src/types.ts
@@ -136,6 +136,7 @@ export interface TreeOptions {
absLimit?: number;
showAllHidden?: boolean;
nodeLimit?: number;
+ levelLimit?: number;
}
/** Session message payload. */
export interface Message {
diff --git a/sdk/typescript/tests/client.test.ts b/sdk/typescript/tests/client.test.ts
index e22f449d7..af38042e8 100644
--- a/sdk/typescript/tests/client.test.ts
+++ b/sdk/typescript/tests/client.test.ts
@@ -201,8 +201,10 @@ describe("OpenVikingClient", () => {
);
});
- it("passes directory list ordering to the server", async () => {
- const fetcher = vi.fn<typeof fetch>().mockResolvedValue(ok([]));
+ it("passes directory list ordering and tree depth to the server", async () => {
+ const fetcher = vi
+ .fn<typeof fetch>()
+ .mockImplementation(async () => ok([]));
const client = new OpenVikingClient({
baseUrl: "https://example.com",
fetch: fetcher,
@@ -213,11 +215,18 @@ describe("OpenVikingClient", () => {
sortBy: "mtime",
sortOrder: "desc",
});
-
- const url = new URL(String(fetcher.mock.calls[0]![0]));
- expect(url.searchParams.get("node_limit")).toBe("200");
- expect(url.searchParams.get("sort_by")).toBe("mtime");
- expect(url.searchParams.get("sort_order")).toBe("desc");
+ await client.tree("viking://resources/docs", { levelLimit: 2 });
+ await client.tree("viking://resources/docs", { levelLimit: 0 });
+ await client.tree("viking://resources/docs");
+
+ const listUrl = new URL(String(fetcher.mock.calls[0]![0]));
+ expect(listUrl.searchParams.get("node_limit")).toBe("200");
+ expect(listUrl.searchParams.get("sort_by")).toBe("mtime");
+ expect(listUrl.searchParams.get("sort_order")).toBe("desc");
+ const treeLimits = fetcher.mock.calls
+ .slice(1)
+ .map((call) => new URL(String(call[0])).searchParams.get("level_limit"));
+ expect(treeLimits).toEqual(["2", "0", "3"]);
});
it("sends addResource tags and tagMode to the server", async () => {