Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(vectordb): bound ordered delta replay batches (#6259)
Evoaa49650a2d1f
diff --git a/openviking/storage/vectordb/collection/local_collection.py b/openviking/storage/vectordb/collection/local_collection.pyindex 7e95afc61..9ddb8467d 100644--- a/openviking/storage/vectordb/collection/local_collection.py+++ b/openviking/storage/vectordb/collection/local_collection.py@@ -54,6 +54,7 @@ from openviking_cli.utils.logger import default_logger as logger# Use imported constants, no longer defined hereAUTO_ID_KEY = SpecialFields.AUTO_ID.value+_RECOVERY_BATCH_SIZE = 1024class _MutationMarker:@@ -1385,33 +1386,33 @@ class PersistCollection(LocalCollection):"Index '%s': replaying delta records lazily to recover from last persistent snapshot",index_name,)- upsert_list: List[DeltaRecord] = []- delete_list: List[DeltaRecord] = []+ records: List[DeltaRecord] = []+ batch_operation = "upsert"_processed = 0_seen = 0_last_log = 0.0for data in delta_records:_seen += 1if data.type == OpType.PUT.value:- if delete_list:- _processed += self._replay_recovery_records(- index_name=index_name,- index=index,- records=delete_list,- operation="delete",- )- delete_list = []- upsert_list.append(data)+ operation = "upsert"elif data.type == OpType.DEL.value:- if upsert_list:+ operation = "delete"+ else:+ operation = None+ if operation is not None:+ # Preserve log order without retaining an entire run of PUTs or DELs.+ if records and (+ operation != batch_operation or len(records) >= _RECOVERY_BATCH_SIZE+ ):_processed += self._replay_recovery_records(index_name=index_name,index=index,- records=upsert_list,- operation="upsert",+ records=records,+ operation=batch_operation,)- upsert_list = []- delete_list.append(data)+ records = []+ batch_operation = operation+ records.append(data)now = time.time()if now - _last_log >= 5.0 and _seen > 0:logger.info(@@ -1421,19 +1422,12 @@ class PersistCollection(LocalCollection):index_name,)_last_log = now- if upsert_list:- _processed += self._replay_recovery_records(- index_name=index_name,- index=index,- records=upsert_list,- operation="upsert",- )- if delete_list:+ if records:_processed += self._replay_recovery_records(index_name=index_name,index=index,- records=delete_list,- operation="delete",+ records=records,+ operation=batch_operation,)logger.info("Index '%s': replay complete (%d records)", index_name, _processed)index._start_dense_rebuild_worker()diff --git a/tests/vectordb/test_crash_recovery.py b/tests/vectordb/test_crash_recovery.pyindex 80d040178..fffc83a3e 100644--- a/tests/vectordb/test_crash_recovery.py+++ b/tests/vectordb/test_crash_recovery.py@@ -6,6 +6,7 @@ import shutilimport sysimport timeimport unittest+import weakreffrom contextlib import ExitStackfrom pathlib import Pathfrom unittest.mock import patch@@ -13,6 +14,7 @@ from unittest.mock import patchfrom openviking.storage.vectordb import enginefrom openviking.storage.vectordb.collection.local_collection import get_or_create_local_collectionfrom openviking.storage.vectordb.store.data import CandidateData, DeltaRecord+from openviking.storage.vectordb.store.store_manager import StoreManagerDB_PATH_CRASH = "./test_data/test_db_crash_recovery"DB_PATH_ROBUST = "./test_data/test_db_robust_crash"@@ -92,9 +94,16 @@ def worker_write_and_crash(path, start_id, count, event_ready):col.upsert_data(data[2:])col.update_data([{"id": start_id, "data": LARGE_TEXT}])col.update_data([{"id": start_id, "data": LARGE_TEXT + " updated"}])- # Leave a large deletion in the log too, without changing the final count.- col.upsert_data([{"id": start_id + count, "vector": [0.1] * 4, "data": LARGE_TEXT}])- col.delete_data([start_id + count])+ # Replay long PUT and DEL runs, including a large deletion, without+ # changing the final count.+ transient_ids = list(range(start_id + count, start_id + 2 * count))+ col.upsert_data(+ [+ {"id": uid, "vector": [0.1] * 4, "data": LARGE_TEXT if i == 0 else "temporary"}+ for i, uid in enumerate(transient_ids)+ ]+ )+ col.delete_data(transient_ids)print("[Subprocess] Upsert done. Not closing.")# Notify main process that write is done@@ -231,6 +240,7 @@ class TestCrashRecovery(unittest.TestCase):shutil.rmtree(DB_PATH_ROBUST)def tearDown(self):+ self.doCleanups()if os.path.exists(DB_PATH_CRASH):shutil.rmtree(DB_PATH_CRASH)if os.path.exists(DB_PATH_ROBUST):@@ -247,7 +257,7 @@ class TestCrashRecovery(unittest.TestCase):ctx = multiprocessing.get_context("spawn")event = ctx.Event()- data_count = 100+ data_count = 2050p = ctx.Process(target=worker_write_and_crash, args=(DB_PATH_CRASH, 0, data_count, event))p.start()@@ -270,10 +280,27 @@ class TestCrashRecovery(unittest.TestCase):# Recoverprint("[Main] Recovering collection in main process...")# Re-opening the collection should trigger recovery logic (PersistentIndex should rebuild/catchup from Store)- col = get_or_create_local_collection(path=DB_PATH_CRASH)+ live_deltas: weakref.WeakValueDictionary[int, DeltaRecord] = weakref.WeakValueDictionary()+ peak_live_deltas = 0+ read_deltas = StoreManager.get_delta_data_after_ts++ def tracked_deltas(manager, version):+ nonlocal peak_live_deltas+ for number, record in enumerate(read_deltas(manager, version)):+ live_deltas[number] = record+ peak_live_deltas = max(peak_live_deltas, len(live_deltas))+ yield record++ with patch.object(StoreManager, "get_delta_data_after_ts", tracked_deltas):+ col = get_or_create_local_collection(path=DB_PATH_CRASH)+ self.addCleanup(col.close)+ self.assertGreater(peak_live_deltas, 0, "Recovery must exercise the persisted delta log")+ self.assertLessEqual(+ peak_live_deltas, 1025, "Recovery must release replayed deltas during long PUT/DEL runs"+ )# 1. Verify Data Persistence (Store)- print("[Main] Verifying data fetch (All 100 items)...")+ print(f"[Main] Verifying data fetch (All {data_count} items)...")# Check all IDsall_ids = list(range(data_count))res = col.fetch_data(all_ids)@@ -307,7 +334,6 @@ class TestCrashRecovery(unittest.TestCase):)self.assertEqual(set(found_ids), set(all_ids))- col.close()print("[Main] Simple recovery test passed.")def run_process_and_crash(self, target_func):