Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(pi): resolve config path from module URL (#3655)

Xinmin Zengb1ec59bda64f
diff --git a/examples/pi-coding-agent-extension/config.ts b/examples/pi-coding-agent-extension/config.ts
index 82f8a89f9..8d9c1dd22 100644
--- a/examples/pi-coding-agent-extension/config.ts
+++ b/examples/pi-coding-agent-extension/config.ts
@@ -1,5 +1,6 @@
import { readFileSync, existsSync } from "node:fs";
import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
import { buildUserAgent, resolveOpenVikingCredentials } from "./shared/credentials.mjs";
import { resolveEffectivePeerId } from "./shared/workspace-peer.mjs";
@@ -86,6 +87,10 @@ const DEFAULT_CONFIG: OVConfig = {
logLevel: "error",
};
+export function loadConfigFromModuleUrl(moduleUrl: string): OVConfig {
+ return loadConfig(dirname(fileURLToPath(moduleUrl)));
+}
+
export function loadConfig(extensionDir: string): OVConfig {
const configPath = join(extensionDir, "config.json");
let file: any = {};
diff --git a/examples/pi-coding-agent-extension/index.ts b/examples/pi-coding-agent-extension/index.ts
index a507270c0..350af7898 100644
--- a/examples/pi-coding-agent-extension/index.ts
+++ b/examples/pi-coding-agent-extension/index.ts
@@ -12,7 +12,7 @@
import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
import { appendFileSync, mkdirSync } from "node:fs";
import { dirname } from "node:path";
-import { loadConfig, type OVConfig } from "./config.js";
+import { loadConfigFromModuleUrl, type OVConfig } from "./config.js";
import { OVClient } from "./client.js";
import { RecallManager } from "./recall.js";
import { SyncManager } from "./sync.js";
@@ -23,7 +23,7 @@ import { createTakeoverManager } from "./takeover.js";
export default async function (pi: ExtensionAPI) {
// --- Load config ---
- const config = loadConfig(dirname(new URL(import.meta.url).pathname));
+ const config = loadConfigFromModuleUrl(import.meta.url);
if (!config.enabled) return;
// Env overrides
diff --git a/examples/pi-coding-agent-extension/tests/config.test.mjs b/examples/pi-coding-agent-extension/tests/config.test.mjs
index 9c5bc1165..a9c3dfcee 100644
--- a/examples/pi-coding-agent-extension/tests/config.test.mjs
+++ b/examples/pi-coding-agent-extension/tests/config.test.mjs
@@ -3,10 +3,11 @@ import assert from "node:assert/strict";
import { mkdtemp, rm, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
-import { loadConfig } from "../config.ts";
+import { pathToFileURL } from "node:url";
+import { loadConfig, loadConfigFromModuleUrl } from "../config.ts";
async function withConfigFile(body, fn, env = {}) {
- const dir = await mkdtemp(join(tmpdir(), "ov-pi-config-"));
+ const dir = await mkdtemp(join(tmpdir(), "ov-pi-config-用户-"));
const oldEnv = {
OPENVIKING_URL: process.env.OPENVIKING_URL,
OPENVIKING_API_KEY: process.env.OPENVIKING_API_KEY,
@@ -36,7 +37,7 @@ async function withConfigFile(body, fn, env = {}) {
try {
await writeFile(join(dir, "config.json"), JSON.stringify(body), "utf8");
- return await fn(loadConfig(dir));
+ return await fn(loadConfig(dir), dir);
} finally {
for (const [key, value] of Object.entries(oldEnv)) {
if (value === undefined) delete process.env[key];
@@ -77,6 +78,18 @@ test("loadConfig maps nested takeover block", async () => {
});
});
+test("loadConfigFromModuleUrl decodes Unicode paths", async () => {
+ await withConfigFile({
+ takeover: {
+ tokenThreshold: 2000,
+ },
+ }, (_cfg, dir) => {
+ const moduleUrl = pathToFileURL(join(dir, "index.ts")).href;
+ const cfg = loadConfigFromModuleUrl(moduleUrl);
+ assert.equal(cfg.takeoverTokenThreshold, 2000);
+ });
+});
+
test("loadConfig keeps top-level takeover aliases for compatibility", async () => {
await withConfigFile({
takeoverTokenThreshold: 42,