Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(config): 服务端启动忽略未知配置字段 (#5165)

Qin Haojieb83815fad5bb
diff --git a/docs/en/configuration/01-server.md b/docs/en/configuration/01-server.md
index 0e4cbcecb..f857721b1 100644
--- a/docs/en/configuration/01-server.md
+++ b/docs/en/configuration/01-server.md
@@ -36,7 +36,7 @@ The server reads the file at startup. Restart the server after changing models,
}
```
-Optional sections use their defaults when omitted. Unknown fields are rejected.
+Optional sections use their defaults when omitted. Unknown fields in `ov.conf` and persisted account settings are ignored for upgrade compatibility. Known fields still validate types and values; misspelled field names are also ignored.
## Top-Level Settings
diff --git a/docs/zh/configuration/01-server.md b/docs/zh/configuration/01-server.md
index bc6c073bc..5d2fc4c4b 100644
--- a/docs/zh/configuration/01-server.md
+++ b/docs/zh/configuration/01-server.md
@@ -36,7 +36,7 @@ openviking-server --config /path/to/ov.conf
}
```
-未配置的可选模块使用默认值。`ov.conf` 不允许未知字段,字段名写错时服务端会拒绝加载。
+未配置的可选模块使用默认值。`ov.conf` 及账户配置会忽略未知字段,兼容旧版本遗留配置;已知字段仍校验类型和取值。字段名拼写错误也会被忽略。
## 顶层配置
diff --git a/openviking/server/account_settings.py b/openviking/server/account_settings.py
index b772ca93a..2d20fab5a 100644
--- a/openviking/server/account_settings.py
+++ b/openviking/server/account_settings.py
@@ -28,28 +28,22 @@ class AccountAgentEvolutionSettings(BaseModel):
enabled: bool
- model_config = {"extra": "forbid"}
-
class AccountAclSettings(BaseModel):
"""Account-scoped ACL switch."""
enabled: bool = False
- model_config = {"extra": "forbid"}
-
class AccountSettings(BaseModel):
"""Persisted account overrides.
- Only explicitly allowlisted hot-reloadable settings belong in this model.
+ Unknown persisted fields are ignored for upgrade compatibility.
"""
agent_evolution: Optional[AccountAgentEvolutionSettings] = None
acl: Optional[AccountAclSettings] = None
- model_config = {"extra": "forbid"}
-
class AccountSettingsPatch(BaseModel):
"""Allowlisted account settings accepted by the update API."""
diff --git a/openviking/server/auth/identity_mapping.py b/openviking/server/auth/identity_mapping.py
index 215a51829..58230f58c 100644
--- a/openviking/server/auth/identity_mapping.py
+++ b/openviking/server/auth/identity_mapping.py
@@ -46,8 +46,6 @@ class MappingSource(BaseModel):
# For list sources (try claims in order)
claims: Optional[List[str]] = None
- model_config = {"extra": "forbid"}
-
# Forward reference update
MappingSource.model_rebuild()
@@ -71,8 +69,6 @@ class AccountMappingConfig(BaseModel):
normalize: Optional[Literal["lowercase", "uppercase", "trim"]] = None
claims: Optional[List[str]] = None
- model_config = {"extra": "forbid"}
-
class UserMappingConfig(BaseModel):
"""User ID mapping configuration."""
@@ -90,8 +86,6 @@ class UserMappingConfig(BaseModel):
normalize: Optional[Literal["lowercase", "uppercase", "trim"]] = None
claims: Optional[List[str]] = None
- model_config = {"extra": "forbid"}
-
class RoleMappingConfig(BaseModel):
"""Role mapping configuration."""
@@ -109,8 +103,6 @@ class RoleMappingConfig(BaseModel):
# Fallback
default: str = Role.USER
- model_config = {"extra": "forbid"}
-
class IdentityMappingConfig(BaseModel):
"""Complete identity mapping configuration."""
@@ -119,8 +111,6 @@ class IdentityMappingConfig(BaseModel):
user_id: UserMappingConfig = Field(default_factory=UserMappingConfig)
role: RoleMappingConfig = Field(default_factory=RoleMappingConfig)
- model_config = {"extra": "forbid"}
-
class IdentityMapper:
"""Identity mapper that applies mapping rules to external identities."""
diff --git a/openviking/server/auth/ldap_config.py b/openviking/server/auth/ldap_config.py
index d9bb34ec2..16f460c36 100644
--- a/openviking/server/auth/ldap_config.py
+++ b/openviking/server/auth/ldap_config.py
@@ -61,8 +61,6 @@ class LDAPConfig(BaseModel):
default_factory=_ldap_default_identity
)
- model_config = {"extra": "forbid"}
-
@field_validator("host")
@classmethod
def validate_host(cls, v: str) -> str:
diff --git a/openviking/server/auth/oidc_config.py b/openviking/server/auth/oidc_config.py
index 82a44a7f4..76e99a255 100644
--- a/openviking/server/auth/oidc_config.py
+++ b/openviking/server/auth/oidc_config.py
@@ -29,8 +29,6 @@ class OIDCConfig(BaseModel):
# Identity mapping
identity: IdentityMappingConfig = Field(default_factory=IdentityMappingConfig)
- model_config = {"extra": "forbid"}
-
@field_validator("issuer")
@classmethod
def validate_issuer(cls, v: str) -> str:
diff --git a/openviking/server/config.py b/openviking/server/config.py
index bf579d36f..2e4033d68 100644
--- a/openviking/server/config.py
+++ b/openviking/server/config.py
@@ -72,8 +72,6 @@ class AddTargetsConfig(BaseModel):
resource_uri: Optional[str] = None
skill_uri: Optional[str] = None
- model_config = {"extra": "forbid"}
-
@field_validator("resource_uri")
@classmethod
def validate_resource_uri(cls, value: Optional[str]) -> Optional[str]:
@@ -131,16 +129,12 @@ class AgentEvolutionConfig(BaseModel):
enabled: bool = False
- model_config = {"extra": "forbid"}
-
class DeprecatedUserAgentEvolutionConfig(BaseModel):
"""Parse-only compatibility for legacy per-user configuration files."""
enabled: Optional[bool] = None
- model_config = {"extra": "forbid"}
-
class UserConfig(BaseModel):
"""User configuration values that can be defaulted or initialized."""
@@ -152,8 +146,6 @@ class UserConfig(BaseModel):
exclude=True,
)
- model_config = {"extra": "forbid"}
-
@field_validator("memory_policy", mode="before")
@classmethod
def validate_memory_policy(cls, value: Any) -> Optional[Dict[str, Any]]:
@@ -172,16 +164,12 @@ class MetricsAccountDimensionConfig(BaseModel):
max_active_accounts: int = 100
metric_allowlist: List[str] = Field(default_factory=list)
- model_config = {"extra": "forbid"}
-
class PrometheusExporterConfig(BaseModel):
"""Prometheus exporter configuration."""
enabled: bool = True
- model_config = {"extra": "forbid"}
-
class OTelExporterConfig(BaseModel):
"""OpenTelemetry exporter configuration."""
@@ -191,8 +179,6 @@ class OTelExporterConfig(BaseModel):
insecure: bool = False
- model_config = {"extra": "forbid"}
-
enabled: bool = False
protocol: str = "grpc" # "grpc", "http", or "local" for traces
tls: TLSConfig = Field(default_factory=TLSConfig)
@@ -204,8 +190,6 @@ class OTelExporterConfig(BaseModel):
local_rotation_mb: int = Field(default=40, gt=0)
local_backup_count: int = Field(default=2, ge=0)
- model_config = {"extra": "forbid"}
-
class MetricsExportersConfig(BaseModel):
"""Metrics exporters configuration."""
@@ -213,8 +197,6 @@ class MetricsExportersConfig(BaseModel):
prometheus: PrometheusExporterConfig = Field(default_factory=PrometheusExporterConfig)
otel: OTelExporterConfig = Field(default_factory=OTelExporterConfig)
- model_config = {"extra": "forbid"}
-
class MetricsConfig(BaseModel):
"""Metrics subsystem configuration."""
@@ -226,8 +208,6 @@ class MetricsConfig(BaseModel):
)
exporters: MetricsExportersConfig = Field(default_factory=MetricsExportersConfig)
- model_config = {"extra": "forbid"}
-
class UsageAuditConfig(BaseModel):
"""Product usage and audit projection configuration."""
@@ -245,8 +225,6 @@ class UsageAuditConfig(BaseModel):
timezone: str = "local"
inventory_ttl_seconds: float = Field(10.0, ge=0)
- model_config = {"extra": "forbid"}
-
class UsageReporterSinkConfig(BaseModel):
"""Usage reporter sink configuration."""
@@ -255,8 +233,6 @@ class UsageReporterSinkConfig(BaseModel):
class_path: Optional[str] = None
config: Dict[str, object] = Field(default_factory=dict)
- model_config = {"extra": "forbid"}
-
class UsageReporterConfig(BaseModel):
"""Usage event reporter configuration."""
@@ -265,8 +241,6 @@ class UsageReporterConfig(BaseModel):
extractors: List[Literal["memory_usage"]] = Field(default_factory=lambda: ["memory_usage"])
sinks: List[UsageReporterSinkConfig] = Field(default_factory=list)
- model_config = {"extra": "forbid"}
-
class TraceDumpBodyConfig(BaseModel):
"""HTTP body dump configuration.
@@ -279,8 +253,6 @@ class TraceDumpBodyConfig(BaseModel):
enabled: bool = False
max_bytes: int = 4096
- model_config = {"extra": "forbid"}
-
class ObservabilityConfig(BaseModel):
"""Server-side observability configuration."""
@@ -291,8 +263,6 @@ class ObservabilityConfig(BaseModel):
logs: OTelExporterConfig = Field(default_factory=OTelExporterConfig)
dump_body: TraceDumpBodyConfig = Field(default_factory=TraceDumpBodyConfig)
- model_config = {"extra": "forbid"}
-
class TempUploadConfig(BaseModel):
"""Temporary upload configuration."""
@@ -306,8 +276,6 @@ class TempUploadConfig(BaseModel):
# to reclaim junk directories that would otherwise be skipped forever.
cleanup_invalid_dirs: bool = False
- model_config = {"extra": "forbid"}
-
class ToolOutputExternalizationConfig(BaseModel):
"""External storage controls for oversized tool outputs."""
@@ -321,8 +289,6 @@ class ToolOutputExternalizationConfig(BaseModel):
aggregate_selection_strategy: Literal["largest_first"] = "largest_first"
failure_mode: Literal["reject", "preserve_raw", "preview_only"] = "preserve_raw"
- model_config = {"extra": "forbid"}
-
class ServerConfig(BaseModel):
host: str = "127.0.0.1"
@@ -380,8 +346,6 @@ class ServerConfig(BaseModel):
default_factory=ToolOutputExternalizationConfig
)
- model_config = {"extra": "forbid"}
-
def get_effective_auth_mode(self) -> str:
"""Get effective auth mode, auto-detecting if not explicitly set.
diff --git a/openviking_cli/utils/config/agfs_config.py b/openviking_cli/utils/config/agfs_config.py
index 56479d2e6..a9afb07aa 100644
--- a/openviking_cli/utils/config/agfs_config.py
+++ b/openviking_cli/utils/config/agfs_config.py
@@ -87,8 +87,6 @@ class S3Config(BaseModel):
"during uploads. Disabled by default for backward compatibility.",
)
- model_config = {"extra": "forbid"}
-
def validate_config(self):
"""Validate S3 configuration completeness"""
missing = []
@@ -142,8 +140,6 @@ class QueueFSConfig(BaseModel):
description="Queue key namespace when backend is 'cache'.",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
valid_modes = {"shared", "worker"}
@@ -197,8 +193,6 @@ class AGFSCacheFSConfig(BaseModel):
description="Path prefixes that bypass cache",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
if not self.namespace.strip():
@@ -242,8 +236,6 @@ class RedisCacheConfig(BaseModel):
default=False, description="Skip Redis TLS certificate verification"
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
if self.mode not in {"standalone", "cluster", "sentinel"}:
@@ -333,8 +325,6 @@ class AGFSPathLockConfig(BaseModel):
description="Seconds before an unrefreshed lock token becomes stale.",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
"""Validate provider and timeout/expiry ranges."""
@@ -459,8 +449,6 @@ class AGFSConfig(BaseModel):
default=None, description="Primary redirect policies."
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
"""Validate configuration completeness and consistency"""
diff --git a/openviking_cli/utils/config/cache_config.py b/openviking_cli/utils/config/cache_config.py
index 403054757..743c15d57 100644
--- a/openviking_cli/utils/config/cache_config.py
+++ b/openviking_cli/utils/config/cache_config.py
@@ -15,8 +15,6 @@ class CacheConfig(BaseModel):
repr=False,
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
if not self.provider.strip():
diff --git a/openviking_cli/utils/config/config_utils.py b/openviking_cli/utils/config/config_utils.py
index d6b9b3b25..11251a02e 100644
--- a/openviking_cli/utils/config/config_utils.py
+++ b/openviking_cli/utils/config/config_utils.py
@@ -16,31 +16,6 @@ def suggest_closest_field(field_name: str, valid_fields: set[str]) -> Optional[s
return None
-def raise_unknown_config_fields(
- *,
- data: dict[str, Any],
- valid_fields: set[str],
- context_name: str,
-) -> None:
- """Raise a user-friendly error for unexpected config fields."""
- unknown_fields = [key for key in data if key not in valid_fields]
- if not unknown_fields:
- return
-
- errors = []
- for field_name in unknown_fields:
- suggestion = suggest_closest_field(field_name, valid_fields)
- if suggestion:
- errors.append(
- f"Unknown config field '{field_name}' in {context_name} "
- f"(did you mean '{suggestion}'?)"
- )
- else:
- errors.append(f"Unknown config field '{field_name}' in {context_name}")
-
- raise ValueError("\n".join(errors))
-
-
def _unwrap_model_type(annotation: Any) -> Optional[type[BaseModel]]:
if isinstance(annotation, type) and issubclass(annotation, BaseModel):
return annotation
diff --git a/openviking_cli/utils/config/embedding_config.py b/openviking_cli/utils/config/embedding_config.py
index aba2242c2..3e1687e39 100644
--- a/openviking_cli/utils/config/embedding_config.py
+++ b/openviking_cli/utils/config/embedding_config.py
@@ -36,8 +36,6 @@ class EmbeddingCredential(BaseModel):
host: Optional[str] = Field(default=None, description="Host for VikingDB API")
extra_headers: Optional[dict[str, str]] = Field(default=None, description="Extra HTTP headers")
- model_config = {"extra": "forbid"}
-
class EmbeddingModelConfig(BaseModel):
"""Configuration for a specific embedding model"""
@@ -151,8 +149,6 @@ class EmbeddingModelConfig(BaseModel):
default=50, description="Number of backup requests after which to attempt failback"
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="before")
@classmethod
def sync_provider_backend(cls, data: Any) -> Any:
@@ -673,8 +669,6 @@ class EmbeddingConfig(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="before")
@classmethod
def apply_default_local_dense(cls, data: Any) -> Any:
diff --git a/openviking_cli/utils/config/encryption_config.py b/openviking_cli/utils/config/encryption_config.py
index bdbd6417a..501926c13 100644
--- a/openviking_cli/utils/config/encryption_config.py
+++ b/openviking_cli/utils/config/encryption_config.py
@@ -143,8 +143,6 @@ class EncryptionConfig(BaseModel):
default_factory=dict, description="Additional encryption-specific parameters"
)
- model_config = {"extra": "forbid"}
-
@classmethod
def from_dict(cls, data: Dict[str, Any]) -> "EncryptionConfig":
"""Create configuration from dictionary.
diff --git a/openviking_cli/utils/config/git_config.py b/openviking_cli/utils/config/git_config.py
index 000962d37..63f4dd8aa 100644
--- a/openviking_cli/utils/config/git_config.py
+++ b/openviking_cli/utils/config/git_config.py
@@ -15,8 +15,6 @@ class GitLocalConfig(BaseModel):
"When empty, defaults to '{storage.path}/.ovgit'.",
)
- model_config = {"extra": "forbid"}
-
class GitS3Config(BaseModel):
"""Configuration for the S3 git object/ref backend.
@@ -63,8 +61,6 @@ class GitS3Config(BaseModel):
"false uses virtual-host style (TOS and some S3-compatible services).",
)
- model_config = {"extra": "forbid"}
-
class GitConfig(BaseModel):
"""Git multi-version management configuration."""
@@ -101,8 +97,6 @@ class GitConfig(BaseModel):
description="Configuration for the 's3' backend. Required when backend='s3'.",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def _validate_backend(self) -> "GitConfig":
"""Ensure the selected backend has the required configuration."""
diff --git a/openviking_cli/utils/config/glob_config.py b/openviking_cli/utils/config/glob_config.py
index 81a903b43..ddb5bbd03 100644
--- a/openviking_cli/utils/config/glob_config.py
+++ b/openviking_cli/utils/config/glob_config.py
@@ -28,5 +28,3 @@ class GlobConfig(BaseModel):
"0 means always use VikingDB when available."
),
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/grep_config.py b/openviking_cli/utils/config/grep_config.py
index 75c12c82d..5db4f29d6 100644
--- a/openviking_cli/utils/config/grep_config.py
+++ b/openviking_cli/utils/config/grep_config.py
@@ -27,5 +27,3 @@ class GrepConfig(BaseModel):
"L2 record count threshold to switch to vikingdb; 0 means always use vikingdb."
),
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/ingest_config.py b/openviking_cli/utils/config/ingest_config.py
index bf4e3fc81..6864c2d38 100644
--- a/openviking_cli/utils/config/ingest_config.py
+++ b/openviking_cli/utils/config/ingest_config.py
@@ -46,8 +46,6 @@ class CommitPolicy(BaseModel):
description="WM v2 sliding window: messages to retain live after a commit (0 = archive all).",
)
- model_config = {"extra": "forbid"}
-
class IngestHarnessConfig(BaseModel):
"""Per-harness ingest settings, keyed by registry name (e.g. ``claude_code``)."""
@@ -79,8 +77,6 @@ class IngestHarnessConfig(BaseModel):
)
commit: CommitPolicy = Field(default_factory=CommitPolicy)
- model_config = {"extra": "forbid"}
-
class IngestConfig(BaseModel):
"""Top-level ingest configuration (``ingest`` section of ``ov.conf``)."""
@@ -110,8 +106,6 @@ class IngestConfig(BaseModel):
description="Per-harness configuration, keyed by registry name.",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def _apply_env_overrides(self) -> "IngestConfig":
# Operational toggles may come from the environment (deploy-time > config).
diff --git a/openviking_cli/utils/config/log_config.py b/openviking_cli/utils/config/log_config.py
index c32fc0c26..e8e8d5136 100644
--- a/openviking_cli/utils/config/log_config.py
+++ b/openviking_cli/utils/config/log_config.py
@@ -8,8 +8,6 @@ from pydantic import BaseModel, Field
class LogConfig(BaseModel):
"""Logging configuration for OpenViking."""
- model_config = {"extra": "forbid"}
-
level: str = Field(
default="WARNING", description="Logging level: DEBUG, INFO, WARNING, ERROR, CRITICAL"
)
diff --git a/openviking_cli/utils/config/memory_config.py b/openviking_cli/utils/config/memory_config.py
index 3cb1eeaae..7069d4f6d 100644
--- a/openviking_cli/utils/config/memory_config.py
+++ b/openviking_cli/utils/config/memory_config.py
@@ -18,8 +18,6 @@ class SessionAutoCommitConfig(BaseModel):
scan_batch_size: int = Field(default=16, gt=0)
scan_batch_pause_seconds: float = Field(default=0.0, ge=0)
- model_config = {"extra": "forbid"}
-
class MemoryConfig(BaseModel):
"""Memory configuration for OpenViking."""
@@ -102,8 +100,6 @@ class MemoryConfig(BaseModel):
description="Server-wide controls for automatic session commits.",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="before")
@classmethod
def drop_deprecated_memory_fields(cls, data: Any) -> Any:
diff --git a/openviking_cli/utils/config/oauth_config.py b/openviking_cli/utils/config/oauth_config.py
index 5336fee35..6abec542f 100644
--- a/openviking_cli/utils/config/oauth_config.py
+++ b/openviking_cli/utils/config/oauth_config.py
@@ -64,5 +64,3 @@ class OAuthConfig(BaseModel):
default="oauth.db",
description="SQLite database filename (relative to OpenVikingConfig.storage.workspace).",
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/open_viking_config.py b/openviking_cli/utils/config/open_viking_config.py
index ae31e438c..e6b3f195d 100644
--- a/openviking_cli/utils/config/open_viking_config.py
+++ b/openviking_cli/utils/config/open_viking_config.py
@@ -13,7 +13,7 @@ from openviking_cli.session.user_id import UserIdentifier
from .cache_config import CacheConfig
from .config_loader import resolve_config_path
-from .config_utils import format_validation_error, raise_unknown_config_fields
+from .config_utils import format_validation_error
from .consts import (
DEFAULT_CONFIG_DIR,
DEFAULT_OV_CONF,
@@ -69,8 +69,6 @@ class ConnectorConfig(BaseModel):
poll_interval_ms: int = 5000
allowed_add_types: List[str] = Field(default_factory=lambda: ["tos"])
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def _validate(self) -> "ConnectorConfig":
if self.enable:
@@ -103,7 +101,6 @@ class ParserApiConfig(BaseModel):
http_timeout_seconds: float = 10.0
response_timeout_seconds: int = 1800
poll_interval_ms: int = 3000
- model_config = {"extra": "forbid"}
@model_validator(mode="after")
def _normalize_and_validate(self) -> "ParserApiConfig":
@@ -144,7 +141,6 @@ class CompileApiConfig(BaseModel):
gateway_token: str = ""
http_timeout_seconds: float = 10.0
poll_interval_ms: int = 30000
- model_config = {"extra": "forbid"}
@model_validator(mode="after")
def _validate(self) -> "CompileApiConfig":
@@ -404,33 +400,6 @@ class OpenVikingConfig(BaseModel):
data["git"] = git
return data
- @model_validator(mode="before")
- @classmethod
- def _reject_removed_cache_config(cls, data: Any) -> Any:
- if not isinstance(data, dict):
- return data
-
- storage_value = data.get("storage")
- if not isinstance(storage_value, dict):
- return data
- agfs_value = storage_value.get("agfs")
- if not isinstance(agfs_value, dict):
- return data
- if "cache" in agfs_value:
- raise ValueError(
- "storage.agfs.cache has been removed; configure cache.provider/cache.params "
- "and storage.agfs.cachefs.backend='cache'"
- )
- queuefs = agfs_value.get("queuefs")
- if isinstance(queuefs, dict) and (
- queuefs.get("backend") == "redis" or "redis" in queuefs
- ):
- raise ValueError(
- "storage.agfs.queuefs backend='redis' and queuefs.redis have been removed; "
- "use backend='cache' with top-level cache.provider/cache.params"
- )
- return data
-
allow_private_networks: bool = Field(
default=False,
description=(
@@ -461,7 +430,7 @@ class OpenVikingConfig(BaseModel):
description="Conversation-log ingest (openviking-server ingest) configuration",
)
- model_config = {"arbitrary_types_allowed": True, "extra": "forbid"}
+ model_config = {"arbitrary_types_allowed": True}
@classmethod
def from_dict(cls, config: Dict[str, Any]) -> "OpenVikingConfig":
@@ -484,11 +453,6 @@ class OpenVikingConfig(BaseModel):
"feishu",
"webfeed",
]
- raise_unknown_config_fields(
- data=config_copy,
- valid_fields=set(cls.model_fields.keys()) | {"server", "bot", "parsers"},
- context_name="OpenVikingConfig",
- )
# Remove sections managed by other loaders (e.g. server config)
config_copy.pop("server", None)
@@ -509,11 +473,6 @@ class OpenVikingConfig(BaseModel):
"Config field 'parsers.excel' was removed and is ignored; "
"spreadsheet parsing now uses 'parsers.anydoc'."
)
- raise_unknown_config_fields(
- data=parser_configs,
- valid_fields=set(parser_types),
- context_name="parsers",
- )
for parser_type in parser_types:
if parser_type in config_copy:
parser_configs[parser_type] = config_copy.pop(parser_type)
@@ -548,8 +507,9 @@ class OpenVikingConfig(BaseModel):
) from e
# Apply parser configurations
- for parser_type, parser_data in parser_configs.items():
- if hasattr(instance, parser_type):
+ for parser_type in parser_types:
+ if parser_type in parser_configs:
+ parser_data = parser_configs[parser_type]
config_class = getattr(instance, parser_type).__class__
setattr(instance, parser_type, config_class.from_dict(parser_data))
diff --git a/openviking_cli/utils/config/parser_config.py b/openviking_cli/utils/config/parser_config.py
index 2423637dc..fcd9ab4a4 100644
--- a/openviking_cli/utils/config/parser_config.py
+++ b/openviking_cli/utils/config/parser_config.py
@@ -14,8 +14,6 @@ from typing import Any, Dict, Optional, Union
from openviking_cli.utils.logger import get_logger
-from .config_utils import raise_unknown_config_fields
-
logger = get_logger(__name__)
@@ -57,15 +55,10 @@ class ParserConfig:
Returns:
ParserConfig instance
- Raises:
- ValueError: If the dictionary contains unknown fields (with suggestions)
-
Examples:
>>> config = ParserConfig.from_dict({"max_content_length": 50000})
"""
- valid_fields = {f.name for f in cls.__dataclass_fields__.values()}
- raise_unknown_config_fields(data=data, valid_fields=valid_fields, context_name=cls.__name__)
- return cls(**data)
+ return cls(**{key: value for key, value in data.items() if key in cls.__dataclass_fields__})
@classmethod
def from_yaml(cls, yaml_path: Union[str, Path]) -> "ParserConfig":
@@ -281,9 +274,7 @@ class CodeConfig(CodeHostingConfig):
"code summaries now always use the fixed skeleton route with LLM fallback"
)
- valid_fields = {f.name for f in cls.__dataclass_fields__.values()}
- raise_unknown_config_fields(data=data, valid_fields=valid_fields, context_name=cls.__name__)
- return cls(**data)
+ return super().from_dict(data)
def validate(self) -> None:
"""
@@ -470,12 +461,6 @@ class AnydocConfig(ParserConfig):
max_table_rows: int = 1000
- @classmethod
- def from_dict(cls, data: Dict[str, Any]) -> "AnydocConfig":
- valid_fields = {f.name for f in cls.__dataclass_fields__.values()}
- raise_unknown_config_fields(data=data, valid_fields=valid_fields, context_name=cls.__name__)
- return cls(**data)
-
def validate(self) -> None:
super().validate()
if self.max_table_rows < 0:
@@ -807,12 +792,6 @@ def load_parser_configs_from_dict(config_dict: Dict[str, Any]) -> Dict[str, Pars
>>> pdf_config = configs["pdf"]
>>> code_config = configs["code"]
"""
- raise_unknown_config_fields(
- data=config_dict,
- valid_fields=set(PARSER_CONFIG_REGISTRY.keys()),
- context_name="parsers",
- )
-
configs = {}
for parser_type, config_class in PARSER_CONFIG_REGISTRY.items():
diff --git a/openviking_cli/utils/config/prompts_config.py b/openviking_cli/utils/config/prompts_config.py
index 340c96529..e7626fe57 100644
--- a/openviking_cli/utils/config/prompts_config.py
+++ b/openviking_cli/utils/config/prompts_config.py
@@ -16,8 +16,6 @@ class PromptsConfig(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
@classmethod
def from_dict(cls, config: Dict[str, Any]) -> "PromptsConfig":
"""Create configuration from dictionary."""
diff --git a/openviking_cli/utils/config/queue_worker_config.py b/openviking_cli/utils/config/queue_worker_config.py
index 4553e11eb..e26ce36c1 100644
--- a/openviking_cli/utils/config/queue_worker_config.py
+++ b/openviking_cli/utils/config/queue_worker_config.py
@@ -14,8 +14,6 @@ class QueueWorkerConfig(BaseModel):
description="Maximum number of jobs processed concurrently",
)
- model_config = {"extra": "forbid"}
-
class AddResourceQueueWorkerConfig(QueueWorkerConfig):
"""Runtime limits for add-resource queue workers."""
@@ -38,5 +36,3 @@ class QueueWorkersConfig(BaseModel):
external_task: QueueWorkerConfig = Field(
default_factory=lambda: QueueWorkerConfig(max_concurrent=10)
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/reindex_config.py b/openviking_cli/utils/config/reindex_config.py
index ec71ede6a..a3d2e16c6 100644
--- a/openviking_cli/utils/config/reindex_config.py
+++ b/openviking_cli/utils/config/reindex_config.py
@@ -13,5 +13,3 @@ class ReindexConfig(BaseModel):
gt=0,
description="Maximum number of files read, prepared, and enqueued concurrently",
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/rerank_config.py b/openviking_cli/utils/config/rerank_config.py
index cdbc2c062..f4e87f73f 100644
--- a/openviking_cli/utils/config/rerank_config.py
+++ b/openviking_cli/utils/config/rerank_config.py
@@ -56,8 +56,6 @@ class RerankConfig(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
def _effective_provider(self) -> Optional[str]:
"""Auto-detect provider from config fields when not explicitly set."""
if self.provider:
diff --git a/openviking_cli/utils/config/retrieval_config.py b/openviking_cli/utils/config/retrieval_config.py
index 993aaab18..055a44ac7 100644
--- a/openviking_cli/utils/config/retrieval_config.py
+++ b/openviking_cli/utils/config/retrieval_config.py
@@ -45,5 +45,3 @@ class RetrievalConfig(BaseModel):
"(same path as no-session search)."
),
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/storage_config.py b/openviking_cli/utils/config/storage_config.py
index 4f447e1f4..ab1953c61 100644
--- a/openviking_cli/utils/config/storage_config.py
+++ b/openviking_cli/utils/config/storage_config.py
@@ -48,8 +48,6 @@ class StorageConfig(BaseModel):
default_factory=dict, description="Additional storage-specific parameters"
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="before")
@classmethod
def ignore_deprecated_task_tracker(cls, data: Any) -> Any:
diff --git a/openviking_cli/utils/config/telemetry_config.py b/openviking_cli/utils/config/telemetry_config.py
index d27da8b19..1411bc811 100644
--- a/openviking_cli/utils/config/telemetry_config.py
+++ b/openviking_cli/utils/config/telemetry_config.py
@@ -13,8 +13,6 @@ class TracerConfig(BaseModel):
ak: str = Field(default="", description="Access key")
sk: str = Field(default="", description="Secret key")
- model_config = {"extra": "forbid"}
-
class TelemetryConfig(BaseModel):
"""Telemetry configuration including tracer."""
@@ -22,5 +20,3 @@ class TelemetryConfig(BaseModel):
tracer: TracerConfig = Field(
default_factory=lambda: TracerConfig(), description="OpenTelemetry tracer configuration"
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/transaction_config.py b/openviking_cli/utils/config/transaction_config.py
index 4184b5254..965909f72 100644
--- a/openviking_cli/utils/config/transaction_config.py
+++ b/openviking_cli/utils/config/transaction_config.py
@@ -34,5 +34,3 @@ class TransactionConfig(BaseModel):
"persistent session_commit queue."
),
)
-
- model_config = {"extra": "forbid"}
diff --git a/openviking_cli/utils/config/vectordb_config.py b/openviking_cli/utils/config/vectordb_config.py
index bccc25cde..aff31a33b 100644
--- a/openviking_cli/utils/config/vectordb_config.py
+++ b/openviking_cli/utils/config/vectordb_config.py
@@ -36,8 +36,6 @@ class VolcengineConfig(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
class VikingDBConfig(BaseModel):
"""Configuration for VikingDB private deployment."""
@@ -47,8 +45,6 @@ class VikingDBConfig(BaseModel):
default_factory=dict, description="Custom headers for requests"
)
- model_config = {"extra": "forbid"}
-
class CuVSConfig(BaseModel):
"""Configuration for GPU dense-vector search through NVIDIA cuVS."""
@@ -175,8 +171,6 @@ class CuVSConfig(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_micro_batching(self):
if not self.micro_batching_enabled:
@@ -265,8 +259,6 @@ class VectorDBBackendConfig(BaseModel):
description="Custom parameters for custom backend adapters",
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="after")
def validate_config(self):
"""Validate configuration completeness and consistency"""
diff --git a/openviking_cli/utils/config/vlm_config.py b/openviking_cli/utils/config/vlm_config.py
index e4f46d1ea..52a73a81f 100644
--- a/openviking_cli/utils/config/vlm_config.py
+++ b/openviking_cli/utils/config/vlm_config.py
@@ -73,8 +73,6 @@ class VLMCredential(BaseModel):
),
)
- model_config = {"extra": "forbid"}
-
@model_validator(mode="before")
@classmethod
def reject_stream_config(cls, data: Any) -> Any:
@@ -108,8 +106,6 @@ class VLMMediaConfig(BaseModel):
description="Video frame sampling rate for providers that support preprocessing",
)
- model_config = {"extra": "forbid"}
-
class VLMConfig(BaseModel):
"""VLM configuration, supports multiple provider backends and multi-credential failover."""
@@ -208,7 +204,7 @@ class VLMConfig(BaseModel):
] = PrivateAttr(default_factory=weakref.WeakKeyDictionary)
_media_semaphore_lock: threading.Lock = PrivateAttr(default_factory=threading.Lock)
- model_config = {"arbitrary_types_allowed": True, "extra": "forbid"}
+ model_config = {"arbitrary_types_allowed": True}
@model_validator(mode="before")
@classmethod
diff --git a/tests/metrics/config/test_server_config.py b/tests/metrics/config/test_server_config.py
index 47f1cc81b..af3ed3b55 100644
--- a/tests/metrics/config/test_server_config.py
+++ b/tests/metrics/config/test_server_config.py
@@ -3,25 +3,27 @@
import json
-import pytest
-
from openviking.server.config import load_server_config
-def test_load_server_config_rejects_legacy_server_metrics_field(tmp_path):
+def test_load_server_config_ignores_legacy_observability_fields(tmp_path):
config_path = tmp_path / "ov.conf"
- config_path.write_text(json.dumps({"server": {"metrics": {"enabled": True}}}))
-
- with pytest.raises(ValueError, match=r"server\.metrics"):
- load_server_config(str(config_path))
-
+ config_path.write_text(
+ json.dumps(
+ {
+ "server": {
+ "metrics": {"enabled": True},
+ "telemetry": {"prometheus": {"enabled": True}},
+ }
+ }
+ )
+ )
-def test_load_server_config_rejects_legacy_server_telemetry_field(tmp_path):
- config_path = tmp_path / "ov.conf"
- config_path.write_text(json.dumps({"server": {"telemetry": {"prometheus": {"enabled": True}}}}))
+ config = load_server_config(str(config_path))
- with pytest.raises(ValueError, match=r"server\.telemetry"):
- load_server_config(str(config_path))
+ assert config.observability.metrics.enabled is False
+ assert "metrics" not in config.model_dump()
+ assert "telemetry" not in config.model_dump()
def test_load_server_config_preserves_metrics_fields_under_server_observability(tmp_path):
diff --git a/tests/misc/test_config_validation.py b/tests/misc/test_config_validation.py
index ad6bf3a6c..939370b1f 100644
--- a/tests/misc/test_config_validation.py
+++ b/tests/misc/test_config_validation.py
@@ -257,7 +257,7 @@ def test_queuefs_cache_uses_top_level_provider_without_enabling_cachefs():
assert binding["cache"]["redis"]["endpoints"] == ["redis://redis:6379"]
-def test_top_level_cache_params_reject_removed_replica_read_config():
+def test_top_level_cache_params_ignore_removed_replica_read_config():
config = OpenVikingConfig.model_validate(
{
"cache": {
@@ -276,11 +276,11 @@ def test_top_level_cache_params_reject_removed_replica_read_config():
}
)
- with pytest.raises(ValueError, match="read_from_replica"):
- RagfsBindingConfig(
- agfs=config.storage.agfs,
- cache=config.cache,
- ).to_binding_dict()
+ binding = RagfsBindingConfig(
+ agfs=config.storage.agfs,
+ cache=config.cache,
+ ).to_binding_dict()
+ assert "read_from_replica" not in binding["cache"]["redis"]
def test_cache_backend_requires_top_level_cache_config():
@@ -295,19 +295,6 @@ def test_cache_backend_requires_top_level_cache_config():
)
-def test_top_level_cache_rejects_global_enabled_flag():
- with pytest.raises(ValueError, match="enabled"):
- OpenVikingConfig.model_validate(
- {
- "cache": {
- "enabled": True,
- "provider": "redis",
- "params": {},
- }
- }
- )
-
-
def test_top_level_cache_repr_hides_provider_params():
config = CacheConfig(
provider="redis",
@@ -337,19 +324,10 @@ def test_unused_top_level_cache_does_not_parse_provider_params():
assert binding["cache"]["provider"] == "redis"
-def test_openviking_config_rejects_removed_nested_cache_schema():
- with pytest.raises(ValueError, match="storage.agfs.cache has been removed"):
- OpenVikingConfig.model_validate(
- {
- "storage": {"agfs": {"cache": {"enabled": True}}},
- }
- )
-
-
def test_openviking_config_dump_uses_only_canonical_cache_schema():
config = OpenVikingConfig.model_validate(
{
- "cache": {"provider": "redis", "params": {}},
+ "cache": {"provider": "redis", "params": {}, "enabled": True},
"storage": {"agfs": {"cachefs": {"backend": "cache"}}},
}
)
diff --git a/tests/server/test_agent_evolution_global_setting.py b/tests/server/test_agent_evolution_global_setting.py
index bd875cc3d..1fb7888a9 100644
--- a/tests/server/test_agent_evolution_global_setting.py
+++ b/tests/server/test_agent_evolution_global_setting.py
@@ -202,16 +202,34 @@ async def test_account_overrides_are_isolated(fake_viking_fs):
async def test_account_settings_update_backs_up_previous_file(fake_viking_fs):
- await update_account_settings(fake_viking_fs, "default", _patch(False))
+ legacy_settings = json.dumps(
+ {
+ "namespace": {
+ "isolate_user_scope_by_agent": True,
+ "isolate_agent_scope_by_user": False,
+ },
+ "agent_evolution": {"enabled": False},
+ "acl": {"enabled": True, "retired_field": False},
+ }
+ ).encode("utf-8")
+ fake_viking_fs.agfs.files[account_settings_path("default")] = legacy_settings
+
+ settings = await read_account_settings(fake_viking_fs, "default")
+ assert settings.model_dump(exclude_none=True) == {
+ "agent_evolution": {"enabled": False},
+ "acl": {"enabled": True},
+ }
+ assert fake_viking_fs.agfs.files[account_settings_path("default")] == legacy_settings
+
await update_account_settings(fake_viking_fs, "default", _patch(True))
current = fake_viking_fs.agfs.files[account_settings_path("default")]
backup = fake_viking_fs.agfs.files[account_settings_backup_path("default")]
- current_payload = json.loads(current.decode("utf-8"))
- backup_payload = json.loads(backup.decode("utf-8"))
-
- assert current_payload["agent_evolution"]["enabled"] is True
- assert backup_payload["agent_evolution"]["enabled"] is False
+ assert json.loads(current) == {
+ "agent_evolution": {"enabled": True},
+ "acl": {"enabled": True},
+ }
+ assert backup == legacy_settings
async def test_account_settings_admin_api_reads_and_updates_effective_value(
diff --git a/tests/test_config_loader.py b/tests/test_config_loader.py
index 9d45b1df6..8f019b0ef 100644
--- a/tests/test_config_loader.py
+++ b/tests/test_config_loader.py
@@ -176,10 +176,7 @@ def test_queue_worker_concurrency_rejects_non_positive_value(value):
def test_parser_and_compile_api_validation():
- with pytest.raises(ValueError) as exc_info:
- ParserApiConfig(max_concurrent=9)
-
- assert exc_info.value.errors()[0]["type"] == "extra_forbidden"
+ assert ParserApiConfig(max_concurrent=9) == ParserApiConfig()
with pytest.raises(ValueError, match="compile_api.base_url must include scheme"):
CompileApiConfig(base_url="compile.example.com")
@@ -284,20 +281,6 @@ def test_openviking_config_handles_nested_parser_compatibility(monkeypatch):
OpenVikingConfigSingleton,
)
- with pytest.raises(ValueError, match="markdown"):
- OpenVikingConfig.from_dict(
- {
- "embedding": {
- "dense": {
- "provider": "openai",
- "api_key": "test-key",
- "model": "text-embedding-3-small",
- }
- },
- "parsers": {"markdwon": {}},
- }
- )
-
errors: list[str] = []
monkeypatch.setattr(
config_module._get_config_logger(),
@@ -323,50 +306,36 @@ def test_openviking_config_handles_nested_parser_compatibility(monkeypatch):
OpenVikingConfigSingleton.reset_instance()
-def test_openviking_config_rejects_unknown_top_level_section_with_suggestion(monkeypatch):
+def test_openviking_config_ignores_unknown_fields(monkeypatch):
monkeypatch.setenv(OPENVIKING_CONFIG_ENV, "/tmp/codex-no-config.json")
-
- from openviking_cli.utils.config.open_viking_config import (
- OpenVikingConfig,
- OpenVikingConfigSingleton,
- )
-
- with pytest.raises(
- ValueError, match=r"Unknown config field 'erver' in OpenVikingConfig .*'server'"
- ):
- OpenVikingConfig.from_dict(
- {
- "erver": {
- "host": "127.0.0.1",
- "port": 1933,
- "root_api_key": "test",
- "cors_origins": ["*"],
- },
- "embedding": {
- "dense": {
- "provider": "openai",
- "api_key": "test-key",
- "model": "text-embedding-3-small",
- }
- },
- }
- )
-
- OpenVikingConfigSingleton.reset_instance()
-
-
-def test_openviking_config_rejects_unknown_memory_field(monkeypatch):
- monkeypatch.setenv("OPENVIKING_CONFIG_FILE", "/tmp/codex-no-config.json")
-
- from openviking_cli.utils.config.open_viking_config import (
- OpenVikingConfig,
- OpenVikingConfigSingleton,
+ config = OpenVikingConfig.from_dict(
+ {
+ "retired_section": {"enabled": True},
+ "default_user": "alice",
+ "glob": {"retired_field": True, "engine": "fs"},
+ "memory": {"unknown_memory_field": "value", "session_skill_extraction_enabled": True},
+ "storage": {"agfs": {"cache": {"enabled": True}}},
+ "parsers": {
+ "markdwon": {},
+ "memory": {"session_skill_extraction_enabled": False},
+ "markdown": {"unknown_field": True, "max_heading_depth": 4},
+ "code": {"unknown_field": True, "max_line_length": 120},
+ "anydoc": {"unknown_field": True, "max_table_rows": 20},
+ },
+ }
)
- with pytest.raises(ValueError, match="Unknown config field 'memory.unknown_memory_field'"):
- OpenVikingConfig.from_dict({"memory": {"unknown_memory_field": "value"}})
-
- OpenVikingConfigSingleton.reset_instance()
+ assert config.default_user == "alice"
+ assert config.glob.engine == "fs"
+ assert config.memory.session_skill_extraction_enabled is True
+ assert config.markdown.max_heading_depth == 4
+ assert config.code.max_line_length == 120
+ assert config.anydoc.max_table_rows == 20
+ dumped = config.to_dict()
+ assert "retired_section" not in dumped
+ assert "retired_field" not in dumped["glob"]
+ assert "unknown_memory_field" not in dumped["memory"]
+ assert "cache" not in dumped["storage"]["agfs"]
def test_memory_extraction_output_format_defaults_to_python_and_accepts_json(monkeypatch):
@@ -513,12 +482,10 @@ def test_openviking_config_singleton_preserves_value_error_for_bad_config(tmp_pa
from openviking_cli.utils.config.open_viking_config import OpenVikingConfigSingleton
config_path = tmp_path / "ov.conf"
- config_path.write_text(
- '{"erver": {"host": "127.0.0.1"}, "embedding": {"dense": {"provider": "openai", "api_key": "x", "model": "m"}}}'
- )
+ config_path.write_text('{"retrieval": {"hotness_alpha": 1.5}}')
OpenVikingConfigSingleton.reset_instance()
- with pytest.raises(ValueError, match="server"):
+ with pytest.raises(ValueError, match="retrieval.hotness_alpha"):
OpenVikingConfigSingleton.initialize(config_path=str(config_path))
OpenVikingConfigSingleton.reset_instance()
diff --git a/tests/test_server_config_loader.py b/tests/test_server_config_loader.py
index 1ad057166..0414eec6a 100644
--- a/tests/test_server_config_loader.py
+++ b/tests/test_server_config_loader.py
@@ -14,34 +14,30 @@ from openviking.server.config import (
)
-def test_load_server_config_rejects_unknown_field(tmp_path):
- config_path = tmp_path / "ov.conf"
- config_path.write_text(json.dumps({"server": {"host": "0.0.0.0", "prt": 9999}}))
-
- with pytest.raises(
- ValueError,
- match=r"server\.prt'.*server\.port",
- ):
- load_server_config(str(config_path))
-
-
-def test_load_server_config_rejects_unknown_nested_field(tmp_path):
+def test_load_server_config_ignores_unknown_fields(tmp_path):
config_path = tmp_path / "ov.conf"
config_path.write_text(
json.dumps(
{
"server": {
- "observability": {"metrics": {"exporters": {"prometheus": {"enabld": True}}}}
+ "host": "0.0.0.0",
+ "prt": 9999,
+ "queuefs_scope": "process",
+ "observability": {
+ "metrics": {"exporters": {"prometheus": {"enabld": True, "enabled": False}}}
+ },
}
}
)
)
- with pytest.raises(
- ValueError,
- match=r"server\.observability\.metrics\.exporters\.prometheus\.enabld'.*server\.observability\.metrics\.exporters\.prometheus\.enabled",
- ):
- load_server_config(str(config_path))
+ config = load_server_config(str(config_path))
+
+ assert config.host == "0.0.0.0"
+ assert config.port == 1933
+ assert config.observability.metrics.exporters.prometheus.enabled is False
+ assert "prt" not in config.model_dump()
+ assert "queuefs_scope" not in config.model_dump()
def test_load_server_config_reports_invalid_value_path(tmp_path):
@@ -109,14 +105,6 @@ def test_load_server_config_rejects_negative_default_executor_size(tmp_path):
load_server_config(str(config_path))
-def test_load_server_config_rejects_legacy_queuefs_scope(tmp_path):
- config_path = tmp_path / "ov.conf"
- config_path.write_text(json.dumps({"server": {"queuefs_scope": "process"}}))
-
- with pytest.raises(ValueError, match=r"server\.queuefs_scope"):
- load_server_config(str(config_path))
-
-
def test_load_bot_gateway_token_reads_token_from_bot_gateway_section(tmp_path):
config_path = tmp_path / "ov.conf"
config_path.write_text(json.dumps({"bot": {"gateway": {"token": "gateway-token"}}}))