Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

refactor(langchain): clarify session commit policy helper (#2283)

Hao Zhec298f92de0ec
diff --git a/openviking/integrations/langchain/client.py b/openviking/integrations/langchain/client.py
index fef6ff0f6..b9217c44c 100644
--- a/openviking/integrations/langchain/client.py
+++ b/openviking/integrations/langchain/client.py
@@ -158,12 +158,12 @@ def ensure_client(connection: OpenVikingConnection) -> Any:
return client
-def maybe_commit_session(
+def apply_commit_policy(
client: Any,
session_id: str,
policy: OpenVikingCommitPolicy | None,
) -> dict[str, Any] | None:
- """Commit a session if the configured policy says the live tail is ready."""
+ """Apply the configured session commit policy."""
if policy is None or policy.mode == "never":
return None
diff --git a/openviking/integrations/langchain/history.py b/openviking/integrations/langchain/history.py
index f0811fe97..021da6219 100644
--- a/openviking/integrations/langchain/history.py
+++ b/openviking/integrations/langchain/history.py
@@ -25,10 +25,10 @@ except ImportError as exc: # pragma: no cover - exercised by optional import pa
from openviking.integrations.langchain.client import (
OpenVikingCommitPolicy,
OpenVikingConnection,
+ apply_commit_policy,
call_openviking,
ensure_client,
extract_message_text,
- maybe_commit_session,
)
logger = logging.getLogger(__name__)
@@ -121,7 +121,7 @@ class OpenVikingChatMessageHistory(BaseChatMessageHistory):
session_id=self.session_id,
messages=batch,
)
- maybe_commit_session(client, self.session_id, self.commit_policy)
+ apply_commit_policy(client, self.session_id, self.commit_policy)
def clear(self) -> None:
client = self._get_client()
diff --git a/openviking/integrations/langchain/middleware.py b/openviking/integrations/langchain/middleware.py
index 6b4fb59ca..5d07c3133 100644
--- a/openviking/integrations/langchain/middleware.py
+++ b/openviking/integrations/langchain/middleware.py
@@ -26,11 +26,11 @@ except ImportError as exc: # pragma: no cover - exercised by optional import pa
from openviking.integrations.langchain.client import (
OpenVikingCommitPolicy,
OpenVikingConnection,
+ apply_commit_policy,
call_openviking,
ensure_client,
extract_message_text,
get_latest_user_text,
- maybe_commit_session,
)
from openviking.integrations.langchain.context import (
OPENVIKING_CONTEXT_MARKER,
@@ -203,7 +203,7 @@ class OpenVikingContextMiddleware(AgentMiddleware):
added += 1
self._captured_signatures[session_id] = current_signatures
if added:
- maybe_commit_session(client, session_id, self.commit_policy)
+ apply_commit_policy(client, session_id, self.commit_policy)
return None
def _resolve_session_id(self, state: dict[str, Any], runtime: Any) -> str:
diff --git a/tests/unit/test_langchain_integration.py b/tests/unit/test_langchain_integration.py
index 2f2564b60..6b3e62146 100644
--- a/tests/unit/test_langchain_integration.py
+++ b/tests/unit/test_langchain_integration.py
@@ -9,6 +9,7 @@ from langchain_core.messages import AIMessage, HumanMessage, SystemMessage, Tool
from langchain_core.runnables import RunnableLambda
from langgraph.store.base import PutOp
+import openviking.integrations.langchain.client as client_helpers
from openviking.integrations.langchain import (
InMemoryOpenVikingClient,
OpenVikingChatMessageHistory,
@@ -22,9 +23,9 @@ from openviking.integrations.langchain import (
)
from openviking.integrations.langchain.client import (
OpenVikingConnection,
+ apply_commit_policy,
call_openviking,
ensure_client,
- maybe_commit_session,
)
from openviking.integrations.langchain.history import (
langchain_message_to_openviking,
@@ -34,6 +35,11 @@ from openviking.integrations.langchain.middleware import _message_signature
from openviking.integrations.langchain.tools import _archive_grep_pattern
+def test_langchain_client_exposes_apply_commit_policy_without_legacy_alias():
+ assert hasattr(client_helpers, "apply_commit_policy")
+ assert not hasattr(client_helpers, "maybe_commit_session")
+
+
def test_retriever_returns_langchain_documents():
client = InMemoryOpenVikingClient(
{
@@ -958,7 +964,7 @@ def test_langgraph_store_uses_create_first_and_preserves_created_at_on_replace()
def test_pending_token_commit_does_not_create_missing_session():
client = InMemoryOpenVikingClient()
- result = maybe_commit_session(
+ result = apply_commit_policy(
client,
"missing-commit-session",
OpenVikingCommitPolicy(mode="pending_tokens", pending_token_threshold=1),