Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
Block deleting protected VikingFS roots (#2873)
Zayn Jarvisc528dfd1afde
diff --git a/openviking/storage/viking_fs.py b/openviking/storage/viking_fs.pyindex 4de90be41..b1af53dc1 100644--- a/openviking/storage/viking_fs.py+++ b/openviking/storage/viking_fs.py@@ -357,6 +357,35 @@ class VikingFS:resource=normalized_uri,)+ def _ensure_delete_access(self, uri: str, ctx: Optional[RequestContext]) -> None:+ self._ensure_access(uri, ctx)+ real_ctx = self._ctx_or_default(ctx)+ normalized_uri, _ = self._normalized_uri_parts(uri)+ if is_hidden_by_actor_peer_view(normalized_uri, real_ctx) or may_include_hidden_actor_peers(+ normalized_uri, real_ctx+ ):+ raise PermissionDeniedError(f"Access denied for {uri}", resource=normalized_uri)+ self._ensure_supported_delete_namespace(normalized_uri)+ if real_ctx.role != Role.ROOT and normalized_uri.rstrip("/") == "viking://temp":+ raise PermissionDeniedError(+ "Temp root is read-only for non-root users",+ resource=normalized_uri,+ )++ def _ensure_supported_delete_namespace(self, normalized_uri: str) -> None:+ parts = [p for p in normalized_uri[len("viking://") :].strip("/").split("/") if p]+ if not parts:+ raise PermissionDeniedError(+ "Deleting viking:// is not supported; use a concrete scope instead.",+ resource=normalized_uri,+ )+ if parts == ["user"]:+ raise PermissionDeniedError(+ "Deleting viking://user is not supported; use an explicit user namespace "+ "or current-user content path instead.",+ resource=normalized_uri,+ )+def _ensure_supported_write_namespace(self, normalized_uri: str) -> None:parts = [p for p in normalized_uri[len("viking://") :].strip("/").split("/") if p]if parts == ["user"]:@@ -480,7 +509,7 @@ class VikingFS:from openviking.storage.errors import LockAcquisitionError, ResourceBusyErrorfrom openviking.storage.transaction import LockContext, get_lock_manager- self._ensure_mutable_access(uri, ctx)+ self._ensure_delete_access(uri, ctx)path = self._uri_to_path(uri, ctx=ctx)target_uri = self._path_to_uri(path, ctx=ctx)diff --git a/tests/misc/test_vikingfs_uri_guard.py b/tests/misc/test_vikingfs_uri_guard.pyindex e6a53f6fe..f64d2122f 100644--- a/tests/misc/test_vikingfs_uri_guard.py+++ b/tests/misc/test_vikingfs_uri_guard.py@@ -8,8 +8,10 @@ from unittest.mock import AsyncMock, MagicMockimport pytestfrom openviking.pyagfs.exceptions import AGFSInvalidOperationError+from openviking.server.identity import RequestContext, Rolefrom openviking.storage.viking_fs import VikingFSfrom openviking_cli.exceptions import PermissionDeniedError+from openviking_cli.session.user_id import UserIdentifierdef _make_viking_fs() -> VikingFS:@@ -19,12 +21,20 @@ def _make_viking_fs() -> VikingFS:fs._async_agfs = fs.agfsfs.query_embedder = Nonefs.rerank_config = None+ fs.grep_config = Nonefs.vector_store = Nonefs._encryptor = Nonefs._bound_ctx = contextvars.ContextVar("vikingfs_bound_ctx_test", default=None)return fs+def _user_ctx(account_id: str = "acct1", user_id: str = "alice") -> RequestContext:+ return RequestContext(+ user=UserIdentifier(account_id=account_id, user_id=user_id),+ role=Role.USER,+ )++class TestVikingFSURITraversalGuard:"""Traversal-style URI components should be rejected before any AGFS I/O."""@@ -93,6 +103,68 @@ class TestVikingFSURITraversalGuard:fs._delete_from_vector_store.assert_not_called()fs.agfs.rm.assert_not_called()+ @pytest.mark.asyncio+ @pytest.mark.parametrize(+ "uri",+ [+ "viking://",+ "/",+ "viking://user",+ "viking://user/",+ "/user",+ "user",+ ],+ )+ async def test_rm_rejects_protected_namespace_roots_before_side_effects(+ self, uri: str+ ) -> None:+ fs = _make_viking_fs()+ fs._collect_uris = AsyncMock(return_value=[])+ fs._delete_from_vector_store = AsyncMock()++ with pytest.raises(PermissionDeniedError, match="Deleting viking://"):+ await fs.rm(uri, recursive=True)++ fs._collect_uris.assert_not_called()+ fs._delete_from_vector_store.assert_not_called()+ fs.agfs.stat.assert_not_called()+ fs.agfs.rm.assert_not_called()++ @pytest.mark.parametrize("uri", ["viking://resources", "viking://session"])+ @pytest.mark.asyncio+ async def test_rm_allows_public_scope_roots_to_reach_agfs(self, uri: str) -> None:+ fs = _make_viking_fs()+ fs.agfs.stat = AsyncMock(side_effect=RuntimeError("sentinel"))++ with pytest.raises(RuntimeError, match="sentinel"):+ await fs.rm(uri, recursive=True)++ fs.agfs.stat.assert_called_once()++ @pytest.mark.asyncio+ async def test_rm_session_root_is_scoped_to_current_user_before_agfs(self) -> None:+ fs = _make_viking_fs()+ fs.agfs.stat = AsyncMock(side_effect=RuntimeError("sentinel"))++ with pytest.raises(RuntimeError, match="sentinel"):+ await fs.rm("viking://session", recursive=True, ctx=_user_ctx())++ fs.agfs.stat.assert_called_once_with("/local/acct1/user/alice/sessions")++ @pytest.mark.asyncio+ async def test_rm_rejects_temp_root_for_non_root_before_side_effects(self) -> None:+ fs = _make_viking_fs()+ fs._collect_uris = AsyncMock(return_value=[])+ fs._delete_from_vector_store = AsyncMock()++ with pytest.raises(PermissionDeniedError, match="Temp root is read-only"):+ await fs.rm("viking://temp", recursive=True, ctx=_user_ctx())++ fs._collect_uris.assert_not_called()+ fs._delete_from_vector_store.assert_not_called()+ fs.agfs.stat.assert_not_called()+ fs.agfs.rm.assert_not_called()+@pytest.mark.asyncio@pytest.mark.parametrize(("old_uri", "new_uri"),