Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

feat(auth): support trusted group header (#6396)

xingooce42a166b785
diff --git a/openviking/server/auth/__init__.py b/openviking/server/auth/__init__.py
index 46b72e95e..9ecf4f49c 100644
--- a/openviking/server/auth/__init__.py
+++ b/openviking/server/auth/__init__.py
@@ -121,14 +121,17 @@ async def _build_request_context(
plugin.get_request_context_checks(request.url.path, identity)
account_id = identity.account_id or "default"
user_id = identity.user_id or "default"
+ group_ids = identity.group_ids
+ if (
+ not group_ids
+ and identity.role != Role.ROOT
+ and _uses_local_account_store(plugin)
+ ):
+ group_ids = await resolve_group_ids(request, account_id, user_id)
ctx = RequestContext(
user=UserIdentifier(account_id, user_id),
role=identity.role,
- group_ids=(
- await resolve_group_ids(request, account_id, user_id)
- if identity.role != Role.ROOT and _uses_local_account_store(plugin)
- else ()
- ),
+ group_ids=group_ids,
actor_peer_id=actor_peer_id,
from_oauth=identity.from_oauth,
api_key=api_key,
diff --git a/openviking/server/auth/plugins/trusted.py b/openviking/server/auth/plugins/trusted.py
index c2c7f80ca..0c9b85ff5 100644
--- a/openviking/server/auth/plugins/trusted.py
+++ b/openviking/server/auth/plugins/trusted.py
@@ -15,6 +15,7 @@ from fastapi import Request
from openviking.core.identifiers import (
validate_account_id,
validate_identifier_length,
+ validate_identifier_part,
validate_user_id,
)
from openviking.server.api_keys import APIKeyManager
@@ -26,6 +27,7 @@ from openviking_cli.exceptions import InvalidArgumentError, UnauthenticatedError
from openviking_cli.utils import get_logger
_TRUSTED_ROLE_HEADER = "X-OpenViking-Role"
+_TRUSTED_GROUPS_HEADER = "X-OpenViking-Groups"
_TRUSTED_ASSERTABLE_ROLES = {
Role.USER: Role.USER,
Role.ADMIN: Role.ADMIN,
@@ -86,6 +88,24 @@ def _asserted_role_from_header(request: Request, *, allow_assertion: bool) -> Op
return _TRUSTED_ASSERTABLE_ROLES[role]
+def _group_ids_from_header(request: Request) -> tuple[str, ...]:
+ raw_groups = request.headers.get(_TRUSTED_GROUPS_HEADER)
+ if raw_groups is None:
+ return ()
+ group_ids: list[str] = []
+ seen: set[str] = set()
+ for raw_group_id in raw_groups.split(","):
+ group_id = raw_group_id.strip()
+ if not group_id:
+ continue
+ if error := validate_identifier_part(group_id, "group_id"):
+ raise InvalidArgumentError(error)
+ if group_id not in seen:
+ group_ids.append(group_id)
+ seen.add(group_id)
+ return tuple(group_ids)
+
+
class TrustedAuthPlugin(AuthPlugin):
"""Trusted mode: trust X-OpenViking-Account/User headers.
@@ -183,6 +203,7 @@ class TrustedAuthPlugin(AuthPlugin):
role=trusted_role,
account_id=effective_account_id,
user_id=effective_user_id,
+ group_ids=_group_ids_from_header(request),
)
if (
self.should_auto_register_trusted_identity(request)
diff --git a/openviking/server/identity.py b/openviking/server/identity.py
index 5b42515de..25a79c9e3 100644
--- a/openviking/server/identity.py
+++ b/openviking/server/identity.py
@@ -81,6 +81,9 @@ class ResolvedIdentity:
role: Role
account_id: Optional[str] = None
user_id: Optional[str] = None
+ # Trusted auth plugins may attach a request-scoped group snapshot. Empty
+ # means callers should fall back to the server-managed group registry.
+ group_ids: tuple[str, ...] = ()
# True when this identity was minted from an OAuth-issued bearer token;
# downstream checks (e.g. ROOT-requires-explicit-tenant headers) can skip
# rules that target raw API-key auth, since OAuth claims already pin
diff --git a/tests/server/test_identity_auth.py b/tests/server/test_identity_auth.py
index aa65077d6..f84d71102 100644
--- a/tests/server/test_identity_auth.py
+++ b/tests/server/test_identity_auth.py
@@ -124,6 +124,61 @@ async def test_trusted_explicit_user_role_with_root_key(runtime):
assert identity.role == Role.USER
+async def test_trusted_group_header_overrides_internal_group_lookup(runtime):
+ await runtime.create_group("acme", "local-team")
+ await runtime.add_group_member("acme", "local-team", "alice")
+ request = await make_request(
+ runtime,
+ "trusted",
+ "root",
+ headers=[(b"x-openviking-groups", b"gateway-team, finance, gateway-team")],
+ )
+ plugin = request.app.state.auth_plugin
+
+ identity = await plugin.resolve_identity(
+ request, api_key="root", x_openviking_account="acme", x_openviking_user="alice"
+ )
+ ctx = await get_request_context(request, identity, None, "root", None)
+
+ assert identity.group_ids == ("gateway-team", "finance")
+ assert ctx.group_ids == ("gateway-team", "finance")
+
+
+async def test_trusted_empty_group_header_falls_back_to_internal_group_lookup(runtime):
+ await runtime.create_group("acme", "local-team")
+ await runtime.add_group_member("acme", "local-team", "alice")
+ request = await make_request(
+ runtime,
+ "trusted",
+ "root",
+ headers=[(b"x-openviking-groups", b" , ")],
+ )
+ plugin = request.app.state.auth_plugin
+
+ identity = await plugin.resolve_identity(
+ request, api_key="root", x_openviking_account="acme", x_openviking_user="alice"
+ )
+ ctx = await get_request_context(request, identity, None, "root", None)
+
+ assert identity.group_ids == ()
+ assert ctx.group_ids == ("local-team",)
+
+
+async def test_trusted_group_header_rejects_invalid_group_id(runtime):
+ request = await make_request(
+ runtime,
+ "trusted",
+ "root",
+ headers=[(b"x-openviking-groups", b"good,bad/group")],
+ )
+ plugin = request.app.state.auth_plugin
+
+ with pytest.raises(InvalidArgumentError, match="group_id"):
+ await plugin.resolve_identity(
+ request, api_key="root", x_openviking_account="acme", x_openviking_user="alice"
+ )
+
+
async def test_oversized_trusted_identity_does_not_block_valid_registration(runtime):
request = await make_request(runtime, "trusted", trusted_flush_interval=300)
plugin = request.app.state.auth_plugin