Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(tasks): treat missing task records as deleted (#4907)
Qin Haojiecf0fb06d0ef6
diff --git a/openviking/service/task_store.py b/openviking/service/task_store.pyindex cd9e4ff2c..d410a2978 100644--- a/openviking/service/task_store.py+++ b/openviking/service/task_store.py@@ -91,13 +91,17 @@ class PersistentTaskStore:return tasksasync def delete(self, task_id: str, *, account_id: str, user_id: Optional[str] = None) -> None:+ """Delete a task record, succeeding if it has already been removed."""if not user_id:return- await self._agfs.rm(- self._task_path(account_id, user_id, task_id),- force=True,- auto_pathlock=False,- )+ try:+ await self._agfs.rm(+ self._task_path(account_id, user_id, task_id),+ force=True,+ auto_pathlock=False,+ )+ except (AGFSNotFoundError, FileNotFoundError):+ returnasync def _write_task(self, task: Any) -> None:account_id = getattr(task, "account_id", None)diff --git a/tests/test_task_tracker.py b/tests/test_task_tracker.pyindex f41926c95..aaa664b63 100644--- a/tests/test_task_tracker.py+++ b/tests/test_task_tracker.py@@ -10,7 +10,7 @@ from copy import deepcopyimport pytest-from openviking.pyagfs.exceptions import AGFSAlreadyExistsError+from openviking.pyagfs.exceptions import AGFSAlreadyExistsError, AGFSNotFoundErrorfrom openviking.server.identity import RequestContext, Rolefrom openviking.service.session_service import SessionServicefrom openviking.service.task_store import PersistentTaskStore, _task_to_payload@@ -140,7 +140,9 @@ class _FakeAgfs:)if self.fail_rm:raise OSError("simulated delete failure")- self.files.pop(path, None)+ if path not in self.files:+ raise AGFSNotFoundError(path)+ del self.files[path]return {"message": "removed", "recursive": recursive, "force": force}@@ -524,11 +526,16 @@ async def test_sanitize_preserves_safe_error():# ── TTL / Eviction ──-async def test_evict_expired_completed(tracker: TaskTracker):[email protected]("already_missing", [False, True])+async def test_evict_expired_completed(already_missing):+ agfs = _FakeAgfs()+ tracker = TaskTracker(store=PersistentTaskStore(agfs))t = await tracker.create("session_commit", **_owner_kwargs())await tracker.start(t.task_id)await tracker.complete(t.task_id, {})assert await tracker._store.get(t.task_id, **_owner_kwargs()) is not None+ if already_missing:+ agfs.files.clear()# Simulate old timestamp (access internal state; get() returns defensive copies)tracker._tasks[t.task_id].updated_at = time.time() - tracker.TTL_COMPLETED - 1await tracker._evict_expired()