Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(recall): hide memory fields metadata (#3240)

huangruitengd14c0673cacb
diff --git a/openviking/retrieve/type_quota_recall.py b/openviking/retrieve/type_quota_recall.py
index b9672d9ed..616060e74 100644
--- a/openviking/retrieve/type_quota_recall.py
+++ b/openviking/retrieve/type_quota_recall.py
@@ -16,6 +16,7 @@ from typing import Any, Mapping
from openviking.core.namespace import canonical_user_root
from openviking.server.identity import RequestContext
+from openviking.session.memory.utils.memory_file_utils import MemoryFileUtils
TYPE_ORDER = ("events", "entities", "preferences", "experiences")
DEFAULT_QUOTAS = {"events": 10, "entities": 10, "preferences": 3, "experiences": 0}
@@ -399,7 +400,11 @@ async def search_type_quota_recall(
abstract = _abstract(item)
content = ""
try:
- content = await service.fs.read(uri, ctx=read_ctx)
+ raw_content = await service.fs.read(uri, ctx=read_ctx)
+ if isinstance(raw_content, bytes):
+ raw_content = raw_content.decode("utf-8")
+ if isinstance(raw_content, str):
+ content = MemoryFileUtils.read(raw_content, uri=uri).content
except Exception:
content = ""
diff --git a/tests/retrieve/test_type_quota_recall.py b/tests/retrieve/test_type_quota_recall.py
index 2efa528ec..bbc94d032 100644
--- a/tests/retrieve/test_type_quota_recall.py
+++ b/tests/retrieve/test_type_quota_recall.py
@@ -112,3 +112,51 @@ async def test_parallel_search_preserves_type_order():
assert [entry.type for entry in result.entries] == ["events", "entities"]
assert [entry.rank for entry in result.entries] == [1, 1]
+
+
+async def test_recall_hides_persisted_memory_fields_metadata():
+ memory_uri = "viking://user/test_user/memories/events/example.md"
+ raw_memory = """Visible memory body
+
+<!-- MEMORY_FIELDS
+{
+ "event_name": "internal-event",
+ "user_id": "test_user",
+ "memory_type": "events"
+}
+-->"""
+
+ async def fake_find(**kwargs):
+ if kwargs["target_uri"].endswith("/events") and "/peers/" not in kwargs["target_uri"]:
+ return _FakeFindResult([{"uri": memory_uri, "score": 0.9}])
+ return _FakeFindResult()
+
+ async def fake_read(uri, **kwargs):
+ del kwargs
+ assert uri == memory_uri
+ return raw_memory
+
+ service = SimpleNamespace(
+ search=SimpleNamespace(find=fake_find),
+ fs=SimpleNamespace(read=fake_read),
+ )
+ ctx = RequestContext(
+ user=UserIdentifier.the_default_user("test_user"),
+ role=Role.USER,
+ actor_peer_id="current",
+ )
+
+ result = await search_type_quota_recall(
+ service=service,
+ ctx=ctx,
+ query="visible memory",
+ peer_scope="actor",
+ quotas={"events": 1, "entities": 0, "preferences": 0, "experiences": 0},
+ max_chars=10_000,
+ )
+
+ assert len(result.entries) == 1
+ assert result.entries[0].content == "Visible memory body"
+ assert "Visible memory body" in result.rendered
+ assert "MEMORY_FIELDS" not in result.rendered
+ assert "internal-event" not in result.rendered