Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(memory): restore vectorization after redo recovery (#3331)
huangruitengd16a92c63f97
diff --git a/openviking/session/memory/streaming_memory_updater.py b/openviking/session/memory/streaming_memory_updater.pyindex 73ec93463..540cc1432 100644--- a/openviking/session/memory/streaming_memory_updater.py+++ b/openviking/session/memory/streaming_memory_updater.py@@ -1826,6 +1826,12 @@ async def get_streaming_memory_updater(with _streaming_memory_updater_registry_lock:existing = _streaming_memory_updater_registry.get(key)if existing is not None:+ # Redo recovery can create the process-global updater before the+ # service compressor is available, using ``vikingdb=None``. Do+ # not let that degraded first caller permanently disable+ # vectorization for later normal commits with the same user key.+ if vikingdb is not None and existing.vikingdb is not vikingdb:+ existing.vikingdb = vikingdbreturn existingupdater = StreamingMemoryUpdater(registry=registry,diff --git a/tests/session/memory/test_streaming_memory_updater.py b/tests/session/memory/test_streaming_memory_updater.pyindex a5a1e54a5..a4d0fa03c 100644--- a/tests/session/memory/test_streaming_memory_updater.py+++ b/tests/session/memory/test_streaming_memory_updater.py@@ -30,6 +30,7 @@ from openviking.session.memory.streaming_memory_updater import (StreamingMemoryUpdateResult,classify_memory_merge_mode,enforce_merge_group_peer_id,+ get_streaming_memory_updater,merge_one_memory_type_operations,operation_to_patch,render_operation_after_file_content,@@ -318,6 +319,88 @@ async def test_streaming_memory_updater_submit_applies_fast_path(monkeypatch):assert "重复预订处理" in written_content+async def test_cached_updater_restores_vectorization_for_tool_and_skill_memories(monkeypatch):+ fs = InMemoryVikingFS({})+ fs.search = AsyncMock(return_value=[])+ monkeypatch.setattr(+ "openviking.session.memory.streaming_memory_updater.get_viking_fs",+ lambda: fs,+ )+ monkeypatch.setattr(+ "openviking.session.memory.memory_updater.get_viking_fs",+ lambda: fs,+ )++ registry = _registry()+ for memory_type, name_field in (("tools", "tool_name"), ("skills", "skill_name")):+ registry.register(+ MemoryTypeSchema(+ memory_type=memory_type,+ description=f"{memory_type} memory",+ directory=f"viking://user/{{{{ user_space }}}}/memories/{memory_type}",+ filename_template=f"{{{{ {name_field} }}}}.md",+ operation_mode="add_only",+ content_template=f"{memory_type}: {{{{ {name_field} }}}}",+ fields=[+ MemoryField(+ name=name_field,+ field_type=FieldType.STRING,+ merge_op=MergeOp.IMMUTABLE,+ )+ ],+ )+ )++ key = ("cached-updater-vectorization", id(fs))+ degraded = await get_streaming_memory_updater(+ key=key,+ registry=registry,+ vikingdb=None,+ )+ vikingdb = AsyncMock()+ vikingdb.enqueue_embedding_msg.return_value = True+ restored = await get_streaming_memory_updater(+ key=key,+ registry=registry,+ vikingdb=vikingdb,+ )++ assert restored is degraded+ assert restored.vikingdb is vikingdb++ operations = []+ for memory_type, name_field, name in (+ ("tools", "tool_name", "terminal"),+ ("skills", "skill_name", "analyze_code"),+ ):+ operations.append(+ ResolvedOperation(+ old_memory_file_content=None,+ memory_type=memory_type,+ uris=[f"viking://user/u/memories/{memory_type}/{name}.md"],+ memory_fields={name_field: name},+ )+ )++ result = await restored.submit(+ MemoryUpdateRequest(+ operations=ResolvedOperations(+ upsert_operations=operations,+ delete_file_contents=[],+ errors=[],+ ),+ messages=[Message(id="m1", role="user", parts=[TextPart("use tools and skills")])],+ ctx=_ctx(),+ )+ )++ assert sorted(result.apply_result.written_uris) == sorted(+ operation.uris[0] for operation in operations+ )+ assert vikingdb.enqueue_embedding_msg.await_count == 2++@pytest.mark.asyncioasync def test_streaming_memory_updater_fast_path_filters_links(monkeypatch):fs = InMemoryVikingFS(