Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(session): handle non-dict LLM responses in memory extraction (#618)
Matt Van Hornd204bd04c1c7
diff --git a/openviking/session/memory_extractor.py b/openviking/session/memory_extractor.pyindex 4130880e3..46917f47d 100644--- a/openviking/session/memory_extractor.py+++ b/openviking/session/memory_extractor.py@@ -294,10 +294,19 @@ class MemoryExtractor:response = await vlm.get_completion_async(prompt)logger.debug("Memory extraction LLM raw response: %s", response)data = parse_json_from_response(response) or {}+ if isinstance(data, list):+ logger.warning(+ "Memory extraction received list instead of dict; wrapping as memories"+ )+ data = {"memories": data}+ elif not isinstance(data, dict):+ logger.warning(+ "Memory extraction received unexpected type %s; skipping", type(data).__name__+ )+ data = {}logger.debug("Memory extraction LLM parsed payload: %s", data)candidates = []- # print(f"memories = {data.get('memories', [])}")for mem in data.get("memories", []):category_str = mem.get("category", "patterns")try:diff --git a/tests/session/test_memory_extractor_response_types.py b/tests/session/test_memory_extractor_response_types.pynew file mode 100644index 000000000..ff2b26fd5--- /dev/null+++ b/tests/session/test_memory_extractor_response_types.py@@ -0,0 +1,77 @@+# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.+# SPDX-License-Identifier: Apache-2.0+"""+Tests that memory extraction handles non-dict LLM responses gracefully.++Covers issue #605: Ollama models may return a JSON list instead of the+expected {"memories": [...]} dict, causing AttributeError on .get().+"""+++def _normalize_parsed_data(data):+ """+ Replicate the type-checking logic added in memory_extractor.py:extract().++ After ``parse_json_from_response(response) or {}``, the code now does:+ - list -> wrap as ``{"memories": data}``+ - dict -> use as-is+ - other -> fall back to ``{}``+ """+ if isinstance(data, list):+ return {"memories": data}+ if not isinstance(data, dict):+ return {}+ return data+++def _make_memory(category="patterns", content="user prefers dark mode"):+ return {"category": category, "content": content, "event": "", "emoji": ""}+++class TestExtractResponseTypes:+ """Verify the type-normalization handles dict, list, and unexpected types."""++ def test_dict_response_passes_through(self):+ """Standard dict format: {"memories": [...]}"""+ payload = {"memories": [_make_memory()]}+ data = _normalize_parsed_data(payload)++ assert isinstance(data, dict)+ assert len(data.get("memories", [])) == 1+ assert data["memories"][0]["content"] == "user prefers dark mode"++ def test_list_response_wrapped_as_memories(self):+ """Ollama-style list format: [{...}, {...}] wrapped into {"memories": [...]}"""+ memories_list = [_make_memory(), _make_memory(content="likes Python")]+ data = _normalize_parsed_data(memories_list)++ assert isinstance(data, dict)+ assert len(data["memories"]) == 2+ assert data["memories"][1]["content"] == "likes Python"++ def test_string_response_yields_empty(self):+ """If parse returns a bare string, treat as empty."""+ data = _normalize_parsed_data("some unexpected string")++ assert data == {}+ assert data.get("memories", []) == []++ def test_none_fallback_yields_empty(self):+ """If parse returns None, the ``or {}`` fallback produces empty dict."""+ data = _normalize_parsed_data(None or {})++ assert data == {}+ assert data.get("memories", []) == []++ def test_int_response_yields_empty(self):+ """Numeric responses should be treated as empty."""+ data = _normalize_parsed_data(42)++ assert data == {}++ def test_empty_list_wraps_to_empty_memories(self):+ """An empty list should produce {"memories": []}."""+ data = _normalize_parsed_data([])++ assert data == {"memories": []}+ assert data.get("memories", []) == []