Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(session): pass memory_policy through CreateSessionOptions (#4495)

Ramid5bd4fd7a8a9
diff --git a/bot/tests/test_openviking_api_key_type.py b/bot/tests/test_openviking_api_key_type.py
index 7b5c973f0..0ef698403 100644
--- a/bot/tests/test_openviking_api_key_type.py
+++ b/bot/tests/test_openviking_api_key_type.py
@@ -54,8 +54,11 @@ class _DummyHTTPClient:
async def initialize(self):
return None
- async def create_session(self, session_id=None, memory_policy=None):
- return {"session_id": session_id or "s-1", "memory_policy": memory_policy}
+ async def create_session(self, session_id=None, options=None):
+ return {
+ "session_id": session_id or "s-1",
+ "memory_policy": (options or {}).get("memory_policy"),
+ }
async def session_exists(self, _session_id):
return False
@@ -1896,9 +1899,9 @@ async def test_viking_client_ensure_session_creates_after_legacy_not_found(monke
async def _get_session(_session_id):
raise NotFoundError("Resource not found")
- async def _create_session(session_id=None, memory_policy=None):
- created.append((session_id, memory_policy))
- return {"session_id": session_id, "memory_policy": memory_policy}
+ async def _create_session(session_id=None, options=None):
+ created.append((session_id, options))
+ return {"session_id": session_id, "memory_policy": (options or {}).get("memory_policy")}
monkeypatch.setattr(client.client, "get_session", _get_session)
monkeypatch.setattr(client.client, "create_session", _create_session)
@@ -1909,7 +1912,7 @@ async def test_viking_client_ensure_session_creates_after_legacy_not_found(monke
)
assert result == {"session_id": "session-1", "memory_policy": {"strategy": "compact"}}
- assert created == [("session-1", {"strategy": "compact"})]
+ assert created == [("session-1", {"memory_policy": {"strategy": "compact"}})]
@pytest.mark.asyncio
diff --git a/bot/vikingbot/openviking_mount/ov_server.py b/bot/vikingbot/openviking_mount/ov_server.py
index bc46ec3b8..14a6fccee 100644
--- a/bot/vikingbot/openviking_mount/ov_server.py
+++ b/bot/vikingbot/openviking_mount/ov_server.py
@@ -1169,7 +1169,7 @@ class VikingClient:
return await client.create_session(
session_id=session_id,
- memory_policy=memory_policy,
+ options={"memory_policy": memory_policy} if memory_policy else None,
)
@staticmethod
diff --git a/openviking/ingest/replay.py b/openviking/ingest/replay.py
index 2e4a1ca0c..daf1c8c5f 100644
--- a/openviking/ingest/replay.py
+++ b/openviking/ingest/replay.py
@@ -68,7 +68,8 @@ class ConversationReplayClient:
return await self._client.get_session(ov_session_id)
except NotFoundError:
return await self._client.create_session(
- session_id=ov_session_id, memory_policy=memory_policy or None
+ session_id=ov_session_id,
+ options={"memory_policy": memory_policy} if memory_policy else None,
)
async def append(self, ov_session_id: str, messages: List[Dict[str, Any]]) -> int:
diff --git a/openviking/session/train/components/session_commit.py b/openviking/session/train/components/session_commit.py
index 50eab2323..b2a003cf1 100644
--- a/openviking/session/train/components/session_commit.py
+++ b/openviking/session/train/components/session_commit.py
@@ -134,7 +134,7 @@ class SessionCommitPolicyTrainer:
stage = "create_session"
await self.client.create_session(
session_id=session_id,
- memory_policy=_training_commit_memory_policy(),
+ options={"memory_policy": _training_commit_memory_policy()},
)
stage = "batch_add_messages"
await self._batch_add_messages(session_id, messages)
diff --git a/tests/ingest/test_replay.py b/tests/ingest/test_replay.py
index ddc8af53f..8c9fcd50f 100644
--- a/tests/ingest/test_replay.py
+++ b/tests/ingest/test_replay.py
@@ -22,8 +22,8 @@ class _FakeSDK:
raise NotFoundError(sid, "session")
return {"session_id": sid, "pending_tokens": 0, "message_count": 0}
- async def create_session(self, session_id=None, memory_policy=None):
- self.created.append(session_id)
+ async def create_session(self, session_id=None, options=None):
+ self.created.append((session_id, options))
self.existing.add(session_id)
return {"session_id": session_id}
@@ -40,9 +40,12 @@ async def test_ensure_session_get_or_create():
sdk = _FakeSDK()
client = ConversationReplayClient(sdk)
await client.ensure_session("s1") # not present -> create
- assert sdk.created == ["s1"]
+ assert sdk.created == [("s1", None)]
await client.ensure_session("s1") # now present -> no second create
- assert sdk.created == ["s1"]
+ assert sdk.created == [("s1", None)]
+ # a memory policy travels inside CreateSessionOptions, not as a keyword
+ await client.ensure_session("s2", {"working_memory": {"enabled": False}})
+ assert sdk.created[-1] == ("s2", {"memory_policy": {"working_memory": {"enabled": False}}})
async def test_append_chunks_at_100():
diff --git a/tests/session/train/test_train_framework.py b/tests/session/train/test_train_framework.py
index 26e250da4..655f94fdc 100644
--- a/tests/session/train/test_train_framework.py
+++ b/tests/session/train/test_train_framework.py
@@ -1206,8 +1206,8 @@ class FakeSessionCommitClient:
self.committed_sessions = []
self.task_poll_counts = {}
- async def create_session(self, *, session_id, memory_policy=None):
- self.created_sessions.append((session_id, memory_policy))
+ async def create_session(self, session_id=None, options=None):
+ self.created_sessions.append((session_id, options))
async def batch_add_messages(self, session_id, messages):
self.messages.setdefault(session_id, []).extend(messages)
@@ -1257,8 +1257,10 @@ async def test_session_commit_policy_trainer_records_commit_trace_id():
(
commit_result["session_id"],
{
- "memory_types": ["cases", "trajectories", "experiences"],
- "working_memory": {"enabled": False},
+ "memory_policy": {
+ "memory_types": ["cases", "trajectories", "experiences"],
+ "working_memory": {"enabled": False},
+ }
},
)
]