Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(pack): preserve restricted resources during account maintenance (#5213)
Jp121987dbffe537e08e
diff --git a/openviking/service/pack_service.py b/openviking/service/pack_service.pyindex e786048ac..3f3fc5a82 100644--- a/openviking/service/pack_service.py+++ b/openviking/service/pack_service.py@@ -51,6 +51,9 @@ class PackService:user=ctx.user,role=Role.ROOT,from_oauth=ctx.from_oauth,+ # ROOT opens user namespaces but does not inherit ADMIN's resource+ # ACL authority. Account maintenance must include restricted resources.+ bypass_acl=True,)async def export_ovpack(diff --git a/tests/misc/test_ovpack_import_policy.py b/tests/misc/test_ovpack_import_policy.pyindex 29ef18b4f..7f93a3440 100644--- a/tests/misc/test_ovpack_import_policy.py+++ b/tests/misc/test_ovpack_import_policy.py@@ -16,6 +16,7 @@ import pytestfrom openviking.server.identity import RequestContext, Rolefrom openviking.service.pack_service import PackService+from openviking.storage.acl import AclManager, AclModefrom openviking.storage.index_consistency import IndexConsistencyReport, IndexExpectationfrom openviking.storage.ovpack.operations import (backup_ovpack,@@ -23,8 +24,10 @@ from openviking.storage.ovpack.operations import (import_ovpack,restore_ovpack,)-from openviking_cli.exceptions import InvalidArgumentError, NotFoundError+from openviking_cli.exceptions import InvalidArgumentError, NotFoundError, PermissionDeniedErrorfrom openviking_cli.session.user_id import UserIdentifier+from tests.storage.test_transfer_merge_binding import binding_fs as binding_fs+from tests.storage.test_transfer_merge_binding import indexed_fs as indexed_fsclass FakeVikingFS:@@ -1119,3 +1122,104 @@ async def test_import_top_level_scope_package_requires_root_target(await import_ovpack(FakeVikingFS(), str(temp_ovpack_path), "viking://resources", request_ctx)+++async def _restricted_pack_source(indexed_fs):+ fs, backend = indexed_fs+ admin = RequestContext(user=UserIdentifier("acct", "admin"), role=Role.ADMIN)+ reader = RequestContext(user=UserIdentifier("acct", "reader"), role=Role.USER)+ outsider = RequestContext(user=UserIdentifier("acct", "outsider"), role=Role.USER)+ root = "viking://resources/repo"+ original = root + "/nested/guide.md"+ await fs.write_file_bytes(original, b"# Current operating guide\n", ctx=admin)+ for uri, level in [(root, 1), (root + "/nested", 1), (original, 2)]:+ await backend.upsert(+ {+ "id": uri,+ "uri": uri,+ "account_id": admin.account_id,+ "level": level,+ "vector": [0.1, 0.2, 0.3, 0.4],+ },+ ctx=admin,+ )+ acl = AclManager(backend)+ acl.set_enabled(admin.account_id, True)+ fs.acl_manager = backend.acl_manager = acl+ await fs.set_acl(+ root,+ entries=[{"principal": "user:reader", "level": "read"}],+ acl_mode=AclMode.RESTRICTED,+ ctx=admin,+ )+ assert await fs.read_file_bytes(original, ctx=reader) == b"# Current operating guide\n"+ with pytest.raises(PermissionDeniedError):+ await fs.read_file_bytes(original, ctx=outsider)+ return fs, admin, reader, outsider, original+++async def test_account_backup_includes_restricted_originals_without_crossing_accounts(+ indexed_fs, tmp_path+):+ fs, admin, reader, outsider, original = await _restricted_pack_source(indexed_fs)+ peer_uri = "viking://user/reader/memories/notes.md"+ await fs.write_file_bytes(peer_uri, b"same-account private notes", ctx=reader)+ other_admin = RequestContext(user=UserIdentifier("other", "admin"), role=Role.ADMIN)+ other_uri = "viking://resources/other-account-only.md"+ await fs.write_file_bytes(other_uri, b"other-account content", ctx=other_admin)+ pack = PackService(fs)+ archive = tmp_path / "account.ovpack"++ with pytest.raises(PermissionDeniedError):+ await pack.backup_ovpack(str(archive), ctx=reader)+ assert not archive.exists()+ await pack.backup_ovpack(str(archive), ctx=admin)++ with zipfile.ZipFile(archive) as zf:+ prefix = "openviking-backup/files/"+ assert zf.read(prefix + "resources/repo/nested/guide.md") == await fs.read_file_bytes(+ original, ctx=admin+ )+ assert zf.read(prefix + "user/reader/memories/notes.md") == b"same-account private notes"+ assert prefix + "resources/other-account-only.md" not in zf.namelist()+ assert all(zf.read(name) != b"other-account content" for name in zf.namelist())+ assert await fs.read_file_bytes(other_uri, ctx=other_admin) == b"other-account content"+ with pytest.raises(PermissionDeniedError):+ await fs.read_file_bytes(original, ctx=outsider)+++async def test_account_restore_overwrites_original_beneath_existing_restricted_root(+ indexed_fs, tmp_path, monkeypatch+):+ fs, admin, reader, outsider, original = await _restricted_pack_source(indexed_fs)+ archive = tmp_path / "account.ovpack"+ # Prepare a native package before restriction to isolate restore from backup's+ # own regression; the destination is restricted at the actual restore call.+ await fs.set_acl("viking://resources/repo", entries=[], acl_mode=AclMode.NONE, ctx=admin)+ await PackService(fs).backup_ovpack(str(archive), ctx=admin)+ await fs.set_acl(+ "viking://resources/repo",+ entries=[{"principal": "user:reader", "level": "read"}],+ acl_mode=AclMode.RESTRICTED,+ ctx=admin,+ )+ await fs.write_file_bytes(original, b"superseded content", ctx=admin)+ enqueue = AsyncMock()+ monkeypatch.setattr(+ "openviking.storage.ovpack.operations._enqueue_direct_vectorization", enqueue+ )++ with pytest.raises(PermissionDeniedError):+ await PackService(fs).restore_ovpack(str(archive), ctx=reader, on_conflict="overwrite")+ assert await fs.read_file_bytes(original, ctx=reader) == b"superseded content"+ assert (+ await PackService(fs).restore_ovpack(str(archive), ctx=admin, on_conflict="overwrite")+ == "viking://"+ )+ assert await fs.read_file_bytes(original, ctx=reader) == b"# Current operating guide\n"+ with pytest.raises(PermissionDeniedError):+ await fs.read_file_bytes(original, ctx=outsider)+ enqueue.assert_awaited_once()+ assert enqueue.call_args.args[1] == "viking://resources"