Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(vector): apply tenant filter to debug scroll and count (#5945)

zhanggaoyuandf222c0c10fa
diff --git a/openviking/storage/viking_vector_index_backend.py b/openviking/storage/viking_vector_index_backend.py
index 18b82f073..014200d68 100644
--- a/openviking/storage/viking_vector_index_backend.py
+++ b/openviking/storage/viking_vector_index_backend.py
@@ -1724,6 +1724,11 @@ class VikingVectorIndexBackend:
ctx: RequestContext,
) -> tuple[List[Dict[str, Any]], Optional[str]]:
backend = await self._get_backend_for_context(ctx)
+ acl_enabled = await self._acl_enabled(ctx)
+ filter = self._merge_filters(
+ filter,
+ self._tenant_filter(ctx, acl_enabled=acl_enabled),
+ )
return await backend.scroll(
filter=filter,
limit=limit,
@@ -1824,6 +1829,11 @@ class VikingVectorIndexBackend:
) -> int:
if ctx:
backend = await self._get_backend_for_context(ctx)
+ acl_enabled = await self._acl_enabled(ctx)
+ filter = self._merge_filters(
+ filter,
+ self._tenant_filter(ctx, acl_enabled=acl_enabled),
+ )
else:
backend = self._get_default_backend()
return await backend.count(filter=filter)
diff --git a/tests/storage/test_viking_vector_scope_filter.py b/tests/storage/test_viking_vector_scope_filter.py
index e3fd9e40a..5394165b0 100644
--- a/tests/storage/test_viking_vector_scope_filter.py
+++ b/tests/storage/test_viking_vector_scope_filter.py
@@ -102,6 +102,59 @@ async def test_search_by_random_passes_runtime_acl_state_to_tenant_filter():
assert adapter.search_by_random.await_args.kwargs["filter"] == _tenant_filter(ctx)
+async def test_scroll_and_count_hide_cross_user_records(vector_backend_factory, tmp_path):
+ ctx = _ctx()
+ backend = vector_backend_factory(
+ config=VectorDBBackendConfig(
+ backend="local",
+ name="context",
+ dimension=4,
+ path=str(tmp_path / "debug_vectors"),
+ )
+ )
+ try:
+ assert await backend.create_collection(
+ "context", CollectionSchemas.context_collection("context", 4)
+ )
+ await backend._upsert_many_raw(
+ [
+ {
+ "id": "alice-memory",
+ "uri": "viking://user/alice/memories/own.md",
+ "account_id": "acct",
+ "context_type": "memory",
+ "level": 2,
+ "updated_at": "2026-01-01T00:00:00Z",
+ "vector": [1.0, 0.0, 0.0, 0.0],
+ },
+ {
+ "id": "bob-memory",
+ "uri": "viking://user/bob/memories/private.md",
+ "account_id": "acct",
+ "context_type": "memory",
+ "level": 2,
+ "updated_at": "2026-01-01T00:00:00Z",
+ "vector": [1.0, 0.0, 0.0, 0.0],
+ },
+ ],
+ ctx=RequestContext(user=UserIdentifier("acct", "admin"), role=Role.ADMIN),
+ )
+
+ records, next_cursor = await backend.scroll(
+ filter=Eq("context_type", "memory"),
+ limit=10,
+ ctx=ctx,
+ )
+ count = await backend.count(filter=Eq("context_type", "memory"), ctx=ctx)
+
+ assert next_cursor is None
+ assert [record["id"] for record in records] == ["alice-memory"]
+ assert count == 1
+ finally:
+ await backend.close()
+
+
def test_descendant_target_elides_only_visible_root_path_filter():
ctx = _ctx()
target = "viking://resources/wiki/physics"