Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(helm): keep PVC on uninstall, honor mountPath for workspace, create ServiceAccount (#3433)

Zayn Jarvisea3ea105cb81
diff --git a/deploy/helm/README.md b/deploy/helm/README.md
index bb609a8a4..d90a93648 100644
--- a/deploy/helm/README.md
+++ b/deploy/helm/README.md
@@ -176,8 +176,8 @@ multiple pods accessing the same RocksDB volume simultaneously.
helm uninstall openviking
```
-Note: The PersistentVolumeClaim is not deleted automatically. To remove stored
-data:
+Note: The PersistentVolumeClaim is retained by Helm and becomes orphaned after
+uninstall. Delete it explicitly to remove the stored data:
```bash
kubectl delete pvc openviking-data
diff --git a/deploy/helm/openviking/templates/configmap.yaml b/deploy/helm/openviking/templates/configmap.yaml
index e86b1b6e3..3b3d9d4ce 100644
--- a/deploy/helm/openviking/templates/configmap.yaml
+++ b/deploy/helm/openviking/templates/configmap.yaml
@@ -1,3 +1,7 @@
+{{- $config := deepCopy .Values.config }}
+{{- if empty $config.storage.workspace }}
+{{- $_ := set $config.storage "workspace" (printf "%s/openviking_workspace" (trimSuffix "/" .Values.persistence.mountPath)) }}
+{{- end }}
apiVersion: v1
kind: ConfigMap
metadata:
@@ -6,4 +10,4 @@ metadata:
{{- include "openviking.labels" . | nindent 4 }}
data:
ov.conf: |
- {{- .Values.config | toPrettyJson | nindent 4 }}
+ {{- $config | toPrettyJson | nindent 4 }}
diff --git a/deploy/helm/openviking/templates/deployment.yaml b/deploy/helm/openviking/templates/deployment.yaml
index f290da528..c965356f0 100644
--- a/deploy/helm/openviking/templates/deployment.yaml
+++ b/deploy/helm/openviking/templates/deployment.yaml
@@ -31,7 +31,7 @@ spec:
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
- {{- if .Values.serviceAccount.create }}
+ {{- if or .Values.serviceAccount.create .Values.serviceAccount.name }}
serviceAccountName: {{ include "openviking.serviceAccountName" . }}
{{- end }}
{{- with .Values.podSecurityContext }}
diff --git a/deploy/helm/openviking/templates/pvc.yaml b/deploy/helm/openviking/templates/pvc.yaml
index a6118d662..be8b9e57a 100644
--- a/deploy/helm/openviking/templates/pvc.yaml
+++ b/deploy/helm/openviking/templates/pvc.yaml
@@ -3,6 +3,8 @@ apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ include "openviking.fullname" . }}-data
+ annotations:
+ "helm.sh/resource-policy": keep
labels:
{{- include "openviking.labels" . | nindent 4 }}
spec:
diff --git a/deploy/helm/openviking/templates/serviceaccount.yaml b/deploy/helm/openviking/templates/serviceaccount.yaml
new file mode 100644
index 000000000..acb5c3076
--- /dev/null
+++ b/deploy/helm/openviking/templates/serviceaccount.yaml
@@ -0,0 +1,12 @@
+{{- if .Values.serviceAccount.create }}
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: {{ include "openviking.serviceAccountName" . }}
+ labels:
+ {{- include "openviking.labels" . | nindent 4 }}
+ {{- with .Values.serviceAccount.annotations }}
+ annotations:
+ {{- toYaml . | nindent 4 }}
+ {{- end }}
+{{- end }}
diff --git a/deploy/helm/openviking/values.yaml b/deploy/helm/openviking/values.yaml
index e5f7440af..7e4b157c4 100644
--- a/deploy/helm/openviking/values.yaml
+++ b/deploy/helm/openviking/values.yaml
@@ -85,7 +85,8 @@ bot:
# ${persistence.mountPath}/ov.conf.
config:
storage:
- workspace: /app/.openviking/openviking_workspace
+ # Defaults to <persistence.mountPath>/openviking_workspace when empty.
+ workspace: ""
vectordb:
name: context
backend: local