Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix: reject file URI for consistency check (#3133)
huangruitengebd729c3e230
diff --git a/openviking/service/core.py b/openviking/service/core.pyindex e55679c6d..2b4f79877 100644--- a/openviking/service/core.py+++ b/openviking/service/core.py@@ -36,7 +36,7 @@ from openviking.utils.agfs_utils import ()from openviking.utils.resource_processor import ResourceProcessorfrom openviking.utils.skill_processor import SkillProcessor-from openviking_cli.exceptions import NotInitializedError+from openviking_cli.exceptions import InvalidArgumentError, NotInitializedErrorfrom openviking_cli.session.user_id import UserIdentifierfrom openviking_cli.utils import get_loggerfrom openviking_cli.utils.config import OPENVIKING_ENABLE_RECORDER_ENV, get_openviking_config@@ -513,6 +513,9 @@ class OpenVikingService:raise NotInitializedError("VikingFS")effective_ctx = ctx or RequestContext(user=self.user, role=Role.ROOT)+ stat = await self._viking_fs.stat(uri, ctx=effective_ctx, skip_count=True)+ if not stat.get("isDir", False):+ raise InvalidArgumentError("Consistency check only supports directory URIs.")entries = await self._viking_fs.tree(uri,show_all_hidden=True,diff --git a/tests/unit/service/test_core_consistency.py b/tests/unit/service/test_core_consistency.pynew file mode 100644index 000000000..6951b5433--- /dev/null+++ b/tests/unit/service/test_core_consistency.py@@ -0,0 +1,63 @@+# Copyright (c) 2026 Beijing Volcano Engine Technology Co., Ltd.+# SPDX-License-Identifier: Apache-2.0+"""Focused tests for system consistency URI validation."""++from unittest.mock import AsyncMock, patch++import pytest++from openviking.server.identity import RequestContext, Role+from openviking.service.core import OpenVikingService+from openviking.storage.index_consistency import IndexConsistencyReport+from openviking_cli.exceptions import InvalidArgumentError+from openviking_cli.session.user_id import UserIdentifier+++def _service_with_fs(stat_result: dict) -> tuple[OpenVikingService, AsyncMock]:+ service = OpenVikingService.__new__(OpenVikingService)+ service._initialized = True+ service._user = UserIdentifier.the_default_user()+ service._vikingdb_manager = AsyncMock()+ service._viking_fs = AsyncMock()+ service._viking_fs.stat.return_value = stat_result+ return service, service._viking_fs+++async def test_check_consistency_rejects_file_uri() -> None:+ service, viking_fs = _service_with_fs({"isDir": False})+ ctx = RequestContext(user=service.user, role=Role.ROOT)++ with pytest.raises(+ InvalidArgumentError,+ match="Consistency check only supports directory URIs",+ ):+ await service.check_consistency(+ uri="viking://resources/consistency-file.md",+ ctx=ctx,+ )++ viking_fs.tree.assert_not_awaited()+++async def test_check_consistency_preserves_directory_behavior() -> None:+ service, viking_fs = _service_with_fs({"isDir": True})+ viking_fs.tree.return_value = []+ ctx = RequestContext(user=service.user, role=Role.ROOT)+ report = IndexConsistencyReport(expected=(), missing_records=())++ with patch(+ "openviking.service.core.check_index_consistency",+ new=AsyncMock(return_value=report),+ ) as check:+ result = await service.check_consistency(uri="viking://resources", ctx=ctx)++ assert result == report.to_dict()+ viking_fs.stat.assert_awaited_once_with(+ "viking://resources",+ ctx=ctx,+ skip_count=True,+ )+ viking_fs.tree.assert_awaited_once()+ check.assert_awaited_once()