Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(bot): enable logs for config-started gateway (#3319)

huangruitengf0d241e4a009
diff --git a/openviking/server/bootstrap.py b/openviking/server/bootstrap.py
index e9168da57..1961e43dc 100644
--- a/openviking/server/bootstrap.py
+++ b/openviking/server/bootstrap.py
@@ -256,7 +256,12 @@ def main():
# Determine if bot logging should be enabled
enable_bot_logging = args.enable_bot_logging
if enable_bot_logging is None:
- enable_bot_logging = args.with_bot
+ # Reaching this block means bot integration is enabled, either by
+ # ``--with-bot`` or by ``server.with_bot`` in ov.conf. Default
+ # logging must not depend only on which activation surface was
+ # used, otherwise config-enabled gateways silently lose their
+ # child-process diagnostics.
+ enable_bot_logging = True
bot_log_dir = args.bot_log_dir or _resolve_default_bot_log_dir(args.config)
# Start vikingbot gateway if --with-bot is set
bot_process = _start_vikingbot_gateway(
diff --git a/tests/server/test_bootstrap.py b/tests/server/test_bootstrap.py
index 04918c2d9..fa0cd9951 100644
--- a/tests/server/test_bootstrap.py
+++ b/tests/server/test_bootstrap.py
@@ -9,6 +9,7 @@ from types import SimpleNamespace
import openviking.server.bootstrap as bootstrap
from openviking.server.config import ServerConfig
from openviking.utils.agfs_utils import resolve_queuefs_mount_point
+from openviking_cli.utils.config.open_viking_config import OpenVikingConfigSingleton
from openviking_cli.utils.config.storage_config import StorageConfig
@@ -120,6 +121,59 @@ def test_main_coerces_cli_host_all_to_none(monkeypatch):
assert captured["port"] == 1933
+def test_main_enables_bot_logging_when_with_bot_comes_from_config(monkeypatch):
+ config = ServerConfig(host="127.0.0.1", port=1933, with_bot=True)
+ captured: dict[str, object] = {}
+ bot_process = object()
+
+ monkeypatch.setattr(bootstrap, "load_server_config", lambda config_path: config)
+ monkeypatch.setattr(bootstrap, "create_app", lambda config: "app")
+ monkeypatch.setattr(bootstrap, "configure_uvicorn_logging", lambda: None)
+ monkeypatch.setattr(
+ OpenVikingConfigSingleton,
+ "initialize",
+ classmethod(lambda cls, config_path: None),
+ )
+ monkeypatch.setattr(
+ bootstrap.argparse.ArgumentParser,
+ "parse_args",
+ lambda self: SimpleNamespace(
+ host=None,
+ port=None,
+ config=None,
+ workers=None,
+ bot=False,
+ with_bot=False,
+ bot_port=bootstrap.VIKINGBOT_DEFAULT_PORT,
+ enable_bot_logging=None,
+ bot_log_dir="/tmp/bot-logs",
+ ),
+ )
+ monkeypatch.setattr(bootstrap, "_abort_if_port_in_use", lambda port, label: None)
+
+ def _fake_start(enable_logging, log_dir, port, **kwargs):
+ captured.update(
+ {
+ "enable_logging": enable_logging,
+ "log_dir": log_dir,
+ "port": port,
+ }
+ )
+ return bot_process
+
+ monkeypatch.setattr(bootstrap, "_start_vikingbot_gateway", _fake_start)
+ monkeypatch.setattr(bootstrap, "_stop_vikingbot_gateway", lambda process: None)
+ monkeypatch.setattr(bootstrap.uvicorn, "run", lambda *args, **kwargs: None)
+
+ bootstrap.main()
+
+ assert captured == {
+ "enable_logging": True,
+ "log_dir": "/tmp/bot-logs",
+ "port": bootstrap.VIKINGBOT_DEFAULT_PORT,
+ }
+
+
def test_resolve_queuefs_mount_point_defaults_to_shared():
config = StorageConfig()